[{"id":14313,"web_url":"https://patchwork.libcamera.org/comment/14313/","msgid":"","date":"2020-12-23T04:04:49","subject":"Re: [libcamera-devel] [PATCH v2 4/9] libcamera: camera_sensor:\n\tRegister ColorFilterArrangement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Dec 18, 2020 at 05:47:49PM +0100, Jacopo Mondi wrote:\n> Inspect the list of media bus codes supported by the camera sensor\n> in order to deduce the color filter arrangement and register the\n> ColorFilterArrangement draft property.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/camera_sensor.cpp | 36 +++++++++++++++++++++++++++++----\n> 1 file changed, 32 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 1628ba9c892b..2b78eb4cb530 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -17,6 +17,7 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/bayer_format.h\"\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> #include \"libcamera/internal/utils.h\"\n> @@ -178,10 +179,6 @@ int CameraSensor::init()\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\tret = initProperties();\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> \t/* Enumerate, sort and cache media bus codes and sizes. */\n> \tformats_ = subdev_->formats(pad_);\n> \tif (formats_.empty()) {\n> @@ -210,6 +207,10 @@ int CameraSensor::init()\n> \t */\n> \tresolution_ = sizes_.back();\n> \n> +\tret = initProperties();\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \treturn 0;\n> }\n> \n> @@ -307,6 +308,33 @@ int CameraSensor::initProperties()\n> \t\tproperties_.set(properties::PixelArrayActiveAreas, { crop });\n> \t}\n> \n> +\t/* Color filter arrangement, default to the generic 'RGB' */\n\ns/arrangement/array pattern/ (CFA stands for color filter array)\n\n> +\tint32_t cfa = properties::draft::RGB;\n\nWould it make sense, for non-Bayer sensors, to not register the property\nat all ? For Android, android.sensor.info.colorFilterArrangement is only\nmandatory when raw capture is supported, so it shouldn't cause any\nissue. For the libcamera native API, reporting RGB for, for instance,\nYUV sensors seems a bit of a weird match.\n\nReviewed-by: Laurent Pinchart \n\n> +\tfor (const auto &format : formats_) {\n> +\t\tunsigned int mbusCode = format.first;\n> +\t\tBayerFormat bayerFormat(mbusCode);\n> +\t\tif (!bayerFormat.isValid())\n> +\t\t\tcontinue;\n> +\n> +\t\t/* Report the CFA ordering of the first valid RAW Bayer format. */\n> +\t\tswitch (bayerFormat.order) {\n> +\t\tcase BayerFormat::BGGR:\n> +\t\t\tcfa = properties::draft::BGGR;\n> +\t\t\tbreak;\n> +\t\tcase BayerFormat::GBRG:\n> +\t\t\tcfa = properties::draft::GBRG;\n> +\t\t\tbreak;\n> +\t\tcase BayerFormat::GRBG:\n> +\t\t\tcfa = properties::draft::GRBG;\n> +\t\t\tbreak;\n> +\t\tcase BayerFormat::RGGB:\n> +\t\t\tcfa = properties::draft::RGGB;\n> +\t\t\tbreak;\n> +\t\t}\n> +\t\tbreak;\n> +\t}\n> +\tproperties_.set(properties::draft::ColorFilterArrangement, cfa);\n> +\n> \treturn 0;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B8D5C0F1B\n\tfor ;\n\tWed, 23 Dec 2020 04:05:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E937615AC;\n\tWed, 23 Dec 2020 05:04:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43BA660320\n\tfor ;\n\tWed, 23 Dec 2020 05:04:58 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3B2CA32;\n\tWed, 23 Dec 2020 05:04:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"itA3JU4u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608696297;\n\tbh=uwaeOv638DKruSaZ3QYYhO7nqCN2CC6yeEHUjp0qzRg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=itA3JU4uSMF6zBKVqXW59blhHG3UUC9pPGA2kajwkotnCubDzipIpsF+to61fPfE5\n\tezdRJploV1lKQx2ocKICUTTIGegVIe9/JWHDAZttdm1e2MBk7DKAa8A+eBIg7kyfwC\n\tkKkxmMmETJvCDGZPWcKPl568caVOWJLifp2W8370=","Date":"Wed, 23 Dec 2020 06:04:49 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201218164754.81422-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 4/9] libcamera: camera_sensor:\n\tRegister ColorFilterArrangement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]