[{"id":14300,"web_url":"https://patchwork.libcamera.org/comment/14300/","msgid":"","date":"2020-12-21T15:44:11","subject":"Re: [libcamera-devel] [PATCH v2 2/9] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Dec 18, 2020 at 05:47:47PM +0100, Jacopo Mondi wrote:\n> Define the 'ColorFilterArrangement' draft property. The property is\n> currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> \n> This patch introdues the following warnings\n> property_ids.cpp:716: warning: no matching class member found for\n> libcamera::properties::draft::ColorFilterArrangementEnum::RGGB\n> property_ids.cpp:719: warning: no matching class member found for\n> libcamera::properties::draft::ColorFilterArrangementEnum::GRBG\n> property_ids.cpp:722: warning: no matching class member found for\n> libcamera::properties::draft::ColorFilterArrangementEnum::GBRG\n> property_ids.cpp:725: warning: no matching class member found for\n> libcamera::properties::draft::ColorFilterArrangementEnum::BGGR\n> \n> Removing one letter from the identifiers, or adding one, makes the\n> warning disapper:\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 411d5b2a398d..8a19b989e6c4 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -697,16 +697,16 @@ controls:\n> top-left 2x2 section of the sensor, in reading order. Currently\n> identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> enum:\n> - - name: RGGB\n> + - name: RGGBZ\n> value: 0\n> description: RGGB color filter arrangement\n> - - name: GRBG\n> + - name: GRBGZ\n> value: 1\n> description: GRBG color filter arrangement\n> - - name: GBRG\n> + - name: GBRGZ\n> value: 2\n> description: GBRG color filter arrangement\n> - - name: BGGR\n> + - name: BGGRZ\n> value: 3\n> description: BGGR color filter arrangement\n> - name: RGB\n> \n> A Doxygen bug maybe ?\n\nI think so. The problem still occurs with the master branch. It's\nprobably related to https://github.com/doxygen/doxygen/issues/6471,\nwhich I've updated with a test case for this specific issue.\n\n> ---\n> src/libcamera/property_ids.yaml | 26 ++++++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index f8e32c1bd8cf..411d5b2a398d 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -689,4 +689,30 @@ controls:\n> The physical dimensions of the full pixel array in millimeters.\n> Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> \n> + - ColorFilterArrangement:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + The arrangement of color filters on sensor; represents the colors in the\n> + top-left 2x2 section of the sensor, in reading order. Currently\n> + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> + enum:\n> + - name: RGGB\n> + value: 0\n> + description: RGGB color filter arrangement\n> + - name: GRBG\n> + value: 1\n> + description: GRBG color filter arrangement\n> + - name: GBRG\n> + value: 2\n> + description: GBRG color filter arrangement\n> + - name: BGGR\n> + value: 3\n> + description: BGGR color filter arrangement\n> + - name: RGB\n> + value: 4\n> + description: |\n> + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> + instead of just 1 16-bit value per pixel.\n> +\n> ...\n\nThis one should be fairly easy to \"undraft\", that's nice :-)\n\nGiven that we'll rework the control when promoting it to non-draft\nstatus, should we prefix the enumerators to avoid the doxygen warning\nfor the time being ? For instance s/RGGB/PatternRGGB/.\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDB2AC0F1B\n\tfor ;\n\tMon, 21 Dec 2020 15:44:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77C9161598;\n\tMon, 21 Dec 2020 16:44:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1242661596\n\tfor ;\n\tMon, 21 Dec 2020 16:44:20 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F8FABA4;\n\tMon, 21 Dec 2020 16:44:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mjMe3XsP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608565459;\n\tbh=FwuPZ/1v1E+VZ39oCY5vXC+w7mrindLguX9ORB8Et/s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mjMe3XsPUymk0yyi28NcG5tdnMAWDXVLTDelfi4InVyARtoWT6VQp3D/8zbA7B/zi\n\tXAsVg7YTtcI/4E8fZMhLyeTa6cM4SAvuHoHAeoOGl3Po4t/VlNqGrf9OHRQKcb66W9\n\tO62ceu6noiwM+U2hToTKOAJhOSF2+rZFSo9DT6m4=","Date":"Mon, 21 Dec 2020 17:44:11 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201218164754.81422-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/9] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14301,"web_url":"https://patchwork.libcamera.org/comment/14301/","msgid":"<20201221160910.txtztghrftgtvrr3@uno.localdomain>","date":"2020-12-21T16:09:10","subject":"Re: [libcamera-devel] [PATCH v2 2/9] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Dec 21, 2020 at 05:44:11PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Fri, Dec 18, 2020 at 05:47:47PM +0100, Jacopo Mondi wrote:\n> > Define the 'ColorFilterArrangement' draft property. The property is\n> > currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> >\n> > This patch introdues the following warnings\n> > property_ids.cpp:716: warning: no matching class member found for\n> > libcamera::properties::draft::ColorFilterArrangementEnum::RGGB\n> > property_ids.cpp:719: warning: no matching class member found for\n> > libcamera::properties::draft::ColorFilterArrangementEnum::GRBG\n> > property_ids.cpp:722: warning: no matching class member found for\n> > libcamera::properties::draft::ColorFilterArrangementEnum::GBRG\n> > property_ids.cpp:725: warning: no matching class member found for\n> > libcamera::properties::draft::ColorFilterArrangementEnum::BGGR\n> >\n> > Removing one letter from the identifiers, or adding one, makes the\n> > warning disapper:\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 411d5b2a398d..8a19b989e6c4 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -697,16 +697,16 @@ controls:\n> > top-left 2x2 section of the sensor, in reading order. Currently\n> > identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > enum:\n> > - - name: RGGB\n> > + - name: RGGBZ\n> > value: 0\n> > description: RGGB color filter arrangement\n> > - - name: GRBG\n> > + - name: GRBGZ\n> > value: 1\n> > description: GRBG color filter arrangement\n> > - - name: GBRG\n> > + - name: GBRGZ\n> > value: 2\n> > description: GBRG color filter arrangement\n> > - - name: BGGR\n> > + - name: BGGRZ\n> > value: 3\n> > description: BGGR color filter arrangement\n> > - name: RGB\n> >\n> > A Doxygen bug maybe ?\n>\n> I think so. The problem still occurs with the master branch. It's\n> probably related to https://github.com/doxygen/doxygen/issues/6471,\n> which I've updated with a test case for this specific issue.\n>\n> > ---\n> > src/libcamera/property_ids.yaml | 26 ++++++++++++++++++++++++++\n> > 1 file changed, 26 insertions(+)\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index f8e32c1bd8cf..411d5b2a398d 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -689,4 +689,30 @@ controls:\n> > The physical dimensions of the full pixel array in millimeters.\n> > Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> >\n> > + - ColorFilterArrangement:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + The arrangement of color filters on sensor; represents the colors in the\n> > + top-left 2x2 section of the sensor, in reading order. Currently\n> > + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > + enum:\n> > + - name: RGGB\n> > + value: 0\n> > + description: RGGB color filter arrangement\n> > + - name: GRBG\n> > + value: 1\n> > + description: GRBG color filter arrangement\n> > + - name: GBRG\n> > + value: 2\n> > + description: GBRG color filter arrangement\n> > + - name: BGGR\n> > + value: 3\n> > + description: BGGR color filter arrangement\n> > + - name: RGB\n> > + value: 4\n> > + description: |\n> > + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> > + instead of just 1 16-bit value per pixel.\n> > +\n> > ...\n>\n> This one should be fairly easy to \"undraft\", that's nice :-)\n>\n> Given that we'll rework the control when promoting it to non-draft\n> status, should we prefix the enumerators to avoid the doxygen warning\n> for the time being ? For instance s/RGGB/PatternRGGB/.\n>\n> Reviewed-by: Laurent Pinchart \n\nI'll add a \\todo to record that we're working around a doxygen bug\n\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07D1FC0F1A\n\tfor ;\n\tMon, 21 Dec 2020 16:09:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8666F61598;\n\tMon, 21 Dec 2020 17:09:01 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBC7061596\n\tfor ;\n\tMon, 21 Dec 2020 17:08:59 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 5AA77200013;\n\tMon, 21 Dec 2020 16:08:59 +0000 (UTC)"],"Date":"Mon, 21 Dec 2020 17:09:10 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201221160910.txtztghrftgtvrr3@uno.localdomain>","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-3-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 2/9] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]