[{"id":14293,"web_url":"https://patchwork.libcamera.org/comment/14293/","msgid":"","date":"2020-12-20T06:02:29","subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:\n> Define the 'SensorPhysicalSize' draft property. The property is\n> currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/property_ids.yaml | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 64e88f0361d6..f8e32c1bd8cf 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -678,4 +678,15 @@ controls:\n> \\todo Turn this property into a \"maximum control value\" for the\n> ScalerCrop control once \"dynamic\" controls have been implemented.\n> \n> + # ----------------------------------------------------------------------------\n> + # Draft properties section\n> +\n> + - SensorPhysicalSize:\n> + type: float\n> + size: [2]\n> + draft: true\n> + description: |\n> + The physical dimensions of the full pixel array in millimeters.\n> + Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n\nWe already have UnitCellSize and PixelArraySize, can't they be used to\ncompute this property ?\n\n> +\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88A8EC0F1B\n\tfor ;\n\tSun, 20 Dec 2020 06:02:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15AD561595;\n\tSun, 20 Dec 2020 07:02:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A62260526\n\tfor ;\n\tSun, 20 Dec 2020 07:02:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED50B593;\n\tSun, 20 Dec 2020 07:02:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AsVVucgq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608444157;\n\tbh=WYZUV2OvUeKLWVBfEoPQLkRG8l7BKrhAJ7vYQUzxoF8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AsVVucgqibb8WGV7T3KRlSWwH0N5si+PRleU9QeTD87jsN4hBTJ6R4eJLxuyR5JDu\n\tiMN9wLj8sEjbu5O5omlywbyzuGlbVRYd9B0ACE/cQlOL919r+9qly/viYwAYct1joz\n\tNX1SQ4Zp6oX6f0OrqQqJDYroibyU1qWnZ4cGp2VE=","Date":"Sun, 20 Dec 2020 08:02:29 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201218164754.81422-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14298,"web_url":"https://patchwork.libcamera.org/comment/14298/","msgid":"<20201221150624.b6z5n3w4fkgif6nb@uno.localdomain>","date":"2020-12-21T15:06:24","subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:\n> > Define the 'SensorPhysicalSize' draft property. The property is\n> > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/property_ids.yaml | 11 +++++++++++\n> > 1 file changed, 11 insertions(+)\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 64e88f0361d6..f8e32c1bd8cf 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -678,4 +678,15 @@ controls:\n> > \\todo Turn this property into a \"maximum control value\" for the\n> > ScalerCrop control once \"dynamic\" controls have been implemented.\n> >\n> > + # ----------------------------------------------------------------------------\n> > + # Draft properties section\n> > +\n> > + - SensorPhysicalSize:\n> > + type: float\n> > + size: [2]\n> > + draft: true\n> > + description: |\n> > + The physical dimensions of the full pixel array in millimeters.\n> > + Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n>\n> We already have UnitCellSize and PixelArraySize, can't they be used to\n> compute this property ?\n\nWe could.\n\nI would like to have these cros-verified with the current values\nreported by the chromeos HALs. I still haven't been able to have a\nnice list of all properties they register.\n\n>\n> > +\n> > ...\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80596C0F1B\n\tfor ;\n\tMon, 21 Dec 2020 15:06:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0704B6159A;\n\tMon, 21 Dec 2020 16:06:16 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D86F261595\n\tfor ;\n\tMon, 21 Dec 2020 16:06:13 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 4C680200017;\n\tMon, 21 Dec 2020 15:06:12 +0000 (UTC)"],"Date":"Mon, 21 Dec 2020 16:06:24 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201221150624.b6z5n3w4fkgif6nb@uno.localdomain>","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-2-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14299,"web_url":"https://patchwork.libcamera.org/comment/14299/","msgid":"","date":"2020-12-21T15:16:21","subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 21, 2020 at 04:06:24PM +0100, Jacopo Mondi wrote:\n> On Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:\n> > On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:\n> > > Define the 'SensorPhysicalSize' draft property. The property is\n> > > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/property_ids.yaml | 11 +++++++++++\n> > > 1 file changed, 11 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > index 64e88f0361d6..f8e32c1bd8cf 100644\n> > > --- a/src/libcamera/property_ids.yaml\n> > > +++ b/src/libcamera/property_ids.yaml\n> > > @@ -678,4 +678,15 @@ controls:\n> > > \\todo Turn this property into a \"maximum control value\" for the\n> > > ScalerCrop control once \"dynamic\" controls have been implemented.\n> > >\n> > > + # ----------------------------------------------------------------------------\n> > > + # Draft properties section\n> > > +\n> > > + - SensorPhysicalSize:\n> > > + type: float\n> > > + size: [2]\n> > > + draft: true\n> > > + description: |\n> > > + The physical dimensions of the full pixel array in millimeters.\n> > > + Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> >\n> > We already have UnitCellSize and PixelArraySize, can't they be used to\n> > compute this property ?\n> \n> We could.\n> \n> I would like to have these cros-verified with the current values\n> reported by the chromeos HALs. I still haven't been able to have a\n> nice list of all properties they register.\n\nThat's a good idea. Is there any off-the-shelf tool we can use for that\n?\n\n> > > +\n> > > ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8677AC0F1A\n\tfor ;\n\tMon, 21 Dec 2020 15:16:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C13E615AC;\n\tMon, 21 Dec 2020 16:16:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC7BB61596\n\tfor ;\n\tMon, 21 Dec 2020 16:16:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E846BA4;\n\tMon, 21 Dec 2020 16:16:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rskTIDbp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608563789;\n\tbh=b8kAKuVLl1ZDQX/UmHTFRfRnmueF/SKXrF2lqbtS2bY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rskTIDbpESRAtmjouJGNJ8n8iB2NvHB4bVpb2thcRDwetVb9M0SJ6wuA0T0MQgGgo\n\t8vKyeEIjYWs0xQaDWuYkc9fRlnABc61P4CCX2olpx2dN29KU99CySziop1qUeAS6Xf\n\t5A+8aM3OA57oC8yLKVXeNmgsZ6riq936aIUzGtDY=","Date":"Mon, 21 Dec 2020 17:16:21 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-2-jacopo@jmondi.org>\n\t\n\t<20201221150624.b6z5n3w4fkgif6nb@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201221150624.b6z5n3w4fkgif6nb@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14302,"web_url":"https://patchwork.libcamera.org/comment/14302/","msgid":"<20201221161132.leykchon7umk5vgk@uno.localdomain>","date":"2020-12-21T16:11:32","subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Dec 21, 2020 at 05:16:21PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Mon, Dec 21, 2020 at 04:06:24PM +0100, Jacopo Mondi wrote:\n> > On Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:\n> > > On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:\n> > > > Define the 'SensorPhysicalSize' draft property. The property is\n> > > > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> > > >\n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > > src/libcamera/property_ids.yaml | 11 +++++++++++\n> > > > 1 file changed, 11 insertions(+)\n> > > >\n> > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > index 64e88f0361d6..f8e32c1bd8cf 100644\n> > > > --- a/src/libcamera/property_ids.yaml\n> > > > +++ b/src/libcamera/property_ids.yaml\n> > > > @@ -678,4 +678,15 @@ controls:\n> > > > \\todo Turn this property into a \"maximum control value\" for the\n> > > > ScalerCrop control once \"dynamic\" controls have been implemented.\n> > > >\n> > > > + # ----------------------------------------------------------------------------\n> > > > + # Draft properties section\n> > > > +\n> > > > + - SensorPhysicalSize:\n> > > > + type: float\n> > > > + size: [2]\n> > > > + draft: true\n> > > > + description: |\n> > > > + The physical dimensions of the full pixel array in millimeters.\n> > > > + Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n> > >\n> > > We already have UnitCellSize and PixelArraySize, can't they be used to\n> > > compute this property ?\n> >\n> > We could.\n> >\n> > I would like to have these cros-verified with the current values\n> > reported by the chromeos HALs. I still haven't been able to have a\n> > nice list of all properties they register.\n>\n> That's a good idea. Is there any off-the-shelf tool we can use for that\n> ?\n\nNot that I know of, but I've nerve actually never researched if\nthere's any android app that can help with that.\n\n>\n> > > > +\n> > > > ...\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F807C0F1B\n\tfor ;\n\tMon, 21 Dec 2020 16:11:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D336A615AC;\n\tMon, 21 Dec 2020 17:11:21 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C6D261596\n\tfor ;\n\tMon, 21 Dec 2020 17:11:21 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id E902D240010;\n\tMon, 21 Dec 2020 16:11:20 +0000 (UTC)"],"Date":"Mon, 21 Dec 2020 17:11:32 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201221161132.leykchon7umk5vgk@uno.localdomain>","References":"<20201218164754.81422-1-jacopo@jmondi.org>\n\t<20201218164754.81422-2-jacopo@jmondi.org>\n\t\n\t<20201221150624.b6z5n3w4fkgif6nb@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: properties:\n\tSensorPhysicalSize draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]