[{"id":14273,"web_url":"https://patchwork.libcamera.org/comment/14273/","msgid":"<6a6d57ab-7412-43fb-516d-c056738fb086@ideasonboard.com>","date":"2020-12-18T13:07:33","subject":"Re: [libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 18/12/2020 10:06, Naushir Patuck wrote:\n> Set the maximum shutter speed for the normal exposure profile to 66ms.\n> Set the maximum shutter speed for the sport exposure profile to 33ms.\n> Add a long exposure profile to allow shutter speeds of up to 120ms.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Tested-by: David Plowman \n\nA little hard to parse some of that from the diff, but that's the mostly\nthe diff, and the changes below seem to match what is described above.\n\nSo on that basis:\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--\n> src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--\n> src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--\n> 3 files changed, 39 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\n> index 212f8b9a..1ec338be 100644\n> --- a/src/ipa/raspberrypi/data/imx219.json\n> +++ b/src/ipa/raspberrypi/data/imx219.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 30000, 30000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 30000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\n> index 12fe2f41..9bee3f16 100644\n> --- a/src/ipa/raspberrypi/data/imx477.json\n> +++ b/src/ipa/raspberrypi/data/imx477.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 60000, 120000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 120000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\n> index 3d8a7c8f..1a354f7c 100644\n> --- a/src/ipa/raspberrypi/data/ov5647.json\n> +++ b/src/ipa/raspberrypi/data/ov5647.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 30000, 30000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 30000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A5A4BD80A\n\tfor ;\n\tFri, 18 Dec 2020 13:07:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5C8961597;\n\tFri, 18 Dec 2020 14:07:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9D896052C\n\tfor ;\n\tFri, 18 Dec 2020 14:07:36 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 288E62CF;\n\tFri, 18 Dec 2020 14:07:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ADRM9XZo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608296856;\n\tbh=5v34f+/uXl0ERCWNGK7JfYlCBfIuw1taZfVk/hrzcAM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ADRM9XZozhjphNBOdEOY5fypPFtKBKSQp9FwvMw2gR5K7pRzXEoVGQGSABc6pSE8o\n\t03oOEDF23P252Jo9Eojn9e+ODboOubl6+J0/Lop5PJ7ego9MTfb0xbu5u9Q0q3EtG9\n\tdRWzO8rU1JjHhq00JskeDtEyGi9oMTnXatvGxsgk=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201218100626.205134-1-naush@raspberrypi.com>\n\t<20201218100626.205134-4-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6a6d57ab-7412-43fb-516d-c056738fb086@ideasonboard.com>","Date":"Fri, 18 Dec 2020 13:07:33 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201218100626.205134-4-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14292,"web_url":"https://patchwork.libcamera.org/comment/14292/","msgid":"","date":"2020-12-20T05:54:50","subject":"Re: [libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Dec 18, 2020 at 10:06:27AM +0000, Naushir Patuck wrote:\n> Set the maximum shutter speed for the normal exposure profile to 66ms.\n> Set the maximum shutter speed for the sport exposure profile to 33ms.\n\nIt would be nice if we could add a sentence to explain why. The content\nof the patch otherwise looks good.\n\nReviewed-by: Laurent Pinchart \n\n> Add a long exposure profile to allow shutter speeds of up to 120ms.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Tested-by: David Plowman \n> ---\n> src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--\n> src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--\n> src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--\n> 3 files changed, 39 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\n> index 212f8b9a..1ec338be 100644\n> --- a/src/ipa/raspberrypi/data/imx219.json\n> +++ b/src/ipa/raspberrypi/data/imx219.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 30000, 30000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 30000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\n> index 12fe2f41..9bee3f16 100644\n> --- a/src/ipa/raspberrypi/data/imx477.json\n> +++ b/src/ipa/raspberrypi/data/imx477.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 60000, 120000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 120000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\n> index 3d8a7c8f..1a354f7c 100644\n> --- a/src/ipa/raspberrypi/data/ov5647.json\n> +++ b/src/ipa/raspberrypi/data/ov5647.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 30000, 30000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 30000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 742F8C0F1A\n\tfor ;\n\tSun, 20 Dec 2020 05:55:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB9A361595;\n\tSun, 20 Dec 2020 06:54:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFCFB60526\n\tfor ;\n\tSun, 20 Dec 2020 06:54:58 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BD87593;\n\tSun, 20 Dec 2020 06:54:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hO7BBb18\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608443698;\n\tbh=aa4rH15QJA8maa9kmZf/EvDcSJ66bexv8widjooc7xg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hO7BBb18n9+h/1rr21btB7lNTWnsNqbqN50FA/tryRlFBu2fOKOlMZ4ZjDuWx5sik\n\tMiCo+snqfDpwLz4EoCfjVIDNf1115oieGo7RhETd0He3zqZlhpKARC1Jl/6xb+VyNC\n\tXFk17qgcJ4nWanDkVERRgoMws2n3z+XDARiBl0pE=","Date":"Sun, 20 Dec 2020 07:54:50 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20201218100626.205134-1-naush@raspberrypi.com>\n\t<20201218100626.205134-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201218100626.205134-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14296,"web_url":"https://patchwork.libcamera.org/comment/14296/","msgid":"","date":"2020-12-21T11:27:41","subject":"Re: [libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your review feedback.\n\nOn Sun, 20 Dec 2020 at 05:54, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Dec 18, 2020 at 10:06:27AM +0000, Naushir Patuck wrote:\n> > Set the maximum shutter speed for the normal exposure profile to 66ms.\n> > Set the maximum shutter speed for the sport exposure profile to 33ms.\n>\n> It would be nice if we could add a sentence to explain why. The content\n> of the patch otherwise looks good.\n>\n\nI can add a quick line of text to explain this a bit more in the next\nrevision.\n\nRegards,\nNaush\n\n\n\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > Add a long exposure profile to allow shutter speeds of up to 120ms.\n> >\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: David Plowman \n> > Tested-by: David Plowman \n> > ---\n> > src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--\n> > src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--\n> > src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--\n> > 3 files changed, 39 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/data/imx219.json\n> b/src/ipa/raspberrypi/data/imx219.json\n> > index 212f8b9a..1ec338be 100644\n> > --- a/src/ipa/raspberrypi/data/imx219.json\n> > +++ b/src/ipa/raspberrypi/data/imx219.json\n> > @@ -133,7 +133,7 @@\n> > {\n> > \"shutter\":\n> > [\n> > - 100, 10000, 30000, 30000, 30000\n> > + 100, 10000, 30000, 60000, 66666\n> > ],\n> > \"gain\":\n> > [\n> > @@ -144,7 +144,18 @@\n> > {\n> > \"shutter\":\n> > [\n> > - 100, 5000, 10000, 20000, 30000\n> > + 100, 5000, 10000, 20000, 33333\n> > + ],\n> > + \"gain\":\n> > + [\n> > + 1.0, 2.0, 4.0, 6.0, 6.0\n> > + ]\n> > + },\n> > + \"long\":\n> > + {\n> > + \"shutter\":\n> > + [\n> > + 100, 10000, 30000, 60000, 120000\n> > ],\n> > \"gain\":\n> > [\n> > diff --git a/src/ipa/raspberrypi/data/imx477.json\n> b/src/ipa/raspberrypi/data/imx477.json\n> > index 12fe2f41..9bee3f16 100644\n> > --- a/src/ipa/raspberrypi/data/imx477.json\n> > +++ b/src/ipa/raspberrypi/data/imx477.json\n> > @@ -133,7 +133,7 @@\n> > {\n> > \"shutter\":\n> > [\n> > - 100, 10000, 30000, 60000, 120000\n> > + 100, 10000, 30000, 60000, 66666\n> > ],\n> > \"gain\":\n> > [\n> > @@ -144,7 +144,18 @@\n> > {\n> > \"shutter\":\n> > [\n> > - 100, 5000, 10000, 20000, 120000\n> > + 100, 5000, 10000, 20000, 33333\n> > + ],\n> > + \"gain\":\n> > + [\n> > + 1.0, 2.0, 4.0, 6.0, 6.0\n> > + ]\n> > + },\n> > + \"long\":\n> > + {\n> > + \"shutter\":\n> > + [\n> > + 100, 10000, 30000, 60000, 120000\n> > ],\n> > \"gain\":\n> > [\n> > diff --git a/src/ipa/raspberrypi/data/ov5647.json\n> b/src/ipa/raspberrypi/data/ov5647.json\n> > index 3d8a7c8f..1a354f7c 100644\n> > --- a/src/ipa/raspberrypi/data/ov5647.json\n> > +++ b/src/ipa/raspberrypi/data/ov5647.json\n> > @@ -133,7 +133,7 @@\n> > {\n> > \"shutter\":\n> > [\n> > - 100, 10000, 30000, 30000, 30000\n> > + 100, 10000, 30000, 60000, 66666\n> > ],\n> > \"gain\":\n> > [\n> > @@ -144,7 +144,18 @@\n> > {\n> > \"shutter\":\n> > [\n> > - 100, 5000, 10000, 20000, 30000\n> > + 100, 5000, 10000, 20000, 33333\n> > + ],\n> > + \"gain\":\n> > + [\n> > + 1.0, 2.0, 4.0, 6.0, 6.0\n> > + ]\n> > + },\n> > + \"long\":\n> > + {\n> > + \"shutter\":\n> > + [\n> > + 100, 10000, 30000, 60000, 120000\n> > ],\n> > \"gain\":\n> > [\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B930C0F1B\n\tfor ;\n\tMon, 21 Dec 2020 11:28:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56FA86159A;\n\tMon, 21 Dec 2020 12:28:00 +0100 (CET)","from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C98F761595\n\tfor ;\n\tMon, 21 Dec 2020 12:27:58 +0100 (CET)","by mail-lf1-x134.google.com with SMTP id s26so22770243lfc.8\n\tfor ;\n\tMon, 21 Dec 2020 03:27:58 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ZJkhDaD9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=fCPZK/N1kQVqCAGVrevq4hf4AWwyRAa5Txy+3n5MeGk=;\n\tb=ZJkhDaD97PNt2E1qE8QyvIY840PQlDkDpydIX0mkJm5YPkkNkh7Cc1nbFltdJP2O+J\n\t5G9NUZf2VXRLnKnpZrGLPmcLy6efdt+S3KGgmeTpskBMtPRLbWPVqMxmj+0TCLirqRl5\n\tPpQ6PRlTS4MdZOIgJmPZmLcCpK3RsijN18JQIyX1BM9SHHplXetko/Fb+VGt7WUenyoV\n\tRKN70Sk6osw2bEcF11h8xH+jJWjVNtS5c/uxbnaSLiZH1Do/yp1LZ+n7NiGF4FuENEx+\n\tfJzDhg3CGjNy6OhOIigdTw0KJFsOgfltrUB946+JeW1M54Z+5349YxGhCkkC/5w8zCUl\n\tFJPw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=fCPZK/N1kQVqCAGVrevq4hf4AWwyRAa5Txy+3n5MeGk=;\n\tb=M5kK6BCHq2ET7FobWq96nl9L/qlnHPuLp35aUNgamDA74suQ8fvDQBKLODhOhrwjwM\n\t5KNLl43yUY63BZj75Obk/4xq5BnTqUh/hN6N58/CuQuZHY6uPstsPpN5ENmfAa29okC0\n\t3sbmuWw8BrBh0vlcTG9xGqvaV26NIpv78qO6AaacAat0W1EOgH6U8ZBjJ4QqlIVBWanZ\n\tyAIILTH8jaK4Qu1Ce8n422/NkQApI986Jmb393nXIq5KNSZA4uSV5zkeFXAy/aVU98Cb\n\t1t98zWF7gkKODBGljhy/Sue4o3qwdvr4QAJpUC4DDnlQgQr4idMvlJwb3J1u+gI+QXR9\n\to5zw==","X-Gm-Message-State":"AOAM532ctwiYg+8m4KizDvWAw2G3fBINhYdGump7z2WCn0Si9LWFcNnV\n\ttAM5yqlAtMOM41TIDt1yG3ATmcd/mRiXqLtFrJx4+efPCnk=","X-Google-Smtp-Source":"ABdhPJwHxSC1tAByY6+yN2emH7RfyUTHOG4M1awn40UB4VJ9kqQIHGeZveZwHX59czmgnMf59UrREcwY/tkAbj3loO0=","X-Received":"by 2002:a2e:a58b:: with SMTP id\n\tm11mr6926823ljp.329.1608550078276; \n\tMon, 21 Dec 2020 03:27:58 -0800 (PST)","MIME-Version":"1.0","References":"<20201218100626.205134-1-naush@raspberrypi.com>\n\t<20201218100626.205134-4-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Mon, 21 Dec 2020 11:27:41 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============1884951433244478993==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]