[{"id":14277,"web_url":"https://patchwork.libcamera.org/comment/14277/","msgid":"<X9zAQOJIWtyrQsdO@wyvern>","date":"2020-12-18T14:44:16","subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: camera_device: Report\n\tnumber of out streams","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-12-17 15:03:58 +0100, Jacopo Mondi wrote:\n> Report the number of supported output streams through the\n> ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS static metadata.\n> \n> The camera HAL currently supports:\n> - 1 optional RAW stream\n> - 2 YUV streams\n> - 1 JPEG stream\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/android/camera_device.cpp | 17 +++++++++++++----\n>  1 file changed, 13 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 26aa3bc4b123..b4618a680f41 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -675,10 +675,10 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n>  {\n>  \t/*\n>  \t * \\todo Keep this in sync with the actual number of entries.\n> -\t * Currently: 52 entries, 698 bytes of static metadata\n> +\t * Currently: 53 entries, 714 bytes of static metadata\n>  \t */\n> -\tuint32_t numEntries = 52;\n> -\tuint32_t byteSize = 698;\n> +\tuint32_t numEntries = 53;\n> +\tuint32_t byteSize = 714;\n>  \n>  \t/*\n>  \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1090,15 +1090,23 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n>  \t};\n>  \n>  \t/* Report if camera supports RAW. */\n> +\tbool rawStreamAvailable = false;\n>  \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n>  \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n>  \tif (cameraConfig && !cameraConfig->empty()) {\n>  \t\tconst PixelFormatInfo &info =\n>  \t\t\tPixelFormatInfo::info(cameraConfig->at(0).pixelFormat);\n> -\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> +\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW) {\n> +\t\t\trawStreamAvailable = true;\n\nI wonder if we should make this check more restrictive and check for \nRAW16 instead of any RAW format?\n\n>  \t\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n> +\t\t}\n>  \t}\n>  \n> +\t/* Number of { RAW, YUV, JPEG } supported output streams */\n> +\tint32_t numOutStreams[] = { rawStreamAvailable, 2, 1 };\n> +\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> +\t\t\t\t  &numOutStreams, 3);\n> +\n>  \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n>  \t\t\t\t  availableCapabilities.data(),\n>  \t\t\t\t  availableCapabilities.size());\n> @@ -1150,6 +1158,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n>  \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n>  \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n>  \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> +\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n>  \t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n>  \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n>  \t};\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68436C0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Dec 2020 14:44:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F372E61595;\n\tFri, 18 Dec 2020 15:44:19 +0100 (CET)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 202CF6052C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 15:44:19 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id m25so5955588lfc.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 06:44:19 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tw13sm1063921ljw.28.2020.12.18.06.44.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Dec 2020 06:44:17 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"izQbsB8a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=GxzbgjkHog2Phsd9mp4F051LaITtYeksSyZse+mnxHQ=;\n\tb=izQbsB8aK0FqgpFzCNzB+k2anY/+r00o0sWlms8Ugj7lP3yF5+YXGMFlwX7tGHsxtz\n\tAME62TwCJK0GHHyTh/d6KJxzWxKRqSdeoEMys6x29eKBUOSOsD7MobQ6cMf6Syo8ZopC\n\tqcLsT3WJgeEO+bJTr0j/1M7tyOgsiTjuE5utuQzovHBFQh3ulaxd+eMGkN4JqdQkMQJS\n\tImMBeq4lqIMcnNQeufcjZ9GMKmvyDzmLUfnhYASSd2ok0cJRPaQOkTNeLVILlq1RC/8S\n\t65KiecFhCZgswSiIFf9y21ujhsDeQFZyi/T/7ti4aQQOQSQFs+JldQnhMDBQLPosyS6q\n\tfq/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=GxzbgjkHog2Phsd9mp4F051LaITtYeksSyZse+mnxHQ=;\n\tb=c2eyrZpQ49EHzVAYAGHEUmaeTShwV/TB83tMaNAAP6f/bS0PcoKSU5LTJLBAlslCc9\n\tCrYY4KglMSB9xmPBj5aUXp55MyQ6U2HXO4C9paCPqMlSxiXcfK1rVpFDi/0NeObLeMCJ\n\tjREzVYA3wXTk3sEHa0SfI7C3nWcrTd7ZU1ROxYy+2fHh/oXwxw1+s+uPO8nFXnLhkiC5\n\tiBgks0ycJV1c9GBzU4Shb5N2paZN0wSEvq/lROB77PSUIMclPf9hjIlCVBCBLAe6e/b8\n\tUIowToZb83lNwtqHAVqd6eYWnvfloDfhXBLojzhU1R5yoyvNZQsQHmch6dhGYGXGuBpy\n\tVVCw==","X-Gm-Message-State":"AOAM530AA1wvpKwYmgzKCxodZgfoWW2dzUaRLPGxLn0koWYv5R1nbEcU\n\tBJjlvdcljrODKozpewn0WDW/L3Ua6l7Fbidj0i0=","X-Google-Smtp-Source":"ABdhPJyMLERHEoLwy0ACXq4VArP28G4HF4rgc4HRk7SmZhtHe9QnIXg3GgixA8PCwcdG8INyXAjb6w==","X-Received":"by 2002:a2e:7a07:: with SMTP id v7mr1950947ljc.119.1608302658519;\n\tFri, 18 Dec 2020 06:44:18 -0800 (PST)","Date":"Fri, 18 Dec 2020 15:44:16 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<X9zAQOJIWtyrQsdO@wyvern>","References":"<20201217140358.17614-1-jacopo@jmondi.org>\n\t<20201217140358.17614-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201217140358.17614-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: camera_device: Report\n\tnumber of out streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":14278,"web_url":"https://patchwork.libcamera.org/comment/14278/","msgid":"<20201218144943.um2nswb76qduu6vq@uno.localdomain>","date":"2020-12-18T14:49:43","subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: camera_device: Report\n\tnumber of out streams","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Dec 18, 2020 at 03:44:16PM +0100, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your patch.\n>\n> On 2020-12-17 15:03:58 +0100, Jacopo Mondi wrote:\n> > Report the number of supported output streams through the\n> > ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS static metadata.\n> >\n> > The camera HAL currently supports:\n> > - 1 optional RAW stream\n> > - 2 YUV streams\n> > - 1 JPEG stream\n> >\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> >  src/android/camera_device.cpp | 17 +++++++++++++----\n> >  1 file changed, 13 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 26aa3bc4b123..b4618a680f41 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -675,10 +675,10 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n> >  {\n> >  \t/*\n> >  \t * \\todo Keep this in sync with the actual number of entries.\n> > -\t * Currently: 52 entries, 698 bytes of static metadata\n> > +\t * Currently: 53 entries, 714 bytes of static metadata\n> >  \t */\n> > -\tuint32_t numEntries = 52;\n> > -\tuint32_t byteSize = 698;\n> > +\tuint32_t numEntries = 53;\n> > +\tuint32_t byteSize = 714;\n> >\n> >  \t/*\n> >  \t * Calculate space occupation in bytes for dynamically built metadata\n> > @@ -1090,15 +1090,23 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> >  \t};\n> >\n> >  \t/* Report if camera supports RAW. */\n> > +\tbool rawStreamAvailable = false;\n> >  \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n> >  \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n> >  \tif (cameraConfig && !cameraConfig->empty()) {\n> >  \t\tconst PixelFormatInfo &info =\n> >  \t\t\tPixelFormatInfo::info(cameraConfig->at(0).pixelFormat);\n> > -\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> > +\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW) {\n> > +\t\t\trawStreamAvailable = true;\n>\n> I wonder if we should make this check more restrictive and check for\n> RAW16 instead of any RAW format?\n\n\nYes, probably, that's related to the question of which formats should\nbe supported in order to claim support for RAW to Android.\n\nI think this is unrelated to this patch, isn't it ?\n\n>\n> >  \t\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n> > +\t\t}\n> >  \t}\n> >\n> > +\t/* Number of { RAW, YUV, JPEG } supported output streams */\n> > +\tint32_t numOutStreams[] = { rawStreamAvailable, 2, 1 };\n> > +\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> > +\t\t\t\t  &numOutStreams, 3);\n> > +\n> >  \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> >  \t\t\t\t  availableCapabilities.data(),\n> >  \t\t\t\t  availableCapabilities.size());\n> > @@ -1150,6 +1158,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> >  \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> >  \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> >  \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > +\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> >  \t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> >  \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> >  \t};\n> > --\n> > 2.29.2\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09BD9BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Dec 2020 14:49:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7A5861593;\n\tFri, 18 Dec 2020 15:49:34 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46FFD6052C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 15:49:33 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id BB761100010;\n\tFri, 18 Dec 2020 14:49:32 +0000 (UTC)"],"Date":"Fri, 18 Dec 2020 15:49:43 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Message-ID":"<20201218144943.um2nswb76qduu6vq@uno.localdomain>","References":"<20201217140358.17614-1-jacopo@jmondi.org>\n\t<20201217140358.17614-3-jacopo@jmondi.org>\n\t<X9zAQOJIWtyrQsdO@wyvern>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<X9zAQOJIWtyrQsdO@wyvern>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: camera_device: Report\n\tnumber of out streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":14279,"web_url":"https://patchwork.libcamera.org/comment/14279/","msgid":"<X9zCuq2D8sT9bM6I@wyvern>","date":"2020-12-18T14:54:50","subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: camera_device: Report\n\tnumber of out streams","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2020-12-18 15:49:43 +0100, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Fri, Dec 18, 2020 at 03:44:16PM +0100, Niklas Söderlund wrote:\n> > Hi Jacopo,\n> >\n> > Thanks for your patch.\n> >\n> > On 2020-12-17 15:03:58 +0100, Jacopo Mondi wrote:\n> > > Report the number of supported output streams through the\n> > > ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS static metadata.\n> > >\n> > > The camera HAL currently supports:\n> > > - 1 optional RAW stream\n> > > - 2 YUV streams\n> > > - 1 JPEG stream\n> > >\n> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > > ---\n> > >  src/android/camera_device.cpp | 17 +++++++++++++----\n> > >  1 file changed, 13 insertions(+), 4 deletions(-)\n> > >\n> > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > > index 26aa3bc4b123..b4618a680f41 100644\n> > > --- a/src/android/camera_device.cpp\n> > > +++ b/src/android/camera_device.cpp\n> > > @@ -675,10 +675,10 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n> > >  {\n> > >  \t/*\n> > >  \t * \\todo Keep this in sync with the actual number of entries.\n> > > -\t * Currently: 52 entries, 698 bytes of static metadata\n> > > +\t * Currently: 53 entries, 714 bytes of static metadata\n> > >  \t */\n> > > -\tuint32_t numEntries = 52;\n> > > -\tuint32_t byteSize = 698;\n> > > +\tuint32_t numEntries = 53;\n> > > +\tuint32_t byteSize = 714;\n> > >\n> > >  \t/*\n> > >  \t * Calculate space occupation in bytes for dynamically built metadata\n> > > @@ -1090,15 +1090,23 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > >  \t};\n> > >\n> > >  \t/* Report if camera supports RAW. */\n> > > +\tbool rawStreamAvailable = false;\n> > >  \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n> > >  \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n> > >  \tif (cameraConfig && !cameraConfig->empty()) {\n> > >  \t\tconst PixelFormatInfo &info =\n> > >  \t\t\tPixelFormatInfo::info(cameraConfig->at(0).pixelFormat);\n> > > -\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> > > +\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW) {\n> > > +\t\t\trawStreamAvailable = true;\n> >\n> > I wonder if we should make this check more restrictive and check for\n> > RAW16 instead of any RAW format?\n> \n> \n> Yes, probably, that's related to the question of which formats should\n> be supported in order to claim support for RAW to Android.\n> \n> I think this is unrelated to this patch, isn't it ?\n\nMaybe it is, I was just thinking a head as I hope to soon tackle RAW and \nCTS so the tests for RAW that require RAW16 are skipped correctly. But \nas I don't know yet how to best do that this is a good step in the right \ndirection.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> \n> >\n> > >  \t\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n> > > +\t\t}\n> > >  \t}\n> > >\n> > > +\t/* Number of { RAW, YUV, JPEG } supported output streams */\n> > > +\tint32_t numOutStreams[] = { rawStreamAvailable, 2, 1 };\n> > > +\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> > > +\t\t\t\t  &numOutStreams, 3);\n> > > +\n> > >  \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> > >  \t\t\t\t  availableCapabilities.data(),\n> > >  \t\t\t\t  availableCapabilities.size());\n> > > @@ -1150,6 +1158,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > >  \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> > >  \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> > >  \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > > +\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> > >  \t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> > >  \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> > >  \t};\n> > > --\n> > > 2.29.2\n> > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n> >\n> > --\n> > Regards,\n> > Niklas Söderlund","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4A2DC0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Dec 2020 14:55:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 467E061595;\n\tFri, 18 Dec 2020 15:55:04 +0100 (CET)","from mail-ed1-x544.google.com (mail-ed1-x544.google.com\n\t[IPv6:2a00:1450:4864:20::544])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F136052C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 15:55:03 +0100 (CET)","by mail-ed1-x544.google.com with SMTP id j16so2656845edr.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 06:55:03 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tx4sm25794623edr.40.2020.12.18.06.55.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Dec 2020 06:55:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"aZaKifIe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=mHDrUhpPNTwLSEm2nzzAf+b+6EJwKwpx7W1K4HVMuCU=;\n\tb=aZaKifIerC3X4rjE1nqHpAWwsFRznQAiuSSXYlvHcLDdHu7V7yfVfaOO92xltwcv4P\n\tkbAl4oaOe7J6egiVpAZcE/Hcrhj+iaWcEox2fTJyEcwhNO2QXPru35qn7zEmw2BUkyH1\n\tY5mWEL0TVoImqFOATnyHaarWSNuNhM9mVxLLfd+hyx1jXZuHnw+UsR2DL3JU48ZEKoev\n\tMXDhGkikCKjZDeIHGcdGUQgqmfesbCxeOLlYln3stYO7rQ7Qu91iTOiYy0rz93h9UOQh\n\tG600zAB3xbvnXl0Sf4KG1WTwUduBT31C9vn6SdrS1x3a+AKAOGKUuhVJqKHhDBTDVrHx\n\tIosg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=mHDrUhpPNTwLSEm2nzzAf+b+6EJwKwpx7W1K4HVMuCU=;\n\tb=eBsU9Uf0/xbWq6ZCI3sg5RgVBytgZ6Wrc1oEFDz/3D0Tf+sfL30NKeBzG6IgRd7piH\n\tew3ki8yRqhLENt7jE9hIA2Iaxhx5+0Tpm/YN9HryEc4BHzHwnaD57i2CMYoDrJ7WSqI3\n\tzoAlpkTG8tjlP2QXNgi0YlCPpvd5S4ncdS1eTSBi2yI4bmIJcmsO1Swgf7bQr5dfqn/T\n\te5Z3QN+UvFGyLz3n2kUSOEPk/x2K62w/dPphnQ7n5sUZH/mSTPxKfPxvksJeuP+9jGEq\n\tKi0azyPaZDRzAlipCcYs6sTmOp2p0pBiyK39pVRC0/NQPCGGgy0Czpg6h1MzW42CWruf\n\tg3Ew==","X-Gm-Message-State":"AOAM5330h6qKzz19535EzAjTKnA2aL6LxYMAttpvcEel9A3cal6jBHFU\n\tTcfaDYkjKFeqREQaqsJqU3cp7NhtGjt9CU7NUro=","X-Google-Smtp-Source":"ABdhPJwbRfQ1PuLLl2rbxrQopMRjICfX+R/uwz0avMhZnq8oseV0jQceoGwfircib8ZVp4dGPC4wWQ==","X-Received":"by 2002:aa7:d41a:: with SMTP id\n\tz26mr1008269edq.267.1608303302801; \n\tFri, 18 Dec 2020 06:55:02 -0800 (PST)","Date":"Fri, 18 Dec 2020 15:54:50 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<X9zCuq2D8sT9bM6I@wyvern>","References":"<20201217140358.17614-1-jacopo@jmondi.org>\n\t<20201217140358.17614-3-jacopo@jmondi.org>\n\t<X9zAQOJIWtyrQsdO@wyvern>\n\t<20201218144943.um2nswb76qduu6vq@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201218144943.um2nswb76qduu6vq@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: camera_device: Report\n\tnumber of out streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]