[{"id":14251,"web_url":"https://patchwork.libcamera.org/comment/14251/","msgid":"<6080db14-77b3-0669-d198-f666aa000dd1@ideasonboard.com>","date":"2020-12-15T10:56:17","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Rename\n\tunicamCtrls_ to sensorCtrls_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 15/12/2020 10:16, Naushir Patuck wrote:\n> These specific controls are part of the sensor device, so rename them\n> appropriately.\n\nSounds reasonable to me.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index a7439bad..5f2e07fd 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -113,7 +113,7 @@ private:\n> \n> \tstd::map buffers_;\n> \n> -\tControlInfoMap unicamCtrls_;\n> +\tControlInfoMap sensorCtrls_;\n> \tControlInfoMap ispCtrls_;\n> \tControlList libcameraMetadata_;\n> \n> @@ -177,7 +177,7 @@ int IPARPi::start(const IPAOperationData &data, IPAOperationData *result)\n> \t/* SwitchMode may supply updated exposure/gain values to use. */\n> \tmetadata.Get(\"agc.status\", agcStatus);\n> \tif (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {\n> -\t\tControlList ctrls(unicamCtrls_);\n> +\t\tControlList ctrls(sensorCtrls_);\n> \t\tapplyAGC(&agcStatus, ctrls);\n> \t\tresult->controls.emplace_back(ctrls);\n> \t\tresult->operation |= RPi::IPA_CONFIG_SENSOR;\n> @@ -287,7 +287,7 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> \n> \tresult->operation = 0;\n> \n> -\tunicamCtrls_ = entityControls.at(0);\n> +\tsensorCtrls_ = entityControls.at(0);\n> \tispCtrls_ = entityControls.at(1);\n> \n> \t/* Setup a metadata ControlList to output metadata. */\n> @@ -364,7 +364,7 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> \t\tcontrollerInit_ = true;\n> \n> \t\t/* Supply initial values for gain and exposure. */\n> -\t\tControlList ctrls(unicamCtrls_);\n> +\t\tControlList ctrls(sensorCtrls_);\n> \t\tAgcStatus agcStatus;\n> \t\tagcStatus.shutter_time = DefaultExposureTime;\n> \t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n> @@ -879,7 +879,7 @@ void IPARPi::processStats(unsigned int bufferId)\n> \n> \tstruct AgcStatus agcStatus;\n> \tif (rpiMetadata_.Get(\"agc.status\", agcStatus) == 0) {\n> -\t\tControlList ctrls(unicamCtrls_);\n> +\t\tControlList ctrls(sensorCtrls_);\n> \t\tapplyAGC(&agcStatus, ctrls);\n> \n> \t\tIPAOperationData op;\n> @@ -917,12 +917,12 @@ void IPARPi::applyAGC(const struct AgcStatus *agcStatus, ControlList &ctrls)\n> \tint32_t gainCode = helper_->GainCode(agcStatus->analogue_gain);\n> \tint32_t exposureLines = helper_->ExposureLines(agcStatus->shutter_time);\n> \n> -\tif (unicamCtrls_.find(V4L2_CID_ANALOGUE_GAIN) == unicamCtrls_.end()) {\n> +\tif (sensorCtrls_.find(V4L2_CID_ANALOGUE_GAIN) == sensorCtrls_.end()) {\n> \t\tLOG(IPARPI, Error) << \"Can't find analogue gain control\";\n> \t\treturn;\n> \t}\n> \n> -\tif (unicamCtrls_.find(V4L2_CID_EXPOSURE) == unicamCtrls_.end()) {\n> +\tif (sensorCtrls_.find(V4L2_CID_EXPOSURE) == sensorCtrls_.end()) {\n> \t\tLOG(IPARPI, Error) << \"Can't find exposure control\";\n> \t\treturn;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8A17BD80A\n\tfor ;\n\tTue, 15 Dec 2020 10:56:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60AD661589;\n\tTue, 15 Dec 2020 11:56:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0ED6600FD\n\tfor ;\n\tTue, 15 Dec 2020 11:56:20 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D40E96;\n\tTue, 15 Dec 2020 11:56:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i9DyO63M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608029780;\n\tbh=KJ8MU1Z6GHmdRJwfb4aJXaL15wYq8AFN0yCdIyTd+Ag=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=i9DyO63ML12Q6WJIILs7f88LVYBVA0ssqqOR4DOLPW4w2DOO0DN+3xs0PSNDj4GFY\n\t9/KnHRj1mZ/uK6nb7R/0OyBAiMxYQrDTBHsDbROEokVTPbJO2gzPrIADISbDnDXxpk\n\tGdh3yIDApiFRnQAdip754zSMpAvavUGtYgzuzTrE=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201215101633.21546-1-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6080db14-77b3-0669-d198-f666aa000dd1@ideasonboard.com>","Date":"Tue, 15 Dec 2020 10:56:17 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201215101633.21546-1-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Rename\n\tunicamCtrls_ to sensorCtrls_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14255,"web_url":"https://patchwork.libcamera.org/comment/14255/","msgid":"","date":"2020-12-16T01:39:55","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Rename\n\tunicamCtrls_ to sensorCtrls_","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Dec 15, 2020 at 10:16:32AM +0000, Naushir Patuck wrote:\n> These specific controls are part of the sensor device, so rename them\n> appropriately.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index a7439bad..5f2e07fd 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -113,7 +113,7 @@ private:\n> \n> \tstd::map buffers_;\n> \n> -\tControlInfoMap unicamCtrls_;\n> +\tControlInfoMap sensorCtrls_;\n> \tControlInfoMap ispCtrls_;\n> \tControlList libcameraMetadata_;\n> \n> @@ -177,7 +177,7 @@ int IPARPi::start(const IPAOperationData &data, IPAOperationData *result)\n> \t/* SwitchMode may supply updated exposure/gain values to use. */\n> \tmetadata.Get(\"agc.status\", agcStatus);\n> \tif (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {\n> -\t\tControlList ctrls(unicamCtrls_);\n> +\t\tControlList ctrls(sensorCtrls_);\n> \t\tapplyAGC(&agcStatus, ctrls);\n> \t\tresult->controls.emplace_back(ctrls);\n> \t\tresult->operation |= RPi::IPA_CONFIG_SENSOR;\n> @@ -287,7 +287,7 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> \n> \tresult->operation = 0;\n> \n> -\tunicamCtrls_ = entityControls.at(0);\n> +\tsensorCtrls_ = entityControls.at(0);\n> \tispCtrls_ = entityControls.at(1);\n> \n> \t/* Setup a metadata ControlList to output metadata. */\n> @@ -364,7 +364,7 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> \t\tcontrollerInit_ = true;\n> \n> \t\t/* Supply initial values for gain and exposure. */\n> -\t\tControlList ctrls(unicamCtrls_);\n> +\t\tControlList ctrls(sensorCtrls_);\n> \t\tAgcStatus agcStatus;\n> \t\tagcStatus.shutter_time = DefaultExposureTime;\n> \t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n> @@ -879,7 +879,7 @@ void IPARPi::processStats(unsigned int bufferId)\n> \n> \tstruct AgcStatus agcStatus;\n> \tif (rpiMetadata_.Get(\"agc.status\", agcStatus) == 0) {\n> -\t\tControlList ctrls(unicamCtrls_);\n> +\t\tControlList ctrls(sensorCtrls_);\n> \t\tapplyAGC(&agcStatus, ctrls);\n> \n> \t\tIPAOperationData op;\n> @@ -917,12 +917,12 @@ void IPARPi::applyAGC(const struct AgcStatus *agcStatus, ControlList &ctrls)\n> \tint32_t gainCode = helper_->GainCode(agcStatus->analogue_gain);\n> \tint32_t exposureLines = helper_->ExposureLines(agcStatus->shutter_time);\n> \n> -\tif (unicamCtrls_.find(V4L2_CID_ANALOGUE_GAIN) == unicamCtrls_.end()) {\n> +\tif (sensorCtrls_.find(V4L2_CID_ANALOGUE_GAIN) == sensorCtrls_.end()) {\n> \t\tLOG(IPARPI, Error) << \"Can't find analogue gain control\";\n> \t\treturn;\n> \t}\n> \n> -\tif (unicamCtrls_.find(V4L2_CID_EXPOSURE) == unicamCtrls_.end()) {\n> +\tif (sensorCtrls_.find(V4L2_CID_EXPOSURE) == sensorCtrls_.end()) {\n> \t\tLOG(IPARPI, Error) << \"Can't find exposure control\";\n> \t\treturn;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 289E3C0F1A\n\tfor ;\n\tWed, 16 Dec 2020 01:40:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88E646158D;\n\tWed, 16 Dec 2020 02:40:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF4436052A\n\tfor ;\n\tWed, 16 Dec 2020 02:40:02 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 399372CF;\n\tWed, 16 Dec 2020 02:40:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XMYb9V3D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608082802;\n\tbh=H6Is+dK5WhxxLmsMQrgrMPO+OSsmGgXPTtfW9/FTB7s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XMYb9V3DzEBE0f4LL0md12jgYuxl31/Z75d7qBwSlveipWC0nmIc5WcKIezsYNOUv\n\taFXm56KjazOxLIcIf2ZEnsM004tO7i0E2s08mGUrQFBwXHj7Fy4C2oeqsA/fu+pevU\n\tZYhKWDsYX8R5VaUAw3IuiUVQemYvCICmvx9bEvn0=","Date":"Wed, 16 Dec 2020 03:39:55 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20201215101633.21546-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201215101633.21546-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Rename\n\tunicamCtrls_ to sensorCtrls_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]