[{"id":14235,"web_url":"https://patchwork.libcamera.org/comment/14235/","msgid":"<20201214021407.GA2095@pyrite.rasen.tech>","date":"2020-12-14T02:14:07","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: vimc: Use\n\tV4L2*::fromEntityName() where possible","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sat, Dec 12, 2020 at 08:51:15PM +0200, Laurent Pinchart wrote:\n> Replace manual construction of V4L2VideoDevice and V4L2Subdevide with\n> the fromEntityName() helper where possible. The returned pointer is\n> managed as a std::unique_ptr<>, which simplifies the VimcCameraData\n> destructor.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/vimc/vimc.cpp | 24 +++++++++---------------\n> 1 file changed, 9 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 2a5054a8b1b8..72256f5b4190 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -42,19 +42,13 @@ class VimcCameraData : public CameraData\n> {\n> public:\n> \tVimcCameraData(PipelineHandler *pipe, MediaDevice *media)\n> -\t\t: CameraData(pipe), media_(media), sensor_(nullptr),\n> -\t\t debayer_(nullptr), scaler_(nullptr), video_(nullptr),\n> -\t\t raw_(nullptr)\n> +\t\t: CameraData(pipe), media_(media), sensor_(nullptr)\n> \t{\n> \t}\n> \n> \t~VimcCameraData()\n> \t{\n> \t\tdelete sensor_;\n> -\t\tdelete debayer_;\n> -\t\tdelete scaler_;\n> -\t\tdelete video_;\n> -\t\tdelete raw_;\n> \t}\n> \n> \tint init();\n> @@ -62,10 +56,10 @@ public:\n> \n> \tMediaDevice *media_;\n> \tCameraSensor *sensor_;\n> -\tV4L2Subdevice *debayer_;\n> -\tV4L2Subdevice *scaler_;\n> -\tV4L2VideoDevice *video_;\n> -\tV4L2VideoDevice *raw_;\n> +\tstd::unique_ptr debayer_;\n> +\tstd::unique_ptr scaler_;\n> +\tstd::unique_ptr video_;\n> +\tstd::unique_ptr raw_;\n> \tStream stream_;\n> };\n> \n> @@ -472,21 +466,21 @@ int VimcCameraData::init()\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tdebayer_ = new V4L2Subdevice(media_->getEntityByName(\"Debayer B\"));\n> +\tdebayer_ = V4L2Subdevice::fromEntityName(media_, \"Debayer B\");\n> \tif (debayer_->open())\n> \t\treturn -ENODEV;\n> \n> -\tscaler_ = new V4L2Subdevice(media_->getEntityByName(\"Scaler\"));\n> +\tscaler_ = V4L2Subdevice::fromEntityName(media_, \"Scaler\");\n> \tif (scaler_->open())\n> \t\treturn -ENODEV;\n> \n> -\tvideo_ = new V4L2VideoDevice(media_->getEntityByName(\"RGB/YUV Capture\"));\n> +\tvideo_ = V4L2VideoDevice::fromEntityName(media_, \"RGB/YUV Capture\");\n> \tif (video_->open())\n> \t\treturn -ENODEV;\n> \n> \tvideo_->bufferReady.connect(this, &VimcCameraData::bufferReady);\n> \n> -\traw_ = new V4L2VideoDevice(media_->getEntityByName(\"Raw Capture 1\"));\n> +\traw_ = V4L2VideoDevice::fromEntityName(media_, \"Raw Capture 1\");\n> \tif (raw_->open())\n> \t\treturn -ENODEV;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D68DEBD80A\n\tfor ;\n\tMon, 14 Dec 2020 02:14:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5329961590;\n\tMon, 14 Dec 2020 03:14:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E5A7600EB\n\tfor ;\n\tMon, 14 Dec 2020 03:14:15 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7D8F96;\n\tMon, 14 Dec 2020 03:14:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MgtE19Ob\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607912054;\n\tbh=+FC9lPI8rHylouGQ/LcujwT8SIfGDqemaWX2uIWMOrk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MgtE19ObrQAnYbdjnIQGLHmksWbS8URWk09iNWErEJQJQdc3N0M/3eKXK8OFmOgrI\n\tATEjf2jXK/FIcbAtCft5hRH2hpH7fHbNisXew6GrZwlUsUC9Exf3IPzwDJ+I6oLezF\n\tse1R/XpPaJCvkWwnB/nlSPYmaOi9OEgO/+Md+iU4=","Date":"Mon, 14 Dec 2020 11:14:07 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20201214021407.GA2095@pyrite.rasen.tech>","References":"<20201212185116.29611-1-laurent.pinchart@ideasonboard.com>\n\t<20201212185116.29611-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201212185116.29611-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: vimc: Use\n\tV4L2*::fromEntityName() where possible","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]