[{"id":14205,"web_url":"https://patchwork.libcamera.org/comment/14205/","msgid":"","date":"2020-12-10T18:03:53","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Temporary fix\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Dec 10, 2020 at 06:59:39PM +0100, Jacopo Mondi wrote:\n> The ChromeOS camera service, which is the current main user of the\n> Android Camera HAL, fails to start if the pixel array properties are\n> not registered.\n> \n> As the sensor driver for the Soraka test device have not yet been\n> updated to report their pixel array properties through the V4L2\n> selection API, temporary fix the gap by re-establishing the default\n> properties values removed by commit 1889cdc2e91c (\"android: camera_device:\n> Initialize pixel array properties\")\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e9fb23175d27..8b46e2d1e4ba 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -735,6 +735,10 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t};\n> \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> \t\t\t\t\t data.data(), data.size());\n> +\t} else {\n\nWith\n\n\t\t/*\n\t\t * \\todo Drop the default once the ov5670 and ov13858 drivers\n\t\t * are updated to report the pixel array size.\n\t\t */\n\n(and possibly the same below),\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tint32_t data[] = { 2592, 1944 };\n> +\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> +\t\t\t\t\t data, 2);\n> \t}\n> \n> \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> @@ -748,6 +752,10 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t};\n> \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> \t\t\t\t\t data.data(), data.size());\n> +\t} else {\n> +\t\tint32_t data[] = { 0, 0, 2560, 1920 };\n> +\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> +\t\t\t\t\t data, 4);\n> \t}\n> \n> \tint32_t sensitivityRange[] = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B275ABD80A\n\tfor ;\n\tThu, 10 Dec 2020 18:04:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53DE56089C;\n\tThu, 10 Dec 2020 19:04:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B2226084B\n\tfor ;\n\tThu, 10 Dec 2020 19:03:59 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F49425E;\n\tThu, 10 Dec 2020 19:03:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hJzlmUE+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607623438;\n\tbh=HATZVEkXP62YHConMtz9yOsQxol7WJ0vfkfFUzC+eIE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hJzlmUE+Bv8yG2td//oY3TjvLC2et4k5LJNvzsIKDUMIE30Z4YVFnUZCtLtx0lTUA\n\tAW2yukZVsPSO8i1wBXNu8aL5B7zk1Z2yB1tFZbwQ7yDCwcKebI2BbanyfbsFUjhXe4\n\tDOVlTBvzOfZOUFudQXnJRI59GborV83ce/FuQEyo=","Date":"Thu, 10 Dec 2020 20:03:53 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201210175939.166033-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201210175939.166033-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Temporary fix\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]