{"id":10631,"url":"https://patchwork.libcamera.org/api/patches/10631/?format=json","web_url":"https://patchwork.libcamera.org/patch/10631/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201209173520.284266-4-jacopo@jmondi.org>","date":"2020-12-09T17:35:19","name":"[libcamera-devel,3/3] android: camera_device: Report number of out streams","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9ffa55afc6b7dda5f194d06f48d6ff9d1bf8016e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10631/mbox/","series":[{"id":1520,"url":"https://patchwork.libcamera.org/api/series/1520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1520","date":"2020-12-09T17:35:16","name":"android: Add more metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/1520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10631/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10631/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1A6FBD808\n\tfor ;\n\tWed, 9 Dec 2020 17:35:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E60AC67F2E;\n\tWed, 9 Dec 2020 18:35:20 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C32EC67F07\n\tfor ;\n\tWed, 9 Dec 2020 18:35:17 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 87D37240005\n\tfor ;\n\tWed, 9 Dec 2020 17:35:17 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 9 Dec 2020 18:35:19 +0100","Message-Id":"<20201209173520.284266-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.1","In-Reply-To":"<20201209173520.284266-1-jacopo@jmondi.org>","References":"<20201209173520.284266-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/3] android: camera_device: Report number\n\tof out streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report the number of supported output streams through the\nANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS static metadata.\n\nThe camera HAL currently supports:\n- 1 RAW stream\n- 2 YUV streams\n- 1 JPEG stream\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 13194d1ea5cc..e9fb23175d27 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -550,10 +550,10 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 52 entries, 698 bytes of static metadata\n+\t * Currently: 53 entries, 714 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 52;\n-\tuint32_t byteSize = 698;\n+\tuint32_t numEntries = 53;\n+\tuint32_t byteSize = 714;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -939,6 +939,11 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t\t &maxPipelineDepth, 1);\n \t}\n \n+\t/* Number of { RAW, YUV, JPEG } supported output streams */\n+\tint32_t numOutStreams[] = { 1, 2, 1 };\n+\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n+\t\t\t\t &numOutStreams, 3);\n+\n \t/* LIMITED does not support reprocessing. */\n \tuint32_t maxNumInputStreams = 0;\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n@@ -1009,6 +1014,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n+\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n \t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n \t};\n","prefixes":["libcamera-devel","3/3"]}