[{"id":14187,"web_url":"https://patchwork.libcamera.org/comment/14187/","msgid":"<fcdb7f8c-af4c-6c37-8b70-7a944d43d684@ideasonboard.com>","date":"2020-12-10T09:41:15","subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Report\n\tpipeline depth","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/12/2020 17:35, Jacopo Mondi wrote:\n> Report the pipeline depth in the capture results if the pipeline\n> reports it.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/android/camera_device.cpp | 21 ++++++++++++++++-----\n>  src/android/camera_device.h   |  4 ++--\n>  src/android/camera_worker.h   |  1 +\n>  3 files changed, 19 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 872c7b18ee49..13194d1ea5cc 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -550,10 +550,10 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n>  {\n>  \t/*\n>  \t * \\todo Keep this in sync with the actual number of entries.\n> -\t * Currently: 51 entries, 687 bytes of static metadata\n> +\t * Currently: 52 entries, 698 bytes of static metadata\n\nI keep dreaming of a day where this is automatic ;)\n\n>  \t */\n>  \tuint32_t numEntries = 52;\n> -\tuint32_t byteSize = 694;\n> +\tuint32_t byteSize = 698;\n>  \n>  \t/*\n>  \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1046,6 +1046,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n>  \t\tANDROID_CONTROL_AWB_STATE,\n>  \t\tANDROID_CONTROL_AWB_LOCK,\n>  \t\tANDROID_LENS_STATE,\n> +\t\tANDROID_REQUEST_PIPELINE_DEPTH,\n>  \t\tANDROID_SCALER_CROP_REGION,\n>  \t\tANDROID_SENSOR_TIMESTAMP,\n>  \t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> @@ -1554,7 +1555,7 @@ void CameraDevice::requestComplete(Request *request)\n>  \t * pipeline handlers) timestamp in the Request itself.\n>  \t */\n>  \tuint64_t timestamp = buffers.begin()->second->metadata().timestamp;\n> -\tresultMetadata = getResultMetadata(descriptor->frameNumber_, timestamp);\n> +\tresultMetadata = getResultMetadata(descriptor, timestamp);\n>  \n>  \t/* Handle any JPEG compression. */\n>  \tfor (unsigned int i = 0; i < descriptor->numBuffers_; ++i) {\n> @@ -1672,15 +1673,17 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n>   * Produce a set of fixed result metadata.\n>   */\n>  std::unique_ptr<CameraMetadata>\n> -CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n> +CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n>  \t\t\t\tint64_t timestamp)\n>  {\n> +\tconst ControlList &metadata = descriptor->request_->request()->metadata();\n> +\n>  \t/*\n>  \t * \\todo Keep this in sync with the actual number of entries.\n>  \t * Currently: 18 entries, 62 bytes\n>  \t */\n>  \tstd::unique_ptr<CameraMetadata> resultMetadata =\n> -\t\tstd::make_unique<CameraMetadata>(18, 62);\n> +\t\tstd::make_unique<CameraMetadata>(19, 63);\n>  \tif (!resultMetadata->isValid()) {\n>  \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n>  \t\treturn nullptr;\n> @@ -1730,6 +1733,14 @@ CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n>  \tresultMetadata->addEntry(ANDROID_STATISTICS_SCENE_FLICKER,\n>  \t\t\t\t &scene_flicker, 1);\n>  \n> +\t/* Add metadata tags reported by libcamera. */\n> +\tif (metadata.contains(controls::draft::PipelineDepth)) {\n> +\t\tuint8_t pipeline_depth =\n> +\t\t\tmetadata.get<int32_t>(controls::draft::PipelineDepth);\n> +\t\tresultMetadata->addEntry(ANDROID_REQUEST_PIPELINE_DEPTH,\n> +\t\t\t\t\t &pipeline_depth, 1);\n> +\t}\n\n\nI wonder if we can (easily) wrap some of that into helpers, as there's\nplenty of boilerplate repetition there for each control/metadata - but\nnothing required for now.\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> +\n>  \t/*\n>  \t * Return the result metadata pack even is not valid: get() will return\n>  \t * nullptr.\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 45efcf477436..07d3a846f8e1 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -105,8 +105,8 @@ private:\n>  \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n>  \tCameraMetadata *requestTemplatePreview();\n>  \tlibcamera::PixelFormat toPixelFormat(int format) const;\n> -\tstd::unique_ptr<CameraMetadata> getResultMetadata(int frame_number,\n> -\t\t\t\t\t\t\t  int64_t timestamp);\n> +\tstd::unique_ptr<CameraMetadata> getResultMetadata(\n> +\t\tCamera3RequestDescriptor *descriptor, int64_t timestamp);\n>  \n>  \tunsigned int id_;\n>  \tcamera3_device_t camera3Device_;\n> diff --git a/src/android/camera_worker.h b/src/android/camera_worker.h\n> index fff5021708d7..9417a816c214 100644\n> --- a/src/android/camera_worker.h\n> +++ b/src/android/camera_worker.h\n> @@ -25,6 +25,7 @@ public:\n>  \tCaptureRequest(libcamera::Camera *camera, uint64_t cookie);\n>  \n>  \tconst std::vector<int> &fences() const { return acquireFences_; }\n> +\tconst libcamera::Request *request() const { return request_.get(); }\n>  \n>  \tvoid addBuffer(libcamera::Stream *stream,\n>  \t\t       libcamera::FrameBuffer *buffer, int fence);\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A346BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Dec 2020 09:41:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E884C67F6E;\n\tThu, 10 Dec 2020 10:41:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E338660323\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Dec 2020 10:41:18 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66D9B25E;\n\tThu, 10 Dec 2020 10:41:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K29rY0/6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607593278;\n\tbh=pYWi+bFF1oPw4a0wXdL+w4jagJbNy+k5KCuJ3rNm3uQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=K29rY0/6x8CIKpzk//QFbi2KEX+yHYLiXXDodkcKo6uzw62/JUKDScZovNn4MJfIT\n\twDeTLBEOOtjLopIRky1szj2mTQiGuqgUaLFtNDQeI47nvZ1lrqFrb624P+3iVrH9j+\n\t5wJemGq4fgSUzK456oksQVjsMnuXmJUbKy5Jnb/M=","To":"Jacopo Mondi <jacopo@jmondi.org>, libcamera-devel@lists.libcamera.org","References":"<20201209173520.284266-1-jacopo@jmondi.org>\n\t<20201209173520.284266-3-jacopo@jmondi.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<fcdb7f8c-af4c-6c37-8b70-7a944d43d684@ideasonboard.com>","Date":"Thu, 10 Dec 2020 09:41:15 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201209173520.284266-3-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Report\n\tpipeline depth","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":14207,"web_url":"https://patchwork.libcamera.org/comment/14207/","msgid":"<X9JpvWr7HAtjuaJI@pendragon.ideasonboard.com>","date":"2020-12-10T18:32:29","subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Report\n\tpipeline depth","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Dec 09, 2020 at 06:35:18PM +0100, Jacopo Mondi wrote:\n> Report the pipeline depth in the capture results if the pipeline\n> reports it.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/android/camera_device.cpp | 21 ++++++++++++++++-----\n>  src/android/camera_device.h   |  4 ++--\n>  src/android/camera_worker.h   |  1 +\n>  3 files changed, 19 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 872c7b18ee49..13194d1ea5cc 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -550,10 +550,10 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n>  {\n>  \t/*\n>  \t * \\todo Keep this in sync with the actual number of entries.\n> -\t * Currently: 51 entries, 687 bytes of static metadata\n> +\t * Currently: 52 entries, 698 bytes of static metadata\n>  \t */\n>  \tuint32_t numEntries = 52;\n> -\tuint32_t byteSize = 694;\n> +\tuint32_t byteSize = 698;\n>  \n>  \t/*\n>  \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1046,6 +1046,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n>  \t\tANDROID_CONTROL_AWB_STATE,\n>  \t\tANDROID_CONTROL_AWB_LOCK,\n>  \t\tANDROID_LENS_STATE,\n> +\t\tANDROID_REQUEST_PIPELINE_DEPTH,\n>  \t\tANDROID_SCALER_CROP_REGION,\n>  \t\tANDROID_SENSOR_TIMESTAMP,\n>  \t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> @@ -1554,7 +1555,7 @@ void CameraDevice::requestComplete(Request *request)\n>  \t * pipeline handlers) timestamp in the Request itself.\n>  \t */\n>  \tuint64_t timestamp = buffers.begin()->second->metadata().timestamp;\n> -\tresultMetadata = getResultMetadata(descriptor->frameNumber_, timestamp);\n> +\tresultMetadata = getResultMetadata(descriptor, timestamp);\n>  \n>  \t/* Handle any JPEG compression. */\n>  \tfor (unsigned int i = 0; i < descriptor->numBuffers_; ++i) {\n> @@ -1672,15 +1673,17 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n>   * Produce a set of fixed result metadata.\n>   */\n>  std::unique_ptr<CameraMetadata>\n> -CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n> +CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n>  \t\t\t\tint64_t timestamp)\n>  {\n> +\tconst ControlList &metadata = descriptor->request_->request()->metadata();\n> +\n>  \t/*\n>  \t * \\todo Keep this in sync with the actual number of entries.\n>  \t * Currently: 18 entries, 62 bytes\n>  \t */\n>  \tstd::unique_ptr<CameraMetadata> resultMetadata =\n> -\t\tstd::make_unique<CameraMetadata>(18, 62);\n> +\t\tstd::make_unique<CameraMetadata>(19, 63);\n>  \tif (!resultMetadata->isValid()) {\n>  \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n>  \t\treturn nullptr;\n> @@ -1730,6 +1733,14 @@ CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n>  \tresultMetadata->addEntry(ANDROID_STATISTICS_SCENE_FLICKER,\n>  \t\t\t\t &scene_flicker, 1);\n>  \n> +\t/* Add metadata tags reported by libcamera. */\n> +\tif (metadata.contains(controls::draft::PipelineDepth)) {\n> +\t\tuint8_t pipeline_depth =\n> +\t\t\tmetadata.get<int32_t>(controls::draft::PipelineDepth);\n> +\t\tresultMetadata->addEntry(ANDROID_REQUEST_PIPELINE_DEPTH,\n> +\t\t\t\t\t &pipeline_depth, 1);\n> +\t}\n> +\n>  \t/*\n>  \t * Return the result metadata pack even is not valid: get() will return\n>  \t * nullptr.\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 45efcf477436..07d3a846f8e1 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -105,8 +105,8 @@ private:\n>  \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n>  \tCameraMetadata *requestTemplatePreview();\n>  \tlibcamera::PixelFormat toPixelFormat(int format) const;\n> -\tstd::unique_ptr<CameraMetadata> getResultMetadata(int frame_number,\n> -\t\t\t\t\t\t\t  int64_t timestamp);\n> +\tstd::unique_ptr<CameraMetadata> getResultMetadata(\n> +\t\tCamera3RequestDescriptor *descriptor, int64_t timestamp);\n>  \n>  \tunsigned int id_;\n>  \tcamera3_device_t camera3Device_;\n> diff --git a/src/android/camera_worker.h b/src/android/camera_worker.h\n> index fff5021708d7..9417a816c214 100644\n> --- a/src/android/camera_worker.h\n> +++ b/src/android/camera_worker.h\n> @@ -25,6 +25,7 @@ public:\n>  \tCaptureRequest(libcamera::Camera *camera, uint64_t cookie);\n>  \n>  \tconst std::vector<int> &fences() const { return acquireFences_; }\n> +\tconst libcamera::Request *request() const { return request_.get(); }\n\nAs the caller of this function only uses it to access metadata, would it\nmake sense to instead have\n\n\tconst libcamera::ControlList &metadata() const { return request_->metadata(); }\n\nthe same we way have addBuffer() to hide the request ? We could then\npossibly drop patch 1/3.\n\n>  \tvoid addBuffer(libcamera::Stream *stream,\n>  \t\t       libcamera::FrameBuffer *buffer, int fence);","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64879BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Dec 2020 18:32:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3199B6044F;\n\tThu, 10 Dec 2020 19:32:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0960B60323\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Dec 2020 19:32:35 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90CB725E;\n\tThu, 10 Dec 2020 19:32:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ct7SJOSJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607625154;\n\tbh=K+z5dr1NztexAQbDtBzl0VRnAgI3fweC/I0fyLfnioY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ct7SJOSJPShuXegp3ye3dJULxWd2SfxCJvoOSw8M4FAUZfw8k8udXX2r14BMJEG1g\n\txFclgPsWG7F04VUSiYdoKHc1GGxCXGtzII8HA1TKgcbpuo9mfojyr2kpt9UDbIQWrF\n\thuVi2A8MMKefyI7pztCaWSh5ZYrsq1BxaiQWoi+Y=","Date":"Thu, 10 Dec 2020 20:32:29 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<X9JpvWr7HAtjuaJI@pendragon.ideasonboard.com>","References":"<20201209173520.284266-1-jacopo@jmondi.org>\n\t<20201209173520.284266-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201209173520.284266-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Report\n\tpipeline depth","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]