[{"id":14186,"web_url":"https://patchwork.libcamera.org/comment/14186/","msgid":"<9dcf6e44-6e93-b3ac-b97c-ac29a7c9f742@ideasonboard.com>","date":"2020-12-10T09:35:16","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/12/2020 17:35, Jacopo Mondi wrote:\n> Mark the metadata() and controls() operations as const function to make\n> it possible to retrieve them from const Request instances.\n> \n\nIs this accurate? How do applications set controls on the request if\nit's const? (before queueing it)\n\nOr is that done somewhere else?\n\nMetadata certainly seems like it should be const though...\n\n--\nKieran\n\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/request.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 655b1324bae8..1a89622ab989 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -45,8 +45,8 @@ public:\n> \n> \tvoid reuse(ReuseFlag flags = Default);\n> \n> -\tControlList &controls() { return *controls_; }\n> -\tControlList &metadata() { return *metadata_; }\n> +\tControlList &controls() const { return *controls_; }\n> +\tControlList &metadata() const { return *metadata_; }\n> \tconst BufferMap &buffers() const { return bufferMap_; }\n> \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n> \tFrameBuffer *findBuffer(const Stream *stream) const;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A600BD808\n\tfor ;\n\tThu, 10 Dec 2020 09:35:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F67867F6C;\n\tThu, 10 Dec 2020 10:35:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17B7A60323\n\tfor ;\n\tThu, 10 Dec 2020 10:35:21 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 783FC25E;\n\tThu, 10 Dec 2020 10:35:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oaHSYBdB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607592920;\n\tbh=v0LdbNuajS+CTrUfHFPNe16H1z9RRvGxiYNkX3cbJHk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=oaHSYBdBvKCCICj3Zn7i3YJDuFDlEEt7rnPkxxeVin6V44B1g7FByNNT9bgfoKY/W\n\t9sB9hWtl8ygBpR14lzJzCWQoucjpdsMu9Nh6gvOc5SyBF+Zglx8TWEDjW9SvsHIxVh\n\tlKmdBnFOyhzWQeJ/CPQxTPP0nUEkmf2TTzjE9IOY=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201209173520.284266-1-jacopo@jmondi.org>\n\t<20201209173520.284266-2-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9dcf6e44-6e93-b3ac-b97c-ac29a7c9f742@ideasonboard.com>","Date":"Thu, 10 Dec 2020 09:35:16 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201209173520.284266-2-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14188,"web_url":"https://patchwork.libcamera.org/comment/14188/","msgid":"<20201210094308.n2oh4i35vdcg2xna@uno.localdomain>","date":"2020-12-10T09:43:08","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Thu, Dec 10, 2020 at 09:35:16AM +0000, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 09/12/2020 17:35, Jacopo Mondi wrote:\n> > Mark the metadata() and controls() operations as const function to make\n> > it possible to retrieve them from const Request instances.\n> >\n>\n> Is this accurate? How do applications set controls on the request if\n> it's const? (before queueing it)\n\nProbably from a 'const Request' you should only be able to get a\n'const ControlList &' ?\n\n>\n> Or is that done somewhere else?\n>\n> Metadata certainly seems like it should be const though...\n\nHappy to drop the const for controls(). I added it there expecting\nsome questions :)\n\n>\n> --\n> Kieran\n>\n>\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/request.h | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> > index 655b1324bae8..1a89622ab989 100644\n> > --- a/include/libcamera/request.h\n> > +++ b/include/libcamera/request.h\n> > @@ -45,8 +45,8 @@ public:\n> >\n> > \tvoid reuse(ReuseFlag flags = Default);\n> >\n> > -\tControlList &controls() { return *controls_; }\n> > -\tControlList &metadata() { return *metadata_; }\n> > +\tControlList &controls() const { return *controls_; }\n> > +\tControlList &metadata() const { return *metadata_; }\n> > \tconst BufferMap &buffers() const { return bufferMap_; }\n> > \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n> > \tFrameBuffer *findBuffer(const Stream *stream) const;\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89F19BD808\n\tfor ;\n\tThu, 10 Dec 2020 09:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D3C767F6E;\n\tThu, 10 Dec 2020 10:43:01 +0100 (CET)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B5D160323\n\tfor ;\n\tThu, 10 Dec 2020 10:43:00 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 53A79FF802;\n\tThu, 10 Dec 2020 09:42:59 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 10 Dec 2020 10:43:08 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201210094308.n2oh4i35vdcg2xna@uno.localdomain>","References":"<20201209173520.284266-1-jacopo@jmondi.org>\n\t<20201209173520.284266-2-jacopo@jmondi.org>\n\t<9dcf6e44-6e93-b3ac-b97c-ac29a7c9f742@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<9dcf6e44-6e93-b3ac-b97c-ac29a7c9f742@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14189,"web_url":"https://patchwork.libcamera.org/comment/14189/","msgid":"<42f428df-e979-2d55-1405-2456e8575136@ideasonboard.com>","date":"2020-12-10T09:50:54","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 10/12/2020 09:43, Jacopo Mondi wrote:\n> Hi Kieran\n> \n> On Thu, Dec 10, 2020 at 09:35:16AM +0000, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 09/12/2020 17:35, Jacopo Mondi wrote:\n>>> Mark the metadata() and controls() operations as const function to make\n>>> it possible to retrieve them from const Request instances.\n>>>\n>>\n>> Is this accurate? How do applications set controls on the request if\n>> it's const? (before queueing it)\n> \n> Probably from a 'const Request' you should only be able to get a\n> 'const ControlList &' ?\n\nDo applications have a const Request?\nAren't they able to modify it to queue as they need?\n\nerr ...\n\nDo we not have any /setting/ of controls in any of our codebase already?\n(From the public-api viewpoint) I don't think we do...\n\nNo current compiling code /sets/ a control in a request.\nI think we need to do something about that ;-)\n\n--\nKieran\n\n> \n>>\n>> Or is that done somewhere else?\n>>\n>> Metadata certainly seems like it should be const though...\n> \n> Happy to drop the const for controls(). I added it there expecting\n> some questions :)\n> \n>>\n>> --\n>> Kieran\n>>\n>>\n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> include/libcamera/request.h | 4 ++--\n>>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n>>> index 655b1324bae8..1a89622ab989 100644\n>>> --- a/include/libcamera/request.h\n>>> +++ b/include/libcamera/request.h\n>>> @@ -45,8 +45,8 @@ public:\n>>>\n>>> \tvoid reuse(ReuseFlag flags = Default);\n>>>\n>>> -\tControlList &controls() { return *controls_; }\n>>> -\tControlList &metadata() { return *metadata_; }\n>>> +\tControlList &controls() const { return *controls_; }\n>>> +\tControlList &metadata() const { return *metadata_; }\n>>> \tconst BufferMap &buffers() const { return bufferMap_; }\n>>> \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n>>> \tFrameBuffer *findBuffer(const Stream *stream) const;\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F5C7BD80A\n\tfor ;\n\tThu, 10 Dec 2020 09:50:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CEE567F6E;\n\tThu, 10 Dec 2020 10:50:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1AA460323\n\tfor ;\n\tThu, 10 Dec 2020 10:50:56 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7257525E;\n\tThu, 10 Dec 2020 10:50:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"omMEK9TL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607593856;\n\tbh=fw1ioAypeWtEHyUW398R/FsDmDPJHlLt6wzkFZ+iUdA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=omMEK9TLBxUYkEtJJUqgNkBYeq/DS0Lp32cwRM29vSkviJolepYFkYcPov4uMsBfm\n\tu9hK5J66koxUAwdp6mu3K8Uas872/CPfWOJwX1ffPnszvkVtghU+ovqfUWDvc7Xbqv\n\tEX92sK2gKIArnMiOe5wmOzbpCpkh9yPfQP9UWO7w=","To":"Jacopo Mondi ","References":"<20201209173520.284266-1-jacopo@jmondi.org>\n\t<20201209173520.284266-2-jacopo@jmondi.org>\n\t<9dcf6e44-6e93-b3ac-b97c-ac29a7c9f742@ideasonboard.com>\n\t<20201210094308.n2oh4i35vdcg2xna@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<42f428df-e979-2d55-1405-2456e8575136@ideasonboard.com>","Date":"Thu, 10 Dec 2020 09:50:54 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201210094308.n2oh4i35vdcg2xna@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14206,"web_url":"https://patchwork.libcamera.org/comment/14206/","msgid":"","date":"2020-12-10T18:32:19","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, Dec 10, 2020 at 10:43:08AM +0100, Jacopo Mondi wrote:\n> On Thu, Dec 10, 2020 at 09:35:16AM +0000, Kieran Bingham wrote:\n> > On 09/12/2020 17:35, Jacopo Mondi wrote:\n> > > Mark the metadata() and controls() operations as const function to make\n> > > it possible to retrieve them from const Request instances.\n> >\n> > Is this accurate? How do applications set controls on the request if\n> > it's const? (before queueing it)\n> \n> Probably from a 'const Request' you should only be able to get a\n> 'const ControlList &' ?\n\nYes, otherwise the user of a const Request would be allowed to modify\nthe controls and metadata stored in the request, which isn't nice.\nThere's no issue having both\n\n\tControlList &metadata() { return *metadata_; }\n\tconst ControlList &metadata() const { return *metadata_; }\n\nThis however means duplicating the documentation I'm afraid, but we can\nuse copydoc. See ControlValue::data().\n\n> > Or is that done somewhere else?\n> >\n> > Metadata certainly seems like it should be const though...\n> \n> Happy to drop the const for controls(). I added it there expecting\n> some questions :)\n\nUp to you. I don't expect there would be lots of use cases for accessing\ncontrols in a const request, but who knows ?\n\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > include/libcamera/request.h | 4 ++--\n> > > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> > > index 655b1324bae8..1a89622ab989 100644\n> > > --- a/include/libcamera/request.h\n> > > +++ b/include/libcamera/request.h\n> > > @@ -45,8 +45,8 @@ public:\n> > >\n> > > \tvoid reuse(ReuseFlag flags = Default);\n> > >\n> > > -\tControlList &controls() { return *controls_; }\n> > > -\tControlList &metadata() { return *metadata_; }\n> > > +\tControlList &controls() const { return *controls_; }\n> > > +\tControlList &metadata() const { return *metadata_; }\n> > > \tconst BufferMap &buffers() const { return bufferMap_; }\n> > > \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n> > > \tFrameBuffer *findBuffer(const Stream *stream) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 408C8BD808\n\tfor ;\n\tThu, 10 Dec 2020 18:32:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D06B16044F;\n\tThu, 10 Dec 2020 19:32:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0983560323\n\tfor ;\n\tThu, 10 Dec 2020 19:32:25 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72C8025E;\n\tThu, 10 Dec 2020 19:32:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e6QdhlPO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607625144;\n\tbh=5YcDd3HHP2m6nFDpQ9Bn2mhKFvJtojo87VmMetpvbEE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e6QdhlPO25UZIB3AQMytxVFtbDTdxOBqSuVwAVzPew4CmpnGrBAwaGIDPG+eY1nrK\n\tJPQKq/a4USysBrE2VOrInXhjYEOQxrwaaiGSuYZ5EE4pHJ3ZQbpn8Xb1iXmmrJHHrm\n\tJeVp/ITtywVwhpFd4+xSr9gwr0sPvNDl1d1psjE0=","Date":"Thu, 10 Dec 2020 20:32:19 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201209173520.284266-1-jacopo@jmondi.org>\n\t<20201209173520.284266-2-jacopo@jmondi.org>\n\t<9dcf6e44-6e93-b3ac-b97c-ac29a7c9f742@ideasonboard.com>\n\t<20201210094308.n2oh4i35vdcg2xna@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201210094308.n2oh4i35vdcg2xna@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: request: Mark\n\tmetadata() and controls() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]