[{"id":14183,"web_url":"https://patchwork.libcamera.org/comment/14183/","msgid":"","date":"2020-12-10T09:10:26","subject":"Re: [libcamera-devel] [PATCH v4 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for these changes. I've been using them and it behaves as I\nexpect - I got 33ms max exposure during preview (because I set fps 30)\nand then it goes up to 66ms for capture (when I clear the fps\nsetting). Perfect!\n\nAs I mentioned in my previous email, running at 30fps we see the issue\nwhere the exposure deficit (versus the exposure profile) gets made up\nas digital, not analogue, gain - so we'll need to work on the business\nof getting the max exposure into the AGC. But that can happen later.\n\nReviewed-by: David Plowman \nTested-by: David Plowman \n\nBest regards\nDavid\n\nOn Wed, 9 Dec 2020 at 10:26, Naushir Patuck wrote:\n>\n> Set the maximum shutter speed for the normal exposure profile to 66ms.\n> Set the maximum shutter speed for the sport exposure profile to 33ms.\n> Add a long exposure profile to allow shutter speeds of up to 120ms.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--\n> src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--\n> src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--\n> 3 files changed, 39 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\n> index 212f8b9a..1ec338be 100644\n> --- a/src/ipa/raspberrypi/data/imx219.json\n> +++ b/src/ipa/raspberrypi/data/imx219.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 30000, 30000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 30000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\n> index 12fe2f41..9bee3f16 100644\n> --- a/src/ipa/raspberrypi/data/imx477.json\n> +++ b/src/ipa/raspberrypi/data/imx477.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 60000, 120000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 120000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\n> index 3d8a7c8f..1a354f7c 100644\n> --- a/src/ipa/raspberrypi/data/ov5647.json\n> +++ b/src/ipa/raspberrypi/data/ov5647.json\n> @@ -133,7 +133,7 @@\n> {\n> \"shutter\":\n> [\n> - 100, 10000, 30000, 30000, 30000\n> + 100, 10000, 30000, 60000, 66666\n> ],\n> \"gain\":\n> [\n> @@ -144,7 +144,18 @@\n> {\n> \"shutter\":\n> [\n> - 100, 5000, 10000, 20000, 30000\n> + 100, 5000, 10000, 20000, 33333\n> + ],\n> + \"gain\":\n> + [\n> + 1.0, 2.0, 4.0, 6.0, 6.0\n> + ]\n> + },\n> + \"long\":\n> + {\n> + \"shutter\":\n> + [\n> + 100, 10000, 30000, 60000, 120000\n> ],\n> \"gain\":\n> [\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C421BD808\n\tfor ;\n\tThu, 10 Dec 2020 09:10:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D437467F6E;\n\tThu, 10 Dec 2020 10:10:39 +0100 (CET)","from mail-oi1-x241.google.com (mail-oi1-x241.google.com\n\t[IPv6:2607:f8b0:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5496060323\n\tfor ;\n\tThu, 10 Dec 2020 10:10:38 +0100 (CET)","by mail-oi1-x241.google.com with SMTP id x16so5000221oic.3\n\tfor ;\n\tThu, 10 Dec 2020 01:10:38 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"oqjKxBCY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=R1W2E79YfeO6ACBdJek5ZfRLVlBUmmDEKXUiw+JdDG4=;\n\tb=oqjKxBCYFO7/a/R5Z4fOohCPZNB+S/T10gXt8mWCpkupt8wKl776jPibAUOS4g1B2k\n\touHBdbh+ESSArctPke9D2/d/IQFMuMAm6TkWj29ZtTwY7/0tRLn8CLk/eR4K/rIvX6wB\n\teN/NDqklCE2awyEMtqbeMnsT+XtlmrXssIE4KVI9584r6n4gsyZ976h5Sjf5NQ0O6uoe\n\tlcvgHRUO+At504bGWVtPwzAYSY5aA6q9LEjp1Bjzi4B7g8ukER49J7WIKEz5pcMmGJKC\n\t7APNFDXU6F0X1ia9QrxfqoHY5OaX6rZX5wyG25S8pkSwoqSDANXe0wfucUPL2lOHAPPY\n\tWKLQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=R1W2E79YfeO6ACBdJek5ZfRLVlBUmmDEKXUiw+JdDG4=;\n\tb=GOpOma1f1Q2qGXyKTIIXSsRUXXf/NFZwDXkGV4VPtSQCuM320er7o72n8+qd1Q07Ui\n\tAbJrr50bhukXcnLBljqabALcNyM2ZbPd9Hq4iTGXI3aB+1b48cWBUyMisI3SXlodsL3W\n\tdQeVS66BmxhtiTbCPrTjCuHKlvCv0HO3gI6ZAC7MUS0f/tZHCqBSXLNO0DMmXhhCNr4g\n\tdn/ejujYrNfLiA7QWFFeio3W4DAsehr06GFLnvt+89aNxnvLMuMXAB7ANXwDl65gS6uB\n\tzP4i3qALQlM0TkSRYnJN5bPdvqTToQnShfdifmWRECNOPQM0h30lMYxYZDkJDdtFdrcg\n\taEKw==","X-Gm-Message-State":"AOAM530J0MeOyNP3Fu7qg7Dz9nllKbJj5vzY4dlhn31jPgcbZo6NHN8B\n\ta4LT9+CSDZtHZzB5YCXykKd8yWH4WylLs2x6Gp49H+cIFaDbwg==","X-Google-Smtp-Source":"ABdhPJzLT3vfKP+ZUda+7nYoUIwAure/Bx1FPIIFoZXyIId2wJ8DVhmIco1WouxKGD9hTjlqcMv4XFWORpT16y7yqAk=","X-Received":"by 2002:aca:4dc3:: with SMTP id\n\ta186mr4571939oib.107.1607591437261; \n\tThu, 10 Dec 2020 01:10:37 -0800 (PST)","MIME-Version":"1.0","References":"<20201209102630.5562-1-naush@raspberrypi.com>\n\t<20201209102630.5562-4-naush@raspberrypi.com>","In-Reply-To":"<20201209102630.5562-4-naush@raspberrypi.com>","From":"David Plowman ","Date":"Thu, 10 Dec 2020 09:10:26 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v4 3/3] ipa: raspberrypi: config:\n\tUpdate shutter speeds for imx219/477 and ov5647","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]