[{"id":14181,"web_url":"https://patchwork.libcamera.org/comment/14181/","msgid":"","date":"2020-12-10T08:44:53","subject":"Re: [libcamera-devel] [PATCH v4 1/3] libcamera: controls: Add frame\n\tduration control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch, I have been eagerly awaiting this set!\n\nOn Wed, 9 Dec 2020 at 10:26, Naushir Patuck wrote:\n>\n> Add a float array control (controls::FrameDurations) to specify the\n> minimum and maximum (in that order) frame duration to be used by the\n> camera sensor.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 6d6f0fee..cd44a620 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -554,4 +554,17 @@ controls:\n> detection, additional format conversions etc) count as an additional\n> pipeline stage.\n>\n> + - FrameDurations:\n> + type: float\n> + description: |\n> + Specifies the minimum and maximum (in that order) allowable frame\n> + duration, in micro-seconds, for the sensor to use. This could also limit\n> + the largest exposure times the sensor can use. For example, if a maximum\n> + frame duration of 33ms is requested (corresponding to 30 frames per\n> + second), the sensor will not be able raise the exposure time above 33ms.\n> + Note that the sensor may not always be able to provide the requested\n> + frame duration limits depending on its mode configuration.\n\nIs it worth remarking that they can be set to the same values to give\na fixed fps mode of operations? Or is that too obvious to mention?\n\nReviewed-by: David Plowman \nTested-by: David Plowman \n\nBest regards\nDavid\n\n> +\n> + \\sa ExposureTime\n> + size: [2]\n> ...\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A511EBD808\n\tfor ;\n\tThu, 10 Dec 2020 08:45:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2691967F6C;\n\tThu, 10 Dec 2020 09:45:08 +0100 (CET)","from mail-oi1-x241.google.com (mail-oi1-x241.google.com\n\t[IPv6:2607:f8b0:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51D6660323\n\tfor ;\n\tThu, 10 Dec 2020 09:45:06 +0100 (CET)","by mail-oi1-x241.google.com with SMTP id q25so4909869oij.10\n\tfor ;\n\tThu, 10 Dec 2020 00:45:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Mx9eroTL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=nHkn8zgLDIUDrTXegsF9FS4PWnQjFy6Oe8TXrs/MqRM=;\n\tb=Mx9eroTLRYmPuO1eWGgg4LEdaum2o5+lpLFAHTBBxBvUWIF7YJHSOKLKxW81+T9/ux\n\tYuRVu5exZmHltpnHyhmiN+FVRBG4xPFgDTUnTAbNfE8QrXTLj99fiXQB611BzLtf4e7l\n\toNWfbKHNLXxob66/wUI7QzrAom9y68L/bQFifurPJZq49T7scliQFxpRxXydOmN4A+kS\n\tdEL3GsGqYizHSqBOQSV/TnILODBIuXrJeASLZ9ZpUgZn+CruGPU80+dlOslimM3F0mfA\n\tvpe+ujFnsUQddNRV/0bONv9yQ/+RjS0XtwffHZvFEX4ekj/IDfTZvaSzuzvpHz/Vxt22\n\tbLYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=nHkn8zgLDIUDrTXegsF9FS4PWnQjFy6Oe8TXrs/MqRM=;\n\tb=s4uIoVIdKg/6yz+p90g96EicUhhlAjhWhoAXtez8XH9wVgd0Wh+34HTZZ0VvHHGiSB\n\thEFb0oIComws9gbvwVnHUerxj5nXAEZ2U0J6UAU/7h92UNeszzJJL/Vze3Zvbw8kiuxs\n\tVciYbPHvx7iocnlkXhr6/5fcBJ7ccXDiDBERSB72oKkVKTAJ2AlcAzU70uL6oy51UJuZ\n\tCM2sk9ZBsxqE4uMEvtJTLfJ/SvaiSgxXPM962L6RXxW5OPLnixOgdYwVrvU+lYmQ+TU0\n\tzX4lm6llWjyWQw/JzXjL7/LzxQTL4j1adepxpwCt3rzExmoogDz1CMIyHes1rDmgjf2m\n\tA5iw==","X-Gm-Message-State":"AOAM532/Dh026PLjCv5IsivrnrUH2MlXZg9q7VJG4Y2FT0zEIECKCIrX\n\tmHRIEtWx2atcDAoAu57RpMUwvq130EUjZbuwceFpng==","X-Google-Smtp-Source":"ABdhPJwZkz6yyB44IueflWdRAArdPIzh9XJ+iHPlAVeO0as8xGcgGnlEdSHbCotuX/KhFaDn7sam4AyYV/Csq/H7Vz4=","X-Received":"by 2002:aca:4dc3:: with SMTP id\n\ta186mr4528827oib.107.1607589905089; \n\tThu, 10 Dec 2020 00:45:05 -0800 (PST)","MIME-Version":"1.0","References":"<20201209102630.5562-1-naush@raspberrypi.com>\n\t<20201209102630.5562-2-naush@raspberrypi.com>","In-Reply-To":"<20201209102630.5562-2-naush@raspberrypi.com>","From":"David Plowman ","Date":"Thu, 10 Dec 2020 08:44:53 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] libcamera: controls: Add frame\n\tduration control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14184,"web_url":"https://patchwork.libcamera.org/comment/14184/","msgid":"","date":"2020-12-10T09:21:03","subject":"Re: [libcamera-devel] [PATCH v4 1/3] libcamera: controls: Add frame\n\tduration control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your review comments.\n\nOn Thu, 10 Dec 2020 at 08:45, David Plowman \nwrote:\n\n> Hi Naush\n>\n> Thanks for the patch, I have been eagerly awaiting this set!\n>\n> On Wed, 9 Dec 2020 at 10:26, Naushir Patuck wrote:\n> >\n> > Add a float array control (controls::FrameDurations) to specify the\n> > minimum and maximum (in that order) frame duration to be used by the\n> > camera sensor.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 13 +++++++++++++\n> > 1 file changed, 13 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml\n> b/src/libcamera/control_ids.yaml\n> > index 6d6f0fee..cd44a620 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -554,4 +554,17 @@ controls:\n> > detection, additional format conversions etc) count as an\n> additional\n> > pipeline stage.\n> >\n> > + - FrameDurations:\n> > + type: float\n> > + description: |\n> > + Specifies the minimum and maximum (in that order) allowable\n> frame\n> > + duration, in micro-seconds, for the sensor to use. This could\n> also limit\n> > + the largest exposure times the sensor can use. For example, if\n> a maximum\n> > + frame duration of 33ms is requested (corresponding to 30 frames\n> per\n> > + second), the sensor will not be able raise the exposure time\n> above 33ms.\n> > + Note that the sensor may not always be able to provide the\n> requested\n> > + frame duration limits depending on its mode configuration.\n>\n> Is it worth remarking that they can be set to the same values to give\n> a fixed fps mode of operations? Or is that too obvious to mention?\n>\n\nNo harm in adding it I suppose. Will make the change and post an update.\n\nRegards,\nNaush\n\n\n>\n> Reviewed-by: David Plowman \n> Tested-by: David Plowman \n>\n> Best regards\n> David\n>\n> > +\n> > + \\sa ExposureTime\n> > + size: [2]\n> > ...\n> > --\n> > 2.25.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC3F0BD80A\n\tfor ;\n\tThu, 10 Dec 2020 09:21:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DAFB67F6E;\n\tThu, 10 Dec 2020 10:21:22 +0100 (CET)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DCA260323\n\tfor ;\n\tThu, 10 Dec 2020 10:21:20 +0100 (CET)","by mail-lj1-x22d.google.com with SMTP id e7so5858191ljg.10\n\tfor ;\n\tThu, 10 Dec 2020 01:21:20 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"r+rI6/oQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=5pZIHG3Aj8H29lotrReb2DpxbUKK27l89+oFqguBdqQ=;\n\tb=r+rI6/oQCHe+hraMrZO0sVTO6bnPTyDXgRX45SGlkU8MIZChKtc25qW5G5w6AzgQZl\n\t/pUa1b6h7uJGuq2fwU+GsmpylZkBvaON/GekkywtpEkrra0sVYv624piu/6cyuL9+/uv\n\tqeM9CBWBSzkwiCG791bO2iEeNYvOonjvdfClLsCbPex4UsBVmajLEKeGxhi4SFjRqyFW\n\ttKKMsuAfveNV5pESuu7/TtOCpqfjm8s7i2OltSwNJTpiCptWhxFnXbA8/FMFXMSJiNOW\n\tQdcsmzySHGh2rbZeBnOxkTCE1Qrl+Z2GJ5v6CITeS8q/eEnaxy0/An7Ydc5LOGz2pCun\n\tyOVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=5pZIHG3Aj8H29lotrReb2DpxbUKK27l89+oFqguBdqQ=;\n\tb=BL81O8mamp9k+MvnPm0abBZn667CrKQKUnxg4kTVydDG708YKl3+410PAwc9lDrMVE\n\tVOnIhEeIFjZ2ggB9l4I71yrIebthQvFrLcJvSemFTnMInt+B2G6/MMhHrMKuf47PVoV4\n\t/jyigInCu4hCsDjap2bhuvgHZfTzOs4r3II6TdUqXMj4t6aq2DxmWjt2pROUa9/BzEil\n\tB0wUkXRNxThjQbepfaxC5ZIeSnHBlqzsSyezgT4aT9VfR+WNss4o897J2iYAXqUPgfm6\n\tpaLBDtwBari6aNjohtbpbivPPZrwbyAFLerDwGRejW+hhvrY/TVaQnJixAsq/c6LmV5T\n\tEktA==","X-Gm-Message-State":"AOAM531aiOoyh+YKN/zm6ndGeUaTvqDpmyjbGPHL69B2xvxMq+bpef4f\n\ttFVEpZjXlwEEonqMbhRGjnAIHURdJxyyefeZF0QY+g==","X-Google-Smtp-Source":"ABdhPJwY+l8feLEtpT+XufFh4c+FpBLvxM5W68VCLCyVvABQuhl74VTeoiTmI0RvraGraXN0TgYJfYM9VdkW9TWuZPI=","X-Received":"by 2002:a05:651c:503:: with SMTP id\n\to3mr2496029ljp.253.1607592079375; \n\tThu, 10 Dec 2020 01:21:19 -0800 (PST)","MIME-Version":"1.0","References":"<20201209102630.5562-1-naush@raspberrypi.com>\n\t<20201209102630.5562-2-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Thu, 10 Dec 2020 09:21:03 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] libcamera: controls: Add frame\n\tduration control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4262420436666849931==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]