[{"id":14152,"web_url":"https://patchwork.libcamera.org/comment/14152/","msgid":"<20201208183848.gee55antup5vebzq@uno.localdomain>","date":"2020-12-08T18:38:48","subject":"Re: [libcamera-devel] [PATCH v4 1/3] android: camera_device:\n\tIntroduce Camera3StreamConfig","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Tue, Dec 08, 2020 at 03:42:31AM +0000, Hirokazu Honda wrote:\n> Camera3StreamConfig is a new class to store camera3_stream and\n> types with associated StreamConfiguration.\n>\n> Signed-off-by: Hirokazu Honda \n\nPlease retain tags received on previous versions, or if you drop them\nintentionally feel free to mention it explicitly.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 675af570..09269d95 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -128,6 +128,18 @@ const std::map camera3FormatsMap = {\n> \t},\n> };\n>\n> +/*\n> + * \\struct Camera3StreamConfig\n> + * \\brief Data to store StreamConfiguration associated with camera3_stream(s).\n> + * \\var streams List of streams requested by Android HAL client.\n> + * \\var types List of CameraStream::Type associated with streams.\n> + * \\var config StreamConfiguration for streams.\n> + */\n> +struct Camera3StreamConfig {\n> +\tstd::vector streams;\n> +\tstd::vector types;\n> +\tStreamConfiguration config;\n> +};\n> } /* namespace */\n>\n> LOG_DECLARE_CATEGORY(HAL)\n> --\n> 2.29.2.576.ga3fc446d84-goog","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DCF7BDB1F\n\tfor ;\n\tTue, 8 Dec 2020 18:38:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7A2D67F09;\n\tTue, 8 Dec 2020 19:38:41 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F44E67F08\n\tfor ;\n\tTue, 8 Dec 2020 19:38:40 +0100 (CET)","from uno.localdomain (mob-37-118-42-44.net.vodafone.it\n\t[37.118.42.44]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 99C2020002;\n\tTue, 8 Dec 2020 18:38:39 +0000 (UTC)"],"X-Originating-IP":"37.118.42.44","Date":"Tue, 8 Dec 2020 19:38:48 +0100","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20201208183848.gee55antup5vebzq@uno.localdomain>","References":"<20201208034234.2501401-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201208034234.2501401-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] android: camera_device:\n\tIntroduce Camera3StreamConfig","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14158,"web_url":"https://patchwork.libcamera.org/comment/14158/","msgid":"","date":"2020-12-08T23:54:58","subject":"Re: [libcamera-devel] [PATCH v4 1/3] android: camera_device:\n\tIntroduce Camera3StreamConfig","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo,\n\nOn Wed, Dec 9, 2020 at 3:38 AM Jacopo Mondi wrote:\n>\n> Hi Hiro,\n>\n> On Tue, Dec 08, 2020 at 03:42:31AM +0000, Hirokazu Honda wrote:\n> > Camera3StreamConfig is a new class to store camera3_stream and\n> > types with associated StreamConfiguration.\n> >\n> > Signed-off-by: Hirokazu Honda \n>\n> Please retain tags received on previous versions, or if you drop them\n> intentionally feel free to mention it explicitly.\n>\n> Reviewed-by: Jacopo Mondi \n>\n\nThanks for reviewing.\nI definitely forgot adding it sorry.\n\nRegards,\n-Hiro\n> Thanks\n> j\n>\n> > ---\n> > src/android/camera_device.cpp | 12 ++++++++++++\n> > 1 file changed, 12 insertions(+)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 675af570..09269d95 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -128,6 +128,18 @@ const std::map camera3FormatsMap = {\n> > },\n> > };\n> >\n> > +/*\n> > + * \\struct Camera3StreamConfig\n> > + * \\brief Data to store StreamConfiguration associated with camera3_stream(s).\n> > + * \\var streams List of streams requested by Android HAL client.\n> > + * \\var types List of CameraStream::Type associated with streams.\n> > + * \\var config StreamConfiguration for streams.\n> > + */\n> > +struct Camera3StreamConfig {\n> > + std::vector streams;\n> > + std::vector types;\n> > + StreamConfiguration config;\n> > +};\n> > } /* namespace */\n> >\n> > LOG_DECLARE_CATEGORY(HAL)\n> > --\n> > 2.29.2.576.ga3fc446d84-goog","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 086C4BDE17\n\tfor ;\n\tTue, 8 Dec 2020 23:55:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 770F967F14;\n\tWed, 9 Dec 2020 00:55:12 +0100 (CET)","from mail-ej1-x642.google.com (mail-ej1-x642.google.com\n\t[IPv6:2a00:1450:4864:20::642])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC9F967F10\n\tfor ;\n\tWed, 9 Dec 2020 00:55:09 +0100 (CET)","by mail-ej1-x642.google.com with SMTP id lt17so396769ejb.3\n\tfor ;\n\tTue, 08 Dec 2020 15:55:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"TiOLtd7n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=mj2oMzl/kN/Wwh0AVWFaFYAaU2r0nsK2GlHfquIDl98=;\n\tb=TiOLtd7nPPhSwg18kfZs+egDtdrlyZOXvB1CAYPDcAs4iLwl/GhLFom7yZxvNC2geD\n\tFFTJM4UDgN4C2aLcWE978LX2NIiVcoB3lYxzFzgu7XnjHlOdrQ86mXB/Ig+Ug7Dne6XV\n\thQmKvyYc+cibpAAH9RzBkrDCvS+qA+9TyRohQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=mj2oMzl/kN/Wwh0AVWFaFYAaU2r0nsK2GlHfquIDl98=;\n\tb=AR5s74n2wBIyVah2XBU6822IcwukgHTMIjJiUULm67IYe7DTrCAGLYG59avTNy/0tn\n\tVGL53twxhuVaXndhLRygmJvElcYeS8bHEitrgj0Ub+QhPAoOPL8QqCfJqQkO7sWjYHRN\n\tvgX2ETiGwCjt8msYJAc6zTdkX71BzrhAY+hpC58NKO77czNTRwwQbCz4MUzEzHWeI4yD\n\tsPZolup6hur1j14ycGwnshCfZvaxEbLjoP7zRD7OCG9kpeQimslWboPvkt7tyyAnv+ep\n\tboG+V+0xUyb6l+dCyfnpdJ42f3Vf6iBcxn652XsVw8oBXvSD7YyvB9/ZG5E9AXIgfReP\n\t7rmA==","X-Gm-Message-State":"AOAM532brmrekI/R1Gc9odjOaUbNl3QOcW3TWQyv1fleQfmEF83cFtmT\n\t7aHJD9sVzasnYSXdNPTwKNTjhu4BZxpcDvoVFdhAxA==","X-Google-Smtp-Source":"ABdhPJwSyuA1drSEiyy+Tn4Oieuoe92xENzb8LRCAVSKqS4IGItKz6gSIaKDn4+gFxL17IQQT3MtEWEZLTnJl+CbLvk=","X-Received":"by 2002:a17:906:a982:: with SMTP id\n\tjr2mr148540ejb.292.1607471709238; \n\tTue, 08 Dec 2020 15:55:09 -0800 (PST)","MIME-Version":"1.0","References":"<20201208034234.2501401-1-hiroh@chromium.org>\n\t<20201208183848.gee55antup5vebzq@uno.localdomain>","In-Reply-To":"<20201208183848.gee55antup5vebzq@uno.localdomain>","From":"Hirokazu Honda ","Date":"Wed, 9 Dec 2020 08:54:58 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] android: camera_device:\n\tIntroduce Camera3StreamConfig","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]