[{"id":14108,"web_url":"https://patchwork.libcamera.org/comment/14108/","msgid":"","date":"2020-12-07T19:15:47","subject":"Re: [libcamera-devel] [PATCH 4/4] meson: test: Simplify top level\n\tmeson","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Dec 07, 2020 at 03:07:37PM +0000, Kieran Bingham wrote:\n> Utilise the subdir_done() functionality as is used with other optional components\n> to simplify the top level meson file.\n> \n> Suggested-by: Jacopo Mondi \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> meson.build | 5 +----\n> test/meson.build | 4 ++++\n> 2 files changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 55cf36e15f57..c47eb420f4db 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -121,10 +121,7 @@ subdir('src')\n> # through configuration values. They are enabled by default.\n> \n> subdir('Documentation')\n> -\n> -if get_option('test')\n> - subdir('test')\n> -endif\n> +subdir('test')\n> \n> if not meson.is_cross_build()\n> kernel_version_req = '>= 5.0.0'\n> diff --git a/test/meson.build b/test/meson.build\n> index 0a1d434e3996..7f0682ad9efe 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -1,5 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +if not get_option('test')\n> + subdir_done()\n> +endif\n> +\n> subdir('libtest')\n> \n> subdir('camera')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41709BDB1F\n\tfor ;\n\tMon, 7 Dec 2020 19:15:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2FC067E6A;\n\tMon, 7 Dec 2020 20:15:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C368635A0\n\tfor ;\n\tMon, 7 Dec 2020 20:15:50 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B56B48D;\n\tMon, 7 Dec 2020 20:15:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ECv2BZ+I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607368549;\n\tbh=/cmW4Qd3lj/PAWbS72I4Uo7Pkr3dKyzq05Ule47mE0E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ECv2BZ+I7ugH/S90RRAF8Qf7OWLFcrysaAKUfKiQoMNX4XcLSLwEhg8GMCUZiE2sm\n\t0Zr/gLYc3H08RK2h8NWLfqdaYuQy/iBqwHDPhX/kc0dbQgqpx8ZwJPOz7oulego/od\n\tw30X0QXxp4csFJOKIaFrH3nX0rUFgKd7jHeZcAfM=","Date":"Mon, 7 Dec 2020 21:15:47 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20201207150737.307692-1-kieran.bingham@ideasonboard.com>\n\t<20201207150737.307692-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201207150737.307692-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/4] meson: test: Simplify top level\n\tmeson","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]