{"id":10593,"url":"https://patchwork.libcamera.org/api/patches/10593/?format=json","web_url":"https://patchwork.libcamera.org/patch/10593/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201207150737.307692-2-kieran.bingham@ideasonboard.com>","date":"2020-12-07T15:07:34","name":"[libcamera-devel,1/4] src: meson: Re-order subdir layout","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7e2c73ef2b81921bb9ec3892e5f8bfd7c0d936f9","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10593/mbox/","series":[{"id":1510,"url":"https://patchwork.libcamera.org/api/series/1510/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1510","date":"2020-12-07T15:07:33","name":"libcamera: Small meson-fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/1510/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10593/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10593/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAF4EBDB20\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  7 Dec 2020 15:07:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8965967E50;\n\tMon,  7 Dec 2020 16:07:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0EDA63546\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  7 Dec 2020 16:07:43 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B1F645D;\n\tMon,  7 Dec 2020 16:07:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NoAsvJPO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607353663;\n\tbh=/kn+pKO4x3p1qU1XkKJYYUy+lbyjJNEc6gXfnPstHNA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NoAsvJPOnRIyAJokj0NjRAGqVa/yr0ojckbijkxieq3gQUOeA2ZbojuXkAzwUgxMi\n\tIBFuolsF1bTC6Tz4GqPvlLpAq5VXf9uPHjnnWmH1ZWzb/npVF+XFkea+IgK4LeLOD7\n\tzxYQrA724sfLZu+ZqFDt5SVs9UU75cuFMJR1jTp0=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Mon,  7 Dec 2020 15:07:34 +0000","Message-Id":"<20201207150737.307692-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201207150737.307692-1-kieran.bingham@ideasonboard.com>","References":"<20201207150737.307692-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/4] src: meson: Re-order subdir layout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Move the android subdir below the configuration options to keep all\nsubdirs together.\n\nAdd a comment explaining why android must come first, and some padding\nto group the libcamera and ipa components, applications, and remaining\nadaptation layers.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/meson.build | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/meson.build b/src/meson.build\nindex b9c7e7599d61..8e219943acb8 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -1,7 +1,5 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-subdir('android')\n-\n openssl = find_program('openssl', required : true)\n if openssl.found()\n     ipa_priv_key = custom_target('ipa-priv-key',\n@@ -13,8 +11,13 @@ else\n     ipa_sign_module = false\n endif\n \n+# The 'android' subdir must be processed first, and the build targets\n+# are included directly into the libcamera library when this is enabled.\n+subdir('android')\n+\n subdir('libcamera')\n subdir('ipa')\n+\n subdir('cam')\n subdir('qcam')\n \n","prefixes":["libcamera-devel","1/4"]}