[{"id":14285,"web_url":"https://patchwork.libcamera.org/comment/14285/","msgid":"","date":"2020-12-18T16:33:21","subject":"Re: [libcamera-devel] [PATCH v5 10/23] ipa: raspberrypi: meson: Add\n\tdependency on generated headers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-12-05 19:30:53 +0900, Paul Elder wrote:\n> The raspberrypi IPA will depend on the raspberrypi IPA header generated\n> from the mojo definition file. Add the dependency. Simply add all\n> generated headers as a dependency, instead of walking the list of\n> headers, to simplify the implementation. This will have the effect of\n> generating all headers before compiling the IPA, which has no drawbacks.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> No change in v5\n> \n> Changes in v4:\n> - rename libcamera_generated_headers to libcamera_generated_ipa_headers\n> \n> Changes in v3:\n> - expand changelog\n> \n> New in v2\n> ---\n> src/ipa/raspberrypi/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\n> index 9445cd09..4331f718 100644\n> --- a/src/ipa/raspberrypi/meson.build\n> +++ b/src/ipa/raspberrypi/meson.build\n> @@ -42,7 +42,7 @@ rpi_ipa_sources = files([\n> ])\n> \n> mod = shared_module(ipa_name,\n> - rpi_ipa_sources,\n> + [rpi_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> include_directories : rpi_ipa_includes,\n> dependencies : rpi_ipa_deps,\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F313C0F1A\n\tfor ;\n\tFri, 18 Dec 2020 16:33:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BAA861595;\n\tFri, 18 Dec 2020 17:33:27 +0100 (CET)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CFDA6052C\n\tfor ;\n\tFri, 18 Dec 2020 17:33:26 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id s26so6895078lfc.8\n\tfor ;\n\tFri, 18 Dec 2020 08:33:26 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tp24sm976322lfo.53.2020.12.18.08.33.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Dec 2020 08:33:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"PqEbOWLa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=jY1llj9/Qhiaz6WGhKQLok6D34KXyCoa++l2JFPW9Mg=;\n\tb=PqEbOWLaDFHOPdWN4ORm6Hv9Q1CNKKZ6aWpd5bpJaPIFfnyDQwvkFc/lEIC0+1d9UV\n\toe7kh03MpxAl5r7NDUT/f+R0Okw/tHeZGQeYwgyuNtUnLj0/oP2GW/e3g1kCJSHQGBrq\n\taM/ReWgF3xXt2nOPfbqePXKVIgvHjBzAcPmT4y94weL18MYBhAbwJ5xLKodSjyHEi6e2\n\tUoGd1zn3r1US8aJVE0yXdehtahgnQAQYUg+S347uOaiYV5hJjphSQavSaYMSRSySZ7oI\n\t8ff4dq/p5vYvPu53RgTdLfap6t6zmqBSSjnxGGaFSpsIkEq6S0U0IzVe+Ns1q/iyP5dy\n\t5Y6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=jY1llj9/Qhiaz6WGhKQLok6D34KXyCoa++l2JFPW9Mg=;\n\tb=nIzsgxsdVb0OuGEp/rX1aY834M9L8zci7Mh8sjSMK29XE4xYU1zdI18jwqYmj4Q+hh\n\tPU1w8M1ztlF6XKkUF/LF79S4ZN9yGmTEn5lfmmHEgY1b25lWIK9/nweKWf8FFwqnsxht\n\tx6VQGGkqfx94T7WbQOpHgwlYMwfMbBNEIlO9H+R9LVAUG5XtvmUrGQtckmZr2L93aXqe\n\tdxJWLdciRPjZr3/Z7fYJpkUVXElEbPt4/v4h/jEjXduUvX2fuCRtx3W+0/G1Xq1runLI\n\tIko78MEYyc5655uUSmL/7GYZssww45C9kaK24DLBk+uoZjeM/WvbumflMVtiPdgTsnB4\n\t5Wtw==","X-Gm-Message-State":"AOAM533pqKdPBgbMRFeJdYUWGYLYD9kiXX7oYOgY+LcgH1uBa+ok2dbO\n\t91VHwpcIRZAn7uMvUQY9QXFUzQ==","X-Google-Smtp-Source":"ABdhPJy4s182sKA4ou/V7xwVKcdPQgY3eyAvH7KTHRZIHxgsJWrMLqFMWk8GCkSsoQycFcDQ+XFa9Q==","X-Received":"by 2002:a2e:8297:: with SMTP id\n\ty23mr2083913ljg.177.1608309205613; \n\tFri, 18 Dec 2020 08:33:25 -0800 (PST)","Date":"Fri, 18 Dec 2020 17:33:21 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"","References":"<20201205103106.242080-1-paul.elder@ideasonboard.com>\n\t<20201205103106.242080-11-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201205103106.242080-11-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 10/23] ipa: raspberrypi: meson: Add\n\tdependency on generated headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]