[{"id":14037,"web_url":"https://patchwork.libcamera.org/comment/14037/","msgid":"<20201204095823.3uopgdhsi7phmdrv@uno.localdomain>","date":"2020-12-04T09:58:23","subject":"Re: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello\n can we remove the end . in $subject when applying ?\n\nThanks\n j\nOn Fri, Dec 04, 2020 at 12:24:50PM +0530, Umang Jain wrote:\n> Failing to do so, the codepath will segfault while trying to acquire\n> a non-existent camera.\n>\n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> ---\n> simple-cam.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index e88fb85..aace5c8 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -307,6 +307,13 @@ int main()\n> \tfor (std::unique_ptr &request : requests)\n> \t\tcamera->queueRequest(request.get());\n>\n> +\tif (!cm->cameras().size()) {\n> +\t\tstd::cout << \"No cameras were identified on the system.\"\n> +\t\t\t << std::endl;\n> +\t\tcm->stop();\n> +\t\treturn EXIT_FAILURE;\n> +\t}\n> +\n> \t/*\n> \t * --------------------------------------------------------------------\n> \t * Run an EventLoop\n> --\n> 2.26.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3118BBE177\n\tfor ;\n\tFri, 4 Dec 2020 09:58:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A37BB635D6;\n\tFri, 4 Dec 2020 10:58:18 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B8E1635D0\n\tfor ;\n\tFri, 4 Dec 2020 10:58:17 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9027E40006;\n\tFri, 4 Dec 2020 09:58:16 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 4 Dec 2020 10:58:23 +0100","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20201204095823.3uopgdhsi7phmdrv@uno.localdomain>","References":"<20201204065452.2764628-1-email@uajain.com>\n\t<20201204065452.2764628-3-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201204065452.2764628-3-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14038,"web_url":"https://patchwork.libcamera.org/comment/14038/","msgid":"<2d25bc98-f7d1-1cbf-74b9-3d323185f1ce@uajain.com>","date":"2020-12-04T10:14:39","subject":"Re: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi\n\nOn 12/4/20 3:28 PM, Jacopo Mondi wrote:\n> Hello\n> can we remove the end . in $subject when applying ?\n>\n> Thanks\n> j\nDamn it, Laurent pointed this out but i forgot again. Sorry.\nKieran please amend while applying.\n> On Fri, Dec 04, 2020 at 12:24:50PM +0530, Umang Jain wrote:\n>> Failing to do so, the codepath will segfault while trying to acquire\n>> a non-existent camera.\n>>\n>> Signed-off-by: Umang Jain \n>> Reviewed-by: Kieran Bingham \n>> Reviewed-by: Laurent Pinchart \n>> ---\n>> simple-cam.cpp | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>> index e88fb85..aace5c8 100644\n>> --- a/simple-cam.cpp\n>> +++ b/simple-cam.cpp\n>> @@ -307,6 +307,13 @@ int main()\n>> \tfor (std::unique_ptr &request : requests)\n>> \t\tcamera->queueRequest(request.get());\n>>\n>> +\tif (!cm->cameras().size()) {\n>> +\t\tstd::cout << \"No cameras were identified on the system.\"\n>> +\t\t\t << std::endl;\n>> +\t\tcm->stop();\n>> +\t\treturn EXIT_FAILURE;\n>> +\t}\n>> +\n>> \t/*\n>> \t * --------------------------------------------------------------------\n>> \t * Run an EventLoop\n>> --\n>> 2.26.2\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC4FFBE176\n\tfor ;\n\tFri, 4 Dec 2020 10:14:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55E0F635D7;\n\tFri, 4 Dec 2020 11:14:43 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3164A635D2\n\tfor ;\n\tFri, 4 Dec 2020 11:14:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"frB2mXdB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1607076881; bh=2O2zrUjxF2bWoSplc2agPoVelhYvk//8PpEfU2Q8VVg=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=frB2mXdBql023VH6OlVFlNeKt1PxMchecdBj6BA0cFTfF7fvcu96NUr7CSWfyKehs\n\tobZbHwz2cM2s+OvFlVM3p0DALztCGODKLfT9YaB+axYMTvkwk99SUyo3IGp4jcNp64\n\ttQGEKd/W9TuCDkCrUdANKLvRB4cVJJ/MBbKqdoziSM/x0ke/l+388fuczNRGrYhl/V\n\t0C6loZwX4Z9kya3BZUBNvipKe0ICfkkL6DKMhMeE4rZsME+ZwbRVTcREIH2FhMI9/j\n\tw0A5EZ/PnvpYjpWiOH/yL42s6nLXvyYcExFxaQnTztgndqMWAGkhdsiEK6AVcAYfYv\n\tQornx48Y6+1Ng==","To":"Jacopo Mondi ","References":"<20201204065452.2764628-1-email@uajain.com>\n\t<20201204065452.2764628-3-email@uajain.com>\n\t<20201204095823.3uopgdhsi7phmdrv@uno.localdomain>","From":"Umang Jain ","Message-ID":"<2d25bc98-f7d1-1cbf-74b9-3d323185f1ce@uajain.com>","Date":"Fri, 4 Dec 2020 15:44:39 +0530","Mime-Version":"1.0","In-Reply-To":"<20201204095823.3uopgdhsi7phmdrv@uno.localdomain>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14042,"web_url":"https://patchwork.libcamera.org/comment/14042/","msgid":"<51b4f211-f0c3-e731-b343-4275b5e13a82@ideasonboard.com>","date":"2020-12-04T10:28:01","subject":"Re: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 04/12/2020 10:14, Umang Jain wrote:\n> Hi\n> \n> On 12/4/20 3:28 PM, Jacopo Mondi wrote:\n>> Hello\n>>     can we remove the end . in $subject when applying ?\n>>\n>> Thanks\n>>      j\n> Damn it, Laurent pointed this out but i forgot again. Sorry.\n> Kieran please amend while applying.\n\nRemoved.\n\n\n>> On Fri, Dec 04, 2020 at 12:24:50PM +0530, Umang Jain wrote:\n>>> Failing to do so, the codepath will segfault while trying to acquire\n>>> a non-existent camera.\n>>>\n>>> Signed-off-by: Umang Jain \n>>> Reviewed-by: Kieran Bingham \n>>> Reviewed-by: Laurent Pinchart \n>>> ---\n>>>   simple-cam.cpp | 7 +++++++\n>>>   1 file changed, 7 insertions(+)\n>>>\n>>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>>> index e88fb85..aace5c8 100644\n>>> --- a/simple-cam.cpp\n>>> +++ b/simple-cam.cpp\n>>> @@ -307,6 +307,13 @@ int main()\n>>>       for (std::unique_ptr &request : requests)\n>>>           camera->queueRequest(request.get());\n>>>\n>>> +    if (!cm->cameras().size()) {\n>>> +        std::cout << \"No cameras were identified on the system.\"\n>>> +              << std::endl;\n>>> +        cm->stop();\n>>> +        return EXIT_FAILURE;\n>>> +    }\n>>> +\n>>>       /*\n>>>        *\n>>> --------------------------------------------------------------------\n>>>        * Run an EventLoop\n>>> -- \n>>> 2.26.2\n>>>\n>>> _______________________________________________\n>>> libcamera-devel mailing list\n>>> libcamera-devel@lists.libcamera.org\n>>> https://lists.libcamera.org/listinfo/libcamera-devel\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71450BE176\n\tfor ;\n\tFri, 4 Dec 2020 10:28:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E8D5635DB;\n\tFri, 4 Dec 2020 11:28:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33503635D8\n\tfor ;\n\tFri, 4 Dec 2020 11:28:04 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C354F99A;\n\tFri, 4 Dec 2020 11:28:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p/4Hp0sM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607077683;\n\tbh=MR561Oi4J823WlepGmyq2cZ5VeAneW8PC6l4OL3jnvk=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=p/4Hp0sMTM7qm8rgBSCw+e8qciGuuo0XlZxcid+JMd3sZFPnwadOt63qwQv3/fLjG\n\tCLGMiSCPz8O4ex51MRFD5mbZ25PaLXQPkeH3DcYAs1NKQvqrbkSwI9DBddwjl0dRMG\n\tLt2UCSnDZNVUX8Si2Wo0d8prqSS0UGC33heXkkDg=","To":"Umang Jain , Jacopo Mondi ","References":"<20201204065452.2764628-1-email@uajain.com>\n\t<20201204065452.2764628-3-email@uajain.com>\n\t<20201204095823.3uopgdhsi7phmdrv@uno.localdomain>\n\t<2d25bc98-f7d1-1cbf-74b9-3d323185f1ce@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<51b4f211-f0c3-e731-b343-4275b5e13a82@ideasonboard.com>","Date":"Fri, 4 Dec 2020 10:28:01 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<2d25bc98-f7d1-1cbf-74b9-3d323185f1ce@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]