{"id":10553,"url":"https://patchwork.libcamera.org/api/patches/10553/?format=json","web_url":"https://patchwork.libcamera.org/patch/10553/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201204065452.2764628-2-email@uajain.com>","date":"2020-12-04T06:54:49","name":"[libcamera-devel,v3,1/4] simple-cam: Make return codes consistent for main()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"024492c6917701bee90eb52f0243e005f496cfb8","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10553/mbox/","series":[{"id":1502,"url":"https://patchwork.libcamera.org/api/series/1502/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1502","date":"2020-12-04T06:54:48","name":"simple-cam: Provide event-loop backed by libevent","version":3,"mbox":"https://patchwork.libcamera.org/series/1502/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10553/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10553/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84A73BE177\n\tfor ;\n\tFri, 4 Dec 2020 06:55:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D45C635D2;\n\tFri, 4 Dec 2020 07:55:05 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74891635D1\n\tfor ;\n\tFri, 4 Dec 2020 07:55:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"qqYLkn90\"; dkim-atps=neutral","From":"Umang Jain ","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1607064903; bh=0KCGP4zxC3q9W8gTwNnQUVSqEd/MT8angyTCA5ukjzg=;\n\th=From:To:Cc:Subject:In-Reply-To:References;\n\tb=qqYLkn90o9GmXkDLqGbfQ6qXP3nc4TQQp0038PfahHbnEEWkaNBapGhannhTD6V92\n\tAHzA8mS9OL5bZJPP6jphLMDoQns1HRz5GiITfIfa1Bk5ZsMhVZa+ctEgQNjRWHyXH5\n\tQIB6WZ6c5UR1aIc4YLcmcYc92ksO1/xyiGhx+dDvVU41BkT3srK8LYgcNfOJGStORQ\n\tCTXRlh02BGNMYFSxsB21DJnud0j1DStK/IjUIy0MCJVbwfkGsp4eJCBbqZwqb9h9rm\n\tVhw+eCJAxJC0WaBZQH9IPOvsrMNwBsIp6xpwXJ2ETFLl0DRChxABK0swLBa5RYcWWA\n\tbsaxPqOMMBGzg==","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 4 Dec 2020 12:24:49 +0530","Message-Id":"<20201204065452.2764628-2-email@uajain.com>","In-Reply-To":"<20201204065452.2764628-1-email@uajain.com>","References":"<20201204065452.2764628-1-email@uajain.com>","Mime-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 1/4] simple-cam: Make return codes\n\tconsistent for main()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use EXIT_FAILURE or EXIT_SUCCESS to indicate program execution\nstatus. These are the return codes that should be used for main()\nas per the C++ standard.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n simple-cam.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 727bb6d..e88fb85 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -184,7 +184,7 @@ int main()\n \tint ret = camera->configure(config.get());\n \tif (ret) {\n \t\tstd::cout << \"CONFIGURATION FAILED!\" << std::endl;\n-\t\treturn -1;\n+\t\treturn EXIT_FAILURE;\n \t}\n #endif\n \n@@ -217,7 +217,7 @@ int main()\n \t\tint ret = allocator->allocate(cfg.stream());\n \t\tif (ret < 0) {\n \t\t\tstd::cerr << \"Can't allocate buffers\" << std::endl;\n-\t\t\treturn -ENOMEM;\n+\t\t\treturn EXIT_FAILURE;\n \t\t}\n \n \t\tunsigned int allocated = allocator->buffers(cfg.stream()).size();\n@@ -250,7 +250,7 @@ int main()\n \t\tif (!request)\n \t\t{\n \t\t\tstd::cerr << \"Can't create request\" << std::endl;\n-\t\t\treturn -ENOMEM;\n+\t\t\treturn EXIT_FAILURE;\n \t\t}\n \n \t\tconst std::unique_ptr &buffer = buffers[i];\n@@ -259,7 +259,7 @@ int main()\n \t\t{\n \t\t\tstd::cerr << \"Can't set buffer for request\"\n \t\t\t\t << std::endl;\n-\t\t\treturn ret;\n+\t\t\treturn EXIT_FAILURE;\n \t\t}\n \n \t\t/*\n@@ -341,5 +341,5 @@ int main()\n \tcamera.reset();\n \tcm->stop();\n \n-\treturn 0;\n+\treturn EXIT_SUCCESS;\n }\n","prefixes":["libcamera-devel","v3","1/4"]}