[{"id":14033,"web_url":"https://patchwork.libcamera.org/comment/14033/","msgid":"<20201202155941.7crqagmzuhgclm26@uno.localdomain>","date":"2020-12-02T15:59:41","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: camera_sensor:\n\tAdjust CameraSensorInfo::analogCrop","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi list,\n\nOn Wed, Dec 02, 2020 at 02:53:51PM +0100, Jacopo Mondi wrote:\n> The CameraSensorInfo::analogCrop top-left corner is defined relatively\n> to the sensor active area.\n>\n> The analogCrop rectangle is constucted by retrieving the V4L2\n> selection target V4L2_SEL_TGT_CROP which is instead defined relatively\n> to the whole sensor's pixel array size.\n>\n> Adjust the the analogCrop rectangle subtracting from its top-left corner\n> the active area distance from the full pixel array.\n>\n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n>\n> ---\n> This patch depends on kernel patch:\n> \"media: i2c: imx219: Selection compliance fixes\":\n>\n> RPi downstream: https://github.com/raspberrypi/linux/pull/3983\n> Linux mainline (should land in v5.11)\n> https://patchwork.linuxtv.org/project/linux-media/patch/20200805105721.15445-5-jacopo@jmondi.org/\n\nBoth patches have now been collected\n\n> ---\n> src/libcamera/camera_sensor.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 935de528c496..c5fa89143ac8 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -527,6 +527,16 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n> \t\treturn ret;\n> \t}\n>\n> +\t/*\n> +\t * CameraSensorInfo::analogCrop::x and CameraSensorInfo::analogCrop::y\n> +\t * are defined relatively to the active pixel area, while V4L2's\n> +\t * TGT_CROP target is defined in respect to the full pixel array.\n> +\t *\n> +\t * Compensate it by subtracting the active areas offset.\n> +\t */\n> +\tinfo->analogCrop.x -= rect.x;\n> +\tinfo->analogCrop.y -= rect.y;\n> +\n> \t/* The bit depth and image size depend on the currently applied format. */\n> \tV4L2SubdeviceFormat format{};\n> \tret = subdev_->getFormat(pad_, &format);\n> --\n> 2.29.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E168BE176\n\tfor ;\n\tWed, 2 Dec 2020 15:59:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19EC8635A1;\n\tWed, 2 Dec 2020 16:59:36 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4FB1634A2\n\tfor ;\n\tWed, 2 Dec 2020 16:59:34 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7B0902000D\n\tfor ;\n\tWed, 2 Dec 2020 15:59:34 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 2 Dec 2020 16:59:41 +0100","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20201202155941.7crqagmzuhgclm26@uno.localdomain>","References":"<20201202135354.264212-1-jacopo@jmondi.org>\n\t<20201202135354.264212-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201202135354.264212-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: camera_sensor:\n\tAdjust CameraSensorInfo::analogCrop","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]