{"id":10536,"url":"https://patchwork.libcamera.org/api/patches/10536/?format=json","web_url":"https://patchwork.libcamera.org/patch/10536/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201201175536.11093-2-david.plowman@raspberrypi.com>","date":"2020-12-01T17:55:32","name":"[libcamera-devel,v4,1/5] src: ipa: raspberrypi: Avoid AGC filtering when both gain and shutter specified","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d947c9ee345fcee9d09960056386e8cd216dd4ef","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10536/mbox/","series":[{"id":1499,"url":"https://patchwork.libcamera.org/api/series/1499/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1499","date":"2020-12-01T17:55:31","name":"Raspberry Pi AGC improvements","version":4,"mbox":"https://patchwork.libcamera.org/series/1499/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10536/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10536/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B8CBBE176\n\tfor ;\n\tTue, 1 Dec 2020 17:55:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49DBD63509;\n\tTue, 1 Dec 2020 18:55:44 +0100 (CET)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A59D63460\n\tfor ;\n\tTue, 1 Dec 2020 18:55:43 +0100 (CET)","by mail-wr1-x42a.google.com with SMTP id z7so4043208wrn.3\n\tfor ;\n\tTue, 01 Dec 2020 09:55:43 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl3sm438561wrr.89.2020.12.01.09.55.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 01 Dec 2020 09:55:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BgTgEuso\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Hu6oCAEIXM/Sa7+sottEdwvBv2khQQQ8N6nhPKg8HIM=;\n\tb=BgTgEusoHDfSxcuyizwK1eub+HdAH7JJFTS2TNenFLWEygX8HKklLKl7oCIVOMYkeu\n\tYZaK/ryVmACczCJF2lQ1QL2pEaKxzb5f+z23RaFdNln/YTxT9J8c5wWg3UeZ28/xJZ6d\n\to+moa4LaeFoEJ+G6lbhrFmClgE5Z56VlmBGWQ4/3YELFoIcbPsgL4Wdvdx/77htIJCq0\n\tTWRCZXGICA/OiPNWf5ygk4yie8XwZLUguUsnkRNl5ARQgmu60DdgCcQkGK9kTRvteyOh\n\tFDz/z7myxuoMJ7NNKuCS8LSJOGGeowqAq9iks6Tz/avAbLE8ozGt7sCnS31GauXNQuNw\n\tjbuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Hu6oCAEIXM/Sa7+sottEdwvBv2khQQQ8N6nhPKg8HIM=;\n\tb=D2vxqeDapW6iyra808t3sXsfQLE8htNmO9rX41VOcUre0iZp/32sUAzozp56DssCN9\n\t/J4X6hkc4RH11qlCgQST9fT9DXsS9G1+iDRTidq5b0wVWYkIDuZbzlORM7SWOWvxb9z8\n\tOaF6dFtCPqQHyqzPmzkGgdTOUmc2MbZ1y0+QoVxP52hnfHFSewJym4zv4FX0sToZ93ZD\n\tWytUdIGAJPLlxRol02jQiA55+nNQlIjTHYb0hVgEHN+0paHzCHu3NZV4U7Swh8FshnNR\n\tYO3k+rjMn5PZ2NUfyuMMgwG+x1TF+JZHGo5Mf9xDFSRl9BG8EuTet4nUdDd+70gJGtf+\n\tBmEg==","X-Gm-Message-State":"AOAM532AaYXg/5jPlqVZg92n14yo71tH9Ss5/dvs0ffakf1BR9sHvG9m\n\t8/fH78Jupx2enNnr+PpY0l9/20ZPzB1C1TwD","X-Google-Smtp-Source":"ABdhPJwMmxMcxpoMmZePa0HNHk6pirStJgZ4QeQeCyJtSqZW4oK56cEj0WcC0yt8zZff+7xZPR19AQ==","X-Received":"by 2002:adf:e5d0:: with SMTP id\n\ta16mr5549049wrn.340.1606845342947; \n\tTue, 01 Dec 2020 09:55:42 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 1 Dec 2020 17:55:32 +0000","Message-Id":"<20201201175536.11093-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201201175536.11093-1-david.plowman@raspberrypi.com>","References":"<20201201175536.11093-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 1/5] src: ipa: raspberrypi: Avoid AGC\n\tfiltering when both gain and shutter specified","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When both gain and shutter have been directly specified, do not filter\nslowly towards those target values, but adopt them immediately. This\nshould match user expectations better.\n\nSigned-off-by: David Plowman \nReviewed-by: Naushir Patuck \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 4c56bdc9..30a1c1c1 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -588,7 +588,12 @@ bool Agc::applyDigitalGain(double gain, double target_Y)\n \n void Agc::filterExposure(bool desaturate)\n {\n-\tdouble speed = frame_count_ <= config_.startup_frames ? 1.0 : config_.speed;\n+\tdouble speed = config_.speed;\n+\t// AGC adapts instantly if both shutter and gain are directly specified\n+\t// or we're in the startup phase.\n+\tif ((status_.fixed_shutter && status_.fixed_analogue_gain) ||\n+\t frame_count_ <= config_.startup_frames)\n+\t\tspeed = 1.0;\n \tif (filtered_.total_exposure == 0.0) {\n \t\tfiltered_.total_exposure = target_.total_exposure;\n \t\tfiltered_.total_exposure_no_dg = target_.total_exposure_no_dg;\n","prefixes":["libcamera-devel","v4","1/5"]}