[{"id":14021,"web_url":"https://patchwork.libcamera.org/comment/14021/","msgid":"<20201201181904.GB3085@pendragon.ideasonboard.com>","date":"2020-12-01T18:19:04","subject":"Re: [libcamera-devel] [PATCH v2 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\ns/\\.$// on the subject line.\n\nOn Tue, Dec 01, 2020 at 11:13:12PM +0530, Umang Jain wrote:\n> Failing to do so, the codepath will segfault while trying to acquire\n> a non-existent camera.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> simple-cam.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index e88fb85..f844ff4 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -307,6 +307,13 @@ int main()\n> \tfor (std::unique_ptr &request : requests)\n> \t\tcamera->queueRequest(request.get());\n> \n> +\tif(!cm->cameras().size()) {\n\nMissing space after if. Doesn't checkstyle.py warn you ? Ah, no, we have\nno checkstyle.py for simple-cam :-)\n\n> +\t\tstd::cout << \"No cameras were identified on the system.\"\n> +\t\t\t << std::endl;\n> +\t\tcm->stop();\n> +\t\treturn EXIT_FAILURE;\n> +\t}\n> +\n> \t/*\n> \t * --------------------------------------------------------------------\n> \t * Run an EventLoop","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3CDDBE177\n\tfor ;\n\tTue, 1 Dec 2020 18:19:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46AFD63503;\n\tTue, 1 Dec 2020 19:19:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93B9563460\n\tfor ;\n\tTue, 1 Dec 2020 19:19:13 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 119D8DBD;\n\tTue, 1 Dec 2020 19:19:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hRvMOr21\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606846753;\n\tbh=gNsyitorjGPkBx9GQjwNtG0LxwryeooUV6paQBItaXw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hRvMOr218EOxPgm7QKDcob5mZG7m990/7GMwIapi/g5cUVXkpAxQ2DNBevV/2DiTo\n\tmG2Lan6TguS7mBIgZt8Q7OFR19WVwP5immYk2mYoeIYT8boXxXWtxIx+2ff3+k/M2f\n\txEA0sYNJaSG3PSo7Ct8dkXG2l6aX4hr+6gPfweqI=","Date":"Tue, 1 Dec 2020 20:19:04 +0200","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20201201181904.GB3085@pendragon.ideasonboard.com>","References":"<20201201174314.12774-1-email@uajain.com>\n\t<20201201174314.12774-3-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201201174314.12774-3-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] simple-cam: Early return if no\n\tcameras are found on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]