[{"id":13924,"web_url":"https://patchwork.libcamera.org/comment/13924/","msgid":"<20201126153248.3jbsnytew5dogffw@uno.localdomain>","date":"2020-11-26T15:32:48","subject":"Re: [libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Add\n\tdigital gain to libcamera metadata","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Thu, Nov 26, 2020 at 02:50:05PM +0000, David Plowman wrote:\n> The digital gain reported by the AGC algorithm is reported in the\n> metadata that is included in completed requests.\n>\n\nI see a potential minor issue here.\nYour AGC algortihm seems to limit the valid digital gain values in the\n[1.0, 4.0] interval. Currently there's no way to report that to\napplication as we don't have a:\n const ControlInfoMap &Camera::metadata() const;\n\nas we have a:\n const ControlInfoMap &Camera::controls() const;\n\nDo you think it would be useful ?\n\n> Signed-off-by: David Plowman \n\nFor the patch itself\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..631fe7b3 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -403,8 +403,10 @@ void IPARPi::reportMetadata()\n> \t}\n>\n> \tAgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n> -\tif (agcStatus)\n> +\tif (agcStatus) {\n> \t\tlibcameraMetadata_.set(controls::AeLocked, agcStatus->locked);\n> +\t\tlibcameraMetadata_.set(controls::DigitalGain, agcStatus->digital_gain);\n> +\t}\n>\n> \tLuxStatus *luxStatus = rpiMetadata_.GetLocked(\"lux.status\");\n> \tif (luxStatus)\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6499BE176\n\tfor ;\n\tThu, 26 Nov 2020 15:32:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53F8A63469;\n\tThu, 26 Nov 2020 16:32:45 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14CCA6344B\n\tfor ;\n\tThu, 26 Nov 2020 16:32:44 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7374B40013;\n\tThu, 26 Nov 2020 15:32:43 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 26 Nov 2020 16:32:48 +0100","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201126153248.3jbsnytew5dogffw@uno.localdomain>","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t<20201126145005.8838-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126145005.8838-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Add\n\tdigital gain to libcamera metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13928,"web_url":"https://patchwork.libcamera.org/comment/13928/","msgid":"","date":"2020-11-26T15:47:29","subject":"Re: [libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Add\n\tdigital gain to libcamera metadata","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Jacopo\n\nThanks for the comments.\n\nOn Thu, 26 Nov 2020 at 15:32, Jacopo Mondi wrote:\n>\n> Hi David,\n>\n> On Thu, Nov 26, 2020 at 02:50:05PM +0000, David Plowman wrote:\n> > The digital gain reported by the AGC algorithm is reported in the\n> > metadata that is included in completed requests.\n> >\n>\n> I see a potential minor issue here.\n> Your AGC algortihm seems to limit the valid digital gain values in the\n> [1.0, 4.0] interval. Currently there's no way to report that to\n> application as we don't have a:\n> const ControlInfoMap &Camera::metadata() const;\n>\n> as we have a:\n> const ControlInfoMap &Camera::controls() const;\n>\n> Do you think it would be useful ?\n\nWell, that whole [1.0, 4.0] thing is entirely arbitrary, I probably\ncouldn't think what else to put in there. Maybe it'll change... so no\nurgency from my point of view!\n\nThanks\nDavid\n\n>\n> > Signed-off-by: David Plowman \n>\n> For the patch itself\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 9853a343..631fe7b3 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -403,8 +403,10 @@ void IPARPi::reportMetadata()\n> > }\n> >\n> > AgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n> > - if (agcStatus)\n> > + if (agcStatus) {\n> > libcameraMetadata_.set(controls::AeLocked, agcStatus->locked);\n> > + libcameraMetadata_.set(controls::DigitalGain, agcStatus->digital_gain);\n> > + }\n> >\n> > LuxStatus *luxStatus = rpiMetadata_.GetLocked(\"lux.status\");\n> > if (luxStatus)\n> > --\n> > 2.20.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E691FBE08A\n\tfor ;\n\tThu, 26 Nov 2020 15:47:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7A656346B;\n\tThu, 26 Nov 2020 16:47:43 +0100 (CET)","from mail-ot1-x341.google.com (mail-ot1-x341.google.com\n\t[IPv6:2607:f8b0:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8C9A6344B\n\tfor ;\n\tThu, 26 Nov 2020 16:47:41 +0100 (CET)","by mail-ot1-x341.google.com with SMTP id g19so2175269otp.13\n\tfor ;\n\tThu, 26 Nov 2020 07:47:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ed1p51hU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=GuWegdbe248WCMME8GyPlAN+RO1cBG2Uo4ptqGI/Kgg=;\n\tb=ed1p51hUmX4fUKqInkoKOw3ffOIdLj1ohWWk3yCXCt3v1ZU3bP2OJCULp9BUcWIAaR\n\tYykav1a34ZF7Z+DiNkF3UDlGtKSiSINBnwkz+O+jPWPiwektV8VQA0GGIxBAphFkjREb\n\t+WgH5YrrweCI8ya+8pFJ9LBf6MYxlGTTodfKj0jNW8LWNDVfk/ioCtJrFeJGgJpC8Iu1\n\tonk+na4uEzhKwSTooS2vlvMbuPfq8w7m/6A7XZuk2/R8ZT55DjfXiSSH717THc3Foc2S\n\tvG2rH1UghGQiRIbauAKrjUTx2i/sLzOmlXJ3iGrRyIfCILJn1r603Mr+28YAzxb+WLH6\n\tDjEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=GuWegdbe248WCMME8GyPlAN+RO1cBG2Uo4ptqGI/Kgg=;\n\tb=OdLZYVWGdo6cUYnFGTcxXibCf6rF86iiyfxUCRxSiJRRh6pqkR7kpJ1QXXPn1X6+9f\n\t3jdjzu7qOKfNCWXscmkmZqqo9SulJ6T/DKjbHpa9mAB+1fZuZ0rXoaNECmbSGUGRLT1W\n\ts5yGOO3njzOjpMauk2bHt//hahaNAJW1a/pWdCokRP02+xiVcZg4ajio3nA5a58SlXQf\n\tNhjE1Wkm1cXGJhjTOuM9dFLhKSZO1X0hg4C3bSgm6WgqIvI5pScdnMUDEiLdUH/wXvCg\n\tN6L52UFRcfG3N4sleEA0YZ4qDeVJsLfYsFIZiH4jFLUa+wtVp4y7R/spLzBSteiJOnQl\n\tBpVA==","X-Gm-Message-State":"AOAM532oDXza5jxPqEku1p2arNTC4nAHLNA/IgqV3TNwo+lAFUQg6iIk\n\tbB8kPkzYVt8/NvaKg0hZDybACTgiYJicPeAACzGrFV+hX0tIPA==","X-Google-Smtp-Source":"ABdhPJxX1C6spcJ+QLAwJAyuaSvAn7KHuNsih6HTN6Uu8tnciBnqhwDDDx/FdW9NwDcTCbic8q5MpkVCekfjphOJPg0=","X-Received":"by 2002:a9d:6f8f:: with SMTP id\n\th15mr2795055otq.166.1606405660512; \n\tThu, 26 Nov 2020 07:47:40 -0800 (PST)","MIME-Version":"1.0","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t<20201126145005.8838-3-david.plowman@raspberrypi.com>\n\t<20201126153248.3jbsnytew5dogffw@uno.localdomain>","In-Reply-To":"<20201126153248.3jbsnytew5dogffw@uno.localdomain>","From":"David Plowman ","Date":"Thu, 26 Nov 2020 15:47:29 +0000","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Add\n\tdigital gain to libcamera metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14289,"web_url":"https://patchwork.libcamera.org/comment/14289/","msgid":"","date":"2020-12-20T03:16:52","subject":"Re: [libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Add\n\tdigital gain to libcamera metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Nov 26, 2020 at 02:50:05PM +0000, David Plowman wrote:\n> The digital gain reported by the AGC algorithm is reported in the\n> metadata that is included in completed requests.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\nI'll push to the master branch shortly after the tests finish running.\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..631fe7b3 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -403,8 +403,10 @@ void IPARPi::reportMetadata()\n> \t}\n> \n> \tAgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n> -\tif (agcStatus)\n> +\tif (agcStatus) {\n> \t\tlibcameraMetadata_.set(controls::AeLocked, agcStatus->locked);\n> +\t\tlibcameraMetadata_.set(controls::DigitalGain, agcStatus->digital_gain);\n> +\t}\n> \n> \tLuxStatus *luxStatus = rpiMetadata_.GetLocked(\"lux.status\");\n> \tif (luxStatus)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A24BCC0F1A\n\tfor ;\n\tSun, 20 Dec 2020 03:17:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3118D61592;\n\tSun, 20 Dec 2020 04:17:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81B1960526\n\tfor ;\n\tSun, 20 Dec 2020 04:17:00 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06D3C593;\n\tSun, 20 Dec 2020 04:16:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZZHg3rzs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608434220;\n\tbh=Qwh/7KXMSt8RZnJhYmCztDHm962UKga8IAtKUuzXyas=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZZHg3rzsu/YwwZ6/HXgB/6jr9C9+m2gXf+ecVSQ8eHSHomMKC85+/2PdXgamwUgcb\n\tmXLYnGUUZ8mcfC5lpik2Bhe2z7/chrDuMiMrLxGjyy9xATsGh+g3DAdI4d6X/4kTxw\n\terDNYmgcoNPw5WcD6D85BAI/fX7fTWrq48qksT8A=","Date":"Sun, 20 Dec 2020 05:16:52 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t<20201126145005.8838-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126145005.8838-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Add\n\tdigital gain to libcamera metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]