[{"id":13923,"web_url":"https://patchwork.libcamera.org/comment/13923/","msgid":"<20201126152653.d22vhjsxjdpjuasv@uno.localdomain>","date":"2020-11-26T15:26:53","subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: controls: Add\n\tDigitalGain control","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Thu, Nov 26, 2020 at 02:50:04PM +0000, David Plowman wrote:\n> This control reports the global digital gain applied by the pipeline\n> as a whole, after capturing a raw image from the sensor.\n>\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index c8874fa9..75a00f79 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -530,4 +530,21 @@ controls:\n> This control is only present when the pipeline supports scaling. Its\n> maximum valid value is given by the properties::ScalerCropMaximum\n> property, and the two can be used to implement digital zoom.\n> +\n> + - DigitalGain:\n> + type: float\n> + description: |\n> + Digital gain value applied during the processing steps applied\n> + to the image as captured from the sensor.\n> +\n> + The global digital gain factor is applied to all the colour channels\n> + of the RAW image. Different pipeline models are free to\n> + specify how the global gain factor applies to each separate\n> + channel.\n> +\n> + If an imaging pipeline applies digital gain in distinct\n> + processing steps, this value indicates their total sum.\n> + Pipelines are free to decide how to adjust each processing\n> + step to respect the received gain factor and shall report\n> + their total value in the request metadata.\n\nStill not sure I agree with myself here completely :)\nBut indeed:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ...\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28D11BE08A\n\tfor ;\n\tThu, 26 Nov 2020 15:26:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8A3F6346A;\n\tThu, 26 Nov 2020 16:26:49 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19418633F6\n\tfor ;\n\tThu, 26 Nov 2020 16:26:49 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 82BBE24000B;\n\tThu, 26 Nov 2020 15:26:48 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 26 Nov 2020 16:26:53 +0100","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201126152653.d22vhjsxjdpjuasv@uno.localdomain>","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t<20201126145005.8838-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126145005.8838-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: controls: Add\n\tDigitalGain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14288,"web_url":"https://patchwork.libcamera.org/comment/14288/","msgid":"","date":"2020-12-20T02:58:55","subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: controls: Add\n\tDigitalGain control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Nov 26, 2020 at 02:50:04PM +0000, David Plowman wrote:\n> This control reports the global digital gain applied by the pipeline\n> as a whole, after capturing a raw image from the sensor.\n\nI believe there's a high chance that we'll end up reworking the\ngain-related controls, but that's not a reason to delay merging this\npatch given that it's quite clear that more design work will be needed\nto design and document the pipeline model (it's quite clear to me at\nleast, with my limited knowledge on the topic, maybe it would be\nstraightforward for someone with more experience :-)).\n\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index c8874fa9..75a00f79 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -530,4 +530,21 @@ controls:\n> This control is only present when the pipeline supports scaling. Its\n> maximum valid value is given by the properties::ScalerCropMaximum\n> property, and the two can be used to implement digital zoom.\n> +\n> + - DigitalGain:\n> + type: float\n> + description: |\n> + Digital gain value applied during the processing steps applied\n> + to the image as captured from the sensor.\n\nThe double applied sounds strange. Given that we'll rework gain-related\ncontrols anyway there's no need for a v3, so\n\nReviewed-by: Laurent Pinchart \n\n> +\n> + The global digital gain factor is applied to all the colour channels\n> + of the RAW image. Different pipeline models are free to\n> + specify how the global gain factor applies to each separate\n> + channel.\n> +\n> + If an imaging pipeline applies digital gain in distinct\n> + processing steps, this value indicates their total sum.\n> + Pipelines are free to decide how to adjust each processing\n> + step to respect the received gain factor and shall report\n> + their total value in the request metadata.\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2E5BBD80A\n\tfor ;\n\tSun, 20 Dec 2020 02:59:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8053A61592;\n\tSun, 20 Dec 2020 03:59:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F282C60526\n\tfor ;\n\tSun, 20 Dec 2020 03:59:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F8F1593;\n\tSun, 20 Dec 2020 03:59:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HqeBxOyn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608433143;\n\tbh=GKzVtEED31o7gbp/HSs4/d82aJDVkN8gRYBEClfOt2M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HqeBxOyno80OZIi1dXhV8IKborQ/8wyf/3ycLmZAkjkjFGtUx8J16XJWTRXyb2ueb\n\tt9PSdgOjGCWRS0EgAWNW6ZiCjnbxuwQxlbMQCmaQDB6Qm37XIqWYRMWIEnp+OIa+Hi\n\tPfIfFBnskZezfkRCiD+HxYeZbahuH9vwAt5cYY6o=","Date":"Sun, 20 Dec 2020 04:58:55 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t<20201126145005.8838-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126145005.8838-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: controls: Add\n\tDigitalGain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]