[{"id":13938,"web_url":"https://patchwork.libcamera.org/comment/13938/","msgid":"<CAEmqJPpNqU+J01knL9haxAwSFoW4vX-HAUaM80B40tqJudJUEA@mail.gmail.com>","date":"2020-11-26T16:44:28","subject":"Re: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, 26 Nov 2020 at 14:23, David Plowman <david.plowman@raspberrypi.com>\nwrote:\n\n> AE/AGC \"disabled\" is now handled better by the algorithm for itself,\n> so it no longer needs to be \"resumed\" before setting fixed shutter or\n> gain values.\n>\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n>\n\nReviewed-by Naushir Patuck <naush@raspberrypi.com>\n\n\n> ---\n>  src/ipa/raspberrypi/raspberrypi.cpp | 8 --------\n>  1 file changed, 8 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..29d48b1b 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n>                         /* This expects units of micro-seconds. */\n>                         agc->SetFixedShutter(ctrl.second.get<int32_t>());\n>\n> -                       /* For the manual values to take effect, AGC must\n> be unpaused. */\n> -                       if (agc->IsPaused())\n> -                               agc->Resume();\n> -\n>                         libcameraMetadata_.set(controls::ExposureTime,\n> ctrl.second.get<int32_t>());\n>                         break;\n>                 }\n> @@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n>                         ASSERT(agc);\n>\n> agc->SetFixedAnalogueGain(ctrl.second.get<float>());\n>\n> -                       /* For the manual values to take effect, AGC must\n> be unpaused. */\n> -                       if (agc->IsPaused())\n> -                               agc->Resume();\n> -\n>                         libcameraMetadata_.set(controls::AnalogueGain,\n>                                                ctrl.second.get<float>());\n>                         break;\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46555BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Nov 2020 16:44:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA3AC6347E;\n\tThu, 26 Nov 2020 17:44:46 +0100 (CET)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D04B6346B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Nov 2020 17:44:45 +0100 (CET)","by mail-lj1-x22e.google.com with SMTP id r18so3025510ljc.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Nov 2020 08:44:45 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"e9lk5D5a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=DIjfusgLXewEdjTQAv/2bVvkI2UvO7MyPJ3KBUYdLVk=;\n\tb=e9lk5D5aMD8E4oyXjDByBSv7YwRdWpH70/l/7oEJbCATW4esjdWeC7AQbYgpC36hwS\n\tpjFwXWcrQ6WbaSRKZCwDPWmBb3lKD+PW0jDAlPn5hdXCnNCqrpysJHjhUsuluBAB/0/u\n\tXbDXlbgWDE6iygdusez6MOodH2hpAKoLRF5iOjfdip1lF0cZllkT8hiPQKocrXUxNOgm\n\to9dFZ5yO2zPtpanXWi4zM8A0+qN4C/8Ys84JmPrA1bysLZ3g/yaMTy/MU1L/cCKSdpwk\n\tAVX5VkUm6Dw6/SOGvFULmk2FMco1i1/zi8ZFzjyPGf38/0s2ZYGbjqH9JPFQ5H0NSQEl\n\tg6BQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=DIjfusgLXewEdjTQAv/2bVvkI2UvO7MyPJ3KBUYdLVk=;\n\tb=T5TDQTHyJZNc3Gm3t/yMP2L1SmVnb2yxGhLHiTpMoxtQSMXAOB4l64NDkRCEO03G9o\n\tNztmeUxxSNpX9lwyroPAUR7gRrHtB5NAQpzfcWDgM6r07ZHZWlqlc7V2nNZaddq5lzOD\n\tG8o8k379nHSBi0kifeE3iRjQ55oTsM56W1LjjGKCILv5X2gupbkbnIvsACESnBdIoj2h\n\tiR5WnRX4Rs2IC+6J1dbUH0B+wmWy4H+x24OuJXg3ePJn/dRLlquuWPpA65+bQHR8G3H0\n\t04yW07B9Mr9Gx2UaSroA4wW5fF0jKhoGoWIXv4tkc9pByDEleDBYxLVwuGUvu7Bc0ji7\n\t1puQ==","X-Gm-Message-State":"AOAM531kRPJo2+Ivkhy35Ykf/jbCoRZhPhOQ75Vw2CNK+UvwV20KskGz\n\tHDjks3Pi/JRE5+jcJQUmi78ZDoyO0pxEGZI+gNSDFw==","X-Google-Smtp-Source":"ABdhPJwIKnozm2wG6qVDcbnPdL71PK14LSK3eGaphj1inbUNO0Be7PmUDqipJ9Kcs/jc20TSK3orS4sJ4HUsTGQJV6w=","X-Received":"by 2002:a2e:84c7:: with SMTP id q7mr1613761ljh.415.1606409084579;\n\tThu, 26 Nov 2020 08:44:44 -0800 (PST)","MIME-Version":"1.0","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>\n\t<20201126142321.5563-4-david.plowman@raspberrypi.com>","In-Reply-To":"<20201126142321.5563-4-david.plowman@raspberrypi.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Thu, 26 Nov 2020 16:44:28 +0000","Message-ID":"<CAEmqJPpNqU+J01knL9haxAwSFoW4vX-HAUaM80B40tqJudJUEA@mail.gmail.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"multipart/mixed;\n\tboundary=\"===============7742433585509255925==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13971,"web_url":"https://patchwork.libcamera.org/comment/13971/","msgid":"<690369ab-473e-68bd-3c7c-c84449f9ab62@ideasonboard.com>","date":"2020-11-30T11:01:33","subject":"Re: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 26/11/2020 14:23, David Plowman wrote:\n> AE/AGC \"disabled\" is now handled better by the algorithm for itself,\n> so it no longer needs to be \"resumed\" before setting fixed shutter or\n> gain values.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nAlso, this was given in v2, so collecting in this version.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/ipa/raspberrypi/raspberrypi.cpp | 8 --------\n>  1 file changed, 8 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..29d48b1b 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n>  \t\t\t/* This expects units of micro-seconds. */\n>  \t\t\tagc->SetFixedShutter(ctrl.second.get<int32_t>());\n>  \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n>  \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get<int32_t>());\n>  \t\t\tbreak;\n>  \t\t}\n> @@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n>  \t\t\tASSERT(agc);\n>  \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get<float>());\n>  \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n>  \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n>  \t\t\t\t\t       ctrl.second.get<float>());\n>  \t\t\tbreak;\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB69EBE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Nov 2020 11:01:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2164634A1;\n\tMon, 30 Nov 2020 12:01:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA32163320\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Nov 2020 12:01:36 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66AFFB26;\n\tMon, 30 Nov 2020 12:01:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"krUYXsdu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606734096;\n\tbh=oxSNQ8HAPW4nu8Z7lfAATUakmAUi1VPzp2dwccbkDWM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=krUYXsdu38+U/6F0YPYRudKfFGGJo/v9wHlw8SPVOqoi/PekDcZ7pB5WbrqENd4iV\n\teu1tE5hSUgLnzt2UPycwIf7ZJ921u/bCjtda5J35n7jJDzcPjS8Ci8/63qe0eE552a\n\tAfJQ4zoDIidBnxkOT7d6dty5UDR8z019upU1Osgc=","To":"David Plowman <david.plowman@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>\n\t<20201126142321.5563-4-david.plowman@raspberrypi.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<690369ab-473e-68bd-3c7c-c84449f9ab62@ideasonboard.com>","Date":"Mon, 30 Nov 2020 11:01:33 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201126142321.5563-4-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13988,"web_url":"https://patchwork.libcamera.org/comment/13988/","msgid":"<20201130185526.GB4141@pendragon.ideasonboard.com>","date":"2020-11-30T18:55:26","subject":"Re: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Nov 26, 2020 at 02:23:20PM +0000, David Plowman wrote:\n> AE/AGC \"disabled\" is now handled better by the algorithm for itself,\n> so it no longer needs to be \"resumed\" before setting fixed shutter or\n> gain values.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nBtw, when I give a Reviewed-by tag conditioned by small issues being\naddressed, feel free to add it to the next version. I trust that you can\naddress removal of a blank line without me needing to review that again\n:-)\n\n> ---\n>  src/ipa/raspberrypi/raspberrypi.cpp | 8 --------\n>  1 file changed, 8 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..29d48b1b 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n>  \t\t\t/* This expects units of micro-seconds. */\n>  \t\t\tagc->SetFixedShutter(ctrl.second.get<int32_t>());\n>  \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n>  \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get<int32_t>());\n>  \t\t\tbreak;\n>  \t\t}\n> @@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n>  \t\t\tASSERT(agc);\n>  \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get<float>());\n>  \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n>  \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n>  \t\t\t\t\t       ctrl.second.get<float>());\n>  \t\t\tbreak;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E69AABE177\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Nov 2020 18:55:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF934634A3;\n\tMon, 30 Nov 2020 19:55:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0581663320\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Nov 2020 19:55:35 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EA3745D;\n\tMon, 30 Nov 2020 19:55:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T0JrecJ5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606762534;\n\tbh=hEDNCqaaKG8v5X9JJe7uAuGqAV3sCKxaVdLBCPzWBSo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T0JrecJ5SGOFDsNUGJPBlweW9FR6OpVZONbzDWu3zxiPHp+PyESoDrKyAgH2qAe0Z\n\t652NTvv6zedzYNzErujFjyEHy2X5vt+aezT95zLoKthHnqIM685RiM2DKPbb2FTpw9\n\tpiK5xhD/W/bTZFskRXJMWsgBPDmi8pwO+ta+XNL8=","Date":"Mon, 30 Nov 2020 20:55:26 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Message-ID":"<20201130185526.GB4141@pendragon.ideasonboard.com>","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>\n\t<20201126142321.5563-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126142321.5563-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]