{"id":10509,"url":"https://patchwork.libcamera.org/api/patches/10509/?format=json","web_url":"https://patchwork.libcamera.org/patch/10509/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201126142321.5563-4-david.plowman@raspberrypi.com>","date":"2020-11-26T14:23:20","name":"[libcamera-devel,v3,3/4] src: ipa: raspberrypi: Improve behaviour when AE disabled","commit_ref":"472d3d3cdb04388b4ada7c7c4cee71fe1145b663","pull_url":null,"state":"accepted","archived":false,"hash":"0687016ed4b5afb825c4cf68ccb27ee98f22ef1d","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10509/mbox/","series":[{"id":1484,"url":"https://patchwork.libcamera.org/api/series/1484/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1484","date":"2020-11-26T14:23:17","name":"Raspberry Pi AGC improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/1484/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10509/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10509/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA83DBE08A\n\tfor ;\n\tThu, 26 Nov 2020 14:23:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89AB16346A;\n\tThu, 26 Nov 2020 15:23:30 +0100 (CET)","from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n\t[IPv6:2a00:1450:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CA1163472\n\tfor ;\n\tThu, 26 Nov 2020 15:23:28 +0100 (CET)","by mail-ed1-x531.google.com with SMTP id k1so2430012eds.13\n\tfor ;\n\tThu, 26 Nov 2020 06:23:28 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tf24sm3237003edx.90.2020.11.26.06.23.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Nov 2020 06:23:26 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ijaPUrGa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=F4f6KNupEAMJcITnVVSvovunsN/G4z8RTNdi2pn/g+Q=;\n\tb=ijaPUrGaBm0DKnfIrH0Y42/ZdQ4RF8gWmG6KioNV1DD6H5XEwfSYeFDfSyyj4E8U+T\n\tBs8+5VpnpFkTtey8b6xg8163zN4eMSwbhtd1/kII8T166A/QsavMJuDXZrM1+X1PFcIz\n\tu42IY/Yi/9sZhmBnhWy62mIDnoq5/pl6Mmv4snnGNTApqpeTnTX3oztyjMMzAKio0ekC\n\tS8u7KiNKEKoBHtbqOLi+xLw80A9+oAQ5qnZi1Qe/uc2fJOSH1hGIAqG9AE/6t7dRJgzM\n\tiWGSrK87oQQjRpJLfq4+24de1uRQcjCLsVZpLwwxB/YPZk5yBjfw6FCXXkCOPsF8uPn7\n\tGTAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=F4f6KNupEAMJcITnVVSvovunsN/G4z8RTNdi2pn/g+Q=;\n\tb=uUOUC8mIjfmY9sGiWSFDGSJ2zjZCnV9UlsF7U5yvjdHWOa1wr8dpBrT2/X4MJSvln5\n\t0sGH6mn1FyZjx1KvZTxt3ZitMsZAfvKLPk71G0WepFTlTNx4DN8AGBqshVRsQGjbbjFo\n\t6DhnWnoI9MnIpDSrtafKv63atw11kG+bmrVfZyMH2MDeVWLJrzBrrlauncX0b+t6oZZm\n\tTa7JfX1Z66Ky9fLUyilbJRO2sunIevS9t2oMMzITUGEvFZ5STtrwD2WjnuBmVFd3L8ci\n\tyRoEOGCxe0DSRJyI+B3DurRep9Bts3y5K1Eanm/bb9NB9VC9PixuJRZSniig5Ong/qp9\n\tnD1Q==","X-Gm-Message-State":"AOAM5334xVuA+O0W9ZQ4xDt5388s4napwLklXPypqcxb6QOk8lzQai8A\n\tK5JDLk+OMr2TXKJuZwwhWm4lm9tabq3YVwbP","X-Google-Smtp-Source":"ABdhPJw7yh1Uaz+iqdK0MzYTVufayq11vW9ZZMZS4ZqdEpvHMRkidJu+VvxUiBZElaQFobn3R2hWBQ==","X-Received":"by 2002:aa7:cad2:: with SMTP id\n\tl18mr2738964edt.183.1606400607452; \n\tThu, 26 Nov 2020 06:23:27 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Nov 2020 14:23:20 +0000","Message-Id":"<20201126142321.5563-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201126142321.5563-1-david.plowman@raspberrypi.com>","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"AE/AGC \"disabled\" is now handled better by the algorithm for itself,\nso it no longer needs to be \"resumed\" before setting fixed shutter or\ngain values.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 --------\n 1 file changed, 8 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 9853a343..29d48b1b 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\t/* This expects units of micro-seconds. */\n \t\t\tagc->SetFixedShutter(ctrl.second.get());\n \n-\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n-\t\t\tif (agc->IsPaused())\n-\t\t\t\tagc->Resume();\n-\n \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get());\n \t\t\tbreak;\n \t\t}\n@@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\tASSERT(agc);\n \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get());\n \n-\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n-\t\t\tif (agc->IsPaused())\n-\t\t\t\tagc->Resume();\n-\n \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n \t\t\t\t\t ctrl.second.get());\n \t\t\tbreak;\n","prefixes":["libcamera-devel","v3","3/4"]}