[{"id":13972,"web_url":"https://patchwork.libcamera.org/comment/13972/","msgid":"","date":"2020-11-30T11:06:39","subject":"Re: [libcamera-devel] [PATCH v3 2/4] src: ipa: raspberrypi: agc:\n\tMake AGC handle Pause/Resume for itself","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 26/11/2020 14:23, David Plowman wrote:\n> AGC, when paused, sets the last exposure/gain it wrote to be its\n> \"fixed\" values and will therefore continue to return them. When\n> resumed, we clear them so that both will float again.\n> \n> This approach is better because AGC can be paused and we can\n> subsequently change (for example) the exposure and the gain won't\n> float again.\n> \n> Signed-off-by: David Plowman \n\nPulling my tag forwards here too:\n\nReviewed-by: Kieran Bingham \n\nNaush, Can you review this one directly please?\n\nThis is the only one in this series that hasn't got your tag.\n\n--\nKieran\n\n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 24 ++++++++++++++++++++++\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 ++++\n> 2 files changed, 28 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 30a1c1c1..9da18c31 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -184,6 +184,26 @@ void Agc::Read(boost::property_tree::ptree const ¶ms)\n> \texposure_mode_ = &config_.exposure_modes[exposure_mode_name_];\n> \tconstraint_mode_name_ = config_.default_constraint_mode;\n> \tconstraint_mode_ = &config_.constraint_modes[constraint_mode_name_];\n> +\t// Set up the \"last shutter/gain\" values, in case AGC starts \"disabled\".\n> +\tstatus_.shutter_time = config_.default_exposure_time;\n> +\tstatus_.analogue_gain = config_.default_analogue_gain;\n> +}\n> +\n> +bool Agc::IsPaused() const\n> +{\n> +\treturn false;\n> +}\n> +\n> +void Agc::Pause()\n> +{\n> +\tfixed_shutter_ = status_.shutter_time;\n> +\tfixed_analogue_gain_ = status_.analogue_gain;\n> +}\n> +\n> +void Agc::Resume()\n> +{\n> +\tfixed_shutter_ = 0;\n> +\tfixed_analogue_gain_ = 0;\n> }\n> \n> void Agc::SetEv(double ev)\n> @@ -199,11 +219,15 @@ void Agc::SetFlickerPeriod(double flicker_period)\n> void Agc::SetFixedShutter(double fixed_shutter)\n> {\n> \tfixed_shutter_ = fixed_shutter;\n> +\t// Set this in case someone calls Pause() straight after.\n> +\tstatus_.shutter_time = fixed_shutter;\n> }\n> \n> void Agc::SetFixedAnalogueGain(double fixed_analogue_gain)\n> {\n> \tfixed_analogue_gain_ = fixed_analogue_gain;\n> +\t// Set this in case someone calls Pause() straight after.\n> +\tstatus_.analogue_gain = fixed_analogue_gain;\n> }\n> \n> void Agc::SetMeteringMode(std::string const &metering_mode_name)\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> index 47ebb324..95db1812 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> @@ -70,6 +70,10 @@ public:\n> \tAgc(Controller *controller);\n> \tchar const *Name() const override;\n> \tvoid Read(boost::property_tree::ptree const ¶ms) override;\n> +\t// AGC handles \"pausing\" for itself.\n> +\tbool IsPaused() const override;\n> +\tvoid Pause() override;\n> +\tvoid Resume() override;\n> \tvoid SetEv(double ev) override;\n> \tvoid SetFlickerPeriod(double flicker_period) override;\n> \tvoid SetFixedShutter(double fixed_shutter) override; // microseconds\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A943BE177\n\tfor ;\n\tMon, 30 Nov 2020 11:06:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E24D6349F;\n\tMon, 30 Nov 2020 12:06:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A78663320\n\tfor ;\n\tMon, 30 Nov 2020 12:06:42 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07329B26;\n\tMon, 30 Nov 2020 12:06:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tZi0DUUe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606734402;\n\tbh=qgZPKx7hLUmw/+Y24W6t6ypX4fbpnjE14wG+x/M63Fw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=tZi0DUUeRvlVf7wPIdH6accNQmZqU4euKXDy6ONenSWUawp37ybKIL+d/NbuBBaAo\n\tMhQthd7r1E4ehrZF8veCW2RQGA0rrSiQ+AHbqyHvmcNSJlnRC0gLQO4cMLwJWNq0qr\n\tGRL/6QbpB/+oPnhPhBoZec1sYtPgjjK1dpBeDPW0=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>\n\t<20201126142321.5563-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 30 Nov 2020 11:06:39 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201126142321.5563-3-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] src: ipa: raspberrypi: agc:\n\tMake AGC handle Pause/Resume for itself","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13977,"web_url":"https://patchwork.libcamera.org/comment/13977/","msgid":"","date":"2020-11-30T12:14:21","subject":"Re: [libcamera-devel] [PATCH v3 2/4] src: ipa: raspberrypi: agc:\n\tMake AGC handle Pause/Resume for itself","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for the patch.\n\n\nOn Thu, 26 Nov 2020, 2:23 pm David Plowman, \nwrote:\n\n> AGC, when paused, sets the last exposure/gain it wrote to be its\n> \"fixed\" values and will therefore continue to return them. When\n> resumed, we clear them so that both will float again.\n>\n> This approach is better because AGC can be paused and we can\n> subsequently change (for example) the exposure and the gain won't\n> float again.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 24 ++++++++++++++++++++++\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 ++++\n> 2 files changed, 28 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 30a1c1c1..9da18c31 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -184,6 +184,26 @@ void Agc::Read(boost::property_tree::ptree const\n> ¶ms)\n> exposure_mode_ = &config_.exposure_modes[exposure_mode_name_];\n> constraint_mode_name_ = config_.default_constraint_mode;\n> constraint_mode_ =\n> &config_.constraint_modes[constraint_mode_name_];\n> + // Set up the \"last shutter/gain\" values, in case AGC starts\n> \"disabled\".\n> + status_.shutter_time = config_.default_exposure_time;\n> + status_.analogue_gain = config_.default_analogue_gain;\n> +}\n> +\n> +bool Agc::IsPaused() const\n> +{\n> + return false;\n> +}\n> +\n> +void Agc::Pause()\n> +{\n> + fixed_shutter_ = status_.shutter_time;\n> + fixed_analogue_gain_ = status_.analogue_gain;\n> +}\n> +\n> +void Agc::Resume()\n> +{\n> + fixed_shutter_ = 0;\n> + fixed_analogue_gain_ = 0;\n> }\n>\n> void Agc::SetEv(double ev)\n> @@ -199,11 +219,15 @@ void Agc::SetFlickerPeriod(double flicker_period)\n> void Agc::SetFixedShutter(double fixed_shutter)\n> {\n> fixed_shutter_ = fixed_shutter;\n> + // Set this in case someone calls Pause() straight after.\n> + status_.shutter_time = fixed_shutter;\n> }\n>\n> void Agc::SetFixedAnalogueGain(double fixed_analogue_gain)\n> {\n> fixed_analogue_gain_ = fixed_analogue_gain;\n> + // Set this in case someone calls Pause() straight after.\n> + status_.analogue_gain = fixed_analogue_gain;\n> }\n>\n> void Agc::SetMeteringMode(std::string const &metering_mode_name)\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> index 47ebb324..95db1812 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> @@ -70,6 +70,10 @@ public:\n> Agc(Controller *controller);\n> char const *Name() const override;\n> void Read(boost::property_tree::ptree const ¶ms) override;\n> + // AGC handles \"pausing\" for itself.\n> + bool IsPaused() const override;\n> + void Pause() override;\n> + void Resume() override;\n> void SetEv(double ev) override;\n> void SetFlickerPeriod(double flicker_period) override;\n> void SetFixedShutter(double fixed_shutter) override; //\n> microseconds\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 349C1BE177\n\tfor ;\n\tMon, 30 Nov 2020 12:14:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A643634A3;\n\tMon, 30 Nov 2020 13:14:34 +0100 (CET)","from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DCFF63320\n\tfor ;\n\tMon, 30 Nov 2020 13:14:33 +0100 (CET)","by mail-lf1-x131.google.com with SMTP id d20so21136449lfe.11\n\tfor ;\n\tMon, 30 Nov 2020 04:14:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FaMIpJpy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=jdIHjCrD/WouILRqTEB5/qihXvM2c13D6X19SFYxPz0=;\n\tb=FaMIpJpyutdMqE8aD6q9rcTH6vi8URTuzi/ddeSvMY6kVww2Bvl2CMvhj+56KsIrAh\n\tZbJHA95GrVmJdkllGqnwE6K9XjnlnZpXTVquZ/QFAHEFKLlzYWtHsN/i6fhaDqqYa4wK\n\tcSZJJacHua715jsjbtemozqw11gzIgf/BLCu9AY5rbaUqLPazTgKNLgvGFfxYplDmDZS\n\tNnqe0i34dtq1Ixd8jLcG6VvBOoJcJSfg3e6tFKTkngmVDlZm0eMLR3NHBqQAStxYm7bL\n\tI/ZFd/qouOdoXSUyeP8B231vPBYn7ZbeWnE9CAsBfIDlomR4/By5gpjeQgPF+reTFeyC\n\tQclg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=jdIHjCrD/WouILRqTEB5/qihXvM2c13D6X19SFYxPz0=;\n\tb=j83xAZxzwuszeUiWtAU1LOWpl0/H+qGfjDy5ynoV7CiDpn3PwGkOZ8M/KS7hW4487d\n\tAKYA0yaY+PY9NWHJ07cW7Qf3j9aEkpu0yALaoN4D1RjPzkfi5miQDz4Yzqlt3reXUecJ\n\tSefd1RpJPwHePJmT5gE2CNHgofe/tQ9Iy++CZJwAEFXOcYcbtTauRg3kCU0e/A4KwkVT\n\tFl2Bb+y8ba7g4lsT78m9rM5rJ4+CHOcvqKKkrJLjaGKbtJLfdOmOC8/kjwHEDBHVj57B\n\tGD5iqc8ohrDUkyfYd7NWL5BR3+h8Kg1h8dTNjw0Ay22bBUGVcVpfzLH/2dNnMg7DDcPu\n\tZGAw==","X-Gm-Message-State":"AOAM530afR9A5WJnYc4lhJLHpPbJzWiBdJPuDEjzaNjqAzHJvGyZvUeF\n\tci7JCI6uHoQ0PN5RqnyynFXN7FpkiRtILiI6nO8kmw==","X-Google-Smtp-Source":"ABdhPJzQfWxqPOi3m4a5on8xCGkbbg6Mbeo5VtL2+YRqwdDJQhlMqRUxppFCmAM6G2tY03cJzM2KR3N3lCMzAVkxWZw=","X-Received":"by 2002:a19:a415:: with SMTP id\n\tq21mr9361471lfc.508.1606738472618; \n\tMon, 30 Nov 2020 04:14:32 -0800 (PST)","MIME-Version":"1.0","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>\n\t<20201126142321.5563-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20201126142321.5563-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Mon, 30 Nov 2020 12:14:21 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] src: ipa: raspberrypi: agc:\n\tMake AGC handle Pause/Resume for itself","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============0981783769376493362==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13987,"web_url":"https://patchwork.libcamera.org/comment/13987/","msgid":"<20201130185356.GA4141@pendragon.ideasonboard.com>","date":"2020-11-30T18:53:56","subject":"Re: [libcamera-devel] [PATCH v3 2/4] src: ipa: raspberrypi: agc:\n\tMake AGC handle Pause/Resume for itself","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Nov 26, 2020 at 02:23:19PM +0000, David Plowman wrote:\n> AGC, when paused, sets the last exposure/gain it wrote to be its\n> \"fixed\" values and will therefore continue to return them. When\n> resumed, we clear them so that both will float again.\n> \n> This approach is better because AGC can be paused and we can\n> subsequently change (for example) the exposure and the gain won't\n> float again.\n\nI think we'll need to revisit this based on the outcome of the\ndiscussion on v2, but that's not a blocker.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 24 ++++++++++++++++++++++\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 ++++\n> 2 files changed, 28 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 30a1c1c1..9da18c31 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -184,6 +184,26 @@ void Agc::Read(boost::property_tree::ptree const ¶ms)\n> \texposure_mode_ = &config_.exposure_modes[exposure_mode_name_];\n> \tconstraint_mode_name_ = config_.default_constraint_mode;\n> \tconstraint_mode_ = &config_.constraint_modes[constraint_mode_name_];\n> +\t// Set up the \"last shutter/gain\" values, in case AGC starts \"disabled\".\n> +\tstatus_.shutter_time = config_.default_exposure_time;\n> +\tstatus_.analogue_gain = config_.default_analogue_gain;\n> +}\n> +\n> +bool Agc::IsPaused() const\n> +{\n> +\treturn false;\n> +}\n> +\n> +void Agc::Pause()\n> +{\n> +\tfixed_shutter_ = status_.shutter_time;\n> +\tfixed_analogue_gain_ = status_.analogue_gain;\n> +}\n> +\n> +void Agc::Resume()\n> +{\n> +\tfixed_shutter_ = 0;\n> +\tfixed_analogue_gain_ = 0;\n> }\n> \n> void Agc::SetEv(double ev)\n> @@ -199,11 +219,15 @@ void Agc::SetFlickerPeriod(double flicker_period)\n> void Agc::SetFixedShutter(double fixed_shutter)\n> {\n> \tfixed_shutter_ = fixed_shutter;\n> +\t// Set this in case someone calls Pause() straight after.\n> +\tstatus_.shutter_time = fixed_shutter;\n> }\n> \n> void Agc::SetFixedAnalogueGain(double fixed_analogue_gain)\n> {\n> \tfixed_analogue_gain_ = fixed_analogue_gain;\n> +\t// Set this in case someone calls Pause() straight after.\n> +\tstatus_.analogue_gain = fixed_analogue_gain;\n> }\n> \n> void Agc::SetMeteringMode(std::string const &metering_mode_name)\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> index 47ebb324..95db1812 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> @@ -70,6 +70,10 @@ public:\n> \tAgc(Controller *controller);\n> \tchar const *Name() const override;\n> \tvoid Read(boost::property_tree::ptree const ¶ms) override;\n> +\t// AGC handles \"pausing\" for itself.\n> +\tbool IsPaused() const override;\n> +\tvoid Pause() override;\n> +\tvoid Resume() override;\n> \tvoid SetEv(double ev) override;\n> \tvoid SetFlickerPeriod(double flicker_period) override;\n> \tvoid SetFixedShutter(double fixed_shutter) override; // microseconds","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE711BE176\n\tfor ;\n\tMon, 30 Nov 2020 18:54:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E733634A1;\n\tMon, 30 Nov 2020 19:54:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2401E63320\n\tfor ;\n\tMon, 30 Nov 2020 19:54:05 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B26345D;\n\tMon, 30 Nov 2020 19:54:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jz0gMF+2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606762444;\n\tbh=MJJe6SVlADEIpr8oMMw4M+sBvfe4KOUp8K8VY9fvbPM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jz0gMF+26pIHGfglizhLkeDti6pgpIXl4Un9QbHQpNYrH/U3yueQ9r30gqAcYJxqv\n\txWpvbapAtCM15ftLf6pgxROC0RwZ4yzoEOqp8zfktJw87wy/+xQiwERRwJmRZ9Kgvk\n\tPapYWE9T6qx2sI9Ml/g6YNcR5Q4i3FJ8VkITpDu4=","Date":"Mon, 30 Nov 2020 20:53:56 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201130185356.GA4141@pendragon.ideasonboard.com>","References":"<20201126142321.5563-1-david.plowman@raspberrypi.com>\n\t<20201126142321.5563-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126142321.5563-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] src: ipa: raspberrypi: agc:\n\tMake AGC handle Pause/Resume for itself","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]