[{"id":13912,"web_url":"https://patchwork.libcamera.org/comment/13912/","msgid":"<20201126125833.GH3905@pendragon.ideasonboard.com>","date":"2020-11-26T12:58:33","subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Nov 26, 2020 at 12:32:02PM +0000, David Plowman wrote:\n> AE/AGC \"disabled\" is now handled better by the algorithm for itself,\n> so it no longer needs to be \"resumed\" before setting fixed shutter or\n> gain values.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 9 +--------\n> 1 file changed, 1 insertion(+), 8 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..e437c626 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -495,6 +495,7 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\tcase controls::AE_ENABLE: {\n> \t\t\tRPiController::Algorithm *agc = controller_.GetAlgorithm(\"agc\");\n> \t\t\tASSERT(agc);\n> +\n\nIt's customary, when including unrelated minor changes such as this, to\nmention it in the commit message, to let reviewers know the change\ndidn't get included by mistake.\n\n> \t\t\tif (ctrl.second.get() == false)\n> \t\t\t\tagc->Pause();\n> \t\t\telse\n> @@ -512,10 +513,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\t\t/* This expects units of micro-seconds. */\n> \t\t\tagc->SetFixedShutter(ctrl.second.get());\n> \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n\nOnly AWB now uses the pause mechanism. I wonder if it will survive, or\nbe dropped there too for the same reason as for the AGC :-)\n\nReviewed-by: Laurent Pinchart \n\n> \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get());\n> \t\t\tbreak;\n> \t\t}\n> @@ -526,10 +523,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\t\tASSERT(agc);\n> \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get());\n> \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n> \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n> \t\t\t\t\t ctrl.second.get());\n> \t\t\tbreak;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E16CBE08A\n\tfor ;\n\tThu, 26 Nov 2020 12:58:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF3EA63446;\n\tThu, 26 Nov 2020 13:58:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F44863408\n\tfor ;\n\tThu, 26 Nov 2020 13:58:42 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17454A1B;\n\tThu, 26 Nov 2020 13:58:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"quQZVhs3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606395522;\n\tbh=1xol/lXnpsfLQTmh1YISBVb0U1E8Mn3wTw34mem6e0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=quQZVhs3lg83HF4WHIKd8DyUxx12do8LJC4kP9ntDUnFvUoxZNk8h//FEMl6Z4Xxh\n\twAevsMyCfek+NyMVT13kzr6pSFRhO1JMxXiIq8gdMpHET/2XXxAS+A5Nwj49B0zam9\n\tt+yqtvrvw3P9J1yW3C0rbA7opV6lP2wwL7KrBqz8=","Date":"Thu, 26 Nov 2020 14:58:33 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201126125833.GH3905@pendragon.ideasonboard.com>","References":"<20201126123203.19105-1-david.plowman@raspberrypi.com>\n\t<20201126123203.19105-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201126123203.19105-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13915,"web_url":"https://patchwork.libcamera.org/comment/13915/","msgid":"","date":"2020-11-26T13:37:58","subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for the review.\n\nOn Thu, 26 Nov 2020 at 12:58, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Thu, Nov 26, 2020 at 12:32:02PM +0000, David Plowman wrote:\n> > AE/AGC \"disabled\" is now handled better by the algorithm for itself,\n> > so it no longer needs to be \"resumed\" before setting fixed shutter or\n> > gain values.\n> >\n> > Signed-off-by: David Plowman \n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 9 +--------\n> > 1 file changed, 1 insertion(+), 8 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 9853a343..e437c626 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -495,6 +495,7 @@ void IPARPi::queueRequest(const ControlList &controls)\n> > case controls::AE_ENABLE: {\n> > RPiController::Algorithm *agc = controller_.GetAlgorithm(\"agc\");\n> > ASSERT(agc);\n> > +\n>\n> It's customary, when including unrelated minor changes such as this, to\n> mention it in the commit message, to let reviewers know the change\n> didn't get included by mistake.\n\nIt was a mistake, of course! :)\n\nI'll remove it and address those other points (about the override).\n\nThanks\nDavid\n\n>\n> > if (ctrl.second.get() == false)\n> > agc->Pause();\n> > else\n> > @@ -512,10 +513,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n> > /* This expects units of micro-seconds. */\n> > agc->SetFixedShutter(ctrl.second.get());\n> >\n> > - /* For the manual values to take effect, AGC must be unpaused. */\n> > - if (agc->IsPaused())\n> > - agc->Resume();\n> > -\n>\n> Only AWB now uses the pause mechanism. I wonder if it will survive, or\n> be dropped there too for the same reason as for the AGC :-)\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > libcameraMetadata_.set(controls::ExposureTime, ctrl.second.get());\n> > break;\n> > }\n> > @@ -526,10 +523,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n> > ASSERT(agc);\n> > agc->SetFixedAnalogueGain(ctrl.second.get());\n> >\n> > - /* For the manual values to take effect, AGC must be unpaused. */\n> > - if (agc->IsPaused())\n> > - agc->Resume();\n> > -\n> > libcameraMetadata_.set(controls::AnalogueGain,\n> > ctrl.second.get());\n> > break;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CDA0BE176\n\tfor ;\n\tThu, 26 Nov 2020 13:38:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD40F6345E;\n\tThu, 26 Nov 2020 14:38:12 +0100 (CET)","from mail-oi1-x242.google.com (mail-oi1-x242.google.com\n\t[IPv6:2607:f8b0:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 179D263408\n\tfor ;\n\tThu, 26 Nov 2020 14:38:11 +0100 (CET)","by mail-oi1-x242.google.com with SMTP id l206so2267970oif.12\n\tfor ;\n\tThu, 26 Nov 2020 05:38:11 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cIgG803D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=BrvHqydVWm79yZyd6YLNcoN+fTah6eUy9K8znGI5xlk=;\n\tb=cIgG803DsbqeHk0Knuq2Bqcz8Hn6PFaiH3wwCChYML4S2YUXKPw41MtROk13EFiIMf\n\tI7v30EF+Qs3gaiEW+s7wWzFE2KUAfnM8iY2xvrFaf9UOgQNo33i9XZr2h4EwBnUMo0r9\n\tMfIEawD2BTcUTtAcWSiLhQicapte0atFLNkRup2/Ilwii/xQ8iDZ332gqplrpjZMDDz5\n\tvqGHsQACvg7CHtMh7V7R59PxH7Cpgc5mXUvxNlRvuSAe14izdsdz1Jv7WsPXQmPk4g/N\n\tJ7KzNuqoYmZpKIT3Th0eYtJ6L5QQxzlxaABFAlDzX6QUxhlfh3zvUPNwHsMwTq36W7MV\n\t7UdQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=BrvHqydVWm79yZyd6YLNcoN+fTah6eUy9K8znGI5xlk=;\n\tb=Ia3lm6/eTdd/EBY6WEljymfd6A9wYU/S0ybw0z8sIXGpBRhwKDYe0+1UYkGZ/kGxyL\n\tShl3R1CsdpZiGcYM1e790TfFa11TYQopDQwer4wtHR8mvaT7IHVvIy2oap58mD06V62f\n\tRzn0m6k3ts2RDSYur4mECHa7O4znzoiVyphs0BcMgoHKn8eVXIurZIJ7/oI/wHVszQJa\n\tg3UUAJ6q8M5pG0znV6PVcIOe/VmLlUy3uZdHx/lr0LLVF5K+8xwp1czsv07fvcysHgyt\n\tEdXqpTpN0jroMCHEij+9a5kVaXHjXw8K62a4usTmNR2VxGMEMxoykF9Oya09Nov5Vsqh\n\t3Z3w==","X-Gm-Message-State":"AOAM530WkElGiF6Pr0CJOBba44fXdlhO+x94CbSyFTB6Qfeg5nWzsfBD\n\tWhBskUajZhoui+lQ0vyTkomo2Ut3qtHvjdA9k8hB13jf1f56Gw==","X-Google-Smtp-Source":"ABdhPJz3qSr0SGkX6Fd0w9Mnw8dM/1naZA6B0DYcNgDW3ZIdjl4G2R7AgNx6PqZBeitFcU3RVQT4iH1KqIsoQbU/S9I=","X-Received":"by 2002:aca:5114:: with SMTP id\n\tf20mr2018980oib.107.1606397889691; \n\tThu, 26 Nov 2020 05:38:09 -0800 (PST)","MIME-Version":"1.0","References":"<20201126123203.19105-1-david.plowman@raspberrypi.com>\n\t<20201126123203.19105-4-david.plowman@raspberrypi.com>\n\t<20201126125833.GH3905@pendragon.ideasonboard.com>","In-Reply-To":"<20201126125833.GH3905@pendragon.ideasonboard.com>","From":"David Plowman ","Date":"Thu, 26 Nov 2020 13:37:58 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13967,"web_url":"https://patchwork.libcamera.org/comment/13967/","msgid":"","date":"2020-11-30T10:41:27","subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 26/11/2020 12:32, David Plowman wrote:\n> AE/AGC \"disabled\" is now handled better by the algorithm for itself,\n> so it no longer needs to be \"resumed\" before setting fixed shutter or\n> gain values.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 9 +--------\n> 1 file changed, 1 insertion(+), 8 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9853a343..e437c626 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -495,6 +495,7 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\tcase controls::AE_ENABLE: {\n> \t\t\tRPiController::Algorithm *agc = controller_.GetAlgorithm(\"agc\");\n> \t\t\tASSERT(agc);\n> +\n> \t\t\tif (ctrl.second.get() == false)\n> \t\t\t\tagc->Pause();\n> \t\t\telse\n> @@ -512,10 +513,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\t\t/* This expects units of micro-seconds. */\n> \t\t\tagc->SetFixedShutter(ctrl.second.get());\n> \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n> \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get());\n> \t\t\tbreak;\n> \t\t}\n> @@ -526,10 +523,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\t\tASSERT(agc);\n> \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get());\n> \n> -\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n> -\t\t\tif (agc->IsPaused())\n> -\t\t\t\tagc->Resume();\n> -\n> \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n> \t\t\t\t\t ctrl.second.get());\n> \t\t\tbreak;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 668E4BE177\n\tfor ;\n\tMon, 30 Nov 2020 10:41:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAF9663497;\n\tMon, 30 Nov 2020 11:41:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90F7A6346B\n\tfor ;\n\tMon, 30 Nov 2020 11:41:30 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11606B26;\n\tMon, 30 Nov 2020 11:41:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TrJoHnnT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606732890;\n\tbh=NyBYWWOV0aC05Sq8xdLKIgdWHL/o5p5UafjGVyAcwQk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=TrJoHnnT6hO3SiLoH8baZeUJc5l84f2LSb4rVnkj0C+v3oo2G7ypyLqd2cxTw3XwP\n\tsbMuc5SUASPTakml40mYHeqAYRpqv5XWOL4g+LXLelHfXag/PKtGS8DzPO/tptjYsK\n\tpTIAy09e0BOI5m+FLYJjmHOHzFB1J0lbTALVKqLQ=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201126123203.19105-1-david.plowman@raspberrypi.com>\n\t<20201126123203.19105-4-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 30 Nov 2020 10:41:27 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201126123203.19105-4-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]