{"id":10504,"url":"https://patchwork.libcamera.org/api/patches/10504/?format=json","web_url":"https://patchwork.libcamera.org/patch/10504/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201126123203.19105-4-david.plowman@raspberrypi.com>","date":"2020-11-26T12:32:02","name":"[libcamera-devel,v2,3/4] src: ipa: raspberrypi: Improve behaviour when AE disabled","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"07ba2d4038588313f5298780dff1850a99e70aba","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10504/mbox/","series":[{"id":1483,"url":"https://patchwork.libcamera.org/api/series/1483/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1483","date":"2020-11-26T12:31:59","name":"Raspberry Pi AGC improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/1483/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10504/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10504/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BB5ABE176\n\tfor ;\n\tThu, 26 Nov 2020 12:32:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09A8363461;\n\tThu, 26 Nov 2020 13:32:17 +0100 (CET)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B9363463\n\tfor ;\n\tThu, 26 Nov 2020 13:32:13 +0100 (CET)","by mail-ej1-x630.google.com with SMTP id oq3so2679690ejb.7\n\tfor ;\n\tThu, 26 Nov 2020 04:32:13 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5sm3064354edp.5.2020.11.26.04.32.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Nov 2020 04:32:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"t63TEj00\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=UvoJ3Ey4fzjxOq8S+86z4FWYBiIf60CMkrI83WlclDs=;\n\tb=t63TEj000IgAA9LZTgC1jRxJOaMa7Pix6NXnjSgvQOpfVpj7UjiP2nlseSSnQAAnaE\n\tdylUycMAU8M2EFNNvIj/4n7yAIHChz5FPvD1sVsG9fGFohegnUkSOU2Otqbnakv3oDks\n\tDxqbyMVlxTO5AxVa6ifLlZ9vV5mckzKLT+Ju3CRhUdHFGHvoKIajS4Z414Q1i2tU194f\n\tLZCiVyR6mCk4o5SXCDsdMK/tLx8gVTRRggtCo81yzJlXs+SO69i/Vv1Xhdp+XX3AUTaW\n\tfKMyAZf/njwNcRa2TQnkACYYOIrFDEhYnty4m7W7HU24CELmfrgkQRF3Qb1ceehfN0Mj\n\tL84w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=UvoJ3Ey4fzjxOq8S+86z4FWYBiIf60CMkrI83WlclDs=;\n\tb=EPVCZAhJIwM5rr1H6BefOHYwr+t6igXa/XehSub/2KCY+ADC2qmRw8etugZmL9XkUD\n\treycRLOi7Hkz/7Ouswq0WScTa4Ifwm1oor5s0JUJhgbf0wOOG0g2VBilEvx59tacW05c\n\taS4WNOq21fTE8vwhT7OnYoHpvVnhWOlpBUFCdqZX7OE7H93rZupIIt55lXZOhw5Ci770\n\tudr4OS+tObwzrxOL0N9fytJcrND2vrgCFdI4nGYLHHPnTIWDLIMsA3y4ycPCTCtHxg2E\n\tQEA7kViESw30TDTy2IBwyySQFZmkgGqoE8+EbNGxKSwnZdCxQyw78XXYGc5S74be1hMe\n\tRxbQ==","X-Gm-Message-State":"AOAM532qjcRU/ghEcHAORWYn+4keErvuBJBZ2j0twBMdCrYbCtXweHYn\n\tSGVFahyP8RV1IKfN+7T5ZVX8NBLHrBhazRI/","X-Google-Smtp-Source":"ABdhPJz8rQqzvoZDkvDcwRvGWbl2C/bXH/YNowqGZ1iqrTN6J+PeXvS/4pU3cPgqYM7v42/63FRt1Q==","X-Received":"by 2002:a17:906:b003:: with SMTP id\n\tv3mr2483187ejy.290.1606393932879; \n\tThu, 26 Nov 2020 04:32:12 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Nov 2020 12:32:02 +0000","Message-Id":"<20201126123203.19105-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201126123203.19105-1-david.plowman@raspberrypi.com>","References":"<20201126123203.19105-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/4] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"AE/AGC \"disabled\" is now handled better by the algorithm for itself,\nso it no longer needs to be \"resumed\" before setting fixed shutter or\ngain values.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 9853a343..e437c626 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -495,6 +495,7 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\tcase controls::AE_ENABLE: {\n \t\t\tRPiController::Algorithm *agc = controller_.GetAlgorithm(\"agc\");\n \t\t\tASSERT(agc);\n+\n \t\t\tif (ctrl.second.get() == false)\n \t\t\t\tagc->Pause();\n \t\t\telse\n@@ -512,10 +513,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\t/* This expects units of micro-seconds. */\n \t\t\tagc->SetFixedShutter(ctrl.second.get());\n \n-\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n-\t\t\tif (agc->IsPaused())\n-\t\t\t\tagc->Resume();\n-\n \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get());\n \t\t\tbreak;\n \t\t}\n@@ -526,10 +523,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\tASSERT(agc);\n \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get());\n \n-\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n-\t\t\tif (agc->IsPaused())\n-\t\t\t\tagc->Resume();\n-\n \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n \t\t\t\t\t ctrl.second.get());\n \t\t\tbreak;\n","prefixes":["libcamera-devel","v2","3/4"]}