[{"id":1477,"web_url":"https://patchwork.libcamera.org/comment/1477/","msgid":"<20190419100303.ujmgfm3mdfrvedt5@uno.localdomain>","date":"2019-04-19T10:03:03","subject":"Re: [libcamera-devel] [PATCH v3 03/13] libcamera: camera: Log\n\trequested configuration in configureStreams()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n I've just noticed a small issue with this patch.\n\nOn Thu, Apr 18, 2019 at 05:14:27PM +0300, Laurent Pinchart wrote:\n> The IPU3 pipeline handler logs the requested configuration in its\n> configureStreams() handler. This is useful for other pipeline handlers\n> as well, move it to the Camera class.\n>\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/camera.cpp | 14 ++++++++++++++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ------\n> 2 files changed, 14 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 75a21008070b..bd381fa1cb56 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -5,6 +5,8 @@\n> * camera.cpp - Camera device\n> */\n>\n> +#include \n> +\n> #include \n> #include \n> #include \n> @@ -595,11 +597,23 @@ int Camera::configureStreams(const CameraConfiguration &config)\n> \t\treturn -EINVAL;\n> \t}\n>\n> +\tstd::ostringstream msg(\"configuring streams:\");\n> +\tunsigned int index = 0;\n> +\n> \tfor (Stream *stream : config) {\n> \t\tif (streams_.find(stream) == streams_.end())\n> \t\t\treturn -EINVAL;\n> +\n> +\t\tconst StreamConfiguration &cfg = config[stream];\n> +\t\tmsg << \" (\" << index << \") \" << cfg.width << \"x\"\n> +\t\t << cfg.height << \"-0x\" << std::hex << std::setfill('0')\n> +\t\t << std::setw(8) << cfg.pixelFormat;\n> +\n> +\t\tindex++;\n\nWhen running with multiple streams I get:\nINFO Camera camera.cpp:615 (0) 640x480-0x3231564e (1) 140xa0-0x3231564e\n\nStream (1) might seems like it is wrongly configured, but it is not,\nit is just printed out as hex...\n\nAccording to the std::hex function documentation, once it gets applied\nto a stream, it sets its basefield to hexadecimal, and all numerical\nvalues pushed to the stream will then be interepreted as hexadecimals.\n\nA 'msg << std::dec;' before assembling the format description string,\nfixes the issue for me.\n\nThanks\n j\n\n\n> \t}\n>\n> +\tLOG(Camera, Info) << msg.str();\n> +\n> \tret = pipe_->configureStreams(this, config);\n> \tif (ret)\n> \t\treturn ret;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 924eb46c58d8..f2306efba3bf 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -244,12 +244,6 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera,\n> \tImgUDevice *imgu = data->imgu_;\n> \tint ret;\n>\n> -\tLOG(IPU3, Info)\n> -\t\t<< \"Requested image format \" << cfg.width << \"x\"\n> -\t\t<< cfg.height << \"-0x\" << std::hex << std::setfill('0')\n> -\t\t<< std::setw(8) << cfg.pixelFormat << \" on camera '\"\n> -\t\t<< camera->name() << \"'\";\n> -\n> \t/*\n> \t * Verify that the requested size respects the IPU3 alignement\n> \t * requirements (the image width shall be a multiple of 8 pixels and\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B77D60004\n\tfor ;\n\tFri, 19 Apr 2019 12:02:10 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id EBE041BF20D;\n\tFri, 19 Apr 2019 10:02:09 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 19 Apr 2019 12:03:03 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190419100303.ujmgfm3mdfrvedt5@uno.localdomain>","References":"<20190418141437.14014-1-laurent.pinchart@ideasonboard.com>\n\t<20190418141437.14014-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"bgcwdiwaycey3goy\"","Content-Disposition":"inline","In-Reply-To":"<20190418141437.14014-4-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v3 03/13] libcamera: camera: Log\n\trequested configuration in configureStreams()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Apr 2019 10:02:10 -0000"}}]