[{"id":13854,"web_url":"https://patchwork.libcamera.org/comment/13854/","msgid":"<458d467f-3758-8373-1c70-8bc77aa1d925@ideasonboard.com>","date":"2020-11-24T19:09:30","subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: Make log less verbose by\n\tdefault","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 24/11/2020 17:43, Laurent Pinchart wrote:\n> The qcam log prints one message per frame, which is pretty verbose. This\n> feature is useful for debugging, but not necessarily as a default\n> option. Silence it by default, and add a -v/--verbose command line\n> parameter to make the log verbose.\n> \n> While this could have been handled manually by checking a verbose flag\n> when printing the message, the feature is instead integrated with the Qt\n> log infrastructure to make it more flexible. Messages printed by\n> qDebug() are now silenced by default and controlled by the -v/--verbose\n> argument.\n\nSeems potentially overkill, but if it works, and gives flexibility later on:\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main.cpp | 5 +++++\n> src/qcam/main_window.cpp | 2 +-\n> src/qcam/main_window.h | 2 ++\n> src/qcam/meson.build | 1 +\n> src/qcam/message_handler.cpp | 27 +++++++++++++++++++++++++++\n> src/qcam/message_handler.h | 26 ++++++++++++++++++++++++++\n> 6 files changed, 62 insertions(+), 1 deletion(-)\n> create mode 100644 src/qcam/message_handler.cpp\n> create mode 100644 src/qcam/message_handler.h\n> \n> diff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\n> index 5505a5d88ef6..5eff90a3fa66 100644\n> --- a/src/qcam/main.cpp\n> +++ b/src/qcam/main.cpp\n> @@ -16,6 +16,7 @@\n> #include \"../cam/options.h\"\n> #include \"../cam/stream_options.h\"\n> #include \"main_window.h\"\n> +#include \"message_handler.h\"\n> \n> void signalHandler([[maybe_unused]] int signal)\n> {\n> @@ -38,6 +39,8 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n> \t\t\t \"renderer\", ArgumentRequired, \"renderer\");\n> \tparser.addOption(OptStream, &streamKeyValue,\n> \t\t\t \"Set configuration of a camera stream\", \"stream\", true);\n> +\tparser.addOption(OptVerbose, OptionNone,\n> +\t\t\t \"Print verbose log messages\", \"verbose\");\n> \n> \tOptionsParser::Options options = parser.parse(argc, argv);\n> \tif (options.isSet(OptHelp))\n> @@ -57,6 +60,8 @@ int main(int argc, char **argv)\n> \tif (options.isSet(OptHelp))\n> \t\treturn 0;\n> \n> +\tMessageHandler msgHandler(options.isSet(OptVerbose));\n> +\n> \tstruct sigaction sa = {};\n> \tsa.sa_handler = &signalHandler;\n> \tsigaction(SIGINT, &sa, nullptr);\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 2502ecd40abe..39d034de6bb2 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -746,7 +746,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> \tfps = lastBufferTime_ && fps ? 1000000000.0 / fps : 0.0;\n> \tlastBufferTime_ = metadata.timestamp;\n> \n> -\tqInfo().noquote()\n> +\tqDebug().noquote()\n> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> \t\t<< \"timestamp:\" << metadata.timestamp\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 64bcfebc7dbd..a9aa8ffcd8fd 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -41,6 +41,7 @@ enum {\n> \tOptHelp = 'h',\n> \tOptRenderer = 'r',\n> \tOptStream = 's',\n> +\tOptVerbose = 'v',\n> };\n> \n> class MainWindow : public QMainWindow\n> @@ -98,6 +99,7 @@ private:\n> \n> \t/* Options */\n> \tconst OptionsParser::Options &options_;\n> +\tbool verbose_;\n> \n> \t/* Camera manager, camera, configuration and buffers */\n> \tCameraManager *cm_;\n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 9bb48c0d06c5..ebcd5ca010cf 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -6,6 +6,7 @@ qcam_sources = files([\n> 'format_converter.cpp',\n> 'main.cpp',\n> 'main_window.cpp',\n> + 'message_handler.cpp',\n> 'viewfinder_qt.cpp',\n> ])\n> \n> diff --git a/src/qcam/message_handler.cpp b/src/qcam/message_handler.cpp\n> new file mode 100644\n> index 000000000000..261623e19ca9\n> --- /dev/null\n> +++ b/src/qcam/message_handler.cpp\n> @@ -0,0 +1,27 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2020, Laurent Pinchart \n> + *\n> + * message_handler.cpp - qcam - Log message handling\n> + */\n> +\n> +#include \"message_handler.h\"\n> +\n> +QtMessageHandler MessageHandler::handler_ = nullptr;\n> +bool MessageHandler::verbose_ = false;\n> +\n> +MessageHandler::MessageHandler(bool verbose)\n> +{\n> +\tverbose_ = verbose;\n> +\thandler_ = qInstallMessageHandler(&MessageHandler::handleMessage);\n> +}\n> +\n> +void MessageHandler::handleMessage(QtMsgType type,\n> +\t\t\t\t const QMessageLogContext &context,\n> +\t\t\t\t const QString &msg)\n> +{\n> +\tif (type == QtDebugMsg && !verbose_)\n> +\t\treturn;\n> +\n> +\thandler_(type, context, msg);\n> +}\n> diff --git a/src/qcam/message_handler.h b/src/qcam/message_handler.h\n> new file mode 100644\n> index 000000000000..4534db9d93f7\n> --- /dev/null\n> +++ b/src/qcam/message_handler.h\n> @@ -0,0 +1,26 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2020, Laurent Pinchart \n> + *\n> + * message_handler.cpp - qcam - Log message handling\n> + */\n> +#ifndef __QCAM_MESSAGE_HANDLER_H__\n> +#define __QCAM_MESSAGE_HANDLER_H__\n> +\n> +#include \n> +\n> +class MessageHandler\n> +{\n> +public:\n> +\tMessageHandler(bool verbose);\n> +\n> +private:\n> +\tstatic void handleMessage(QtMsgType type,\n> +\t\t\t\t const QMessageLogContext &context,\n> +\t\t\t\t const QString &msg);\n> +\n> +\tstatic QtMessageHandler handler_;\n> +\tstatic bool verbose_;\n> +};\n> +\n> +#endif /* __QCAM_MESSAGE_HANDLER_H__ */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69646BE176\n\tfor ;\n\tTue, 24 Nov 2020 19:09:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3673563406;\n\tTue, 24 Nov 2020 20:09:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F9D5615AC\n\tfor ;\n\tTue, 24 Nov 2020 20:09:34 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EB5FA19;\n\tTue, 24 Nov 2020 20:09:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ULNhdq5k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606244974;\n\tbh=bJ47+s2401DtTJYLMwYDtdLjNL9EOSWebu7KLFjSXck=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ULNhdq5kQnyH8ljcHPec4uVHe/HJjrLlwj+FxS9uBtEhIC5Mkgx2P5rygULAGa07D\n\tbf/YrCB7yn0Eohuaplr1/uBlAII1Ve2q4sDLbNxSeV21hjRoXUOJM1b7ROJ9l/dqnd\n\trWxGYCKosbmW75i/dp4/IuAH1qhClV0kMs05MiVw=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201124174342.19587-1-laurent.pinchart@ideasonboard.com>\n\t<20201124174342.19587-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<458d467f-3758-8373-1c70-8bc77aa1d925@ideasonboard.com>","Date":"Tue, 24 Nov 2020 19:09:30 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201124174342.19587-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: Make log less verbose by\n\tdefault","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13857,"web_url":"https://patchwork.libcamera.org/comment/13857/","msgid":"<20201124202802.fdvz7hxwgmzkgxkl@uno.localdomain>","date":"2020-11-24T20:28:02","subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: Make log less verbose by\n\tdefault","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Nov 24, 2020 at 07:43:42PM +0200, Laurent Pinchart wrote:\n> The qcam log prints one message per frame, which is pretty verbose. This\n> feature is useful for debugging, but not necessarily as a default\n> option. Silence it by default, and add a -v/--verbose command line\n> parameter to make the log verbose.\n>\n> While this could have been handled manually by checking a verbose flag\n> when printing the message, the feature is instead integrated with the Qt\n> log infrastructure to make it more flexible. Messages printed by\n> qDebug() are now silenced by default and controlled by the -v/--verbose\n> argument.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main.cpp | 5 +++++\n> src/qcam/main_window.cpp | 2 +-\n> src/qcam/main_window.h | 2 ++\n> src/qcam/meson.build | 1 +\n> src/qcam/message_handler.cpp | 27 +++++++++++++++++++++++++++\n> src/qcam/message_handler.h | 26 ++++++++++++++++++++++++++\n> 6 files changed, 62 insertions(+), 1 deletion(-)\n> create mode 100644 src/qcam/message_handler.cpp\n> create mode 100644 src/qcam/message_handler.h\n>\n> diff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\n> index 5505a5d88ef6..5eff90a3fa66 100644\n> --- a/src/qcam/main.cpp\n> +++ b/src/qcam/main.cpp\n> @@ -16,6 +16,7 @@\n> #include \"../cam/options.h\"\n> #include \"../cam/stream_options.h\"\n> #include \"main_window.h\"\n> +#include \"message_handler.h\"\n>\n> void signalHandler([[maybe_unused]] int signal)\n> {\n> @@ -38,6 +39,8 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n> \t\t\t \"renderer\", ArgumentRequired, \"renderer\");\n> \tparser.addOption(OptStream, &streamKeyValue,\n> \t\t\t \"Set configuration of a camera stream\", \"stream\", true);\n> +\tparser.addOption(OptVerbose, OptionNone,\n> +\t\t\t \"Print verbose log messages\", \"verbose\");\n>\n> \tOptionsParser::Options options = parser.parse(argc, argv);\n> \tif (options.isSet(OptHelp))\n> @@ -57,6 +60,8 @@ int main(int argc, char **argv)\n> \tif (options.isSet(OptHelp))\n> \t\treturn 0;\n>\n> +\tMessageHandler msgHandler(options.isSet(OptVerbose));\n> +\n> \tstruct sigaction sa = {};\n> \tsa.sa_handler = &signalHandler;\n> \tsigaction(SIGINT, &sa, nullptr);\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 2502ecd40abe..39d034de6bb2 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -746,7 +746,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> \tfps = lastBufferTime_ && fps ? 1000000000.0 / fps : 0.0;\n> \tlastBufferTime_ = metadata.timestamp;\n>\n> -\tqInfo().noquote()\n> +\tqDebug().noquote()\n> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> \t\t<< \"timestamp:\" << metadata.timestamp\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 64bcfebc7dbd..a9aa8ffcd8fd 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -41,6 +41,7 @@ enum {\n> \tOptHelp = 'h',\n> \tOptRenderer = 'r',\n> \tOptStream = 's',\n> +\tOptVerbose = 'v',\n> };\n>\n> class MainWindow : public QMainWindow\n> @@ -98,6 +99,7 @@ private:\n>\n> \t/* Options */\n> \tconst OptionsParser::Options &options_;\n> +\tbool verbose_;\n\nIs this used ?\nIt seems you pass the result of options.isSet() directly.\n\n>\n> \t/* Camera manager, camera, configuration and buffers */\n> \tCameraManager *cm_;\n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 9bb48c0d06c5..ebcd5ca010cf 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -6,6 +6,7 @@ qcam_sources = files([\n> 'format_converter.cpp',\n> 'main.cpp',\n> 'main_window.cpp',\n> + 'message_handler.cpp',\n> 'viewfinder_qt.cpp',\n> ])\n>\n> diff --git a/src/qcam/message_handler.cpp b/src/qcam/message_handler.cpp\n> new file mode 100644\n> index 000000000000..261623e19ca9\n> --- /dev/null\n> +++ b/src/qcam/message_handler.cpp\n> @@ -0,0 +1,27 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2020, Laurent Pinchart \n> + *\n> + * message_handler.cpp - qcam - Log message handling\n> + */\n> +\n> +#include \"message_handler.h\"\n> +\n> +QtMessageHandler MessageHandler::handler_ = nullptr;\n> +bool MessageHandler::verbose_ = false;\n> +\n> +MessageHandler::MessageHandler(bool verbose)\n> +{\n> +\tverbose_ = verbose;\n> +\thandler_ = qInstallMessageHandler(&MessageHandler::handleMessage);\n> +}\n> +\n> +void MessageHandler::handleMessage(QtMsgType type,\n> +\t\t\t\t const QMessageLogContext &context,\n> +\t\t\t\t const QString &msg)\n> +{\n> +\tif (type == QtDebugMsg && !verbose_)\n> +\t\treturn;\n> +\n> +\thandler_(type, context, msg);\n> +}\n> diff --git a/src/qcam/message_handler.h b/src/qcam/message_handler.h\n> new file mode 100644\n> index 000000000000..4534db9d93f7\n> --- /dev/null\n> +++ b/src/qcam/message_handler.h\n> @@ -0,0 +1,26 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2020, Laurent Pinchart \n> + *\n> + * message_handler.cpp - qcam - Log message handling\n\ns/.cpp/.h\n\n> + */\n> +#ifndef __QCAM_MESSAGE_HANDLER_H__\n> +#define __QCAM_MESSAGE_HANDLER_H__\n> +\n> +#include \n> +\n> +class MessageHandler\n> +{\n> +public:\n> +\tMessageHandler(bool verbose);\n> +\n> +private:\n> +\tstatic void handleMessage(QtMsgType type,\n> +\t\t\t\t const QMessageLogContext &context,\n> +\t\t\t\t const QString &msg);\n> +\n> +\tstatic QtMessageHandler handler_;\n> +\tstatic bool verbose_;\n> +};\n> +\n> +#endif /* __QCAM_MESSAGE_HANDLER_H__ */\n\nAs Kieran said, potentially an overkill, but if we want more control\nwe can filter on the QtMsgType with this\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A6D3BE08A\n\tfor ;\n\tTue, 24 Nov 2020 20:28:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A43DE63404;\n\tTue, 24 Nov 2020 21:28:00 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 116DF615AC\n\tfor ;\n\tTue, 24 Nov 2020 21:27:59 +0100 (CET)","from uno.localdomain (host-87-16-255-135.retail.telecomitalia.it\n\t[87.16.255.135]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2D5A660005;\n\tTue, 24 Nov 2020 20:27:57 +0000 (UTC)"],"X-Originating-IP":"87.16.255.135","Date":"Tue, 24 Nov 2020 21:28:02 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201124202802.fdvz7hxwgmzkgxkl@uno.localdomain>","References":"<20201124174342.19587-1-laurent.pinchart@ideasonboard.com>\n\t<20201124174342.19587-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201124174342.19587-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: Make log less verbose by\n\tdefault","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]