{"id":10476,"url":"https://patchwork.libcamera.org/api/patches/10476/?format=json","web_url":"https://patchwork.libcamera.org/patch/10476/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201123164319.152742-6-kieran.bingham@ideasonboard.com>","date":"2020-11-23T16:43:16","name":"[libcamera-devel,RFC,5/8] src: ipa: meson: Re-use existing system paths","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"9cec05933ee400482469a85c3fed31c1b975b1d7","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10476/mbox/","series":[{"id":1477,"url":"https://patchwork.libcamera.org/api/series/1477/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1477","date":"2020-11-23T16:43:11","name":"Configuration files and parsing","version":1,"mbox":"https://patchwork.libcamera.org/series/1477/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10476/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10476/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53EC9BE08A\n\tfor ;\n\tMon, 23 Nov 2020 16:45:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 136BA6340C;\n\tMon, 23 Nov 2020 17:45:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7872C633F2\n\tfor ;\n\tMon, 23 Nov 2020 17:44:59 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21DFE71;\n\tMon, 23 Nov 2020 17:44:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gumwg+zy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606149899;\n\tbh=Ohi7DMLd0Tf9EdGfdkQfO12SvSLQ1dK/ovx3NnXDAiY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gumwg+zyvy2pnConvB6wObTDeZ1K/83CBu6/64cAAOWEACxfYnCKXT9qUUza1d3+Z\n\tRQUGWfwn39hNpT+IfR4XJTwWWF+/CIqVSVcpm/hR7/rW1XoHzQr/YmDntLZKeaE9ND\n\tLukIVoteZlzUWb+BZr5SAtCaz1vnsfwKwucZ5drM=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 23 Nov 2020 16:43:16 +0000","Message-Id":"<20201123164319.152742-6-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 5/8] src: ipa: meson: Re-use existing\n\tsystem paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make use of the new system path variables and map the ipa paths upon the\nlibcamera system paths.\n\nWhile we're at it, make use of the new shorter syntax for join_paths().\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/meson.build | 16 +++++++---------\n src/meson.build | 2 ++\n 2 files changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex 5a5de267c147..c1dc1ce6fa90 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -1,19 +1,17 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n-ipa_data_dir = join_paths(get_option('datadir'), 'libcamera', 'ipa')\n-ipa_sysconf_dir = join_paths(get_option('sysconfdir'), 'libcamera', 'ipa')\n-\n ipa_includes = [\n libcamera_includes,\n ]\n \n-config_h.set('IPA_CONFIG_DIR',\n- '\"' + join_paths(get_option('prefix'), ipa_sysconf_dir) +\n- ':' + join_paths(get_option('prefix'), ipa_data_dir) + '\"')\n+ipa_install_dir = libcamera_libdir\n+ipa_data_dir = libcamera_datadir / 'ipa'\n+ipa_sysconf_dir = libcamera_sysconfdir / 'ipa'\n+\n+config_h.set('IPA_CONFIG_DIR', '\"' + prefix / ipa_sysconf_dir +\n+ ':' + prefix / ipa_data_dir + '\"')\n \n-config_h.set('IPA_MODULE_DIR',\n- '\"' + join_paths(get_option('prefix'), ipa_install_dir) + '\"')\n+config_h.set('IPA_MODULE_DIR', '\"' + prefix / ipa_install_dir + '\"')\n \n subdir('libipa')\n \ndiff --git a/src/meson.build b/src/meson.build\nindex b1b3514f6ed7..c7430805fd86 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -2,10 +2,12 @@\n \n # Handle system paths\n datadir = get_option('datadir')\n+libdir = get_option('libdir')\n prefix = get_option('prefix')\n sysconfdir = get_option('sysconfdir')\n \n libcamera_datadir = datadir / 'libcamera'\n+libcamera_libdir = libdir / 'libcamera'\n libcamera_sysconfdir = sysconfdir / 'libcamera'\n \n config_h.set('LIBCAMERA_SYSCONF_DIR', '\"' + prefix / libcamera_sysconfdir + '\"')\n","prefixes":["libcamera-devel","RFC","5/8"]}