{"id":10474,"url":"https://patchwork.libcamera.org/api/patches/10474/?format=json","web_url":"https://patchwork.libcamera.org/patch/10474/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201123164319.152742-4-kieran.bingham@ideasonboard.com>","date":"2020-11-23T16:43:14","name":"[libcamera-devel,RFC,3/8] src: meson: Simplify v4l2 enablement","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"5e78357b1a798d8457e073ef66849ec309f7fb17","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10474/mbox/","series":[{"id":1477,"url":"https://patchwork.libcamera.org/api/series/1477/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1477","date":"2020-11-23T16:43:11","name":"Configuration files and parsing","version":1,"mbox":"https://patchwork.libcamera.org/series/1477/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10474/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10474/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7658ABE08A\n\tfor ;\n\tMon, 23 Nov 2020 16:45:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43FCD633FB;\n\tMon, 23 Nov 2020 17:45:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0FD0633F6\n\tfor ;\n\tMon, 23 Nov 2020 17:44:58 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8427871;\n\tMon, 23 Nov 2020 17:44:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q5v1YVDJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606149898;\n\tbh=aBox++raUvo2sW/mFpOTME+Qelppss6T2peHGVCvfT4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Q5v1YVDJFcRvngap79AqmXdyREGXdLqeb51hu8x6kBE4nYlXl2MwCQY6lg/lqzZcy\n\tAuoLCIMTN7Rp96VP6+gAkHKZ/9wRXewt6/LJa+IWZvu5m+RvsdQ05N/Z9lpfD7Km7B\n\twUYOxaLJ6PrFiplbguDUJzrE6oYPudZUKrprF/30=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 23 Nov 2020 16:43:14 +0000","Message-Id":"<20201123164319.152742-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 3/8] src: meson: Simplify v4l2\n\tenablement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Simplify the src level meson file by moving the declaration of the v4l2 subdir\nto match the other invocations, making use of 'subdir_done()' to break out if the\nadaptation layer is not enabled.\n\nSigned-off-by: Kieran Bingham \n---\n src/meson.build | 5 +----\n src/v4l2/meson.build | 4 ++++\n 2 files changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/meson.build b/src/meson.build\nindex 27f70544f1f6..8c7449f9b8a0 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -20,8 +20,5 @@ subdir('ipa')\n subdir('cam')\n subdir('qcam')\n \n-if get_option('v4l2')\n- subdir('v4l2')\n-endif\n-\n+subdir('v4l2')\n subdir('gstreamer')\ndiff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex e3838f0b07cc..dbe6a424b10e 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -1,5 +1,9 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+if not get_option('v4l2')\n+ subdir_done()\n+endif\n+\n v4l2_compat_sources = files([\n 'v4l2_camera.cpp',\n 'v4l2_camera_file.cpp',\n","prefixes":["libcamera-devel","RFC","3/8"]}