[{"id":13860,"web_url":"https://patchwork.libcamera.org/comment/13860/","msgid":"<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>","date":"2020-11-24T20:56:37","subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Mon, Nov 23, 2020 at 04:43:13PM +0000, Kieran Bingham wrote:\n> Move the android subdir below the configuration options to keep all\n> subdirs together.\n>\n> Add a comment explaining why android must come first, and some padding\n> to group the libcamera and ipa components, applications, and remaining\n> adaptation layers.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/meson.build | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/meson.build b/src/meson.build\n> index b9c7e7599d61..27f70544f1f6 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -1,7 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> -subdir('android')\n> -\n> openssl = find_program('openssl', required : true)\n> if openssl.found()\n> ipa_priv_key = custom_target('ipa-priv-key',\n> @@ -13,8 +11,12 @@ else\n> ipa_sign_module = false\n> endif\n>\n> +# The Android HAL must be built before, and is included in libcamera.\n\nwell, to be picky, I think it's because of how we add the\nandroid_hal_sources and the metadata library definition that we reuse\nin the src/libcamera/meson.build file when building the library.\n\nIt's then mostly about how we instrumented the build system I think\n\n# The 'android' subdir must be listed first, as build targets there\n# defined are required when building libcamera\n\nJust an idea\n\nWhatever is fine,really\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +subdir('android')\n> +\n> subdir('libcamera')\n> subdir('ipa')\n> +\n> subdir('cam')\n> subdir('qcam')\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 163AEBE176\n\tfor ;\n\tTue, 24 Nov 2020 20:56:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D40663404;\n\tTue, 24 Nov 2020 21:56:35 +0100 (CET)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8C87615AC\n\tfor ;\n\tTue, 24 Nov 2020 21:56:33 +0100 (CET)","from uno.localdomain (host-87-16-255-135.retail.telecomitalia.it\n\t[87.16.255.135]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 0DCA21BF203;\n\tTue, 24 Nov 2020 20:56:32 +0000 (UTC)"],"X-Originating-IP":"87.16.255.135","Date":"Tue, 24 Nov 2020 21:56:37 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201123164319.152742-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13863,"web_url":"https://patchwork.libcamera.org/comment/13863/","msgid":"<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>","date":"2020-11-24T21:10:29","subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 24/11/2020 20:56, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Mon, Nov 23, 2020 at 04:43:13PM +0000, Kieran Bingham wrote:\n>> Move the android subdir below the configuration options to keep all\n>> subdirs together.\n>>\n>> Add a comment explaining why android must come first, and some padding\n>> to group the libcamera and ipa components, applications, and remaining\n>> adaptation layers.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/meson.build | 6 ++++--\n>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/meson.build b/src/meson.build\n>> index b9c7e7599d61..27f70544f1f6 100644\n>> --- a/src/meson.build\n>> +++ b/src/meson.build\n>> @@ -1,7 +1,5 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>>\n>> -subdir('android')\n>> -\n>> openssl = find_program('openssl', required : true)\n>> if openssl.found()\n>> ipa_priv_key = custom_target('ipa-priv-key',\n>> @@ -13,8 +11,12 @@ else\n>> ipa_sign_module = false\n>> endif\n>>\n>> +# The Android HAL must be built before, and is included in libcamera.\n> \n> well, to be picky, I think it's because of how we add the\n> android_hal_sources and the metadata library definition that we reuse\n> in the src/libcamera/meson.build file when building the library.\n> \n> It's then mostly about how we instrumented the build system I think\n> \n> # The 'android' subdir must be listed first, as build targets there\n> # defined are required when building libcamera\n> \n\nIt's a good point. The android layer isn't built during this subdir call\n- it's just processed, and the build targets collected into a variable\nwhich gets built into the main library I believe.\n\nHow about\n# The 'android' subdir must be processed first, and the build targets\n# are included directly into the libcamera library when this is enabled.\n\n> Just an idea\n> \n> Whatever is fine,really\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n>> +subdir('android')\n>> +\n>> subdir('libcamera')\n>> subdir('ipa')\n>> +\n>> subdir('cam')\n>> subdir('qcam')\n>>\n>> --\n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BB42BE176\n\tfor ;\n\tTue, 24 Nov 2020 21:10:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E55063404;\n\tTue, 24 Nov 2020 22:10:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54404615AC\n\tfor ;\n\tTue, 24 Nov 2020 22:10:32 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF1A0A19;\n\tTue, 24 Nov 2020 22:10:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SsaDXXC7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606252232;\n\tbh=VIiMSPsxCZr14AaOT94twzE59kYnKtD6ynztTkK9yd8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=SsaDXXC7y2n7Zz/OqwpbsRvmUglhy2bULku36nBX2Bh5CRc/thR7f8drHM2gMmLGm\n\tbupKU5FRJHR3Tmg1KkHFAEwfWH+Mn/gWNWYT44L828CsoiXhhLoIS3ZQdVqm00PQT1\n\tfzL5W+SJtzebH2QDUKRfUjpOdYeVYjz7g3eHc74c=","To":"Jacopo Mondi ","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-3-kieran.bingham@ideasonboard.com>\n\t<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>","Date":"Tue, 24 Nov 2020 21:10:29 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13864,"web_url":"https://patchwork.libcamera.org/comment/13864/","msgid":"<20201124212203.tq56q4moior6yrez@uno.localdomain>","date":"2020-11-24T21:22:03","subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Tue, Nov 24, 2020 at 09:10:29PM +0000, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 24/11/2020 20:56, Jacopo Mondi wrote:\n> > Hi Kieran,\n> >\n> > On Mon, Nov 23, 2020 at 04:43:13PM +0000, Kieran Bingham wrote:\n> >> Move the android subdir below the configuration options to keep all\n> >> subdirs together.\n> >>\n> >> Add a comment explaining why android must come first, and some padding\n> >> to group the libcamera and ipa components, applications, and remaining\n> >> adaptation layers.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/meson.build | 6 ++++--\n> >> 1 file changed, 4 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/meson.build b/src/meson.build\n> >> index b9c7e7599d61..27f70544f1f6 100644\n> >> --- a/src/meson.build\n> >> +++ b/src/meson.build\n> >> @@ -1,7 +1,5 @@\n> >> # SPDX-License-Identifier: CC0-1.0\n> >>\n> >> -subdir('android')\n> >> -\n> >> openssl = find_program('openssl', required : true)\n> >> if openssl.found()\n> >> ipa_priv_key = custom_target('ipa-priv-key',\n> >> @@ -13,8 +11,12 @@ else\n> >> ipa_sign_module = false\n> >> endif\n> >>\n> >> +# The Android HAL must be built before, and is included in libcamera.\n> >\n> > well, to be picky, I think it's because of how we add the\n> > android_hal_sources and the metadata library definition that we reuse\n> > in the src/libcamera/meson.build file when building the library.\n> >\n> > It's then mostly about how we instrumented the build system I think\n> >\n> > # The 'android' subdir must be listed first, as build targets there\n> > # defined are required when building libcamera\n> >\n>\n> It's a good point. The android layer isn't built during this subdir call\n> - it's just processed, and the build targets collected into a variable\n> which gets built into the main library I believe.\n>\n> How about\n> # The 'android' subdir must be processed first, and the build targets\n> # are included directly into the libcamera library when this is enabled.\n>\n\nEven better ;)\n\nThanks\n j\n\n> > Just an idea\n> >\n> > Whatever is fine,really\n> > Reviewed-by: Jacopo Mondi \n> >\n> > Thanks\n> > j\n> >\n> >> +subdir('android')\n> >> +\n> >> subdir('libcamera')\n> >> subdir('ipa')\n> >> +\n> >> subdir('cam')\n> >> subdir('qcam')\n> >>\n> >> --\n> >> 2.25.1\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 159D8BE08A\n\tfor ;\n\tTue, 24 Nov 2020 21:22:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA8C763401;\n\tTue, 24 Nov 2020 22:22:01 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56C2A615AC\n\tfor ;\n\tTue, 24 Nov 2020 22:22:00 +0100 (CET)","from uno.localdomain (host-87-16-255-135.retail.telecomitalia.it\n\t[87.16.255.135]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 75A8820004;\n\tTue, 24 Nov 2020 21:21:59 +0000 (UTC)"],"X-Originating-IP":"87.16.255.135","Date":"Tue, 24 Nov 2020 22:22:03 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201124212203.tq56q4moior6yrez@uno.localdomain>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-3-kieran.bingham@ideasonboard.com>\n\t<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>\n\t<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14015,"web_url":"https://patchwork.libcamera.org/comment/14015/","msgid":"<20201201171438.GO4569@pendragon.ideasonboard.com>","date":"2020-12-01T17:14:38","subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Nov 24, 2020 at 09:10:29PM +0000, Kieran Bingham wrote:\n> On 24/11/2020 20:56, Jacopo Mondi wrote:\n> > On Mon, Nov 23, 2020 at 04:43:13PM +0000, Kieran Bingham wrote:\n> >> Move the android subdir below the configuration options to keep all\n> >> subdirs together.\n> >>\n> >> Add a comment explaining why android must come first, and some padding\n> >> to group the libcamera and ipa components, applications, and remaining\n> >> adaptation layers.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/meson.build | 6 ++++--\n> >> 1 file changed, 4 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/meson.build b/src/meson.build\n> >> index b9c7e7599d61..27f70544f1f6 100644\n> >> --- a/src/meson.build\n> >> +++ b/src/meson.build\n> >> @@ -1,7 +1,5 @@\n> >> # SPDX-License-Identifier: CC0-1.0\n> >>\n> >> -subdir('android')\n> >> -\n> >> openssl = find_program('openssl', required : true)\n> >> if openssl.found()\n> >> ipa_priv_key = custom_target('ipa-priv-key',\n> >> @@ -13,8 +11,12 @@ else\n> >> ipa_sign_module = false\n> >> endif\n> >>\n> >> +# The Android HAL must be built before, and is included in libcamera.\n> > \n> > well, to be picky, I think it's because of how we add the\n> > android_hal_sources and the metadata library definition that we reuse\n> > in the src/libcamera/meson.build file when building the library.\n> > \n> > It's then mostly about how we instrumented the build system I think\n> > \n> > # The 'android' subdir must be listed first, as build targets there\n> > # defined are required when building libcamera\n> \n> It's a good point. The android layer isn't built during this subdir call\n> - it's just processed, and the build targets collected into a variable\n> which gets built into the main library I believe.\n> \n> How about\n> # The 'android' subdir must be processed first, and the build targets\n> # are included directly into the libcamera library when this is enabled.\n\nReviewed-by: Laurent Pinchart \n\nI wonder if at some point we'll split it to a separate library.\n\n> > Just an idea\n> > \n> > Whatever is fine,really\n> > Reviewed-by: Jacopo Mondi \n> > \n> > Thanks\n> > j\n> > \n> >> +subdir('android')\n> >> +\n> >> subdir('libcamera')\n> >> subdir('ipa')\n> >> +\n> >> subdir('cam')\n> >> subdir('qcam')\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53D41BE177\n\tfor ;\n\tTue, 1 Dec 2020 17:14:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E674863503;\n\tTue, 1 Dec 2020 18:14:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92AA963460\n\tfor ;\n\tTue, 1 Dec 2020 18:14:47 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02D65DBD;\n\tTue, 1 Dec 2020 18:14:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wf0/JAR1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606842887;\n\tbh=qb29qIAK4cjaCgcGpe1egpguAxb9bwRtK34Koao3RCk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wf0/JAR1ro5z9S78phCQ8UfhU+tdLoY/0eeqUZ8qCm1AeCtASQlUpgSBs4lEqYrMt\n\tDX1nMGthiz/hFBMp+Jr0/DjG13DTdC935mertymBiznAAiWYkNrMkwCqRYnL0DRNGU\n\t/b+f0yY2jhPlGnoAWvxN95hczv9BXyah8PfcBcQc=","Date":"Tue, 1 Dec 2020 19:14:38 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201201171438.GO4569@pendragon.ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-3-kieran.bingham@ideasonboard.com>\n\t<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>\n\t<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14031,"web_url":"https://patchwork.libcamera.org/comment/14031/","msgid":"","date":"2020-12-01T23:20:28","subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/12/2020 17:14, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Nov 24, 2020 at 09:10:29PM +0000, Kieran Bingham wrote:\n>> On 24/11/2020 20:56, Jacopo Mondi wrote:\n>>> On Mon, Nov 23, 2020 at 04:43:13PM +0000, Kieran Bingham wrote:\n>>>> Move the android subdir below the configuration options to keep all\n>>>> subdirs together.\n>>>>\n>>>> Add a comment explaining why android must come first, and some padding\n>>>> to group the libcamera and ipa components, applications, and remaining\n>>>> adaptation layers.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> src/meson.build | 6 ++++--\n>>>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>>>>\n>>>> diff --git a/src/meson.build b/src/meson.build\n>>>> index b9c7e7599d61..27f70544f1f6 100644\n>>>> --- a/src/meson.build\n>>>> +++ b/src/meson.build\n>>>> @@ -1,7 +1,5 @@\n>>>> # SPDX-License-Identifier: CC0-1.0\n>>>>\n>>>> -subdir('android')\n>>>> -\n>>>> openssl = find_program('openssl', required : true)\n>>>> if openssl.found()\n>>>> ipa_priv_key = custom_target('ipa-priv-key',\n>>>> @@ -13,8 +11,12 @@ else\n>>>> ipa_sign_module = false\n>>>> endif\n>>>>\n>>>> +# The Android HAL must be built before, and is included in libcamera.\n>>>\n>>> well, to be picky, I think it's because of how we add the\n>>> android_hal_sources and the metadata library definition that we reuse\n>>> in the src/libcamera/meson.build file when building the library.\n>>>\n>>> It's then mostly about how we instrumented the build system I think\n>>>\n>>> # The 'android' subdir must be listed first, as build targets there\n>>> # defined are required when building libcamera\n>>\n>> It's a good point. The android layer isn't built during this subdir call\n>> - it's just processed, and the build targets collected into a variable\n>> which gets built into the main library I believe.\n>>\n>> How about\n>> # The 'android' subdir must be processed first, and the build targets\n>> # are included directly into the libcamera library when this is enabled.\n> \n> Reviewed-by: Laurent Pinchart \n> \n> I wonder if at some point we'll split it to a separate library.\n\nI think that would be better indeed, and would help with packaging\nperhaps too.\n\nBut it's not for now ;-)\n\n--\nKieran\n\n>>> Just an idea\n>>>\n>>> Whatever is fine,really\n>>> Reviewed-by: Jacopo Mondi \n>>>\n>>> Thanks\n>>> j\n>>>\n>>>> +subdir('android')\n>>>> +\n>>>> subdir('libcamera')\n>>>> subdir('ipa')\n>>>> +\n>>>> subdir('cam')\n>>>> subdir('qcam')\n>>>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB33BBE177\n\tfor ;\n\tTue, 1 Dec 2020 23:20:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 506DC6358F;\n\tWed, 2 Dec 2020 00:20:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AAB863320\n\tfor ;\n\tWed, 2 Dec 2020 00:20:31 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9698E99A;\n\tWed, 2 Dec 2020 00:20:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VPUM5xM4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606864830;\n\tbh=Qo9+1eKU5FHrGs6ZSj3rZxba2LHqE9zw/znpMo4JVL0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=VPUM5xM4+VMftMhijyBZzOy/xpfZ7g0eNXDwEs2tKMYnA0hXlvL1H3IUlqdVnt1Mj\n\tQkFVBp23D0oUYHCbhNy+Ma0vNnyQLzEQTmrBXULKqxtoWJPOc1Uu3GRlpn3dz0TECn\n\tYXWCWVSIvnHYyuIO5Cm4G4YzVJrhBq3ep3XegNlE=","To":"Laurent Pinchart ","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-3-kieran.bingham@ideasonboard.com>\n\t<20201124205637.k6ibdqpwlyxrphqs@uno.localdomain>\n\t<5bccd2ac-925a-6957-4d38-b7f42d8f3dc0@ideasonboard.com>\n\t<20201201171438.GO4569@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 1 Dec 2020 23:20:28 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201201171438.GO4569@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH 2/8] src: meson: Re-order subdir\n\tlayout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]