[{"id":14008,"web_url":"https://patchwork.libcamera.org/comment/14008/","msgid":"<20201201165038.GK4569@pendragon.ideasonboard.com>","date":"2020-12-01T16:50:38","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n> Later versions of meson allow for the first positional argument to\n> specificy the defaults. Specify the libcamera library as the first\n> argument, and remove the filebase.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> meson.build | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 55cf36e15f57..ced4afa7d726 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n> configure_file(output : 'config.h', configuration : config_h)\n> \n> pkg_mod = import('pkgconfig')\n> -pkg_mod.generate(libraries : libcamera,\n> +pkg_mod.generate(libcamera,\n> version : '1.0',\n> name : 'libcamera',\n> - filebase : 'camera',\n> description : 'Complex Camera Support Library',\n> subdirs : 'libcamera')\n> \n\nThe documentation states\n\nSince 0.46 a StaticLibrary or SharedLibrary object can optionally be\npassed as first positional argument. If one is provided a default value\nwill be provided for all required fields of the pc file:\n\n- install_dir is set to pkgconfig folder in the same location than the\n provided library.\n- description is set to the project's name followed by the library's\n name.\n- name is set to the library's name.\n\n\nIs it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\nseems to default to name, so it would be set to \"libcamera\", not\n\"camera\". If we drop the name argument then name will default to the\nshared library name, which is \"camera\", and filebase will then default\nto name. There thus seems to be a change of behaviour, which should be\ndocumented in the commit message (and verified to ensure it's correct).","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A4AEBE177\n\tfor ;\n\tTue, 1 Dec 2020 16:50:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A7E063460;\n\tTue, 1 Dec 2020 17:50:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35C0663460\n\tfor ;\n\tTue, 1 Dec 2020 17:50:47 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2E2EDBD;\n\tTue, 1 Dec 2020 17:50:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P3cQEnAX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606841446;\n\tbh=blBlWue2yPHN/YP+uq0D/mOPQEt0ld8W23bIFzm+1cY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P3cQEnAXjr0fzdIrv7+cKWvrv8EpCucw0jdMTvCbg4t5QEbShoAMBLAzLVuAq6CEH\n\tIw7ELq8eN7ryT8t9MKaSpWP86AK0Q76J+143t/VQWMk/UVAWiHFxDndq7/xJdGTD5k\n\tS9cPjcussMC4bbspt3bzd7IIKQlvbRkqvHaUNpMY=","Date":"Tue, 1 Dec 2020 18:50:38 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201201165038.GK4569@pendragon.ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201123164319.152742-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14009,"web_url":"https://patchwork.libcamera.org/comment/14009/","msgid":"<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>","date":"2020-12-01T16:56:56","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/12/2020 16:50, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n>> Later versions of meson allow for the first positional argument to\n>> specificy the defaults. Specify the libcamera library as the first\n>> argument, and remove the filebase.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> meson.build | 3 +--\n>> 1 file changed, 1 insertion(+), 2 deletions(-)\n>>\n>> diff --git a/meson.build b/meson.build\n>> index 55cf36e15f57..ced4afa7d726 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n>> configure_file(output : 'config.h', configuration : config_h)\n>> \n>> pkg_mod = import('pkgconfig')\n>> -pkg_mod.generate(libraries : libcamera,\n>> +pkg_mod.generate(libcamera,\n>> version : '1.0',\n>> name : 'libcamera',\n>> - filebase : 'camera',\n>> description : 'Complex Camera Support Library',\n>> subdirs : 'libcamera')\n>> \n> \n> The documentation states\n> \n> Since 0.46 a StaticLibrary or SharedLibrary object can optionally be\n> passed as first positional argument. If one is provided a default value\n> will be provided for all required fields of the pc file:\n> \n> - install_dir is set to pkgconfig folder in the same location than the\n> provided library.\n> - description is set to the project's name followed by the library's\n> name.\n> - name is set to the library's name.\n> \n> \n> Is it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\n> seems to default to name, so it would be set to \"libcamera\", not\n> \"camera\". If we drop the name argument then name will default to the\n> shared library name, which is \"camera\", and filebase will then default\n> to name. There thus seems to be a change of behaviour, which should be\n> documented in the commit message (and verified to ensure it's correct).\n\n\nI'll have to check, but this was a patch I had stuck around for ages,\nwhich I created upon a recommendation from one of the meson devs.\n\nI haven't seen any change in behaviour, but I'll double check again\nlater, meanwhile: an install from this build seems to show everything\nstill correctly named 'libcamera' ...\n\n/tmp/libcamera-build-prefix/usr/share/libcamera\n/tmp/libcamera-build-prefix/usr/share/doc/libcamera-0.0.11\n/tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/libcamera.so\n/tmp/libcamera-build-prefix/usr/include/libcamera/libcamera/version.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCC25BE176\n\tfor ;\n\tTue, 1 Dec 2020 16:57:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C21963501;\n\tTue, 1 Dec 2020 17:57:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B204263460\n\tfor ;\n\tTue, 1 Dec 2020 17:56:59 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3103693;\n\tTue, 1 Dec 2020 17:56:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AS9ISzm8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606841819;\n\tbh=ETHgpefjtxutL0oJH9Sf0HZHAx0lIPVVcBT3gM2CCN0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=AS9ISzm8H2e4HcPgxzAwXcMCLSa1tCtQynksz8khh1NHM1+xQ0w692WXWGN3VKfQ7\n\tLnjZWoh3ieRwY5QKR3K4Ny1IAGcFA5+M1cpzQRHwYFBfY5cNiK5LeLo1locsRjFSGI\n\tK51OxV20Bq920sJm6GpI5m6IOFmU/ay7IbNN+NQ0=","To":"Laurent Pinchart ","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>\n\t<20201201165038.GK4569@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>","Date":"Tue, 1 Dec 2020 16:56:56 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201201165038.GK4569@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14010,"web_url":"https://patchwork.libcamera.org/comment/14010/","msgid":"<20201201165851.GL4569@pendragon.ideasonboard.com>","date":"2020-12-01T16:58:51","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Dec 01, 2020 at 04:56:56PM +0000, Kieran Bingham wrote:\n> On 01/12/2020 16:50, Laurent Pinchart wrote:\n> > On Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n> >> Later versions of meson allow for the first positional argument to\n> >> specificy the defaults. Specify the libcamera library as the first\n> >> argument, and remove the filebase.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> meson.build | 3 +--\n> >> 1 file changed, 1 insertion(+), 2 deletions(-)\n> >>\n> >> diff --git a/meson.build b/meson.build\n> >> index 55cf36e15f57..ced4afa7d726 100644\n> >> --- a/meson.build\n> >> +++ b/meson.build\n> >> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n> >> configure_file(output : 'config.h', configuration : config_h)\n> >> \n> >> pkg_mod = import('pkgconfig')\n> >> -pkg_mod.generate(libraries : libcamera,\n> >> +pkg_mod.generate(libcamera,\n> >> version : '1.0',\n> >> name : 'libcamera',\n> >> - filebase : 'camera',\n> >> description : 'Complex Camera Support Library',\n> >> subdirs : 'libcamera')\n> >> \n> > \n> > The documentation states\n> > \n> > Since 0.46 a StaticLibrary or SharedLibrary object can optionally be\n> > passed as first positional argument. If one is provided a default value\n> > will be provided for all required fields of the pc file:\n> > \n> > - install_dir is set to pkgconfig folder in the same location than the\n> > provided library.\n> > - description is set to the project's name followed by the library's\n> > name.\n> > - name is set to the library's name.\n> > \n> > \n> > Is it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\n> > seems to default to name, so it would be set to \"libcamera\", not\n> > \"camera\". If we drop the name argument then name will default to the\n> > shared library name, which is \"camera\", and filebase will then default\n> > to name. There thus seems to be a change of behaviour, which should be\n> > documented in the commit message (and verified to ensure it's correct).\n> \n> \n> I'll have to check, but this was a patch I had stuck around for ages,\n> which I created upon a recommendation from one of the meson devs.\n> \n> I haven't seen any change in behaviour, but I'll double check again\n> later, meanwhile: an install from this build seems to show everything\n> still correctly named 'libcamera' ...\n> \n> /tmp/libcamera-build-prefix/usr/share/libcamera\n> /tmp/libcamera-build-prefix/usr/share/doc/libcamera-0.0.11\n> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/libcamera.so\n> /tmp/libcamera-build-prefix/usr/include/libcamera/libcamera/version.h\n\nI expect this patch to only affect the .pc file generation :-) Could you\ndiff its contents, and check if its name changes ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B6BBBE176\n\tfor ;\n\tTue, 1 Dec 2020 16:59:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E98A163503;\n\tTue, 1 Dec 2020 17:59:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4169F63460\n\tfor ;\n\tTue, 1 Dec 2020 17:59:00 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9AB5DBD;\n\tTue, 1 Dec 2020 17:58:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Uh5OSUHs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606841939;\n\tbh=8Z2Gtsdt0g2EfO4lG+fmIc/RoDM5pUx8Y6u5a22BzTc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Uh5OSUHsHcgTfByrYBYcZ4GDSlUR5i4NXngZ6h1HP8VHzICzncig7TuArScTz9Dqo\n\td3+4dTJ4JX1qjjgGeYJ33YXafY79EZUW6RvKPWMLUla8KoC47E7J9UHV00nKiJosSa\n\teNPMB2XI7nK5byc2spoSJYMcaQ7k+p9nC6r6fsvE=","Date":"Tue, 1 Dec 2020 18:58:51 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201201165851.GL4569@pendragon.ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>\n\t<20201201165038.GK4569@pendragon.ideasonboard.com>\n\t<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14012,"web_url":"https://patchwork.libcamera.org/comment/14012/","msgid":"","date":"2020-12-01T17:01:46","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/12/2020 16:58, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Tue, Dec 01, 2020 at 04:56:56PM +0000, Kieran Bingham wrote:\n>> On 01/12/2020 16:50, Laurent Pinchart wrote:\n>>> On Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n>>>> Later versions of meson allow for the first positional argument to\n>>>> specificy the defaults. Specify the libcamera library as the first\n>>>> argument, and remove the filebase.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> meson.build | 3 +--\n>>>> 1 file changed, 1 insertion(+), 2 deletions(-)\n>>>>\n>>>> diff --git a/meson.build b/meson.build\n>>>> index 55cf36e15f57..ced4afa7d726 100644\n>>>> --- a/meson.build\n>>>> +++ b/meson.build\n>>>> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n>>>> configure_file(output : 'config.h', configuration : config_h)\n>>>> \n>>>> pkg_mod = import('pkgconfig')\n>>>> -pkg_mod.generate(libraries : libcamera,\n>>>> +pkg_mod.generate(libcamera,\n>>>> version : '1.0',\n>>>> name : 'libcamera',\n>>>> - filebase : 'camera',\n>>>> description : 'Complex Camera Support Library',\n>>>> subdirs : 'libcamera')\n>>>> \n>>>\n>>> The documentation states\n>>>\n>>> Since 0.46 a StaticLibrary or SharedLibrary object can optionally be\n>>> passed as first positional argument. If one is provided a default value\n>>> will be provided for all required fields of the pc file:\n>>>\n>>> - install_dir is set to pkgconfig folder in the same location than the\n>>> provided library.\n>>> - description is set to the project's name followed by the library's\n>>> name.\n>>> - name is set to the library's name.\n>>>\n>>>\n>>> Is it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\n>>> seems to default to name, so it would be set to \"libcamera\", not\n>>> \"camera\". If we drop the name argument then name will default to the\n>>> shared library name, which is \"camera\", and filebase will then default\n>>> to name. There thus seems to be a change of behaviour, which should be\n>>> documented in the commit message (and verified to ensure it's correct).\n>>\n>>\n>> I'll have to check, but this was a patch I had stuck around for ages,\n>> which I created upon a recommendation from one of the meson devs.\n>>\n>> I haven't seen any change in behaviour, but I'll double check again\n>> later, meanwhile: an install from this build seems to show everything\n>> still correctly named 'libcamera' ...\n>>\n>> /tmp/libcamera-build-prefix/usr/share/libcamera\n>> /tmp/libcamera-build-prefix/usr/share/doc/libcamera-0.0.11\n>> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/libcamera.so\n>> /tmp/libcamera-build-prefix/usr/include/libcamera/libcamera/version.h\n> \n> I expect this patch to only affect the .pc file generation :-) Could you\n> diff its contents, and check if its name changes ?\n> \n\ndiff\n/tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n/usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n\n ;-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45653BE177\n\tfor ;\n\tTue, 1 Dec 2020 17:01:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F82A63506;\n\tTue, 1 Dec 2020 18:01:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AEB663460\n\tfor ;\n\tTue, 1 Dec 2020 18:01:50 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C01531D;\n\tTue, 1 Dec 2020 18:01:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QlYTHSEs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606842109;\n\tbh=dJPpPtnimXAkBtFYLAoB5AzphQq7yeoLtvecr4972wM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=QlYTHSEsUUfPz5fOWLdUMS5qE3dK8EI1wogQuWjNYx0RbVltQPJXRzcQLRSWxKvp3\n\tYdv3DOh5QT/0W+NtwfFdFrUJRAT5urc04rvfEHzUzQEASEm82YQoTuuKaCaNUXhuYb\n\t3wXo4iAhTzEq0vF7SmnkzC5ZPBAtpnNB7HUL39BU=","To":"Laurent Pinchart ","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>\n\t<20201201165038.GK4569@pendragon.ideasonboard.com>\n\t<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>\n\t<20201201165851.GL4569@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 1 Dec 2020 17:01:46 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201201165851.GL4569@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14014,"web_url":"https://patchwork.libcamera.org/comment/14014/","msgid":"<20201201171225.GN4569@pendragon.ideasonboard.com>","date":"2020-12-01T17:12:25","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Dec 01, 2020 at 05:01:46PM +0000, Kieran Bingham wrote:\n> Hi Laurent,\n> \n> On 01/12/2020 16:58, Laurent Pinchart wrote:\n> > Hi Kieran,\n> > \n> > On Tue, Dec 01, 2020 at 04:56:56PM +0000, Kieran Bingham wrote:\n> >> On 01/12/2020 16:50, Laurent Pinchart wrote:\n> >>> On Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n> >>>> Later versions of meson allow for the first positional argument to\n> >>>> specificy the defaults. Specify the libcamera library as the first\n> >>>> argument, and remove the filebase.\n> >>>>\n> >>>> Signed-off-by: Kieran Bingham \n> >>>> ---\n> >>>> meson.build | 3 +--\n> >>>> 1 file changed, 1 insertion(+), 2 deletions(-)\n> >>>>\n> >>>> diff --git a/meson.build b/meson.build\n> >>>> index 55cf36e15f57..ced4afa7d726 100644\n> >>>> --- a/meson.build\n> >>>> +++ b/meson.build\n> >>>> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n> >>>> configure_file(output : 'config.h', configuration : config_h)\n> >>>> \n> >>>> pkg_mod = import('pkgconfig')\n> >>>> -pkg_mod.generate(libraries : libcamera,\n> >>>> +pkg_mod.generate(libcamera,\n> >>>> version : '1.0',\n> >>>> name : 'libcamera',\n> >>>> - filebase : 'camera',\n> >>>> description : 'Complex Camera Support Library',\n> >>>> subdirs : 'libcamera')\n> >>>> \n> >>>\n> >>> The documentation states\n> >>>\n> >>> Since 0.46 a StaticLibrary or SharedLibrary object can optionally be\n> >>> passed as first positional argument. If one is provided a default value\n> >>> will be provided for all required fields of the pc file:\n> >>>\n> >>> - install_dir is set to pkgconfig folder in the same location than the\n> >>> provided library.\n> >>> - description is set to the project's name followed by the library's\n> >>> name.\n> >>> - name is set to the library's name.\n> >>>\n> >>>\n> >>> Is it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\n> >>> seems to default to name, so it would be set to \"libcamera\", not\n> >>> \"camera\". If we drop the name argument then name will default to the\n> >>> shared library name, which is \"camera\", and filebase will then default\n> >>> to name. There thus seems to be a change of behaviour, which should be\n> >>> documented in the commit message (and verified to ensure it's correct).\n> >>\n> >>\n> >> I'll have to check, but this was a patch I had stuck around for ages,\n> >> which I created upon a recommendation from one of the meson devs.\n> >>\n> >> I haven't seen any change in behaviour, but I'll double check again\n> >> later, meanwhile: an install from this build seems to show everything\n> >> still correctly named 'libcamera' ...\n> >>\n> >> /tmp/libcamera-build-prefix/usr/share/libcamera\n> >> /tmp/libcamera-build-prefix/usr/share/doc/libcamera-0.0.11\n> >> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/libcamera.so\n> >> /tmp/libcamera-build-prefix/usr/include/libcamera/libcamera/version.h\n> > \n> > I expect this patch to only affect the .pc file generation :-) Could you\n> > diff its contents, and check if its name changes ?\n> \n> diff\n> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n> /usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n> \n> ;-)\n\nThat's strange, here I have\n\ndiff -Nur a/usr/local/lib64/pkgconfig/camera.pc b/usr/local/lib64/pkgconfig/camera.pc\n--- a/usr/local/lib64/pkgconfig/camera.pc 2020-12-01 17:37:07.077026434 +0200\n+++ b/usr/local/lib64/pkgconfig/camera.pc 1970-01-01 02:00:00.000000000 +0200\n@@ -1,9 +0,0 @@\n-prefix=/usr/local\n-libdir=${prefix}/lib64\n-includedir=${prefix}/include\n-\n-Name: libcamera\n-Description: Complex Camera Support Library\n-Version: 1.0\n-Libs: -L${libdir} -lcamera\n-Cflags: -I${includedir}/libcamera\ndiff -Nur a/usr/local/lib64/pkgconfig/libcamera.pc b/usr/local/lib64/pkgconfig/libcamera.pc\n--- a/usr/local/lib64/pkgconfig/libcamera.pc 1970-01-01 02:00:00.000000000 +0200\n+++ b/usr/local/lib64/pkgconfig/libcamera.pc 2020-12-01 19:04:21.415247132 +0200\n@@ -0,0 +1,9 @@\n+prefix=/usr/local\n+libdir=${prefix}/lib64\n+includedir=${prefix}/include\n+\n+Name: libcamera\n+Description: Complex Camera Support Library\n+Version: 1.0\n+Libs: -L${libdir} -lcamera\n+Cflags: -I${includedir}/libcamera\n\nContents are the same, but the .pc file got renamed from camera.pc to\nlibcamera.pc. No necessarily an issue, but pkg-config will need to be\nrun with an updated name, requiring an update to simple-cam I believe.\n\nIf we additionally drop the name argument, the file name is preserved,\nbut its contents change to\n\n--- a/usr/local/lib64/pkgconfig/camera.pc\t2020-12-01 17:37:07.077026434 +0200\n+++ b/usr/local/lib64/pkgconfig/camera.pc\t2020-12-01 19:09:47.299260873 +0200\n@@ -2,7 +2,7 @@\n libdir=${prefix}/lib64\n includedir=${prefix}/include\n \n-Name: libcamera\n+Name: camera\n Description: Complex Camera Support Library\n Version: 1.0\n Libs: -L${libdir} -lcamera\n\n\nI'm not a pkg-config expert so I don't know if we should include the lib\nprefix in the file name and/or the Name.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D22A2BE176\n\tfor ;\n\tTue, 1 Dec 2020 17:12:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CAD063503;\n\tTue, 1 Dec 2020 18:12:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 122D263460\n\tfor ;\n\tTue, 1 Dec 2020 18:12:34 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D1A5DBD;\n\tTue, 1 Dec 2020 18:12:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MQ20SuXX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606842753;\n\tbh=KWlumujkaBWyKELxNZq24SlinUlKEk8dek1ZYI2k+bs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MQ20SuXXteyh2Ay66SLpfNkfIFxk+fryJ9JVNff6qHgPQSEN8q4ON27T70C7B0dkz\n\tHK/hnRo4EgCsscP8wCnMpqJcnMjqc9tRT8yCg6xcvtGlsFs0BzY2iWYKY7T3Tq1F2u\n\t83LDG4s+s66jZo0eFd1y1n6aj47qH1Vre6IxgvVw=","Date":"Tue, 1 Dec 2020 19:12:25 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201201171225.GN4569@pendragon.ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>\n\t<20201201165038.GK4569@pendragon.ideasonboard.com>\n\t<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>\n\t<20201201165851.GL4569@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14103,"web_url":"https://patchwork.libcamera.org/comment/14103/","msgid":"<62617c7e-a50c-e502-d970-8e70c27ea5c0@ideasonboard.com>","date":"2020-12-07T15:31:55","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/12/2020 17:12, Laurent Pinchart wrote:\n> On Tue, Dec 01, 2020 at 05:01:46PM +0000, Kieran Bingham wrote:\n>> Hi Laurent,\n>>\n>> On 01/12/2020 16:58, Laurent Pinchart wrote:\n>>> Hi Kieran,\n>>>\n>>> On Tue, Dec 01, 2020 at 04:56:56PM +0000, Kieran Bingham wrote:\n>>>> On 01/12/2020 16:50, Laurent Pinchart wrote:\n>>>>> On Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n>>>>>> Later versions of meson allow for the first positional argument to\n>>>>>> specificy the defaults. Specify the libcamera library as the first\n>>>>>> argument, and remove the filebase.\n>>>>>>\n>>>>>> Signed-off-by: Kieran Bingham \n>>>>>> ---\n>>>>>> meson.build | 3 +--\n>>>>>> 1 file changed, 1 insertion(+), 2 deletions(-)\n>>>>>>\n>>>>>> diff --git a/meson.build b/meson.build\n>>>>>> index 55cf36e15f57..ced4afa7d726 100644\n>>>>>> --- a/meson.build\n>>>>>> +++ b/meson.build\n>>>>>> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n>>>>>> configure_file(output : 'config.h', configuration : config_h)\n>>>>>> \n>>>>>> pkg_mod = import('pkgconfig')\n>>>>>> -pkg_mod.generate(libraries : libcamera,\n>>>>>> +pkg_mod.generate(libcamera,\n>>>>>> version : '1.0',\n>>>>>> name : 'libcamera',\n>>>>>> - filebase : 'camera',\n>>>>>> description : 'Complex Camera Support Library',\n>>>>>> subdirs : 'libcamera')\n>>>>>> \n>>>>>\n>>>>> The documentation states\n>>>>>\n>>>>> Since 0.46 a StaticLibrary or SharedLibrary object can optionally be\n>>>>> passed as first positional argument. If one is provided a default value\n>>>>> will be provided for all required fields of the pc file:\n>>>>>\n>>>>> - install_dir is set to pkgconfig folder in the same location than the\n>>>>> provided library.\n>>>>> - description is set to the project's name followed by the library's\n>>>>> name.\n>>>>> - name is set to the library's name.\n>>>>>\n>>>>>\n>>>>> Is it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\n>>>>> seems to default to name, so it would be set to \"libcamera\", not\n>>>>> \"camera\". If we drop the name argument then name will default to the\n>>>>> shared library name, which is \"camera\", and filebase will then default\n>>>>> to name. There thus seems to be a change of behaviour, which should be\n>>>>> documented in the commit message (and verified to ensure it's correct).\n>>>>\n>>>>\n>>>> I'll have to check, but this was a patch I had stuck around for ages,\n>>>> which I created upon a recommendation from one of the meson devs.\n>>>>\n>>>> I haven't seen any change in behaviour, but I'll double check again\n>>>> later, meanwhile: an install from this build seems to show everything\n>>>> still correctly named 'libcamera' ...\n>>>>\n>>>> /tmp/libcamera-build-prefix/usr/share/libcamera\n>>>> /tmp/libcamera-build-prefix/usr/share/doc/libcamera-0.0.11\n>>>> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/libcamera.so\n>>>> /tmp/libcamera-build-prefix/usr/include/libcamera/libcamera/version.h\n>>>\n>>> I expect this patch to only affect the .pc file generation :-) Could you\n>>> diff its contents, and check if its name changes ?\n>>\n>> diff\n>> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n>> /usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n>>\n>> ;-)\n> \n> That's strange, here I have\n\nI must have installed a 'patched' version at some point which broke my\ncomparison.\n\nAnyway, this patch is a distraction - so I've split out the meson fixes\nto a new series and dropped this patch for now.\n\nThere's no bug/issue here - it was only a recommendation from meson\ndevelopers.\n\nWe can always revisit it later.\n\n\n\n> diff -Nur a/usr/local/lib64/pkgconfig/camera.pc b/usr/local/lib64/pkgconfig/camera.pc\n> --- a/usr/local/lib64/pkgconfig/camera.pc 2020-12-01 17:37:07.077026434 +0200\n> +++ b/usr/local/lib64/pkgconfig/camera.pc 1970-01-01 02:00:00.000000000 +0200\n> @@ -1,9 +0,0 @@\n> -prefix=/usr/local\n> -libdir=${prefix}/lib64\n> -includedir=${prefix}/include\n> -\n> -Name: libcamera\n> -Description: Complex Camera Support Library\n> -Version: 1.0\n> -Libs: -L${libdir} -lcamera\n> -Cflags: -I${includedir}/libcamera\n> diff -Nur a/usr/local/lib64/pkgconfig/libcamera.pc b/usr/local/lib64/pkgconfig/libcamera.pc\n> --- a/usr/local/lib64/pkgconfig/libcamera.pc 1970-01-01 02:00:00.000000000 +0200\n> +++ b/usr/local/lib64/pkgconfig/libcamera.pc 2020-12-01 19:04:21.415247132 +0200\n> @@ -0,0 +1,9 @@\n> +prefix=/usr/local\n> +libdir=${prefix}/lib64\n> +includedir=${prefix}/include\n> +\n> +Name: libcamera\n> +Description: Complex Camera Support Library\n> +Version: 1.0\n> +Libs: -L${libdir} -lcamera\n> +Cflags: -I${includedir}/libcamera\n> \n> Contents are the same, but the .pc file got renamed from camera.pc to\n> libcamera.pc. No necessarily an issue, but pkg-config will need to be\n\nI see, I must have missed that, as the builds will have still found the\nold version.\n\nPersonally, I'd actually rather see the library specified as 'libcamera'\nto pkg-config, as that's our name though.\n\n\n\n> run with an updated name, requiring an update to simple-cam I believe.\n> \n> If we additionally drop the name argument, the file name is preserved,\n> but its contents change to\n> \n> --- a/usr/local/lib64/pkgconfig/camera.pc\t2020-12-01 17:37:07.077026434 +0200\n> +++ b/usr/local/lib64/pkgconfig/camera.pc\t2020-12-01 19:09:47.299260873 +0200\n> @@ -2,7 +2,7 @@\n> libdir=${prefix}/lib64\n> includedir=${prefix}/include\n> \n> -Name: libcamera\n> +Name: camera\n\nOk, so we don't want that bit though ;-)\n\n> Description: Complex Camera Support Library\n> Version: 1.0\n> Libs: -L${libdir} -lcamera\n> \n> \n> I'm not a pkg-config expert so I don't know if we should include the lib\n> prefix in the file name and/or the Name.\n\nI think that's up to us isn't it ?\n\nHowever I suspect most libraries do not prefix with 'lib' ... but most\nlibraries do not have 'lib' in their name. (Except for the fact that\nthey are libraries).\n\nWe're a bit different because we are 'libcamera' as opposed to say\n'gtk', which is not known widely as 'libgtk', that's just it's library.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52347BDB20\n\tfor ;\n\tMon, 7 Dec 2020 15:31:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C92A867E6C;\n\tMon, 7 Dec 2020 16:31:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2204F635A0\n\tfor ;\n\tMon, 7 Dec 2020 16:31:58 +0100 (CET)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 848E68D;\n\tMon, 7 Dec 2020 16:31:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SHy6hrDb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607355117;\n\tbh=iCjpfv/GOlm4V2PsZajHrRSKS37yK3cyNgMTOmKA4Fw=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=SHy6hrDbWupoApdpcHQvJc0ZlGPXTD2xe+Y14i2rN5E3FS2BypsE6UokYHgUPFG4y\n\tS/to/onbdlGnTESZ9n/LCnestnr5hojstq3fNudrYGcHPdxIV07LijULolthRwGCZb\n\t+oAEmB8vGIQXhBy8EK7zv2BwoU9GXlSuReYAeWuE=","To":"Laurent Pinchart ","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>\n\t<20201201165038.GK4569@pendragon.ideasonboard.com>\n\t<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>\n\t<20201201165851.GL4569@pendragon.ideasonboard.com>\n\t\n\t<20201201171225.GN4569@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<62617c7e-a50c-e502-d970-8e70c27ea5c0@ideasonboard.com>","Date":"Mon, 7 Dec 2020 15:31:55 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201201171225.GN4569@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14105,"web_url":"https://patchwork.libcamera.org/comment/14105/","msgid":"","date":"2020-12-07T17:04:15","subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Dec 07, 2020 at 03:31:55PM +0000, Kieran Bingham wrote:\n> On 01/12/2020 17:12, Laurent Pinchart wrote:\n> > On Tue, Dec 01, 2020 at 05:01:46PM +0000, Kieran Bingham wrote:\n> >> On 01/12/2020 16:58, Laurent Pinchart wrote:\n> >>> On Tue, Dec 01, 2020 at 04:56:56PM +0000, Kieran Bingham wrote:\n> >>>> On 01/12/2020 16:50, Laurent Pinchart wrote:\n> >>>>> On Mon, Nov 23, 2020 at 04:43:12PM +0000, Kieran Bingham wrote:\n> >>>>>> Later versions of meson allow for the first positional argument to\n> >>>>>> specificy the defaults. Specify the libcamera library as the first\n> >>>>>> argument, and remove the filebase.\n> >>>>>>\n> >>>>>> Signed-off-by: Kieran Bingham \n> >>>>>> ---\n> >>>>>> meson.build | 3 +--\n> >>>>>> 1 file changed, 1 insertion(+), 2 deletions(-)\n> >>>>>>\n> >>>>>> diff --git a/meson.build b/meson.build\n> >>>>>> index 55cf36e15f57..ced4afa7d726 100644\n> >>>>>> --- a/meson.build\n> >>>>>> +++ b/meson.build\n> >>>>>> @@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n> >>>>>> configure_file(output : 'config.h', configuration : config_h)\n> >>>>>> \n> >>>>>> pkg_mod = import('pkgconfig')\n> >>>>>> -pkg_mod.generate(libraries : libcamera,\n> >>>>>> +pkg_mod.generate(libcamera,\n> >>>>>> version : '1.0',\n> >>>>>> name : 'libcamera',\n> >>>>>> - filebase : 'camera',\n> >>>>>> description : 'Complex Camera Support Library',\n> >>>>>> subdirs : 'libcamera')\n> >>>>>> \n> >>>>>\n> >>>>> The documentation states\n> >>>>>\n> >>>>> Since 0.46 a StaticLibrary or SharedLibrary object can optionally be\n> >>>>> passed as first positional argument. If one is provided a default value\n> >>>>> will be provided for all required fields of the pc file:\n> >>>>>\n> >>>>> - install_dir is set to pkgconfig folder in the same location than the\n> >>>>> provided library.\n> >>>>> - description is set to the project's name followed by the library's\n> >>>>> name.\n> >>>>> - name is set to the library's name.\n> >>>>>\n> >>>>>\n> >>>>> Is it the \"name\" argument that can be dropped, not \"filebase\" ? filebase\n> >>>>> seems to default to name, so it would be set to \"libcamera\", not\n> >>>>> \"camera\". If we drop the name argument then name will default to the\n> >>>>> shared library name, which is \"camera\", and filebase will then default\n> >>>>> to name. There thus seems to be a change of behaviour, which should be\n> >>>>> documented in the commit message (and verified to ensure it's correct).\n> >>>>\n> >>>>\n> >>>> I'll have to check, but this was a patch I had stuck around for ages,\n> >>>> which I created upon a recommendation from one of the meson devs.\n> >>>>\n> >>>> I haven't seen any change in behaviour, but I'll double check again\n> >>>> later, meanwhile: an install from this build seems to show everything\n> >>>> still correctly named 'libcamera' ...\n> >>>>\n> >>>> /tmp/libcamera-build-prefix/usr/share/libcamera\n> >>>> /tmp/libcamera-build-prefix/usr/share/doc/libcamera-0.0.11\n> >>>> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/libcamera.so\n> >>>> /tmp/libcamera-build-prefix/usr/include/libcamera/libcamera/version.h\n> >>>\n> >>> I expect this patch to only affect the .pc file generation :-) Could you\n> >>> diff its contents, and check if its name changes ?\n> >>\n> >> diff\n> >> /tmp/libcamera-build-prefix/usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n> >> /usr/lib/x86_64-linux-gnu/pkgconfig/libcamera.pc\n> >>\n> >> ;-)\n> > \n> > That's strange, here I have\n> \n> I must have installed a 'patched' version at some point which broke my\n> comparison.\n> \n> Anyway, this patch is a distraction - so I've split out the meson fixes\n> to a new series and dropped this patch for now.\n> \n> There's no bug/issue here - it was only a recommendation from meson\n> developers.\n> \n> We can always revisit it later.\n> \n> > diff -Nur a/usr/local/lib64/pkgconfig/camera.pc b/usr/local/lib64/pkgconfig/camera.pc\n> > --- a/usr/local/lib64/pkgconfig/camera.pc 2020-12-01 17:37:07.077026434 +0200\n> > +++ b/usr/local/lib64/pkgconfig/camera.pc 1970-01-01 02:00:00.000000000 +0200\n> > @@ -1,9 +0,0 @@\n> > -prefix=/usr/local\n> > -libdir=${prefix}/lib64\n> > -includedir=${prefix}/include\n> > -\n> > -Name: libcamera\n> > -Description: Complex Camera Support Library\n> > -Version: 1.0\n> > -Libs: -L${libdir} -lcamera\n> > -Cflags: -I${includedir}/libcamera\n> > diff -Nur a/usr/local/lib64/pkgconfig/libcamera.pc b/usr/local/lib64/pkgconfig/libcamera.pc\n> > --- a/usr/local/lib64/pkgconfig/libcamera.pc 1970-01-01 02:00:00.000000000 +0200\n> > +++ b/usr/local/lib64/pkgconfig/libcamera.pc 2020-12-01 19:04:21.415247132 +0200\n> > @@ -0,0 +1,9 @@\n> > +prefix=/usr/local\n> > +libdir=${prefix}/lib64\n> > +includedir=${prefix}/include\n> > +\n> > +Name: libcamera\n> > +Description: Complex Camera Support Library\n> > +Version: 1.0\n> > +Libs: -L${libdir} -lcamera\n> > +Cflags: -I${includedir}/libcamera\n> > \n> > Contents are the same, but the .pc file got renamed from camera.pc to\n> > libcamera.pc. No necessarily an issue, but pkg-config will need to be\n> \n> I see, I must have missed that, as the builds will have still found the\n> old version.\n> \n> Personally, I'd actually rather see the library specified as 'libcamera'\n> to pkg-config, as that's our name though.\n> \n> > run with an updated name, requiring an update to simple-cam I believe.\n> > \n> > If we additionally drop the name argument, the file name is preserved,\n> > but its contents change to\n> > \n> > --- a/usr/local/lib64/pkgconfig/camera.pc\t2020-12-01 17:37:07.077026434 +0200\n> > +++ b/usr/local/lib64/pkgconfig/camera.pc\t2020-12-01 19:09:47.299260873 +0200\n> > @@ -2,7 +2,7 @@\n> > libdir=${prefix}/lib64\n> > includedir=${prefix}/include\n> > \n> > -Name: libcamera\n> > +Name: camera\n> \n> Ok, so we don't want that bit though ;-)\n> \n> > Description: Complex Camera Support Library\n> > Version: 1.0\n> > Libs: -L${libdir} -lcamera\n> > \n> > \n> > I'm not a pkg-config expert so I don't know if we should include the lib\n> > prefix in the file name and/or the Name.\n> \n> I think that's up to us isn't it ?\n\nI think so. I would expect there are best practice rules, but maybe it's\nonly cargo cult programming :-)\n\n> However I suspect most libraries do not prefix with 'lib' ... but most\n> libraries do not have 'lib' in their name. (Except for the fact that\n> they are libraries).\n> \n> We're a bit different because we are 'libcamera' as opposed to say\n> 'gtk', which is not known widely as 'libgtk', that's just it's library.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1FD6BDB20\n\tfor ;\n\tMon, 7 Dec 2020 17:04:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 737B667E6A;\n\tMon, 7 Dec 2020 18:04:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07466635A0\n\tfor ;\n\tMon, 7 Dec 2020 18:04:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BE298D;\n\tMon, 7 Dec 2020 18:04:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I55Xk9UI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607360658;\n\tbh=Jdqn6ClgOnQEaQNd47uuC4/XJUs1ERopT/ZcUT4pW8o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I55Xk9UIw11FZ64uwz4UttLF6+DNtLXmN6UIyIZxK5ZH7fv8ZtyVSc8J8T/GH9Ikd\n\tThNguC2Jg5FnGJGxztoa8PcCo2kmm6nuZGtPKWto+0Jk9qASdG4t+K9T52jwQzAbrJ\n\td0Z0nuizysI0ju+pt1A7txhc8MBNR655GxzM2QzM=","Date":"Mon, 7 Dec 2020 19:04:15 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>\n\t<20201123164319.152742-2-kieran.bingham@ideasonboard.com>\n\t<20201201165038.GK4569@pendragon.ideasonboard.com>\n\t<2bcb51e2-5b57-6926-8d80-da244dde4500@ideasonboard.com>\n\t<20201201165851.GL4569@pendragon.ideasonboard.com>\n\t\n\t<20201201171225.GN4569@pendragon.ideasonboard.com>\n\t<62617c7e-a50c-e502-d970-8e70c27ea5c0@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<62617c7e-a50c-e502-d970-8e70c27ea5c0@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 1/8] meson: Simplify\n\tpkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]