[{"id":13817,"web_url":"https://patchwork.libcamera.org/comment/13817/","msgid":"<20201120150240.GB15389@pendragon.ideasonboard.com>","date":"2020-11-20T15:02:40","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Improve Control\n\tdocumentation grammar","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Nov 20, 2020 at 03:00:21PM +0000, Kieran Bingham wrote:\n> A few grammatical errors remain in the Control class documentation.\n> Fix them.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/controls.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index aad461121651..c58ed3946f3b 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -437,8 +437,8 @@ void ControlValue::reserve(ControlType type, bool isArray, std::size_t numElemen\n> * the control value. See for instance how the ControlList::get() method\n> * returns a value corresponding to the type of the requested control.\n> *\n> - * While this class is the main mean to refer to a control, the control\n> - * identifying information are stored in the non-template base ControlId class.\n> + * While this class is the main means to refer to a control, the control\n> + * identifying information is stored in the non-template base ControlId class.\n> * This allows code that operates on a set of controls of different types to\n> * reference those controls through a ControlId instead of a Control. For\n> * instance, the list of controls supported by a camera is exposed as ControlId","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFFF5BE176\n\tfor ;\n\tFri, 20 Nov 2020 15:02:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64A6B625AC;\n\tFri, 20 Nov 2020 16:02:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAB9D6220D\n\tfor ;\n\tFri, 20 Nov 2020 16:02:47 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61F052A3;\n\tFri, 20 Nov 2020 16:02:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JRANVMya\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605884567;\n\tbh=5/2mL7P/lpctfjEmYydyt7RyHKRufWRD/rVWyteIXq0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JRANVMyajGNIc1Rlj//wH5VvVDTG2JyyP6rFKpfg+Tg63H5Csx6FfgBCAeIhhKXtm\n\tGu1OV+vUOB2hUVIkc38RUEcVrtOWyy6epipx53mguxJHvxe/BZjX74J23NS6kla/up\n\tdxcF6I5WDrX3s5PdcnkvfdBnYiC+JYA0Objej66U=","Date":"Fri, 20 Nov 2020 17:02:40 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201120150240.GB15389@pendragon.ideasonboard.com>","References":"<20201120150021.81865-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201120150021.81865-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Improve Control\n\tdocumentation grammar","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]