[{"id":13799,"web_url":"https://patchwork.libcamera.org/comment/13799/","msgid":"","date":"2020-11-19T12:40:08","subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\n$SUBJECT is missing a \"simple-cam:\" prefix to match the others.\n\nWas this patch already posted somewhere?\n\nI don't seem to be able to find it, but I do half-recollect it ;-)\nI just can't figure out where from.\n\n\nOn 19/11/2020 12:34, Umang Jain wrote:\n> Failing to do so, the codepath will segfault while trying to acquire\n> a non-existent camera.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n> ---\n> simple-cam.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 727bb6d..af9c8b1 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -307,6 +307,13 @@ int main()\n> \tfor (std::unique_ptr &request : requests)\n> \t\tcamera->queueRequest(request.get());\n> \n> +\tif(!cm->cameras().size()) {\n> +\t\tstd::cout << \"No cameras were identified on the system.\"\n> +\t\t\t << std::endl;\n> +\t\tcm->stop();\n> +\t\treturn -1;\n\nI think we should we return -ENODEV instead of -1 here. We already use\nerrno values (for example -ENOMEM is used).\n\n--\nKieran\n\n\n> +\t}\n> +\n> \t/*\n> \t * --------------------------------------------------------------------\n> \t * Run an EventLoop\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 045B8BE08A\n\tfor ;\n\tThu, 19 Nov 2020 12:40:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3476615A5;\n\tThu, 19 Nov 2020 13:40:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63B4E615A1\n\tfor ;\n\tThu, 19 Nov 2020 13:40:11 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 021E5292;\n\tThu, 19 Nov 2020 13:40:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V1GdzDxG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605789611;\n\tbh=Hc9+hpWE12hbxhjjBjqbMqEbeDbvyf8nnzLI8EileiI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=V1GdzDxGboZIZLESiwoeTbeBkazVdQU+2cqQ2h8NSfdfXPl1rgfdhCxvmd60Rkh1x\n\tqp+KoNgeugz+NSIVbqV/dJTOGT6nBF74t6rFEQOFOow6r/gVaf9Jl+Xj58qVr6dgHh\n\t5iJ/qdr62h4nB1Sog9vRPdNq+HqyGR5Jc6C1ytqk=","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20201119123427.53864-1-email@uajain.com>\n\t<20201119123427.53864-2-email@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 19 Nov 2020 12:40:08 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201119123427.53864-2-email@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13801,"web_url":"https://patchwork.libcamera.org/comment/13801/","msgid":"<400ba269-3a13-e1d0-6725-2fbf8ea62756@uajain.com>","date":"2020-11-19T14:50:53","subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Kieran,\n\nOn 11/19/20 6:10 PM, Kieran Bingham wrote:\n> Hi Umang,\n>\n> $SUBJECT is missing a \"simple-cam:\" prefix to match the others.\n>\n> Was this patch already posted somewhere?\n>\n> I don't seem to be able to find it, but I do half-recollect it ;-)\n> I just can't figure out where from.\nNoted. Let me address this in a new version after 3/3 is reviewed. As \nmentioned in the cover-letter, I submitted  this patch earlier a while \nback on the list but it didn't make the merge somehow. Hence, I \nre-submitted it here. So let's try to get it merged via this series itself.\n>\n>\n> On 19/11/2020 12:34, Umang Jain wrote:\n>> Failing to do so, the codepath will segfault while trying to acquire\n>> a non-existent camera.\n>>\n>> Signed-off-by: Umang Jain \n>> Reviewed-by: Kieran Bingham \n>> ---\n>> simple-cam.cpp | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>> index 727bb6d..af9c8b1 100644\n>> --- a/simple-cam.cpp\n>> +++ b/simple-cam.cpp\n>> @@ -307,6 +307,13 @@ int main()\n>> \tfor (std::unique_ptr &request : requests)\n>> \t\tcamera->queueRequest(request.get());\n>> \n>> +\tif(!cm->cameras().size()) {\n>> +\t\tstd::cout << \"No cameras were identified on the system.\"\n>> +\t\t\t << std::endl;\n>> +\t\tcm->stop();\n>> +\t\treturn -1;\n> I think we should we return -ENODEV instead of -1 here. We already use\n> errno values (for example -ENOMEM is used).\nNoted.\n>\n> --\n> Kieran\n>\n>\n>> +\t}\n>> +\n>> \t/*\n>> \t * --------------------------------------------------------------------\n>> \t * Run an EventLoop\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 649DBBE176\n\tfor ;\n\tThu, 19 Nov 2020 14:51:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3236B615AD;\n\tThu, 19 Nov 2020 15:51:01 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95823615A5\n\tfor ;\n\tThu, 19 Nov 2020 15:50:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"R8lvOdIN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1605797458; bh=DmXWOlP6hn9MrmuUCgI/JGTNRbsqiUjF4uhVdVZfKUA=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=R8lvOdINNH+4SLPTOicMeh/Fa8RucwpMB90AgwOjxb0fsnnzE0oPNAKW0l/UCI3QO\n\tojgqC0kS2VCiPVOP535qTgBldkvJaeidC603GJ0myw3McPy8gWuH90iOsffBzpBUDN\n\t7xzBO4jAewkBnwj1ZeTcU7RekKklzvTLrAIZqNb3LBLd4pq7y+u9HCAGLcBtGIb4uy\n\t1sH68Lr6XiYsmyEX2YmQKDcSTRV0xacVzZHu/XLyYbTxWP6f07ZfZNLZc7Pzvy5VBO\n\tQsqwqVgqmFzyFFRwE/ICdlcHaicQIPkkRTbr/qr2Hwwj5Vfuu7UcnLQoS9bym4tZm/\n\txJzt2FM3sKDmQ==","To":"kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org","References":"<20201119123427.53864-1-email@uajain.com>\n\t<20201119123427.53864-2-email@uajain.com>\n\t","From":"Umang Jain ","Message-ID":"<400ba269-3a13-e1d0-6725-2fbf8ea62756@uajain.com>","Date":"Thu, 19 Nov 2020 20:20:53 +0530","Mime-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13806,"web_url":"https://patchwork.libcamera.org/comment/13806/","msgid":"","date":"2020-11-19T15:58:54","subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 19/11/2020 14:50, Umang Jain wrote:\n> Hi Kieran,\n> \n> On 11/19/20 6:10 PM, Kieran Bingham wrote:\n>> Hi Umang,\n>>\n>> $SUBJECT is missing a \"simple-cam:\" prefix to match the others.\n>>\n>> Was this patch already posted somewhere?\n>>\n>> I don't seem to be able to find it, but I do half-recollect it ;-)\n>> I just can't figure out where from.\n\nAh - found the earlier series now.\n\n> Noted. Let me address this in a new version after 3/3 is reviewed. As\n> mentioned in the cover-letter, I submitted  this patch earlier a while\n> back on the list but it didn't make the merge somehow. Hence, I\n\nHrm, sorry for letting that slip.\n\n\n> re-submitted it here. So let's try to get it merged via this series itself.\n>>\n\nYes, lets keep this series moving ;-)\n\n>> On 19/11/2020 12:34, Umang Jain wrote:\n>>> Failing to do so, the codepath will segfault while trying to acquire\n>>> a non-existent camera.\n>>>\n>>> Signed-off-by: Umang Jain \n>>> Reviewed-by: Kieran Bingham \n\nThis still stands with the -ENODEV resolved below, and the $SUBJECT\nfixed of course.\n\n>>> ---\n>>>   simple-cam.cpp | 7 +++++++\n>>>   1 file changed, 7 insertions(+)\n>>>\n>>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>>> index 727bb6d..af9c8b1 100644\n>>> --- a/simple-cam.cpp\n>>> +++ b/simple-cam.cpp\n>>> @@ -307,6 +307,13 @@ int main()\n>>>       for (std::unique_ptr &request : requests)\n>>>           camera->queueRequest(request.get());\n>>>   +    if(!cm->cameras().size()) {\n>>> +        std::cout << \"No cameras were identified on the system.\"\n>>> +              << std::endl;\n>>> +        cm->stop();\n>>> +        return -1;\n>> I think we should we return -ENODEV instead of -1 here. We already use\n>> errno values (for example -ENOMEM is used).\n> Noted.\n>>\n>> -- \n>> Kieran\n>>\n>>\n>>> +    }\n>>> +\n>>>       /*\n>>>        *\n>>> --------------------------------------------------------------------\n>>>        * Run an EventLoop\n>>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EE17BE08A\n\tfor ;\n\tThu, 19 Nov 2020 15:59:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3E55615AF;\n\tThu, 19 Nov 2020 16:58:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20D95615A5\n\tfor ;\n\tThu, 19 Nov 2020 16:58:58 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73B6D24D;\n\tThu, 19 Nov 2020 16:58:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DQf1kmkR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605801537;\n\tbh=gXhX9XGMng/Pz13s4+EaSsir7LSuZJ6BQpoxOSOn8h4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=DQf1kmkRNlYwkpy5LlFDf678K+3p3hccG33alJJ/VbsXuvcflNUX/q30pAVVknVIt\n\t2WZfLyxbncKqtb5z+7u3FoBNd8ju/R1QjPhUuJ9L5C6Fj9JUia5mGC+5He/ZapD4kf\n\tFg6lDP+sFHzmZnDOAi0PgfWX/F/QxvSrpaJp+ESY=","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20201119123427.53864-1-email@uajain.com>\n\t<20201119123427.53864-2-email@uajain.com>\n\t\n\t<400ba269-3a13-e1d0-6725-2fbf8ea62756@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 19 Nov 2020 15:58:54 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<400ba269-3a13-e1d0-6725-2fbf8ea62756@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13848,"web_url":"https://patchwork.libcamera.org/comment/13848/","msgid":"<20201124144041.GG4592@pendragon.ideasonboard.com>","date":"2020-11-24T14:40:41","subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Nov 19, 2020 at 12:40:08PM +0000, Kieran Bingham wrote:\n> Hi Umang,\n> \n> $SUBJECT is missing a \"simple-cam:\" prefix to match the others.\n> \n> Was this patch already posted somewhere?\n> \n> I don't seem to be able to find it, but I do half-recollect it ;-)\n> I just can't figure out where from.\n> \n> On 19/11/2020 12:34, Umang Jain wrote:\n> > Failing to do so, the codepath will segfault while trying to acquire\n> > a non-existent camera.\n> > \n> > Signed-off-by: Umang Jain \n> > Reviewed-by: Kieran Bingham \n> > ---\n> > simple-cam.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/simple-cam.cpp b/simple-cam.cpp\n> > index 727bb6d..af9c8b1 100644\n> > --- a/simple-cam.cpp\n> > +++ b/simple-cam.cpp\n> > @@ -307,6 +307,13 @@ int main()\n> > \tfor (std::unique_ptr &request : requests)\n> > \t\tcamera->queueRequest(request.get());\n> > \n> > +\tif(!cm->cameras().size()) {\n> > +\t\tstd::cout << \"No cameras were identified on the system.\"\n> > +\t\t\t << std::endl;\n> > +\t\tcm->stop();\n> > +\t\treturn -1;\n> \n> I think we should we return -ENODEV instead of -1 here. We already use\n> errno values (for example -ENOMEM is used).\n\nNote that the return value of the main() function is a bit special. C\nand C++ define EXIT_SUCCESS and EXIT_FAILURE to denote success and\nfailure respectively (not a surprise :-)). The value of those macros is\nunspecified. See https://en.cppreference.com/w/c/program/EXIT_status.\n\n(Interestingly, the standard defines that both EXIT_SUCCESS and the\nvalue zero indicate successful program execution status, but don't\nrequire EXIT_SUCCESS to be equal to zero.)\n\nOther values are allowed, but only the 8 least significant bits are\nconveyed to the parent, so the range of usable values is effectively\n0-255. Furthermore, shells may reserve some values. For instance, bash\nsets $? to 126 if a command is found but not executable, 127 if the\ncommand is not found, and 128+N if the command terminates with a fatal\nsignal N.\n\nAs I don't expect we'll need to convey failure reasons through the exit\nstatus for simple cam, how about returning either 0 and 1, or\nEXIT_SUCCESS and EXIT_FAILURE ?\n\n> > +\t}\n> > +\n> > \t/*\n> > \t * --------------------------------------------------------------------\n> > \t * Run an EventLoop","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D4F9BE08A\n\tfor ;\n\tTue, 24 Nov 2020 14:40:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1990B63402;\n\tTue, 24 Nov 2020 15:40:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C66663343\n\tfor ;\n\tTue, 24 Nov 2020 15:40:49 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F8A4292;\n\tTue, 24 Nov 2020 15:40:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aXaHxhqK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606228848;\n\tbh=mnaJ4siG+p87UsLg5lxrU+G50oAonMWBAEF+DmH+6pM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aXaHxhqK6j+jO1IjuKt+sPIVt1JND5y2P8EZ1PXntn4J1d4SXIIDYIwYMyBEHpa+6\n\taiFDYBbT8eRFHLLmzGwjEeMSjiaJlJrtI8/elpXjuZTIEsqTAWkF6bit6DVXx+9R77\n\tTM54HmkqRO2uGiMJHYAWHAtcmpY5RSPfm6Y3pYLo=","Date":"Tue, 24 Nov 2020 16:40:41 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201124144041.GG4592@pendragon.ideasonboard.com>","References":"<20201119123427.53864-1-email@uajain.com>\n\t<20201119123427.53864-2-email@uajain.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13856,"web_url":"https://patchwork.libcamera.org/comment/13856/","msgid":"<24c724d5-6ad6-5980-de7c-3d1c751034a6@ideasonboard.com>","date":"2020-11-24T19:22:08","subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 24/11/2020 14:40, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Thu, Nov 19, 2020 at 12:40:08PM +0000, Kieran Bingham wrote:\n>> Hi Umang,\n>>\n>> $SUBJECT is missing a \"simple-cam:\" prefix to match the others.\n>>\n>> Was this patch already posted somewhere?\n>>\n>> I don't seem to be able to find it, but I do half-recollect it ;-)\n>> I just can't figure out where from.\n>>\n>> On 19/11/2020 12:34, Umang Jain wrote:\n>>> Failing to do so, the codepath will segfault while trying to acquire\n>>> a non-existent camera.\n>>>\n>>> Signed-off-by: Umang Jain \n>>> Reviewed-by: Kieran Bingham \n>>> ---\n>>> simple-cam.cpp | 7 +++++++\n>>> 1 file changed, 7 insertions(+)\n>>>\n>>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>>> index 727bb6d..af9c8b1 100644\n>>> --- a/simple-cam.cpp\n>>> +++ b/simple-cam.cpp\n>>> @@ -307,6 +307,13 @@ int main()\n>>> \tfor (std::unique_ptr &request : requests)\n>>> \t\tcamera->queueRequest(request.get());\n>>> \n>>> +\tif(!cm->cameras().size()) {\n>>> +\t\tstd::cout << \"No cameras were identified on the system.\"\n>>> +\t\t\t << std::endl;\n>>> +\t\tcm->stop();\n>>> +\t\treturn -1;\n>>\n>> I think we should we return -ENODEV instead of -1 here. We already use\n>> errno values (for example -ENOMEM is used).\n> \n> Note that the return value of the main() function is a bit special. C\n> and C++ define EXIT_SUCCESS and EXIT_FAILURE to denote success and\n> failure respectively (not a surprise :-)). The value of those macros is\n> unspecified. See https://en.cppreference.com/w/c/program/EXIT_status.\n> \n> (Interestingly, the standard defines that both EXIT_SUCCESS and the\n> value zero indicate successful program execution status, but don't\n> require EXIT_SUCCESS to be equal to zero.)\n> \n> Other values are allowed, but only the 8 least significant bits are\n> conveyed to the parent, so the range of usable values is effectively\n> 0-255. Furthermore, shells may reserve some values. For instance, bash\n> sets $? to 126 if a command is found but not executable, 127 if the\n> command is not found, and 128+N if the command terminates with a fatal\n> signal N.\n> \n> As I don't expect we'll need to convey failure reasons through the exit\n> status for simple cam, how about returning either 0 and 1, or\n> EXIT_SUCCESS and EXIT_FAILURE ?\n\nAha - good point, I'd totally missed that. I guess I don't spend much\ntime in main() :-)\n\nI'd prefer the explicit EXIT_SUCCESS / EXIT_FAILURE in these cases, but\nit might be nice to make the file consistent either way.\n\nI'll leave it up to you Umang to decide what you prefer.\n\n--\nKieran\n\n\n> \n>>> +\t}\n>>> +\n>>> \t/*\n>>> \t * --------------------------------------------------------------------\n>>> \t * Run an EventLoop\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03E7CBE176\n\tfor ;\n\tTue, 24 Nov 2020 19:22:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67B5363404;\n\tTue, 24 Nov 2020 20:22:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45BD9615AC\n\tfor ;\n\tTue, 24 Nov 2020 20:22:13 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C1AEA19;\n\tTue, 24 Nov 2020 20:22:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kOA6wFia\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606245732;\n\tbh=BkHBVtPGzfJwMtwjLI6f3CNg7kVISWPIUQ3XL41iYSw=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=kOA6wFia8vrN9/mhllp7aUOF7DVwwbBmthFirRrBd43wnV96hzFRHXbKaErL/uDSd\n\teuYS7Ge9lW31XM5GDava2jf9SHea+ugMxpcWkIaGGvdT1ZWhpIBWmzPjI8AX9lcCSe\n\tx2MT+gSD8tV8UcvVR4Q6f/S+ag6OlV6HGqL0uXg4=","To":"Laurent Pinchart ","References":"<20201119123427.53864-1-email@uajain.com>\n\t<20201119123427.53864-2-email@uajain.com>\n\t\n\t<20201124144041.GG4592@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<24c724d5-6ad6-5980-de7c-3d1c751034a6@ideasonboard.com>","Date":"Tue, 24 Nov 2020 19:22:08 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201124144041.GG4592@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] Early return if no cameras are\n\tfound on the system.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]