[{"id":13744,"web_url":"https://patchwork.libcamera.org/comment/13744/","msgid":"","date":"2020-11-17T11:14:10","subject":"Re: [libcamera-devel] [PATCH 2/2] src: ipa: raspberrypi: Change\n\t'sport' exposure mode name to 'short'","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\n\nOn Tue, 17 Nov 2020 at 09:32, David Plowman \nwrote:\n\n> The names have to match for the setting to work. I've chosen to go\n> with the libcamera terminology (even though it touches more files).\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/data/imx219.json | 2 +-\n> src/ipa/raspberrypi/data/imx477.json | 2 +-\n> src/ipa/raspberrypi/data/ov5647.json | 2 +-\n> utils/raspberrypi/ctt/ctt.py | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx219.json\n> b/src/ipa/raspberrypi/data/imx219.json\n> index ce7ff36f..b03a7beb 100644\n> --- a/src/ipa/raspberrypi/data/imx219.json\n> +++ b/src/ipa/raspberrypi/data/imx219.json\n> @@ -140,7 +140,7 @@\n> 1.0, 2.0, 4.0, 6.0, 6.0\n> ]\n> },\n> - \"sport\":\n> + \"short\":\n> {\n> \"shutter\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/imx477.json\n> b/src/ipa/raspberrypi/data/imx477.json\n> index 73ad1ae9..12fe2f41 100644\n> --- a/src/ipa/raspberrypi/data/imx477.json\n> +++ b/src/ipa/raspberrypi/data/imx477.json\n> @@ -140,7 +140,7 @@\n> 1.0, 2.0, 4.0, 6.0, 6.0\n> ]\n> },\n> - \"sport\":\n> + \"short\":\n> {\n> \"shutter\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/ov5647.json\n> b/src/ipa/raspberrypi/data/ov5647.json\n> index a2469059..3d8a7c8f 100644\n> --- a/src/ipa/raspberrypi/data/ov5647.json\n> +++ b/src/ipa/raspberrypi/data/ov5647.json\n> @@ -140,7 +140,7 @@\n> 1.0, 2.0, 4.0, 6.0, 6.0\n> ]\n> },\n> - \"sport\":\n> + \"short\":\n> {\n> \"shutter\":\n> [\n> diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\n> index 30d35ae4..15064634 100755\n> --- a/utils/raspberrypi/ctt/ctt.py\n> +++ b/utils/raspberrypi/ctt/ctt.py\n> @@ -130,7 +130,7 @@ class Camera:\n> \"shutter\": [100, 10000, 30000, 60000, 120000],\n> \"gain\": [1.0, 2.0, 4.0, 6.0, 6.0]\n> },\n> - \"sport\": {\n> + \"short\": {\n> \"shutter\": [100, 5000, 10000, 20000, 120000],\n> \"gain\": [1.0, 2.0, 4.0, 6.0, 6.0]\n> }\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 510ABBE081\n\tfor ;\n\tTue, 17 Nov 2020 11:14:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C5DF6332C;\n\tTue, 17 Nov 2020 12:14:29 +0100 (CET)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6D4663282\n\tfor ;\n\tTue, 17 Nov 2020 12:14:27 +0100 (CET)","by mail-lj1-x234.google.com with SMTP id b17so23764485ljf.12\n\tfor ;\n\tTue, 17 Nov 2020 03:14:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mEIZBE7S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=nP/gr91xIayv7oypk/nfw2roaDDzkti8H8e5m1R9XSk=;\n\tb=mEIZBE7SNQfXFOUtwr9AQrtfbxFuR7JN8w5ExS8wwGQQUtR8zCmcSSmmZOle+tGsgO\n\tQ5wGJ1ZxJvvuTiyCik7xj0o8hphUy76ksaQJUgZEECbQxG6Si0SnpORW3bnqg4AJpETz\n\t0T/vHZl3HrnOmZX4x+n3NsMMt11ccaLF4gPc2UyRTWx+VkdxpNGhUvZsZ392LGBKWoJq\n\tqnWX85E8w8eVVnGtNMJV0QSoWGmPRn0bfhBOemCOrbnJL88Gf4fGnQ72qXrG8JrWPKBt\n\t+KRvcgAS3iSSALHa6BA/Cf0ueIKzZYFkezMKybplanhQMDDLJwXKZBnVf8yJpz8tKQqb\n\t71PA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=nP/gr91xIayv7oypk/nfw2roaDDzkti8H8e5m1R9XSk=;\n\tb=c/w7wwiiLWYIuymVyi7cM0ILj8TWSQ1/lzcbKlvNial6D/0e6sfhPoNoYFFF7lsBUZ\n\tCmPgUSUoYAIuXETGZVUNZB7pF2IHR9YsiRe9cmNEywqltQcUpz2F3sYOtld+I6ylB0vw\n\tLsn3XYBQBPq6WCIOFUowVXWfWBiLzn89MbafXz4BprQdOu7YVDUsOTI71Aj+voq4/Bm2\n\tXWq6vVuDpDCfD/rrwUiFyINCIoLxhhX5DnL81GqR0AkIj6g/BK1zSvoYsoFIjifLKPM/\n\tGTIwT5CG4pVu6Gq8V8o/vhoAVhSFs8/9roUbn0CYQ1lBJcOMPeLfNykrx/XDERrXraX7\n\tR3pQ==","X-Gm-Message-State":"AOAM531pgoKQ1ymwFts1L1BDfpbfBiN9y0pU9IlvO4hnroKQm8F4tpL9\n\t0jftm6vZzY47o6rHUrtorzkBA+Iaeh3j7asHJuiy8jdsZ5nOfA==","X-Google-Smtp-Source":"ABdhPJybg1OiefsaehwflhV6p/NgdCO1JPTYRmXo7/X+Q3zxT7tIcCZa41AJbm90VN5qtFGyJ57UCM7opiAdivKWPd0=","X-Received":"by 2002:a2e:3310:: with SMTP id\n\td16mr1942263ljc.103.1605611667284; \n\tTue, 17 Nov 2020 03:14:27 -0800 (PST)","MIME-Version":"1.0","References":"<20201117093205.9521-1-david.plowman@raspberrypi.com>\n\t<20201117093205.9521-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20201117093205.9521-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 17 Nov 2020 11:14:10 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 2/2] src: ipa: raspberrypi: Change\n\t'sport' exposure mode name to 'short'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============7726861189240276139==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13778,"web_url":"https://patchwork.libcamera.org/comment/13778/","msgid":"<38902a2e-1f6b-b5c4-6c7b-e529708007cc@ideasonboard.com>","date":"2020-11-18T13:17:27","subject":"Re: [libcamera-devel] [PATCH 2/2] src: ipa: raspberrypi: Change\n\t'sport' exposure mode name to 'short'","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 17/11/2020 09:32, David Plowman wrote:\n> The names have to match for the setting to work. I've chosen to go\n> with the libcamera terminology (even though it touches more files).\n\nI hope short vs sport won't be too confusing. But looking at the\nexposure modes, \"Normal, Short, Long, Custom\" I think this is the right\nchoice.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/data/imx219.json | 2 +-\n> src/ipa/raspberrypi/data/imx477.json | 2 +-\n> src/ipa/raspberrypi/data/ov5647.json | 2 +-\n> utils/raspberrypi/ctt/ctt.py | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\n> index ce7ff36f..b03a7beb 100644\n> --- a/src/ipa/raspberrypi/data/imx219.json\n> +++ b/src/ipa/raspberrypi/data/imx219.json\n> @@ -140,7 +140,7 @@\n> 1.0, 2.0, 4.0, 6.0, 6.0\n> ]\n> },\n> - \"sport\":\n> + \"short\":\n> {\n> \"shutter\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\n> index 73ad1ae9..12fe2f41 100644\n> --- a/src/ipa/raspberrypi/data/imx477.json\n> +++ b/src/ipa/raspberrypi/data/imx477.json\n> @@ -140,7 +140,7 @@\n> 1.0, 2.0, 4.0, 6.0, 6.0\n> ]\n> },\n> - \"sport\":\n> + \"short\":\n> {\n> \"shutter\":\n> [\n> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\n> index a2469059..3d8a7c8f 100644\n> --- a/src/ipa/raspberrypi/data/ov5647.json\n> +++ b/src/ipa/raspberrypi/data/ov5647.json\n> @@ -140,7 +140,7 @@\n> 1.0, 2.0, 4.0, 6.0, 6.0\n> ]\n> },\n> - \"sport\":\n> + \"short\":\n> {\n> \"shutter\":\n> [\n> diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\n> index 30d35ae4..15064634 100755\n> --- a/utils/raspberrypi/ctt/ctt.py\n> +++ b/utils/raspberrypi/ctt/ctt.py\n> @@ -130,7 +130,7 @@ class Camera:\n> \"shutter\": [100, 10000, 30000, 60000, 120000],\n> \"gain\": [1.0, 2.0, 4.0, 6.0, 6.0]\n> },\n> - \"sport\": {\n> + \"short\": {\n> \"shutter\": [100, 5000, 10000, 20000, 120000],\n> \"gain\": [1.0, 2.0, 4.0, 6.0, 6.0]\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA284BE176\n\tfor ;\n\tWed, 18 Nov 2020 13:17:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7DB16156B;\n\tWed, 18 Nov 2020 14:17:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63D4E61565\n\tfor ;\n\tWed, 18 Nov 2020 14:17:30 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB6749BF;\n\tWed, 18 Nov 2020 14:17:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jKl8THVR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605705450;\n\tbh=mE+Y2GqE/6rNby+GHDSQSEC5kMXUyMTtuTD7vhZmrxE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=jKl8THVRqn23mWrjr4btZWIl8LvSqbOXp10MnHeQJB4SjD1K/Rp0u7U4kMfBWs/y2\n\t5CltiUTygBQxlgaEr9Xvaq51ePBJSyPt/E++HSWS1BuMUzS0S3Ri+KCe84dWwKgvIu\n\tSn0P6uIPERoEXzBlhH0B2a8b+p5f+b61HcMCXgK0=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201117093205.9521-1-david.plowman@raspberrypi.com>\n\t<20201117093205.9521-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<38902a2e-1f6b-b5c4-6c7b-e529708007cc@ideasonboard.com>","Date":"Wed, 18 Nov 2020 13:17:27 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201117093205.9521-3-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] src: ipa: raspberrypi: Change\n\t'sport' exposure mode name to 'short'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]