[{"id":13743,"web_url":"https://patchwork.libcamera.org/comment/13743/","msgid":"","date":"2020-11-17T11:13:43","subject":"Re: [libcamera-devel] [PATCH 1/2] src: ipa: raspberrypi: Add\n\tmissing 'cloudly' AWB mode","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\n\nOn Tue, 17 Nov 2020 at 09:32, David Plowman \nwrote:\n\n> This had just been forgotten.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 4632d764..9853a343 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -477,6 +477,7 @@ static const std::map\n> AwbModeTable = {\n> { controls::AwbFluorescent, \"fluorescent\" },\n> { controls::AwbIndoor, \"indoor\" },\n> { controls::AwbDaylight, \"daylight\" },\n> + { controls::AwbCloudy, \"cloudy\" },\n> { controls::AwbCustom, \"custom\" },\n> };\n>\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0EC5BE081\n\tfor ;\n\tTue, 17 Nov 2020 11:14:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3C03632B4;\n\tTue, 17 Nov 2020 12:14:01 +0100 (CET)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCBBA63282\n\tfor ;\n\tTue, 17 Nov 2020 12:13:59 +0100 (CET)","by mail-lf1-x130.google.com with SMTP id u18so29509374lfd.9\n\tfor ;\n\tTue, 17 Nov 2020 03:13:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"U+VzeP43\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=TATjw4w27KU89VAKlSLOWbOaFoS7nducLNiaxR4wMdM=;\n\tb=U+VzeP43/cKbe6CYmNaFpaWnGOMHSgHV3yHFXs+d4UYQKBEHfkcijdrP2jY5OrjoPF\n\t7sd6sXFPV0JXGa+kK3ftln2IowOinbC/cQL0pRdzSqw9QhfMzrflc0xEmsvLlo7xrXBm\n\tHIpbTCEDN6ZYpSvZ4kFVqTpeS0xrtugjO+6VITlEmMF3/RHJtAREA1P7rHgdk6IFWG/q\n\teZHjpO69ObDD1jriswpTUOq2Az3a+4Xp5aQFksi9XSxjX6x/VPC+s9s0fF2nT9t/yT3J\n\tAs341W5Rs/Q6TUnsvu04+577ylz/IoRDTsJx1pVRYGMx9uxA4yHAzCcsJED9abH9/JAb\n\tdjIg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=TATjw4w27KU89VAKlSLOWbOaFoS7nducLNiaxR4wMdM=;\n\tb=LnkS9fageVLa/3aRqGkAW53CqYkkjBHc+x2FsmCqbte9Og/iCAx2nhrDDqjlUDG6SD\n\tvHBzdt7m9U8fG6sdo+IgOi6CLACBq0cIvIRu3ImPI/ztd5E5/mtyWAu8a5z5APt137Np\n\tomZSdpQbKfGYhQx43Bx19rwPAc5hAXc3fqUnK+dg5qjanz/T/biq3iypQ14hjZp5x6Wr\n\ty2oo+HM+e2/gWnQg01Yt0vvdHdkqEc1Y5C+IcaE3j2wCp7qjcUuqpYjcexe05cFUKldZ\n\ts5l52kyuapDLdG378Ad4CnOkgobfCVqZHWtym9EpOsZBpNOR1+T39krQUREUX19BVEMr\n\tqlPw==","X-Gm-Message-State":"AOAM531zv2TDEpRKmkNNHhvDaya6H0WugVzdLMeB2GrDyjdr11xHb9F5\n\tXGeLG3kmyqD3yRHCK1eP4C23R1wSwh5G+yiSVFFTnA==","X-Google-Smtp-Source":"ABdhPJx94t0ukqKLOIJhCpb+ctkUUEBRJg6Ex1slV7J3UFyacikW+SZchJn12+74BmQlp7QIKfYKafLqByDtsGHkEHk=","X-Received":"by 2002:a19:a415:: with SMTP id\n\tq21mr1460815lfc.508.1605611639268; \n\tTue, 17 Nov 2020 03:13:59 -0800 (PST)","MIME-Version":"1.0","References":"<20201117093205.9521-1-david.plowman@raspberrypi.com>\n\t<20201117093205.9521-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20201117093205.9521-2-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 17 Nov 2020 11:13:43 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 1/2] src: ipa: raspberrypi: Add\n\tmissing 'cloudly' AWB mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============1020597384175551243==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13775,"web_url":"https://patchwork.libcamera.org/comment/13775/","msgid":"<7d4ed5aa-7293-102d-c485-60de133a24c2@ideasonboard.com>","date":"2020-11-18T13:12:53","subject":"Re: [libcamera-devel] [PATCH 1/2] src: ipa: raspberrypi: Add\n\tmissing 'cloudly' AWB mode","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 17/11/2020 09:32, David Plowman wrote:\n> This had just been forgotten.\n\nPerhaps:\n\n\"Support the 'cloudy' AWB mode which was left out when the AwbModeTable\nwas introduced.\"\n\nBut it doesn't warrant a resend, and doesn't really matter.\n\n\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 4632d764..9853a343 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -477,6 +477,7 @@ static const std::map AwbModeTable = {\n> \t{ controls::AwbFluorescent, \"fluorescent\" },\n> \t{ controls::AwbIndoor, \"indoor\" },\n> \t{ controls::AwbDaylight, \"daylight\" },\n> +\t{ controls::AwbCloudy, \"cloudy\" },\n> \t{ controls::AwbCustom, \"custom\" },\n\nIs there any particular sort ordering on this table?\n\n> };\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 807FDBE08A\n\tfor ;\n\tWed, 18 Nov 2020 13:12:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 312526156B;\n\tWed, 18 Nov 2020 14:12:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35A0661565\n\tfor ;\n\tWed, 18 Nov 2020 14:12:56 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B90FF9BF;\n\tWed, 18 Nov 2020 14:12:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"udCQkP9q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605705175;\n\tbh=zGggM7sggKSj9AZgV7or2N77guBKxI1WAFCv4Q2P4tI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=udCQkP9qfTZGfiU8yL42Do2T+gtRUw9sW18P2+wPADpsSM3LHc6YWe1eb04zP7Mk+\n\t0EVmaZaZ5w/ZVLyrYbYBOcJ1N9NopXF1913wknSHFJAWgr1s7OxYcFSCzWeSvI6bCm\n\tOhh2e5KVOiuHJsaPvBK+BAKnnE4riN5KPJZ02VWI=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201117093205.9521-1-david.plowman@raspberrypi.com>\n\t<20201117093205.9521-2-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7d4ed5aa-7293-102d-c485-60de133a24c2@ideasonboard.com>","Date":"Wed, 18 Nov 2020 13:12:53 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201117093205.9521-2-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] src: ipa: raspberrypi: Add\n\tmissing 'cloudly' AWB mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]