{"id":10437,"url":"https://patchwork.libcamera.org/api/patches/10437/?format=json","web_url":"https://patchwork.libcamera.org/patch/10437/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201116164918.2055-9-david.plowman@raspberrypi.com>","date":"2020-11-16T16:49:16","name":"[libcamera-devel,08/10] libcamera: src: ipa: raspberrypi: agc: Fix uninitialised members in status_","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3dc4d36c1a88097646c21c463d32e2f98add87dd","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10437/mbox/","series":[{"id":1464,"url":"https://patchwork.libcamera.org/api/series/1464/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1464","date":"2020-11-16T16:49:08","name":"Raspberry Pi AGC","version":1,"mbox":"https://patchwork.libcamera.org/series/1464/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10437/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10437/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3810DBE082\n\tfor ;\n\tMon, 16 Nov 2020 16:49:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0080E632DB;\n\tMon, 16 Nov 2020 17:49:38 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8025C632D4\n\tfor ;\n\tMon, 16 Nov 2020 17:49:32 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id a3so24196581wmb.5\n\tfor ;\n\tMon, 16 Nov 2020 08:49:32 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tq16sm23716973wrn.13.2020.11.16.08.49.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Nov 2020 08:49:31 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"eBYKjrbk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zzxO+7DUtU4wEkTcoTYpn2fnio2NuM0p+0OqFUa+9G0=;\n\tb=eBYKjrbkEFAWUpGYGtQ0Y92mVUtanvq4Hbog9icNuX1RK5S6LzphO12ThC8xqADi3n\n\tt3fZfque1QX4aXor6cc8n3pnUT0V51MUywiN7x9d0+iystD2jrHyj1uf0DEv/YFSATiR\n\tcaypXhgvBUMM1Rpb8/LfSMDdUV91uEM/MSdpmsbnJeREk5OgEvlgFDc3X4lsxinoab1O\n\tK84A50AO3DBDUCnsnjJILLD/XeSIzbGHu9vDiQnufhXoPP+FQK9zOQMw6v5RLlvbhZ8R\n\tKJGTOFkim9XPTo5aFn3ppnlF6Wugsp6eMEorloFHzf2XN3GASNxrI5n+QY8e2eiEAZfO\n\tVoDg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zzxO+7DUtU4wEkTcoTYpn2fnio2NuM0p+0OqFUa+9G0=;\n\tb=HlbjWK0EKe5GVMrqo9XgB/0r337L830Q/BLADtEBYJBMIJESmXytML12J721XLDYYf\n\tWkysgc26Wg4ABzOX4dIAKxeWTH1fs7xkqtNKVtpGI5DWZgsy0Q+mDJrMKZSEi/FLWDze\n\twtNUg8ZD9X+FJOGtgRZrn11qiYfxXd8LUDE8TR2L/mPcS3EuzxlT5/2N9f7RGcJIioka\n\tTPflYNRvr5DwAywgf6jXMiuKps0Foi1ecH486ffHtf5qa8xX2Xy9+dOcOXqyTPj3+7hv\n\t1xUSnPw2Btq7asv4eZoh6b7zR2ewFkh4GIC6g5weIEBlHKWMIJ+WJ9vZFK5uVI1MQq9z\n\tVLSg==","X-Gm-Message-State":"AOAM5315oKNQlsUeSGsOMgdwCgq3aBpEn83Ary9kqZov8uh45HGVXs5e\n\tN/F0Fi2AAbT8lherTYbdskOOVPUqNznxgQ==","X-Google-Smtp-Source":"ABdhPJz/aeIHZrcy4YCzqoZQMkX+gKRmpc77fkV4geVK0kHPYer4uqy0pG9pRZFSk/pMPrQVdz4A/A==","X-Received":"by 2002:a1c:df89:: with SMTP id\n\tw131mr15777113wmg.164.1605545371965; \n\tMon, 16 Nov 2020 08:49:31 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 16 Nov 2020 16:49:16 +0000","Message-Id":"<20201116164918.2055-9-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201116164918.2055-1-david.plowman@raspberrypi.com>","References":"<20201116164918.2055-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 08/10] libcamera: src: ipa: raspberrypi:\n\tagc: Fix uninitialised members in status_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use memset in the constructor, it is tidier and initialises\neverything.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 7c7944e8..1037f968 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -157,14 +157,13 @@ Agc::Agc(Controller *controller)\n \t exposure_mode_(nullptr), constraint_mode_(nullptr),\n \t frame_count_(0), lock_count_(0)\n {\n+\t// Setting status_.total_exposure_value_ to zero initially tells us\n+\t// it's not been calculated yet (i.e. Process hasn't yet run).\n+\tmemset(&status_, 0, sizeof(status_));\n \tev_ = status_.ev = 1.0;\n-\tflicker_period_ = status_.flicker_period = 0.0;\n-\tfixed_shutter_ = status_.fixed_shutter = 0;\n-\tfixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;\n-\t// set to zero initially, so we can tell it's not been calculated\n-\tstatus_.total_exposure_value = 0.0;\n-\tstatus_.target_exposure_value = 0.0;\n-\tstatus_.locked = false;\n+\tflicker_period_ = 0.0;\n+\tfixed_shutter_ = 0;\n+\tfixed_analogue_gain_ = 0.0;\n }\n \n char const *Agc::Name() const\n","prefixes":["libcamera-devel","08/10"]}