[{"id":13737,"web_url":"https://patchwork.libcamera.org/comment/13737/","msgid":"","date":"2020-11-17T10:47:47","subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: ipa: raspberrypi:\n\tawb: Add SwitchMode method to output AWB status","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\n\nOn Mon, 16 Nov 2020 at 16:49, David Plowman \nwrote:\n\n> The Awb class now implements a SwitchMode method which outputs its\n> AwbStatus for other algorithms to read, should they be interested.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 14 ++++++++++++++\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 1 +\n> 2 files changed, 15 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index 469d0e53..020825e3 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -179,6 +179,20 @@ void Awb::SetManualGains(double manual_r, double\n> manual_b)\n> manual_b_ = manual_b;\n> }\n>\n> +void Awb::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n> + Metadata *metadata)\n> +{\n> + // If fixed colour gains have been set, we should let other\n> algorithms\n> + // know by writing it into the image metadata.\n> + if (manual_r_ != 0.0 && manual_b_ != 0.0) {\n> + prev_sync_results_.gain_r = manual_r_;\n> + prev_sync_results_.gain_g = 1.0;\n> + prev_sync_results_.gain_b = manual_b_;\n> + sync_results_ = prev_sync_results_;\n> + }\n> + metadata->Set(\"awb.status\", prev_sync_results_);\n> +}\n> +\n> void Awb::fetchAsyncResults()\n> {\n> RPI_LOG(\"Fetch AWB results\");\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> index 9124d042..545d85a8 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> @@ -84,6 +84,7 @@ public:\n> void Read(boost::property_tree::ptree const ¶ms) override;\n> void SetMode(std::string const &name) override;\n> void SetManualGains(double manual_r, double manual_b) override;\n> + void SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> override;\n> void Prepare(Metadata *image_metadata) override;\n> void Process(StatisticsPtr &stats, Metadata *image_metadata)\n> override;\n> struct RGB {\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21686BE082\n\tfor ;\n\tTue, 17 Nov 2020 10:48:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB00763321;\n\tTue, 17 Nov 2020 11:48:06 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B22D63320\n\tfor ;\n\tTue, 17 Nov 2020 11:48:04 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id a9so28439450lfh.2\n\tfor ;\n\tTue, 17 Nov 2020 02:48:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"sXdx2LV0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=UZv1egi6hmF6bXF8DT/LQvbcY5OEeUOv/XF8vCbPS5c=;\n\tb=sXdx2LV0jMDpF3gR56VlnRSeaWeMLGzpuzi0Q605366Hjit6eQykEbkHtrjQHkT9Y/\n\tbqZe7yid/qRjf//NxMqvSRlGe1IyGu0bb4HWLkONQcTvp8cNhzS0TEI6023/VCXV6AlX\n\tmVDjeMB6hKzDB28iIYRBWRi8H+ivbLZr3Ln7nDcgZg4IEMvfKWLt4z0CBgMfTRmU2pae\n\tgcfHw7XxYo8QDK2eopkH9EBa5vNSHozwirTuG9g4F/CKFLY6BanvtAOOqceyIrXJKaNo\n\tkRU2gDovAg5esFIZvTBN6gvYrCU2SQGd+SHRAkeoVI9D+GGy7vTfyZrAlJ2HlNxBp4e+\n\tONlQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=UZv1egi6hmF6bXF8DT/LQvbcY5OEeUOv/XF8vCbPS5c=;\n\tb=oiSBfe11yLkJKbrizR8TUq0ALOKnVAVWcdBz9EeeM77lHrZeqA82JcMrTDHG79/hOw\n\tF+gvQY0CriKGhFbGzj+QbHUHOd5y4Q0jxobvmnZ4qNqpFj3qa23omw3VbNsBWi65Ermh\n\tY4n/H/UbltkQ6YBCYfgQAQY690e8CHWjtZXF6AVq5pEiZ/j18nXbKkKHwby7Wi2MxHyk\n\tfZp11T17hatviVOFeSup5frbEZYvjQrrd5u5F8XRyWizFauGROVaJBy25aGvFbJOC4nA\n\tRMVTcm+mLIneXKzoZ5vpZU3ChHgtw5YOKFMj8dWnybq0d1YVggcTQAK/YY9i2NFwaav5\n\tCnzA==","X-Gm-Message-State":"AOAM533c8+w7S1QnSRbFDgZ97B/J0dQ2wy8YY61O2hzUe5y33lKcmAJa\n\tvb1OWByoVOW4N1/C73Q3VssLT2zq9PRdahzQaI5z53xFy9nGEg==","X-Google-Smtp-Source":"ABdhPJxmJnqo5ExkKryM5e7EU7C5M+dKGwewOBPb/ZdNKIVoRvs15+727sRvmnfDy6YfLXoTkDY6TrDc2/N0EWDIgoc=","X-Received":"by 2002:a19:428c:: with SMTP id\n\tp134mr1609098lfa.413.1605610083996; \n\tTue, 17 Nov 2020 02:48:03 -0800 (PST)","MIME-Version":"1.0","References":"<20201116164918.2055-1-david.plowman@raspberrypi.com>\n\t<20201116164918.2055-7-david.plowman@raspberrypi.com>","In-Reply-To":"<20201116164918.2055-7-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 17 Nov 2020 10:47:47 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: ipa: raspberrypi:\n\tawb: Add SwitchMode method to output AWB status","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============8603454846577708885==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]