{"id":10435,"url":"https://patchwork.libcamera.org/api/patches/10435/?format=json","web_url":"https://patchwork.libcamera.org/patch/10435/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201116164918.2055-7-david.plowman@raspberrypi.com>","date":"2020-11-16T16:49:14","name":"[libcamera-devel,06/10] libcamera: ipa: raspberrypi: awb: Add SwitchMode method to output AWB status","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"afd0c28a7eb523096ec4da6e443d9721e77733fd","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10435/mbox/","series":[{"id":1464,"url":"https://patchwork.libcamera.org/api/series/1464/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1464","date":"2020-11-16T16:49:08","name":"Raspberry Pi AGC","version":1,"mbox":"https://patchwork.libcamera.org/series/1464/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10435/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10435/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47383BE082\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Nov 2020 16:49:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1769B632C8;\n\tMon, 16 Nov 2020 17:49:33 +0100 (CET)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99F78632D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Nov 2020 17:49:30 +0100 (CET)","by mail-wm1-x32b.google.com with SMTP id w24so24214662wmi.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Nov 2020 08:49:30 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tq16sm23716973wrn.13.2020.11.16.08.49.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Nov 2020 08:49:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dnHuGQ6+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=aisa3uaRSaovPCtBa0hhRtIHRsyDdDRuZE0+SvpTmd4=;\n\tb=dnHuGQ6+EqVuy7vXu6PNA2i9Xmrufe7M7u4fnihV7ay6g2q+hmohWnUgZtxMn7mPhB\n\tzDro9fDSCUiOdc6cazpWSgY7GtHFypx13lEVsNNozoLXR2tc8Rmq82hsVCcXgFyACLvl\n\tx+1tbrmlgSq8BbvRnF/T9s/1sq5sRK2Xa5zM66qvTiYYJH2EYA7rX4x8NMyVMA9tm+C3\n\tj8tLuGzvGHTKmEDzuH+HpEcs1ed1BWasSeheUEjGEm36LGrIkqS5PkVn8bNPsbjaYpp0\n\tu4JKSygVOXu6KuHRNJ49dasPF2zO3vEffSJ1YU1J+GV8avMcuvMs4YHi9sxft+f2JAPf\n\tZJRA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=aisa3uaRSaovPCtBa0hhRtIHRsyDdDRuZE0+SvpTmd4=;\n\tb=CoYk5PBGwJ+htFqSe7OGAZTBY5GF2KBThoZDOMyhlOEv1X/34/URcfHzbdWPqOgLSH\n\tbwxH/t8MyQV32Y2Etq4x51UVHMMKufLlTa7JMh2rQUhVlfmsNUCBvU1jdUNGnQJIBE5l\n\tZH6mDI2QvxjQdmg1Eun5iiGXE9+HJtqnQrRqK7WS73u4XUpVkEUksMRbE+EE2s4dgEEK\n\txOO7zuShplbczKMKkis3Yf8tIPn3rzZ34XbbC0cHWs2k1il6x9nG9FmK2b/Q11RRKCnj\n\tkv3jJPAr6KVlbbr8hAHBZB9guA/AnlJ/YPbKj66ZbNVryD+TbVrXKlTdWFr7raehbbaE\n\tuKnQ==","X-Gm-Message-State":"AOAM530rUGKBD5WWmHbLwyRiCuj+OopsiIiyPIRpugDu7tjGFMx/DPKF\n\tzAXMvHCm93yn79vzWcrsmzlkUqDCQJxkYA==","X-Google-Smtp-Source":"ABdhPJz0lTJz43rMZ2AKhCd1mGPILHMOoCgD9F4UIOAMhrTQwogF0CblH2YVmDV19dnwtEOxV4E23w==","X-Received":"by 2002:a1c:103:: with SMTP id 3mr16101819wmb.81.1605545370018; \n\tMon, 16 Nov 2020 08:49:30 -0800 (PST)","From":"David Plowman <david.plowman@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 16 Nov 2020 16:49:14 +0000","Message-Id":"<20201116164918.2055-7-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201116164918.2055-1-david.plowman@raspberrypi.com>","References":"<20201116164918.2055-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 06/10] libcamera: ipa: raspberrypi: awb:\n\tAdd SwitchMode method to output AWB status","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The Awb class now implements a SwitchMode method which outputs its\nAwbStatus for other algorithms to read, should they be interested.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 14 ++++++++++++++\n src/ipa/raspberrypi/controller/rpi/awb.hpp |  1 +\n 2 files changed, 15 insertions(+)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex 469d0e53..020825e3 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -179,6 +179,20 @@ void Awb::SetManualGains(double manual_r, double manual_b)\n \tmanual_b_ = manual_b;\n }\n \n+void Awb::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n+\t\t     Metadata *metadata)\n+{\n+\t// If fixed colour gains have been set, we should let other algorithms\n+\t// know by writing it into the image metadata.\n+\tif (manual_r_ != 0.0 && manual_b_ != 0.0) {\n+\t\tprev_sync_results_.gain_r = manual_r_;\n+\t\tprev_sync_results_.gain_g = 1.0;\n+\t\tprev_sync_results_.gain_b = manual_b_;\n+\t\tsync_results_ = prev_sync_results_;\n+\t}\n+\tmetadata->Set(\"awb.status\", prev_sync_results_);\n+}\n+\n void Awb::fetchAsyncResults()\n {\n \tRPI_LOG(\"Fetch AWB results\");\ndiff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp b/src/ipa/raspberrypi/controller/rpi/awb.hpp\nindex 9124d042..545d85a8 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n@@ -84,6 +84,7 @@ public:\n \tvoid Read(boost::property_tree::ptree const &params) override;\n \tvoid SetMode(std::string const &name) override;\n \tvoid SetManualGains(double manual_r, double manual_b) override;\n+\tvoid SwitchMode(CameraMode const &camera_mode, Metadata *metadata) override;\n \tvoid Prepare(Metadata *image_metadata) override;\n \tvoid Process(StatisticsPtr &stats, Metadata *image_metadata) override;\n \tstruct RGB {\n","prefixes":["libcamera-devel","06/10"]}