[{"id":13734,"web_url":"https://patchwork.libcamera.org/comment/13734/","msgid":"","date":"2020-11-17T10:36:22","subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: ipa: raspberrypi:\n\tagc: Rename method to divideUpExposure","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\n\nOn Mon, 16 Nov 2020 at 16:49, David Plowman \nwrote:\n\n> The method formerly known as divvyupExposure is given a more\n> understandable name.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 ++++----\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +-\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index c4379b99..d29b1156 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -225,7 +225,7 @@ void Agc::SwitchMode([[maybe_unused]] CameraMode const\n> &camera_mode,\n> // write the results into the metadata we've been given.\n> if (status_.total_exposure_value) {\n> housekeepConfig();\n> - divvyupExposure();\n> + divideUpExposure();\n> writeAndFinish(metadata, false);\n> }\n> }\n> @@ -304,9 +304,9 @@ void Agc::Process(StatisticsPtr &stats, Metadata\n> *image_metadata)\n> bool desaturate = applyDigitalGain(image_metadata, gain, target_Y);\n> // The results have to be filtered so as not to change too rapidly.\n> filterExposure(desaturate);\n> - // The last thing is to divvy up the exposure value into a shutter\n> time\n> + // The last thing is to divide up the exposure value into a\n> shutter time\n> // and analogue_gain, according to the current exposure mode.\n> - divvyupExposure();\n> + divideUpExposure();\n> // Finally advertise what we've done.\n> writeAndFinish(image_metadata, desaturate);\n> }\n> @@ -545,7 +545,7 @@ void Agc::filterExposure(bool desaturate)\n> << \" no dg \" << filtered_.total_exposure_no_dg;\n> }\n>\n> -void Agc::divvyupExposure()\n> +void Agc::divideUpExposure()\n> {\n> // Sending the fixed shutter/gain cases through the same code may\n> seem\n> // unnecessary, but it will make more sense when extend this to\n> cover\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> index 5a02df4e..2442fc03 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> @@ -89,7 +89,7 @@ private:\n> bool applyDigitalGain(Metadata *image_metadata, double gain,\n> double target_Y);\n> void filterExposure(bool desaturate);\n> - void divvyupExposure();\n> + void divideUpExposure();\n> void writeAndFinish(Metadata *image_metadata, bool desaturate);\n> AgcMeteringMode *metering_mode_;\n> AgcExposureMode *exposure_mode_;\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03265BE082\n\tfor ;\n\tTue, 17 Nov 2020 10:36:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F6556331F;\n\tTue, 17 Nov 2020 11:36:41 +0100 (CET)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB8FA63282\n\tfor ;\n\tTue, 17 Nov 2020 11:36:39 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id y16so23708106ljh.0\n\tfor ;\n\tTue, 17 Nov 2020 02:36:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"TB2Ytn+G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=PyfK3xSU5I0hLOHJxqUrHiB3XtHwyoi9duoo8GRYjvw=;\n\tb=TB2Ytn+GknqdTePbLork9287BjSLgzOUWtoNMsRc5ZEMWIqXjmO5dc/4E/aD61lZvr\n\tS0a5+VTjxeQchOnkESmDG123xm4XyenlqmFKQSMRE9vhKxh47UpV+m4VgJD5bjmjUA1G\n\t3Dn0nTJDRdheTe8A5ayqWrdjMoXehXiZvWpUP67vXrRe+Kbfr+WwGcVy7ziChSvS1H9p\n\trXVpR7LVq69AFh4ohobxsNtPPLfDoMTIrMBd/kk15cV1FAHsWYx7+tKA9ezn/++T5qAU\n\tURO5/jYErIytdNA612DEJBPTgrZCLXHFiVWaS5jbkaU5O7KQPpbApb1gKTsck3advIw5\n\tplkw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=PyfK3xSU5I0hLOHJxqUrHiB3XtHwyoi9duoo8GRYjvw=;\n\tb=TsRYKx1hPe+AvlT98cANxtFyC4+JZYqXyRqSl/2qAEZMeKP2hKcq2Ouy5iKsv4wvIL\n\tRutDDlX/55/kycHmoxp4Y7MOhsRxxW+EOsU8K1/W+wLqbsbPDNnDpCcr6FqxIT4UHK+1\n\tTDIg/2s667bxJ7eKvolCykgzpAYxuLPXKGfl8yldmMswgFbFCfw+hUawaRDTv4mDdKW1\n\ti1rTffqihpVe1wYwfZCtKsTgwRorVGtBPUrqZQuzJzpHa5QkKDkexmD1RJWm4QJIS1pm\n\t1VRN9dVDDeZes5YBQG3NXK+Wmvnr62K5i0xT3v00GCIy1WTc/I9p/9ekDctrvJMLFVbX\n\tnjYA==","X-Gm-Message-State":"AOAM532eBVz2t8O6dikenQnrYZxReE3j9+KERssOUOeWymClSMO9W+lS\n\t53OProJbY7qTcug3FgFY6cPQPpPvbohBvauMuPD1Rg==","X-Google-Smtp-Source":"ABdhPJw7dXxkTEbye1QBiabkksbUpuOGXs1GyOsr2tzH4ftxBYFH/4kiJX/Fw8z613PGPxNoO224Ofu69C6TBdyOFus=","X-Received":"by 2002:a2e:84c7:: with SMTP id q7mr1577746ljh.415.1605609398956;\n\tTue, 17 Nov 2020 02:36:38 -0800 (PST)","MIME-Version":"1.0","References":"<20201116164918.2055-1-david.plowman@raspberrypi.com>\n\t<20201116164918.2055-4-david.plowman@raspberrypi.com>","In-Reply-To":"<20201116164918.2055-4-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 17 Nov 2020 10:36:22 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: ipa: raspberrypi:\n\tagc: Rename method to divideUpExposure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============8008725312755476202==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]