[{"id":13700,"web_url":"https://patchwork.libcamera.org/comment/13700/","msgid":"<8a5501b1-e9c0-ff89-658a-d60d640a60f5@ideasonboard.com>","date":"2020-11-13T10:06:57","subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 13/11/2020 06:38, Laurent Pinchart wrote:\n> The request completion handler is invoked in the camera manager thread,\n> which shouldn't be blocked for large amounts of time. As writing the\n> frames to disk can be a time-consuming process, move request processing\n> to the main thread by queueing an event to the event loop.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/cam/capture.cpp | 9 +++++++++\n> src/cam/capture.h | 1 +\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> index 7580f798288c..43b109d099f6 100644\n> --- a/src/cam/capture.cpp\n> +++ b/src/cam/capture.cpp\n> @@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n> \tif (request->status() == Request::RequestCancelled)\n> \t\treturn;\n> \n> +\t/*\n> +\t * Defer processing of the completed request to the event loop, to avoid\n> +\t * blocking the camera manager thread.\n> +\t */\n> +\tloop_->callLater(std::bind(&Capture::processRequest, this, request));\n> +}\n> +\n> +void Capture::processRequest(Request *request)\n> +{\n> \tconst Request::BufferMap &buffers = request->buffers();\n> \n> \t/*\n> diff --git a/src/cam/capture.h b/src/cam/capture.h\n> index 45e5e8a9ba27..d21c95a26ce7 100644\n> --- a/src/cam/capture.h\n> +++ b/src/cam/capture.h\n> @@ -33,6 +33,7 @@ private:\n> \tint capture(libcamera::FrameBufferAllocator *allocator);\n> \n> \tvoid requestComplete(libcamera::Request *request);\n> +\tvoid processRequest(libcamera::Request *request);\n> \n> \tstd::shared_ptr camera_;\n> \tlibcamera::CameraConfiguration *config_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BC92BE086\n\tfor ;\n\tFri, 13 Nov 2020 10:07:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 26490631BD;\n\tFri, 13 Nov 2020 11:07:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 103A0631B8\n\tfor ;\n\tFri, 13 Nov 2020 11:07:00 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A69EB31A;\n\tFri, 13 Nov 2020 11:06:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V4JvC5Px\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605262019;\n\tbh=3DwdrqKN29Uis2fXqVcJu1Z7AFnl9fvkGilri0128xA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=V4JvC5PxkpnAvFK7fzeFomlgxHpay/JI+F/vybICOg13wxtaGctBVKyFjar5WpLIQ\n\tJWe8dflFuMI4MuPw21x/vus4s1GNItO3B2Lf9PMi1e6gmQdirt2Gh2Qz5y5z5hTHv+\n\tTH1qDvoRvBYfywPXP0ZYxjdayEkO5MOzkopg/o1U=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8a5501b1-e9c0-ff89-658a-d60d640a60f5@ideasonboard.com>","Date":"Fri, 13 Nov 2020 10:06:57 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13708,"web_url":"https://patchwork.libcamera.org/comment/13708/","msgid":"<20201113103655.GI1603296@oden.dyn.berto.se>","date":"2020-11-13T10:36:55","subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-11-13 08:38:15 +0200, Laurent Pinchart wrote:\n> The request completion handler is invoked in the camera manager thread,\n> which shouldn't be blocked for large amounts of time. As writing the\n> frames to disk can be a time-consuming process, move request processing\n> to the main thread by queueing an event to the event loop.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/capture.cpp | 9 +++++++++\n> src/cam/capture.h | 1 +\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> index 7580f798288c..43b109d099f6 100644\n> --- a/src/cam/capture.cpp\n> +++ b/src/cam/capture.cpp\n> @@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n> \tif (request->status() == Request::RequestCancelled)\n> \t\treturn;\n> \n> +\t/*\n> +\t * Defer processing of the completed request to the event loop, to avoid\n> +\t * blocking the camera manager thread.\n> +\t */\n> +\tloop_->callLater(std::bind(&Capture::processRequest, this, request));\n> +}\n> +\n> +void Capture::processRequest(Request *request)\n> +{\n> \tconst Request::BufferMap &buffers = request->buffers();\n> \n> \t/*\n> diff --git a/src/cam/capture.h b/src/cam/capture.h\n> index 45e5e8a9ba27..d21c95a26ce7 100644\n> --- a/src/cam/capture.h\n> +++ b/src/cam/capture.h\n> @@ -33,6 +33,7 @@ private:\n> \tint capture(libcamera::FrameBufferAllocator *allocator);\n> \n> \tvoid requestComplete(libcamera::Request *request);\n> +\tvoid processRequest(libcamera::Request *request);\n> \n> \tstd::shared_ptr camera_;\n> \tlibcamera::CameraConfiguration *config_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 533A9BE082\n\tfor ;\n\tFri, 13 Nov 2020 10:36:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E114631BD;\n\tFri, 13 Nov 2020 11:36:58 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B45A631B8\n\tfor ;\n\tFri, 13 Nov 2020 11:36:57 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id d17so13058303lfq.10\n\tfor ;\n\tFri, 13 Nov 2020 02:36:57 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tq5sm1166482ljc.46.2020.11.13.02.36.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Nov 2020 02:36:56 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"DBu+TQsn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=wgJZj5hbxor6sqgzl2q9xzsKD87o1izPLT8gVZfKNBk=;\n\tb=DBu+TQsnSmUCOCjsM1a46ITaZbdbr5FsauqP9CmIstbagcygmaSztp7eVxUuMRFtaw\n\tb5fmbfTcLIn+984Qr2nvSgvDz50pzC4+VywKtFDoC1rX5ID7I+tBS0kJZRMqzrXdwdrI\n\tu9w9evQZ9QM7eMoRAER0+JYNloGU4veEyTorKYS9ZA1fF9FSjsINegIJB/mgOst+nVbm\n\tdth5YW7k07iC+F4FU2FapB1Y2pnF1KHia+i0Wmkn8lEBQn/NUwYSfft3SzdBK/nyGhve\n\tYTZ3bf9n4brz+lvNPB0AbJ3kjXb9XcNGArQks8IwUMGuNePpKRAwMPKGlrYqidBW3M7O\n\tSM+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=wgJZj5hbxor6sqgzl2q9xzsKD87o1izPLT8gVZfKNBk=;\n\tb=C6XLT/InIuBwvdhY0IqthA4tyzTIW+FimZoSqK5ymY/91ZlbIJ3uoxTHHFhzyZmbGI\n\tYOqGKSdBcvbvdHuMK+tQVssrkDPsldEz7o85tUXFr3AH1MhW3+CYmMeBSGG7yI2ZiQXs\n\tJNC+VrI60J/x1bYsh11O3tANvEHCGf24apT1k02EzM27/gJbyjCFw5I2RzeohoLxfQpz\n\tRQ/YVdNyzjr/fkR5Ki5EOJNpsBLBawIzC3rCp5m7XWl5KdihoSBq+WjCcoGjqvtq4TO1\n\tvWZ3+NdEFyUfeaBhLOZ2oDTAgVsznrZvTNuksOx3oUMrH1h7PyJFLC+zyQPkM2CtZNy5\n\taGIw==","X-Gm-Message-State":"AOAM533ql66/F9x5rpv5yPFC6L4/vAc9BN07uhrz608SV/C4XdatvOQ8\n\t9JaoDQiYLSaNFCR3lZG9Q+E+iQ==","X-Google-Smtp-Source":"ABdhPJwf+YshyzLaSsXwmnjksJo7aI/Qbe2aZNI8S3iu1fIbYfxZALMqOcW2K2tSMngCeCEZkbaNLA==","X-Received":"by 2002:a19:cc91:: with SMTP id c139mr614421lfg.31.1605263816623;\n\tFri, 13 Nov 2020 02:36:56 -0800 (PST)","Date":"Fri, 13 Nov 2020 11:36:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201113103655.GI1603296@oden.dyn.berto.se>","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13710,"web_url":"https://patchwork.libcamera.org/comment/13710/","msgid":"","date":"2020-11-13T12:35:40","subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","submitter":{"id":51,"url":"https://patchwork.libcamera.org/api/people/51/","name":"Marvin Schmidt","email":"marvin.schmidt1987@gmail.com"},"content":"Hey Laurent,\n\nThanks for your work\n\nAm Fr., 13. Nov. 2020 um 07:38 Uhr schrieb Laurent Pinchart\n:\n>\n> The request completion handler is invoked in the camera manager thread,\n> which shouldn't be blocked for large amounts of time. As writing the\n> frames to disk can be a time-consuming process, move request processing\n> to the main thread by queueing an event to the event loop.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/capture.cpp | 9 +++++++++\n> src/cam/capture.h | 1 +\n> 2 files changed, 10 insertions(+)\n>\n> diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> index 7580f798288c..43b109d099f6 100644\n> --- a/src/cam/capture.cpp\n> +++ b/src/cam/capture.cpp\n> @@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n> if (request->status() == Request::RequestCancelled)\n> return;\n>\n> + /*\n> + * Defer processing of the completed request to the event loop, to avoid\n> + * blocking the camera manager thread.\n> + */\n> + loop_->callLater(std::bind(&Capture::processRequest, this, request));\n\nYou could use a lambda here instead of std::bind:\n\n [=] { processRequest(request); }\n\nstd::bind would otherwise require including ``\n\n> +}\n> +\n> +void Capture::processRequest(Request *request)\n> +{\n> const Request::BufferMap &buffers = request->buffers();\n>\n> /*\n> diff --git a/src/cam/capture.h b/src/cam/capture.h\n> index 45e5e8a9ba27..d21c95a26ce7 100644\n> --- a/src/cam/capture.h\n> +++ b/src/cam/capture.h\n> @@ -33,6 +33,7 @@ private:\n> int capture(libcamera::FrameBufferAllocator *allocator);\n>\n> void requestComplete(libcamera::Request *request);\n> + void processRequest(libcamera::Request *request);\n>\n> std::shared_ptr camera_;\n> libcamera::CameraConfiguration *config_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C9C1BE086\n\tfor ;\n\tFri, 13 Nov 2020 12:36:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4C26631BC;\n\tFri, 13 Nov 2020 13:36:04 +0100 (CET)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8359563161\n\tfor ;\n\tFri, 13 Nov 2020 13:36:03 +0100 (CET)","by mail-wm1-x343.google.com with SMTP id s13so8347177wmh.4\n\tfor ;\n\tFri, 13 Nov 2020 04:36:03 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eJzJluqX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=p7Dw+Vx8WqSqLnG00pQpWl/+vtCXpdgnKoAbYC8EKkw=;\n\tb=eJzJluqXCZ926L0b8snjIXi6ZtiyhOMWVWMVSTEiMc17UH025MxqN1ddjPbBeoXRch\n\tREY9Kzz4xOEp8lII4WBmmVuwELY7QeCmM1bjpWNGUI8nNxUywJSia4KekI3uYedwDaJ1\n\ttGI/7P9/87PPW5y/2DD+goxa7nn04uIr3eoNDoVuswxPJmFCq0Wsvn+9ngzlSgDN+f4B\n\tPIMP1vn92zTEpkk1WYwZvkXCanmNzpqtd7evts074cucpXmNdLq82sDHQYaDmX7Y8Tm/\n\tAVZzWQKjs1X+aBlosir75ULMcrtxlfI4wmkstf32+f4Rdwu3n0xrq2jeYIxzJZaGOyN4\n\txVZg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=p7Dw+Vx8WqSqLnG00pQpWl/+vtCXpdgnKoAbYC8EKkw=;\n\tb=ECKjMN4J/pZe8p41Sn0j9hzdSnmAo4YTkE+AmWxx/4UvJnVPAI/Tykz7uqJkgFXT1o\n\tH9ZIvWqWIFhOpkM8J65qU5FfPQnrutOufF+JE76y6IUhyoIklQm848FybyPq5MsVdgrZ\n\t2rhEFDmg5zpQHFM3SPKpiV+AqZAFDhNMULO3LWtKlF4H1y3E1IoaBSLc/TiNMt3DchV0\n\tvR9ir4Uy9JOJepGNXRVX6iWRUhJu5h0uGqaIaFRNkEl5be1kiF0bT5FOoys8/dMwH3LE\n\tQwjhNzX/jy2ApKYL8S/GxX6crp5OA6rg784wPAFfYgQ3W0RpWreYQDfS3QH0q/FZiVsh\n\ttAfg==","X-Gm-Message-State":"AOAM531v7vXEtuMQlvJWzNxJwkMwGyJS+VmmgQaHK7zfSU8YVRRWD/YI\n\tjJzhj4NokPb/5PcoNGr275ZSgQZKfiWeY1kJlvVLHk73tC0=","X-Google-Smtp-Source":"ABdhPJwah9PpShp8RCeZEdJusvQnG5Ux3sCti/PZ8M5cPDMjmHYoPOzncKPTWbc15GORXlQAUYOf2I5p5sorLvItE9w=","X-Received":"by 2002:a1c:1b85:: with SMTP id\n\tb127mr2421054wmb.163.1605270963079; \n\tFri, 13 Nov 2020 04:36:03 -0800 (PST)","MIME-Version":"1.0","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>","From":"Marvin Schmidt ","Date":"Fri, 13 Nov 2020 13:35:40 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13711,"web_url":"https://patchwork.libcamera.org/comment/13711/","msgid":"<20201113124520.GK7524@pendragon.ideasonboard.com>","date":"2020-11-13T12:45:20","subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marvin,\n\nOn Fri, Nov 13, 2020 at 01:35:40PM +0100, Marvin Schmidt wrote:\n> Hey Laurent,\n> \n> Thanks for your work\n> \n> Am Fr., 13. Nov. 2020 um 07:38 Uhr schrieb Laurent Pinchart:\n> >\n> > The request completion handler is invoked in the camera manager thread,\n> > which shouldn't be blocked for large amounts of time. As writing the\n> > frames to disk can be a time-consuming process, move request processing\n> > to the main thread by queueing an event to the event loop.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/cam/capture.cpp | 9 +++++++++\n> > src/cam/capture.h | 1 +\n> > 2 files changed, 10 insertions(+)\n> >\n> > diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> > index 7580f798288c..43b109d099f6 100644\n> > --- a/src/cam/capture.cpp\n> > +++ b/src/cam/capture.cpp\n> > @@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n> > if (request->status() == Request::RequestCancelled)\n> > return;\n> >\n> > + /*\n> > + * Defer processing of the completed request to the event loop, to avoid\n> > + * blocking the camera manager thread.\n> > + */\n> > + loop_->callLater(std::bind(&Capture::processRequest, this, request));\n> \n> You could use a lambda here instead of std::bind:\n> \n> [=] { processRequest(request); }\n> \n> std::bind would otherwise require including ``\n\n is included by event_loop.h, as the callLater() function\ntakes an std::function parameter. But a lambda would certainly work. I\nwonder, between std::bind and the proposed lambda function, what would\nbe more efficient ?\n\n> > +}\n> > +\n> > +void Capture::processRequest(Request *request)\n> > +{\n> > const Request::BufferMap &buffers = request->buffers();\n> >\n> > /*\n> > diff --git a/src/cam/capture.h b/src/cam/capture.h\n> > index 45e5e8a9ba27..d21c95a26ce7 100644\n> > --- a/src/cam/capture.h\n> > +++ b/src/cam/capture.h\n> > @@ -33,6 +33,7 @@ private:\n> > int capture(libcamera::FrameBufferAllocator *allocator);\n> >\n> > void requestComplete(libcamera::Request *request);\n> > + void processRequest(libcamera::Request *request);\n> >\n> > std::shared_ptr camera_;\n> > libcamera::CameraConfiguration *config_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EBB9BE082\n\tfor ;\n\tFri, 13 Nov 2020 12:45:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CABFA631CC;\n\tFri, 13 Nov 2020 13:45:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3F01631AB\n\tfor ;\n\tFri, 13 Nov 2020 13:45:25 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 405FF31A;\n\tFri, 13 Nov 2020 13:45:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZSz9bKLO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605271525;\n\tbh=6XG9jXAXHOgYBCXDTa4OMOzxoOK+FemAuBjm5cRbWmY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZSz9bKLOpQXtox+W9S2lxNNKcDoIctGhVY1UCemdJoT72/TMCiN8ML17kBtoynSHl\n\tS2a+0bMAOeI/a/e0xuQZueoZaAI877cOQhULry2gm5hg+R2jcs774EJp/qKZ2pXcYU\n\tiMhQcwbHWUwZqNwSPpaE/kpHBSAz8ohsmjxeu8Og=","Date":"Fri, 13 Nov 2020 14:45:20 +0200","From":"Laurent Pinchart ","To":"Marvin Schmidt ","Message-ID":"<20201113124520.GK7524@pendragon.ideasonboard.com>","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13712,"web_url":"https://patchwork.libcamera.org/comment/13712/","msgid":"","date":"2020-11-13T13:31:09","subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","submitter":{"id":51,"url":"https://patchwork.libcamera.org/api/people/51/","name":"Marvin Schmidt","email":"marvin.schmidt1987@gmail.com"},"content":"Am Fr., 13. Nov. 2020 um 13:45 Uhr schrieb Laurent Pinchart\n:\n>\n> Hi Marvin,\n>\n> On Fri, Nov 13, 2020 at 01:35:40PM +0100, Marvin Schmidt wrote:\n> > Hey Laurent,\n> >\n> > Thanks for your work\n> >\n> > Am Fr., 13. Nov. 2020 um 07:38 Uhr schrieb Laurent Pinchart:\n> > >\n> > > The request completion handler is invoked in the camera manager thread,\n> > > which shouldn't be blocked for large amounts of time. As writing the\n> > > frames to disk can be a time-consuming process, move request processing\n> > > to the main thread by queueing an event to the event loop.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/cam/capture.cpp | 9 +++++++++\n> > > src/cam/capture.h | 1 +\n> > > 2 files changed, 10 insertions(+)\n> > >\n> > > diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> > > index 7580f798288c..43b109d099f6 100644\n> > > --- a/src/cam/capture.cpp\n> > > +++ b/src/cam/capture.cpp\n> > > @@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n> > > if (request->status() == Request::RequestCancelled)\n> > > return;\n> > >\n> > > + /*\n> > > + * Defer processing of the completed request to the event loop, to avoid\n> > > + * blocking the camera manager thread.\n> > > + */\n> > > + loop_->callLater(std::bind(&Capture::processRequest, this, request));\n> >\n> > You could use a lambda here instead of std::bind:\n> >\n> > [=] { processRequest(request); }\n> >\n> > std::bind would otherwise require including ``\n>\n> is included by event_loop.h, as the callLater() function\n> takes an std::function parameter. But a lambda would certainly work. I\n> wonder, between std::bind and the proposed lambda function, what would\n> be more efficient ?\n\nSince lambdas are a language feature I would imagine that they can be\nbetter optimized by compilers. Other people seem to agree with that and\nfound that lambdas are faster (at least in their use-case / benchmark):\nhttps://stackoverflow.com/questions/24852764/stdbind-vs-lambda-performance\n\nAlso the existence of clang-tidy's `modernize-avoid-bind` check[1] makes me\nthink that lambdas should be used where possible :-)\n\n[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html\n\n> > > +}\n> > > +\n> > > +void Capture::processRequest(Request *request)\n> > > +{\n> > > const Request::BufferMap &buffers = request->buffers();\n> > >\n> > > /*\n> > > diff --git a/src/cam/capture.h b/src/cam/capture.h\n> > > index 45e5e8a9ba27..d21c95a26ce7 100644\n> > > --- a/src/cam/capture.h\n> > > +++ b/src/cam/capture.h\n> > > @@ -33,6 +33,7 @@ private:\n> > > int capture(libcamera::FrameBufferAllocator *allocator);\n> > >\n> > > void requestComplete(libcamera::Request *request);\n> > > + void processRequest(libcamera::Request *request);\n> > >\n> > > std::shared_ptr camera_;\n> > > libcamera::CameraConfiguration *config_;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11FB3BE086\n\tfor ;\n\tFri, 13 Nov 2020 13:31:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E9DB631CC;\n\tFri, 13 Nov 2020 14:31:34 +0100 (CET)","from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B91E1631AB\n\tfor ;\n\tFri, 13 Nov 2020 14:31:32 +0100 (CET)","by mail-wr1-x441.google.com with SMTP id p8so9939650wrx.5\n\tfor ;\n\tFri, 13 Nov 2020 05:31:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QnV9CTmm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=q5LkMtz8bjHUM891yWWctYSEuv+FgVOir1WyHeU238w=;\n\tb=QnV9CTmmZRxBkhYmTU+EUMpgPFqhWrxx2FoDiIGl1I7m9quQMEiwHfCJPF4J2LuLzI\n\te54uZzEMVXvO7YMmsI7tq4gGXLNDMHFD31kZXGq6fjYTGrpHUeUwd/HpnhKWkHWLkZwD\n\tPxi1YcPuaqph2pouq5FjCK3vijouoIGoA+pKJDgBYCfl/gueyYo432n/tas2Wk4pbRLX\n\twGmlm03tpgrLXsep09rNSa1PCdCu9t2wXb4noQHhhv48NnFgyUc8fBn+fgmnGpLBqKJJ\n\thlLKgWsM68iV9dz0k9Rn0VXQA0pZ/b8VVtp8p9zMBdSOK8j6T71D09OaLhPO4aaPJcVQ\n\tzWRA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=q5LkMtz8bjHUM891yWWctYSEuv+FgVOir1WyHeU238w=;\n\tb=ory2d8jx5jrJauvCFeAv7YG6QpoIxbG8jLCK6Xr6UxnHhTKdwo773oPlrbjY45osXV\n\twXE/HU5FIO/FjBPskNP/BkqGDlvvWxwuq4ZbnUEQi4F19M3qSSUfSG+KVLucWErA82wS\n\t7PtZlrlwLXCrYeEm2MmTOt7APafX8WQ7u3fDrgSjDK3MJTpQfcdFZ4/C2wSTX/K9/PiA\n\tL+1ndp+X34WhIzH99MT6F1pzTkj/OSYmFUN0qYBiwM7QhCsowBi4WyXivum0QNuVYZQt\n\tOV2MBXYj8vSnRyJFKE8a35sHMeMzDwFfVdJY0lFhIo0mJj8oa4vzB0Oag7gomC+cMJRX\n\t3KrA==","X-Gm-Message-State":"AOAM530DAIVCZQGBZTzvQkzDQInWlkph1tOC8NYa3ijUF+kTqcS5mUn3\n\tj0RWXVyqb9PK5LcnmWO8bINyHfY9rfST1jaqAO0=","X-Google-Smtp-Source":"ABdhPJyujL2pZVbmFTytv+uDHWW8uxkYL8/mevqxGGN3RuLC/FVOES83tC7N8dvpFT7sCglil8JefW9bGPyQ48uGaIQ=","X-Received":"by 2002:adf:84a6:: with SMTP id 35mr3554377wrg.18.1605274292338; \n\tFri, 13 Nov 2020 05:31:32 -0800 (PST)","MIME-Version":"1.0","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>\n\t\n\t<20201113124520.GK7524@pendragon.ideasonboard.com>","In-Reply-To":"<20201113124520.GK7524@pendragon.ideasonboard.com>","From":"Marvin Schmidt ","Date":"Fri, 13 Nov 2020 14:31:09 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13713,"web_url":"https://patchwork.libcamera.org/comment/13713/","msgid":"<20201113134748.GL7524@pendragon.ideasonboard.com>","date":"2020-11-13T13:47:48","subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marvin,\n\nOn Fri, Nov 13, 2020 at 02:31:09PM +0100, Marvin Schmidt wrote:\n> Am Fr., 13. Nov. 2020 um 13:45 Uhr schrieb Laurent Pinchart:\n> > On Fri, Nov 13, 2020 at 01:35:40PM +0100, Marvin Schmidt wrote:\n> > > Hey Laurent,\n> > >\n> > > Thanks for your work\n> > >\n> > > Am Fr., 13. Nov. 2020 um 07:38 Uhr schrieb Laurent Pinchart:\n> > > >\n> > > > The request completion handler is invoked in the camera manager thread,\n> > > > which shouldn't be blocked for large amounts of time. As writing the\n> > > > frames to disk can be a time-consuming process, move request processing\n> > > > to the main thread by queueing an event to the event loop.\n> > > >\n> > > > Signed-off-by: Laurent Pinchart \n> > > > ---\n> > > > src/cam/capture.cpp | 9 +++++++++\n> > > > src/cam/capture.h | 1 +\n> > > > 2 files changed, 10 insertions(+)\n> > > >\n> > > > diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> > > > index 7580f798288c..43b109d099f6 100644\n> > > > --- a/src/cam/capture.cpp\n> > > > +++ b/src/cam/capture.cpp\n> > > > @@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n> > > > if (request->status() == Request::RequestCancelled)\n> > > > return;\n> > > >\n> > > > + /*\n> > > > + * Defer processing of the completed request to the event loop, to avoid\n> > > > + * blocking the camera manager thread.\n> > > > + */\n> > > > + loop_->callLater(std::bind(&Capture::processRequest, this, request));\n> > >\n> > > You could use a lambda here instead of std::bind:\n> > >\n> > > [=] { processRequest(request); }\n> > >\n> > > std::bind would otherwise require including ``\n> >\n> > is included by event_loop.h, as the callLater() function\n> > takes an std::function parameter. But a lambda would certainly work. I\n> > wonder, between std::bind and the proposed lambda function, what would\n> > be more efficient ?\n> \n> Since lambdas are a language feature I would imagine that they can be\n> better optimized by compilers. Other people seem to agree with that and\n> found that lambdas are faster (at least in their use-case / benchmark):\n> https://stackoverflow.com/questions/24852764/stdbind-vs-lambda-performance\n> \n> Also the existence of clang-tidy's `modernize-avoid-bind` check[1] makes me\n> think that lambdas should be used where possible :-)\n> \n> [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html\n\nThanks for the interesting information. I'll switch to using a lambda.\n\n> > > > +}\n> > > > +\n> > > > +void Capture::processRequest(Request *request)\n> > > > +{\n> > > > const Request::BufferMap &buffers = request->buffers();\n> > > >\n> > > > /*\n> > > > diff --git a/src/cam/capture.h b/src/cam/capture.h\n> > > > index 45e5e8a9ba27..d21c95a26ce7 100644\n> > > > --- a/src/cam/capture.h\n> > > > +++ b/src/cam/capture.h\n> > > > @@ -33,6 +33,7 @@ private:\n> > > > int capture(libcamera::FrameBufferAllocator *allocator);\n> > > >\n> > > > void requestComplete(libcamera::Request *request);\n> > > > + void processRequest(libcamera::Request *request);\n> > > >\n> > > > std::shared_ptr camera_;\n> > > > libcamera::CameraConfiguration *config_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A92DEBE082\n\tfor ;\n\tFri, 13 Nov 2020 13:47:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19B89631D0;\n\tFri, 13 Nov 2020 14:47:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82E6F631AB\n\tfor ;\n\tFri, 13 Nov 2020 14:47:53 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E832231A;\n\tFri, 13 Nov 2020 14:47:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N9tcsxCt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605275273;\n\tbh=kyhqTrslTsUR5028PLL/I84rYLy5LhFdPkBmkID6kgc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N9tcsxCt+0cRtHR03Pp0mOMxpY7McL7wtaIyBP/13u853nYyUOlA8rcqSwPUWkpZC\n\th7syBHKR8CclkK41fg3xP/dHx7aZy3eQ7ASAZXr3XkNdctCXayHkTir0CpPSeq4uCi\n\tvCNxkgw81MFCK7Ue7/n+XH2KsykFnNLQF3q9IxYE=","Date":"Fri, 13 Nov 2020 15:47:48 +0200","From":"Laurent Pinchart ","To":"Marvin Schmidt ","Message-ID":"<20201113134748.GL7524@pendragon.ideasonboard.com>","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>\n\t\n\t<20201113124520.GK7524@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] cam: Move request processing\n\tto main thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]