{"id":10419,"url":"https://patchwork.libcamera.org/api/patches/10419/?format=json","web_url":"https://patchwork.libcamera.org/patch/10419/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201113063815.10288-5-laurent.pinchart@ideasonboard.com>","date":"2020-11-13T06:38:14","name":"[libcamera-devel,v1,4/5] cam: event_loop: Add deferred calls support","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2a86180a412b1e25c9d55095d5043b1ecf7dc9c5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10419/mbox/","series":[{"id":1458,"url":"https://patchwork.libcamera.org/api/series/1458/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1458","date":"2020-11-13T06:38:10","name":"cam: Move request processing to main thread","version":1,"mbox":"https://patchwork.libcamera.org/series/1458/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10419/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10419/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7E17BE086\n\tfor ;\n\tFri, 13 Nov 2020 06:38:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75541631B1;\n\tFri, 13 Nov 2020 07:38:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6619863149\n\tfor ;\n\tFri, 13 Nov 2020 07:38:25 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06B3FA1B\n\tfor ;\n\tFri, 13 Nov 2020 07:38:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NhgeRl+I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605249505;\n\tbh=kayCqxYadOhi7xZmSDg7d3vUdi+NuYPicv0jnngLwH8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NhgeRl+IJQpz6FfeRxeXH0RdqyC8ZGWnneIx5hCQ+ZZDGKZnLkbKhJWkXu90dXbc9\n\t8y13sdu37Sr5i8T5zHIfkM3Lx2M91DorLOPzWgWX/9Kcj+WhpeqkJfdLpCnytv6fES\n\tEoA0J5dFXOhKZDgq0CUWJYdZA51ULapSzLuFYh/I=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 13 Nov 2020 08:38:14 +0200","Message-Id":"<20201113063815.10288-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v1 4/5] cam: event_loop: Add deferred\n\tcalls support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a deferred cals queue to the EventLoop class to support queuing\ncalls from a different thread and processing them in the event loop's\nthread.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/event_loop.cpp | 29 ++++++++++++++++++++++++++++-\n src/cam/event_loop.h | 9 +++++++++\n 2 files changed, 37 insertions(+), 1 deletion(-)","diff":"diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\nindex 13f2583da0a1..94c5d1d36245 100644\n--- a/src/cam/event_loop.cpp\n+++ b/src/cam/event_loop.cpp\n@@ -40,8 +40,10 @@ int EventLoop::exec()\n \texitCode_ = -1;\n \texit_.store(false, std::memory_order_release);\n \n-\twhile (!exit_.load(std::memory_order_acquire))\n+\twhile (!exit_.load(std::memory_order_acquire)) {\n+\t\tdispatchCalls();\n \t\tevent_base_loop(event_, EVLOOP_NO_EXIT_ON_EMPTY);\n+\t}\n \n \treturn exitCode_;\n }\n@@ -57,3 +59,28 @@ void EventLoop::interrupt()\n {\n \tevent_base_loopbreak(event_);\n }\n+\n+void EventLoop::callLater(const std::function &func)\n+{\n+\t{\n+\t\tstd::unique_lock locker(lock_);\n+\t\tcalls_.push_back(func);\n+\t}\n+\n+\tinterrupt();\n+}\n+\n+void EventLoop::dispatchCalls()\n+{\n+\tstd::unique_lock locker(lock_);\n+\n+\tfor (auto iter = calls_.begin(); iter != calls_.end(); ) {\n+\t\tstd::function call = std::move(*iter);\n+\n+\t\titer = calls_.erase(iter);\n+\n+\t\tlocker.unlock();\n+\t\tcall();\n+\t\tlocker.lock();\n+\t}\n+}\ndiff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\nindex b1c6bd103080..408073c50594 100644\n--- a/src/cam/event_loop.h\n+++ b/src/cam/event_loop.h\n@@ -8,6 +8,9 @@\n #define __CAM_EVENT_LOOP_H__\n \n #include \n+#include \n+#include \n+#include \n \n struct event_base;\n \n@@ -22,6 +25,8 @@ public:\n \tint exec();\n \tvoid exit(int code = 0);\n \n+\tvoid callLater(const std::function &func);\n+\n private:\n \tstatic EventLoop *instance_;\n \n@@ -29,7 +34,11 @@ private:\n \tstd::atomic exit_;\n \tint exitCode_;\n \n+\tstd::list> calls_;\n+\tstd::mutex lock_;\n+\n \tvoid interrupt();\n+\tvoid dispatchCalls();\n };\n \n #endif /* __CAM_EVENT_LOOP_H__ */\n","prefixes":["libcamera-devel","v1","4/5"]}