[{"id":13696,"web_url":"https://patchwork.libcamera.org/comment/13696/","msgid":"<88c2e438-3675-50c1-5b01-c85d7dc3bd9e@ideasonboard.com>","date":"2020-11-13T09:55:22","subject":"Re: [libcamera-devel] [PATCH v1 1/5] test: Get event dispatcher\n\tfrom current thread","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 13/11/2020 06:38, Laurent Pinchart wrote:\n> Get the event dispatcher from the current thread instead of the camera\n> manager. This prepares for the removal of\n> CameraManager::eventDispatcher().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> test/camera/buffer_import.cpp | 3 ++-\n> test/camera/capture.cpp | 4 +++-\n> 2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 4b626dffa575..ccf532d7b7fc 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -17,6 +17,7 @@\n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> +#include \"libcamera/internal/thread.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> #include \"buffer_source.h\"\n> @@ -131,7 +132,7 @@ protected:\n> \t\t\t}\n> \t\t}\n> \n> -\t\tEventDispatcher *dispatcher = cm_->eventDispatcher();\n> +\t\tEventDispatcher *dispatcher = Thread::current()->eventDispatcher();\n> \n> \t\tTimer timer;\n> \t\ttimer.start(1000);\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index f13ca53b8cdf..fd5292b7c8c9 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -11,6 +11,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/thread.h\"\n> +\n> #include \"camera_test.h\"\n> #include \"test.h\"\n> \n> @@ -131,7 +133,7 @@ protected:\n> \t\t\t}\n> \t\t}\n> \n> -\t\tEventDispatcher *dispatcher = cm_->eventDispatcher();\n> +\t\tEventDispatcher *dispatcher = Thread::current()->eventDispatcher();\n> \n> \t\tTimer timer;\n> \t\ttimer.start(1000);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0DCFBE086\n\tfor ;\n\tFri, 13 Nov 2020 09:55:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 467F1631BE;\n\tFri, 13 Nov 2020 10:55:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B3F9631B8\n\tfor ;\n\tFri, 13 Nov 2020 10:55:26 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B741731A;\n\tFri, 13 Nov 2020 10:55:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h9FmaR6+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605261325;\n\tbh=IsbY/kf78+A+1TZbiVUeksaZLu5mUTTOPywG/QLdNC8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=h9FmaR6+FBOmZ3vJAiJij0dqAry33/wgk6RY0+/uzqbAquj3YrPGcGB89dBYAiJxF\n\tO7M2DWrTLiUDuALoJqlUyOLNDayZ4aHV22b/KVLpC3tGO1TRSXGV7MFv6Bn/4pc+SD\n\td1Z/nyRuHaV6c+VrKBgBjwq4aUxeiDq7UgBOw5bs=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<88c2e438-3675-50c1-5b01-c85d7dc3bd9e@ideasonboard.com>","Date":"Fri, 13 Nov 2020 09:55:22 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201113063815.10288-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v1 1/5] test: Get event dispatcher\n\tfrom current thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13703,"web_url":"https://patchwork.libcamera.org/comment/13703/","msgid":"<20201113102305.GE1603296@oden.dyn.berto.se>","date":"2020-11-13T10:23:05","subject":"Re: [libcamera-devel] [PATCH v1 1/5] test: Get event dispatcher\n\tfrom current thread","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-11-13 08:38:11 +0200, Laurent Pinchart wrote:\n> Get the event dispatcher from the current thread instead of the camera\n> manager. This prepares for the removal of\n> CameraManager::eventDispatcher().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/camera/buffer_import.cpp | 3 ++-\n> test/camera/capture.cpp | 4 +++-\n> 2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 4b626dffa575..ccf532d7b7fc 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -17,6 +17,7 @@\n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> +#include \"libcamera/internal/thread.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> #include \"buffer_source.h\"\n> @@ -131,7 +132,7 @@ protected:\n> \t\t\t}\n> \t\t}\n> \n> -\t\tEventDispatcher *dispatcher = cm_->eventDispatcher();\n> +\t\tEventDispatcher *dispatcher = Thread::current()->eventDispatcher();\n> \n> \t\tTimer timer;\n> \t\ttimer.start(1000);\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index f13ca53b8cdf..fd5292b7c8c9 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -11,6 +11,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/thread.h\"\n> +\n> #include \"camera_test.h\"\n> #include \"test.h\"\n> \n> @@ -131,7 +133,7 @@ protected:\n> \t\t\t}\n> \t\t}\n> \n> -\t\tEventDispatcher *dispatcher = cm_->eventDispatcher();\n> +\t\tEventDispatcher *dispatcher = Thread::current()->eventDispatcher();\n> \n> \t\tTimer timer;\n> \t\ttimer.start(1000);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23F47BE086\n\tfor ;\n\tFri, 13 Nov 2020 10:23:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B467B631B9;\n\tFri, 13 Nov 2020 11:23:09 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4E6F631B8\n\tfor ;\n\tFri, 13 Nov 2020 11:23:07 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id s30so13054788lfc.4\n\tfor ;\n\tFri, 13 Nov 2020 02:23:07 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tq27sm1477881lfd.261.2020.11.13.02.23.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Nov 2020 02:23:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"QcKbKosZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=wOaUjvy03bhk9e2h+FXFPIJg+2jdf28q9iQ+OOMYhig=;\n\tb=QcKbKosZ/PAQckYsNTiZEYasAP/O3jEObezHe1BXeAze2ND8fg6NanYfijb9q5t7LN\n\t+0uoBxWTUk2qCOKV6K9qunSQ2QnNrmZ41uwa2eJ7XztY90F/A1atWznvOZ6QeY0Oa3Ue\n\t9I14+Gzu2L+d4GKv+fh3t7/XkGlHuSVPXTsmhOpe7fFtJE8/+aeRvwwB9Fex6zWS873d\n\tbpgI8vlD7KnRYgn9JS8U1Ee8LWrHIpSPUkEZ027mTn7tJ0y0WL8H3byFlIiN+cYu/RNm\n\tr1y984mUX+NhLMOCPddUoR+z2kv5s111H7+iRte5ZX4WuxKBfFHChNLqHMkC+bx5dIxd\n\t6jBQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=wOaUjvy03bhk9e2h+FXFPIJg+2jdf28q9iQ+OOMYhig=;\n\tb=fCroB/m/ypyMsMX1C9cFX6qKcrWVuX6ZrNiWAr0tD2I2l1xbOxAPL1Y+QPQqRav+LZ\n\tYzytgdgAhz7JJb8jXNHyplG5fIENw1XJTyGIdCqrtFeRA9il+V/frQCPGlORuInt27IT\n\thyKzyAPcoQZjEQ4U57ETixtm+9j+Mt2pWowsw2tGb5WERRnefi6RLT288vznwCT6PNIy\n\t2TiGNhY/SL0W/60yRRmQx3BaGy12rzeGuT9CpYWYlfRURuc4HswjABNcWDTVBzkIivR0\n\tU9/Pg8ncFD2trzurYWHO27Ue602Q+I/nVZBYkAIy96C9n3tRbPv39yZaCMNzb/UnEKbR\n\tOZ2g==","X-Gm-Message-State":"AOAM530RmahFPlnZRmzM+8YEl9voUadhE7I5Go4ptsRp83ztm/x/OzLN\n\tMc9tKf73myG/xn/0pgahv9VJlQ==","X-Google-Smtp-Source":"ABdhPJxdgZEp8awt4T409fPtwVZUi4i3pU6KcrYh9EX1THzIFi4P0t3qQjwrs/sxhv+oOcQqxd7S7Q==","X-Received":"by 2002:a19:cc2:: with SMTP id 185mr647923lfm.318.1605262986875; \n\tFri, 13 Nov 2020 02:23:06 -0800 (PST)","Date":"Fri, 13 Nov 2020 11:23:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201113102305.GE1603296@oden.dyn.berto.se>","References":"<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>\n\t<20201113063815.10288-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201113063815.10288-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/5] test: Get event dispatcher\n\tfrom current thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]