{"id":10383,"url":"https://patchwork.libcamera.org/api/patches/10383/?format=json","web_url":"https://patchwork.libcamera.org/patch/10383/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201106103707.49660-36-paul.elder@ideasonboard.com>","date":"2020-11-06T10:37:05","name":"[libcamera-devel,v4,35/37] tests: Add test for IPAIPCUnixSocket","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7930ac28571291bdcde1d059b3b6c8314f3bc6dc","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10383/mbox/","series":[{"id":1448,"url":"https://patchwork.libcamera.org/api/series/1448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1448","date":"2020-11-06T10:36:30","name":"IPA isolation implementation","version":4,"mbox":"https://patchwork.libcamera.org/series/1448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10383/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10383/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 919FDBDB89\n\tfor ;\n\tFri, 6 Nov 2020 10:38:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C18062D50;\n\tFri, 6 Nov 2020 11:38:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BC8662D4E\n\tfor ;\n\tFri, 6 Nov 2020 11:38:35 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4ADFA19;\n\tFri, 6 Nov 2020 11:38:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"okS94RXR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604659114;\n\tbh=ZezVWNJcYT+7eJzzMNyb0WApdjepfZ4tGPgjPa6syXc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=okS94RXRlKBhHEhlfDby932lJQ3n5A8Q8PUk6Uhylgvzto4k8GN/2Yk5TwfkTHL1e\n\tKxAOnmlsbVo6vRg+NwUAAclor470kaqz9UCcPFZsiws+stFLQHy4RDBA66EckFUSkX\n\tybjIKlGfXQtJ4fHW/tbNGSTXh8YqAOkf+Rg1UC/Q=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Nov 2020 19:37:05 +0900","Message-Id":"<20201106103707.49660-36-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 35/37] tests: Add test for\n\tIPAIPCUnixSocket","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Test the IPC functions of IPAIPCUnixSocket.\n\nSigned-off-by: Paul Elder \n\n---\nNo change in v4\n\nChanges in v3:\n- use readHeader, writeHeader, and eraseHeader as static class functions\n of IPAIPCUnixSocket\n\nNew in v2\n---\n test/ipc/meson.build | 3 +-\n test/ipc/unixsocket_ipc.cpp | 238 ++++++++++++++++++++++++++++++++++++\n 2 files changed, 240 insertions(+), 1 deletion(-)\n create mode 100644 test/ipc/unixsocket_ipc.cpp","diff":"diff --git a/test/ipc/meson.build b/test/ipc/meson.build\nindex 650df1d6..ecb6d022 100644\n--- a/test/ipc/meson.build\n+++ b/test/ipc/meson.build\n@@ -1,7 +1,8 @@\n # SPDX-License-Identifier: CC0-1.0\n \n ipc_tests = [\n- [ 'unixsocket', 'unixsocket.cpp' ],\n+ [ 'unixsocket_ipc', 'unixsocket_ipc.cpp' ],\n+ [ 'unixsocket', 'unixsocket.cpp' ],\n ]\n \n foreach t : ipc_tests\ndiff --git a/test/ipc/unixsocket_ipc.cpp b/test/ipc/unixsocket_ipc.cpp\nnew file mode 100644\nindex 00000000..467c26ca\n--- /dev/null\n+++ b/test/ipc/unixsocket_ipc.cpp\n@@ -0,0 +1,238 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Google Inc.\n+ *\n+ * unixsocket_ipc.cpp - Unix socket IPC test\n+ */\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+#include \n+#include \n+\n+#include \"libcamera/internal/ipa_data_serializer.h\"\n+#include \"libcamera/internal/ipa_ipc_unixsocket.h\"\n+#include \"libcamera/internal/process.h\"\n+#include \"libcamera/internal/thread.h\"\n+#include \"libcamera/internal/utils.h\"\n+\n+#include \"test.h\"\n+\n+#define CMD_EXIT\t0\n+#define CMD_GET_SYNC\t1\n+#define CMD_SET_ASYNC\t2\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class UnixSocketTestIPCSlave\n+{\n+public:\n+\tUnixSocketTestIPCSlave()\n+\t\t: value_(1337), exitCode_(EXIT_FAILURE), exit_(false)\n+\t{\n+\t\tdispatcher_ = Thread::current()->eventDispatcher();\n+\t\tipc_.readyRead.connect(this, &UnixSocketTestIPCSlave::readyRead);\n+\t}\n+\n+\tint run(int fd)\n+\t{\n+\t\tif (ipc_.bind(fd)) {\n+\t\t\tcerr << \"Failed to connect to IPC channel\" << endl;\n+\t\t\treturn EXIT_FAILURE;\n+\t\t}\n+\n+\t\twhile (!exit_)\n+\t\t\tdispatcher_->processEvents();\n+\n+\t\tipc_.close();\n+\n+\t\treturn exitCode_;\n+\t}\n+\n+private:\n+\tvoid readyRead(IPCUnixSocket *ipc)\n+\t{\n+\t\tIPCUnixSocket::Payload message, response;\n+\t\tint ret;\n+\n+\t\tret = ipc->receive(&message);\n+\t\tif (ret) {\n+\t\t\tcerr << \"Receive message failed: \" << ret << endl;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tuint32_t cmd, seq;\n+\t\tstd::tie(cmd, seq) = IPAIPCUnixSocket::readHeader(message);\n+\t\tIPAIPCUnixSocket::eraseHeader(message);\n+\n+\t\tswitch (cmd) {\n+\t\tcase CMD_EXIT: {\n+\t\t exit_ = true;\n+\t\t break;\n+\t\t}\n+\n+\t\tcase CMD_GET_SYNC: {\n+\t\t\tIPAIPCUnixSocket::writeHeader(response, cmd, seq);\n+\n+\t\t\tvector buf;\n+\t\t\ttie(buf, ignore) = IPADataSerializer::serialize(value_);\n+\t\t\tresponse.data.insert(response.data.end(), buf.begin(), buf.end());\n+\n+\t\t\tret = ipc_.send(response);\n+\t\t\tif (ret < 0) {\n+\t\t\t\tcerr << \"Reply failed\" << endl;\n+\t\t\t\tstop(ret);\n+\t\t\t}\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tcase CMD_SET_ASYNC: {\n+\t\t\tvalue_ = IPADataSerializer::deserialize(message.data);\n+\t\t\tbreak;\n+\t\t}\n+\t\t}\n+\t}\n+\n+\tvoid stop(int code)\n+\t{\n+\t\texitCode_ = code;\n+\t\texit_ = true;\n+\t}\n+\n+\tint32_t value_;\n+\n+\tIPCUnixSocket ipc_;\n+\tEventDispatcher *dispatcher_;\n+\tint exitCode_;\n+\tbool exit_;\n+};\n+\n+class UnixSocketTestIPC : public Test\n+{\n+protected:\n+\tint init()\n+\t{\n+\t\treturn 0;\n+\t}\n+\n+\tint setVal(int32_t val)\n+\t{\n+\t\tvector buf;\n+\t\ttie(buf, ignore) = IPADataSerializer::serialize(val);\n+\n+\t\tint ret = ipc_->sendAsync(CMD_SET_ASYNC, buf, {});\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to call set value\" << endl;\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\treturn 0;\n+\t}\n+\n+\tint getVal()\n+\t{\n+\t\tvector buf;\n+\n+\t\tint ret = ipc_->sendSync(CMD_GET_SYNC, {}, {}, &buf);\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to call get value\" << endl;\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\treturn IPADataSerializer::deserialize(buf);\n+\t}\n+\n+\tint exit()\n+\t{\n+\t\tint ret = ipc_->sendAsync(CMD_EXIT, {}, {});\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to call exit\" << endl;\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\treturn 0;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\tchar selfpath[100];\n+\t\tmemset(selfpath, 0, sizeof(selfpath));\n+\t\tint ret = readlink(\"/proc/self/exe\", selfpath, sizeof(selfpath));\n+\t\tif (ret < 0) {\n+\t\t\tint err = errno;\n+\t\t\tcerr << \"Failed to get path: \" << strerror(err) << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tipc_ = std::make_unique(\"\", selfpath);\n+\t\tif (!ipc_->isValid()) {\n+\t\t\tcerr << \"Failed to create IPAIPC\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\n+\t\tret = getVal();\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to get initial value: \" << strerror(-ret) << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\t\tif (ret != 1337) {\n+\t\t\tcerr << \"Wrong inital value, expected 1337, got \" << ret << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tret = setVal(9001);\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to set value: \" << strerror(-ret) << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tret = getVal();\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to get value: \" << strerror(-ret) << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\t\tif (ret != 9001) {\n+\t\t\tcerr << \"Wrong set value, expected 9001, got \" << ret << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tret = exit();\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"Failed to exit: \" << strerror(-ret) << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+private:\n+\tProcessManager processManager_;\n+\n+\tstd::unique_ptr ipc_;\n+};\n+\n+/*\n+ * Can't use TEST_REGISTER() as single binary needs to act as both proxy\n+ * master and slave.\n+ */\n+int main(int argc, char **argv)\n+{\n+\t/* IPAIPCUnixSocket passes IPA module path in argv[1] */\n+\tif (argc == 3) {\n+\t\tint ipcfd = std::stoi(argv[2]);\n+\t\tUnixSocketTestIPCSlave slave;\n+\t\treturn slave.run(ipcfd);\n+\t}\n+\n+\treturn UnixSocketTestIPC().execute();\n+}\n","prefixes":["libcamera-devel","v4","35/37"]}