[{"id":13930,"web_url":"https://patchwork.libcamera.org/comment/13930/","msgid":"<20201126155259.GT3905@pendragon.ideasonboard.com>","date":"2020-11-26T15:52:59","subject":"Re: [libcamera-devel] [PATCH v4 32/37] tests: ipa_interface_test:\n\tUpdate to use new createIPA","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:37:02PM +0900, Paul Elder wrote:\n> Update the IPA interface test to use the new createIPA function from\n> IPAManager. Also declare ProcessManager, as it is not longer globally\n\nMaybe \"Also create an instance of ProcessManager, as no single global\ninstance is created automatically anymore.\" ?\n\n> defined. Update meson.build to depend on the generated IPA interface\n> headers.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v4:\n> - rename libcamera_generated_headers to libcamera_generated_ipa_headers\n> \n> Changes in v3:\n> - declare ProcessManager\n> - add libcamera_generated_headers as dependency to meson\n> - otherwise test might build before the generated IPA headers and\n> #include will fail\n> \n> New in v2\n> ---\n> test/ipa/ipa_interface_test.cpp | 8 ++++++--\n> test/ipa/meson.build | 2 +-\n> 2 files changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 67488409..db95a9e5 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -15,12 +15,14 @@\n> #include \n> #include \n> #include \n> +#include \n\nAlphabetical order. Doesn't checkstyle.py flag it ?\n\nReviewed-by: Laurent Pinchart \n\n> #include \n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/ipa_module.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/process.h\"\n> #include \"libcamera/internal/thread.h\"\n> \n> #include \"test.h\"\n> @@ -95,7 +97,7 @@ protected:\n> \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n> \t\tTimer timer;\n> \n> -\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n> +\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n> \t\tif (!ipa_) {\n> \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n> \t\t\treturn TestFail;\n> @@ -163,8 +165,10 @@ private:\n> \t\t}\n> \t}\n> \n> +\tProcessManager processManager_;\n> +\n> \tstd::shared_ptr pipe_;\n> -\tstd::unique_ptr ipa_;\n> +\tstd::unique_ptr ipa_;\n> \tstd::unique_ptr ipaManager_;\n> \tenum IPAOperationCode trace_;\n> \tEventNotifier *notifier_;\n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index b25bfcf4..fce58a31 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -7,7 +7,7 @@ ipa_test = [\n> ]\n> \n> foreach t : ipa_test\n> - exe = executable(t[0], t[1],\n> + exe = executable(t[0], [t[1], libcamera_generated_ipa_headers],\n> dependencies : libcamera_dep,\n> link_with : test_libraries,\n> include_directories : test_includes_internal)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6161BE176\n\tfor ;\n\tThu, 26 Nov 2020 15:53:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34EA76346B;\n\tThu, 26 Nov 2020 16:53:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B99C6344B\n\tfor ;\n\tThu, 26 Nov 2020 16:53:08 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1313CA1B;\n\tThu, 26 Nov 2020 16:53:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wPSin4JW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606405988;\n\tbh=EaUxAMrCmVvULTsIYfdiHMNHV0LR0P+bCSWAqLmYE+c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wPSin4JW9/r1gBsrJbWfbcGxJNhcwvQ05OBW6JFI33FxlrOMtcuhFlhYCwuMrgZjY\n\t2u0OZnxz29qQaFZ9b9olASaPTzJxVoOlvH5T7sU3s3p+N2csETI5VafleybN8bWtzx\n\ttsdyr01EOJ5HYuZ1VIfnTm+zESAdABH5lZjYS5IE=","Date":"Thu, 26 Nov 2020 17:52:59 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201126155259.GT3905@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-33-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-33-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 32/37] tests: ipa_interface_test:\n\tUpdate to use new createIPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]