{"id":10380,"url":"https://patchwork.libcamera.org/api/patches/10380/?format=json","web_url":"https://patchwork.libcamera.org/patch/10380/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201106103707.49660-33-paul.elder@ideasonboard.com>","date":"2020-11-06T10:37:02","name":"[libcamera-devel,v4,32/37] tests: ipa_interface_test: Update to use new createIPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f6b8ea861bc0538580994d36694116c9e0cec4e6","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10380/mbox/","series":[{"id":1448,"url":"https://patchwork.libcamera.org/api/series/1448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1448","date":"2020-11-06T10:36:30","name":"IPA isolation implementation","version":4,"mbox":"https://patchwork.libcamera.org/series/1448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10380/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10380/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EE17BDB89\n\tfor ;\n\tFri, 6 Nov 2020 10:38:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D26262D47;\n\tFri, 6 Nov 2020 11:38:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B4CA62D43\n\tfor ;\n\tFri, 6 Nov 2020 11:38:29 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D4B0A19;\n\tFri, 6 Nov 2020 11:38:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"olBz5WF3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604659109;\n\tbh=zxwCrJq2+9Za9AFQUNJZwVcnzBDrZ/eEcWivbU1WSsI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=olBz5WF3LA165wOBW31f4mvh58yqaU3XnnhEY0aYsRSDbUhNbN+EaJiawv4R/AnZj\n\ttFjYvaFm/1xwmYvs+uaZnUmWb9IkHUREEfaN47NvexzsCn0ibDYT47hs7eUta/lRal\n\tMhfpL1gNHU5+rxm78SAbmGMIHwEeZZ9jj2m0juaw=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Nov 2020 19:37:02 +0900","Message-Id":"<20201106103707.49660-33-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 32/37] tests: ipa_interface_test:\n\tUpdate to use new createIPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the IPA interface test to use the new createIPA function from\nIPAManager. Also declare ProcessManager, as it is not longer globally\ndefined. Update meson.build to depend on the generated IPA interface\nheaders.\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v4:\n- rename libcamera_generated_headers to libcamera_generated_ipa_headers\n\nChanges in v3:\n- declare ProcessManager\n- add libcamera_generated_headers as dependency to meson\n - otherwise test might build before the generated IPA headers and\n #include will fail\n\nNew in v2\n---\n test/ipa/ipa_interface_test.cpp | 8 ++++++--\n test/ipa/meson.build | 2 +-\n 2 files changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\nindex 67488409..db95a9e5 100644\n--- a/test/ipa/ipa_interface_test.cpp\n+++ b/test/ipa/ipa_interface_test.cpp\n@@ -15,12 +15,14 @@\n #include \n #include \n #include \n+#include \n #include \n \n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/ipa_module.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/process.h\"\n #include \"libcamera/internal/thread.h\"\n \n #include \"test.h\"\n@@ -95,7 +97,7 @@ protected:\n \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n \t\tTimer timer;\n \n-\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n+\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n \t\tif (!ipa_) {\n \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n \t\t\treturn TestFail;\n@@ -163,8 +165,10 @@ private:\n \t\t}\n \t}\n \n+\tProcessManager processManager_;\n+\n \tstd::shared_ptr pipe_;\n-\tstd::unique_ptr ipa_;\n+\tstd::unique_ptr ipa_;\n \tstd::unique_ptr ipaManager_;\n \tenum IPAOperationCode trace_;\n \tEventNotifier *notifier_;\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nindex b25bfcf4..fce58a31 100644\n--- a/test/ipa/meson.build\n+++ b/test/ipa/meson.build\n@@ -7,7 +7,7 @@ ipa_test = [\n ]\n \n foreach t : ipa_test\n- exe = executable(t[0], t[1],\n+ exe = executable(t[0], [t[1], libcamera_generated_ipa_headers],\n dependencies : libcamera_dep,\n link_with : test_libraries,\n include_directories : test_includes_internal)\n","prefixes":["libcamera-devel","v4","32/37"]}