[{"id":13684,"web_url":"https://patchwork.libcamera.org/comment/13684/","msgid":"<20201112111347.GF1480295@oden.dyn.berto.se>","date":"2020-11-12T11:13:47","subject":"Re: [libcamera-devel] [PATCH v4 28/37] libcamera: pipeline,\n\tipa: rkisp1: Support the new IPC mechanism","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-11-06 19:36:58 +0900, Paul Elder wrote:\n> Add support to the rkisp1 pipeline handler and IPA for the new IPC\n> mechanism.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nI love how much nicer this interface is to comprehend. And once we get \nthis series merged I think we can evolve it even further, but for now I \nreally like it to \"just\" translate the old interface to the new.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> \n> ---\n> Changes in v4:\n> - rename Controls to controls\n> - rename IPARkISP1CallbackInterface to IPARkISP1EventInterface\n> - rename libcamera_generated_headers to libcamera_generated_ipa_headers\n>   in meson\n> - use the new header name, rkisp1_ipa_interface.h\n> \n> Changes in v3:\n> - change namespacing of base ControlInfoMap structure\n> \n> New in v2\n> ---\n>  include/libcamera/ipa/meson.build        |  1 +\n>  include/libcamera/ipa/rkisp1.h           | 18 ++++----\n>  include/libcamera/ipa/rkisp1.mojom       | 42 +++++++++++++++++++\n>  src/ipa/rkisp1/meson.build               |  2 +-\n>  src/ipa/rkisp1/rkisp1.cpp                | 53 +++++++++++-------------\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 44 +++++++++++---------\n>  6 files changed, 104 insertions(+), 56 deletions(-)\n>  create mode 100644 include/libcamera/ipa/rkisp1.mojom\n> \n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index 70f5dfc8..84a7f63d 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -26,6 +26,7 @@ ipa_mojom_core = custom_target(core_mojom_file.split('.')[0] + '_mojom_module',\n>  \n>  ipa_mojom_files = [\n>      'raspberrypi.mojom',\n> +    'rkisp1.mojom',\n>      'vimc.mojom',\n>  ]\n>  \n> diff --git a/include/libcamera/ipa/rkisp1.h b/include/libcamera/ipa/rkisp1.h\n> index bb824f29..35f97ee4 100644\n> --- a/include/libcamera/ipa/rkisp1.h\n> +++ b/include/libcamera/ipa/rkisp1.h\n> @@ -7,15 +7,19 @@\n>  #ifndef __LIBCAMERA_IPA_INTERFACE_RKISP1_H__\n>  #define __LIBCAMERA_IPA_INTERFACE_RKISP1_H__\n>  \n> +#include <libcamera/controls.h>\n> +\n>  #ifndef __DOXYGEN__\n>  \n> -enum RkISP1Operations {\n> -\tRKISP1_IPA_ACTION_V4L2_SET = 1,\n> -\tRKISP1_IPA_ACTION_PARAM_FILLED = 2,\n> -\tRKISP1_IPA_ACTION_METADATA = 3,\n> -\tRKISP1_IPA_EVENT_SIGNAL_STAT_BUFFER = 4,\n> -\tRKISP1_IPA_EVENT_QUEUE_REQUEST = 5,\n> -};\n> +namespace libcamera {\n> +\n> +namespace RkISP1 {\n> +\n> +static ControlInfoMap controls;\n> +\n> +} /* namespace RkISP1 */\n> +\n> +} /* namespace libcamera */\n>  \n>  #endif /* __DOXYGEN__ */\n>  \n> diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\n> new file mode 100644\n> index 00000000..7f1a4ddd\n> --- /dev/null\n> +++ b/include/libcamera/ipa/rkisp1.mojom\n> @@ -0,0 +1,42 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +\n> +import \"include/libcamera/ipa/core.mojom\";\n> +\n> +interface IPARkISP1Interface {\n> +\tinit(IPASettings settings) => (int32 ret);\n> +\tstart() => (int32 ret);\n> +\tstop();\n> +\n> +\tconfigure(CameraSensorInfo sensorInfo,\n> +\t\t  map<uint32, IPAStream> streamConfig,\n> +\t\t  map<uint32, ControlInfoMap> entityControls) => ();\n> +\n> +\tmapBuffers(array<IPABuffer> buffers);\n> +\tunmapBuffers(array<uint32> ids);\n> +\n> +\t[async] processEvent(RkISP1Event ev);\n> +};\n> +\n> +interface IPARkISP1EventInterface {\n> +\tqueueFrameAction(uint32 frame, RkISP1Action action);\n> +};\n> +\n> +enum RkISP1Operations {\n> +\tRKISP1_IPA_ACTION_V4L2_SET = 1,\n> +\tRKISP1_IPA_ACTION_PARAM_FILLED = 2,\n> +\tRKISP1_IPA_ACTION_METADATA = 3,\n> +\tRKISP1_IPA_EVENT_SIGNAL_STAT_BUFFER = 4,\n> +\tRKISP1_IPA_EVENT_QUEUE_REQUEST = 5,\n> +};\n> +\n> +struct RkISP1Event {\n> +\tRkISP1Operations op;\n> +\tuint32 frame;\n> +\tuint32 bufferId;\n> +\tControlList controls;\n> +};\n> +\n> +struct RkISP1Action {\n> +\tRkISP1Operations op;\n> +\tControlList controls;\n> +};\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index ed9a6b6b..3061d53c 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -3,7 +3,7 @@\n>  ipa_name = 'ipa_rkisp1'\n>  \n>  mod = shared_module(ipa_name,\n> -                    'rkisp1.cpp',\n> +                    ['rkisp1.cpp', libcamera_generated_ipa_headers],\n>                      name_prefix : '',\n>                      include_directories : [ipa_includes, libipa_includes],\n>                      dependencies : libcamera_dep,\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 07d7f1b2..7bb261c6 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -20,6 +20,7 @@\n>  #include <libcamera/ipa/ipa_interface.h>\n>  #include <libcamera/ipa/ipa_module_info.h>\n>  #include <libcamera/ipa/rkisp1.h>\n> +#include <libcamera/ipa/rkisp1_ipa_interface.h>\n>  #include <libcamera/request.h>\n>  \n>  #include <libipa/ipa_interface_wrapper.h>\n> @@ -30,7 +31,7 @@ namespace libcamera {\n>  \n>  LOG_DEFINE_CATEGORY(IPARkISP1)\n>  \n> -class IPARkISP1 : public IPAInterface\n> +class IPARkISP1 : public IPARkISP1Interface\n>  {\n>  public:\n>  \tint init([[maybe_unused]] const IPASettings &settings) override\n> @@ -41,13 +42,11 @@ public:\n>  \tvoid stop() override {}\n>  \n>  \tvoid configure(const CameraSensorInfo &info,\n> -\t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> -\t\t       const IPAOperationData &ipaConfig,\n> -\t\t       IPAOperationData *response) override;\n> +\t\t       const std::map<uint32_t, IPAStream> &streamConfig,\n> +\t\t       const std::map<uint32_t, ControlInfoMap> &entityControls) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n> -\tvoid processEvent(const IPAOperationData &event) override;\n> +\tvoid processEvent(const RkISP1Event &event) override;\n>  \n>  private:\n>  \tvoid queueRequest(unsigned int frame, rkisp1_params_cfg *params,\n> @@ -80,10 +79,8 @@ private:\n>   * before accessing them.\n>   */\n>  void IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n> -\t\t\t  [[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> -\t\t\t  [[maybe_unused]] const IPAOperationData &ipaConfig,\n> -\t\t\t  [[maybe_unused]] IPAOperationData *result)\n> +\t\t\t  [[maybe_unused]] const std::map<uint32_t, IPAStream> &streamConfig,\n> +\t\t\t  const std::map<uint32_t, ControlInfoMap> &entityControls)\n>  {\n>  \tif (entityControls.empty())\n>  \t\treturn;\n> @@ -159,12 +156,12 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)\n>  \t}\n>  }\n>  \n> -void IPARkISP1::processEvent(const IPAOperationData &event)\n> +void IPARkISP1::processEvent(const RkISP1Event &event)\n>  {\n> -\tswitch (event.operation) {\n> +\tswitch (event.op_) {\n>  \tcase RKISP1_IPA_EVENT_SIGNAL_STAT_BUFFER: {\n> -\t\tunsigned int frame = event.data[0];\n> -\t\tunsigned int bufferId = event.data[1];\n> +\t\tunsigned int frame = event.frame_;\n> +\t\tunsigned int bufferId = event.bufferId_;\n>  \n>  \t\tconst rkisp1_stat_buffer *stats =\n>  \t\t\tstatic_cast<rkisp1_stat_buffer *>(buffersMemory_[bufferId]);\n> @@ -173,17 +170,17 @@ void IPARkISP1::processEvent(const IPAOperationData &event)\n>  \t\tbreak;\n>  \t}\n>  \tcase RKISP1_IPA_EVENT_QUEUE_REQUEST: {\n> -\t\tunsigned int frame = event.data[0];\n> -\t\tunsigned int bufferId = event.data[1];\n> +\t\tunsigned int frame = event.frame_;\n> +\t\tunsigned int bufferId = event.bufferId_;\n>  \n>  \t\trkisp1_params_cfg *params =\n>  \t\t\tstatic_cast<rkisp1_params_cfg *>(buffersMemory_[bufferId]);\n>  \n> -\t\tqueueRequest(frame, params, event.controls[0]);\n> +\t\tqueueRequest(frame, params, event.controls_);\n>  \t\tbreak;\n>  \t}\n>  \tdefault:\n> -\t\tLOG(IPARkISP1, Error) << \"Unknown event \" << event.operation;\n> +\t\tLOG(IPARkISP1, Error) << \"Unknown event \" << event.op_;\n>  \t\tbreak;\n>  \t}\n>  }\n> @@ -203,8 +200,8 @@ void IPARkISP1::queueRequest(unsigned int frame, rkisp1_params_cfg *params,\n>  \t\tparams->module_en_update = RKISP1_CIF_ISP_MODULE_AEC;\n>  \t}\n>  \n> -\tIPAOperationData op;\n> -\top.operation = RKISP1_IPA_ACTION_PARAM_FILLED;\n> +\tRkISP1Action op;\n> +\top.op_ = RKISP1_IPA_ACTION_PARAM_FILLED;\n>  \n>  \tqueueFrameAction.emit(frame, op);\n>  }\n> @@ -256,13 +253,13 @@ void IPARkISP1::updateStatistics(unsigned int frame,\n>  \n>  void IPARkISP1::setControls(unsigned int frame)\n>  {\n> -\tIPAOperationData op;\n> -\top.operation = RKISP1_IPA_ACTION_V4L2_SET;\n> +\tRkISP1Action op;\n> +\top.op_ = RKISP1_IPA_ACTION_V4L2_SET;\n>  \n>  \tControlList ctrls(ctrls_);\n>  \tctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure_));\n>  \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain_));\n> -\top.controls.push_back(ctrls);\n> +\top.controls_ = ctrls;\n>  \n>  \tqueueFrameAction.emit(frame, op);\n>  }\n> @@ -274,9 +271,9 @@ void IPARkISP1::metadataReady(unsigned int frame, unsigned int aeState)\n>  \tif (aeState)\n>  \t\tctrls.set(controls::AeLocked, aeState == 2);\n>  \n> -\tIPAOperationData op;\n> -\top.operation = RKISP1_IPA_ACTION_METADATA;\n> -\top.controls.push_back(ctrls);\n> +\tRkISP1Action op;\n> +\top.op_ = RKISP1_IPA_ACTION_METADATA;\n> +\top.controls_ = ctrls;\n>  \n>  \tqueueFrameAction.emit(frame, op);\n>  }\n> @@ -293,9 +290,9 @@ const struct IPAModuleInfo ipaModuleInfo = {\n>  \t\"rkisp1\",\n>  };\n>  \n> -struct ipa_context *ipaCreate()\n> +IPAInterface *ipaCreate()\n>  {\n> -\treturn new IPAInterfaceWrapper(std::make_unique<IPARkISP1>());\n> +\treturn new IPARkISP1();\n>  }\n>  }\n>  \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c74a2e9b..0bf31918 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -19,6 +19,8 @@\n>  #include <libcamera/control_ids.h>\n>  #include <libcamera/formats.h>\n>  #include <libcamera/ipa/rkisp1.h>\n> +#include <libcamera/ipa/rkisp1_ipa_interface.h>\n> +#include <libcamera/ipa/ipa_proxy_rkisp1.h>\n>  #include <libcamera/request.h>\n>  #include <libcamera/stream.h>\n>  \n> @@ -144,9 +146,11 @@ public:\n>  \tRkISP1MainPath *mainPath_;\n>  \tRkISP1SelfPath *selfPath_;\n>  \n> +\tstd::unique_ptr<IPAProxyRkISP1> ipa_;\n> +\n>  private:\n>  \tvoid queueFrameAction(unsigned int frame,\n> -\t\t\t      const IPAOperationData &action);\n> +\t\t\t      const RkISP1Action &action);\n>  \n>  \tvoid metadataReady(unsigned int frame, const ControlList &metadata);\n>  };\n> @@ -412,7 +416,7 @@ private:\n>  \n>  int RkISP1CameraData::loadIPA()\n>  {\n> -\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n> +\tipa_ = IPAManager::createIPA<IPAProxyRkISP1>(pipe_, 1, 1);\n>  \tif (!ipa_)\n>  \t\treturn -ENOENT;\n>  \n> @@ -425,11 +429,11 @@ int RkISP1CameraData::loadIPA()\n>  }\n>  \n>  void RkISP1CameraData::queueFrameAction(unsigned int frame,\n> -\t\t\t\t\tconst IPAOperationData &action)\n> +\t\t\t\t\tconst RkISP1Action &action)\n>  {\n> -\tswitch (action.operation) {\n> +\tswitch (action.op_) {\n>  \tcase RKISP1_IPA_ACTION_V4L2_SET: {\n> -\t\tconst ControlList &controls = action.controls[0];\n> +\t\tconst ControlList &controls = action.controls_;\n>  \t\ttimeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,\n>  \t\t\t\t\t\t\t\t\t\t sensor_,\n>  \t\t\t\t\t\t\t\t\t\t controls));\n> @@ -442,10 +446,10 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame,\n>  \t\tbreak;\n>  \t}\n>  \tcase RKISP1_IPA_ACTION_METADATA:\n> -\t\tmetadataReady(frame, action.controls[0]);\n> +\t\tmetadataReady(frame, action.controls_);\n>  \t\tbreak;\n>  \tdefault:\n> -\t\tLOG(RkISP1, Error) << \"Unknown action \" << action.operation;\n> +\t\tLOG(RkISP1, Error) << \"Unknown action \" << action.op_;\n>  \t\tbreak;\n>  \t}\n>  }\n> @@ -908,12 +912,10 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n>  \t\tret = 0;\n>  \t}\n>  \n> -\tstd::map<unsigned int, const ControlInfoMap &> entityControls;\n> +\tstd::map<uint32_t, ControlInfoMap> entityControls;\n>  \tentityControls.emplace(0, data->sensor_->controls());\n>  \n> -\tIPAOperationData ipaConfig;\n> -\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls,\n> -\t\t\t      ipaConfig, nullptr);\n> +\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n>  \n>  \treturn ret;\n>  }\n> @@ -955,11 +957,12 @@ int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n>  \tif (!info)\n>  \t\treturn -ENOENT;\n>  \n> -\tIPAOperationData op;\n> -\top.operation = RKISP1_IPA_EVENT_QUEUE_REQUEST;\n> -\top.data = { data->frame_, info->paramBuffer->cookie() };\n> -\top.controls = { request->controls() };\n> -\tdata->ipa_->processEvent(op);\n> +\tRkISP1Event ev;\n> +\tev.op_ = RKISP1_IPA_EVENT_QUEUE_REQUEST;\n> +\tev.frame_ = data->frame_;\n> +\tev.bufferId_ = info->paramBuffer->cookie();\n> +\tev.controls_ = request->controls();\n> +\tdata->ipa_->processEvent(ev);\n>  \n>  \tdata->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,\n>  \t\t\t\t\t\t\t\t\t\t  data,\n> @@ -1181,10 +1184,11 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n>  \tif (data->frame_ <= buffer->metadata().sequence)\n>  \t\tdata->frame_ = buffer->metadata().sequence + 1;\n>  \n> -\tIPAOperationData op;\n> -\top.operation = RKISP1_IPA_EVENT_SIGNAL_STAT_BUFFER;\n> -\top.data = { info->frame, info->statBuffer->cookie() };\n> -\tdata->ipa_->processEvent(op);\n> +\tRkISP1Event ev;\n> +\tev.op_ = RKISP1_IPA_EVENT_SIGNAL_STAT_BUFFER;\n> +\tev.frame_ = info->frame;\n> +\tev.bufferId_ = info->statBuffer->cookie();\n> +\tdata->ipa_->processEvent(ev);\n>  }\n>  \n>  REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0ECBABDB89\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Nov 2020 11:13:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9531763162;\n\tThu, 12 Nov 2020 12:13:51 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCAE16305E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Nov 2020 12:13:49 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id l10so5641977lji.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Nov 2020 03:13:49 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tz4sm520203lfd.123.2020.11.12.03.13.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Nov 2020 03:13:48 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"v46JdUXM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=plmovm+cEB2fzO8uw+FN2Wk5V9l5ZnaZes6vp0cK2OQ=;\n\tb=v46JdUXMvBM93zsLWOHA2kt9Cqu6Lkepd7rZr4hs1kxtApdUWUeZ7gGeyEmDf+ywD+\n\tMCLPyNb/E6+GPJJPhWXukd8uGTxd2G02/U3iiuR9gtj4GjAtyFBsB2RnYxE7smtwt51o\n\td55Tdg6tcsSENsGuAhDvXEzdDsYcU+pzGdn2aQXgxs+IuXKBogbHvkb3mXxEB4bLHH3X\n\t0ZpREd3T0b/h5DbvGosKltgGiwmaenlgwUVjvgtqHd/mjg0XTS3wv6ZSJk0/+1iqytGy\n\tCK0sxwx73+66Hyk0LEH0/DnuM24N4+bgbqYcO7ccqhhv3+yUt2KmedxCyrbIiM+P4+Ja\n\tUyCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=plmovm+cEB2fzO8uw+FN2Wk5V9l5ZnaZes6vp0cK2OQ=;\n\tb=tlZN2Ulb/gOhz7Vmd5/eV5FQKXPzbRzENKipepuNBZcSRjf4JXHKQj0u+iBwALNMpK\n\tJRoU94J7pJEXhAhv6/YWul4nFeVVOUIWn7PtBcrcK9HpfOg4vf7eRcW5etp8YWEmeDkO\n\ts53zYHysxCV4Cq9qoGVZmpIvmPZGe0SVu9YiCSz3OCtNbJeD1hhHv3A6fPH1YfBOqf0W\n\t2+p2vYh/7O5VScC76m+fq3HKFVNyblPRDC9k+WPpPASxdOb9oYxcKqbksNk8p6qLA+Ii\n\tDq/TFZnDi06KZ+2VaF9JcubmuCbU11f9lf7jgxQSjtOBtDPHSr9n77m1n6n0UFcH7fs7\n\t2DCA==","X-Gm-Message-State":"AOAM532baLfqY+tCSsdnmh8+p8EbZ+90NB7H3vYygWquGPDUINCnjEGW\n\tIhVIQx5W0v2fNqUHBDocA3P/E1QSXQbQKQ==","X-Google-Smtp-Source":"ABdhPJwzxUwulJNBL9xojEjTW3u9K2dlm7aMqMgMw2fMY+VySmbRdaZFT5iEftkCAyIkZI5DZPByAg==","X-Received":"by 2002:a2e:bc1a:: with SMTP id\n\tb26mr11317159ljf.359.1605179629074; \n\tThu, 12 Nov 2020 03:13:49 -0800 (PST)","Date":"Thu, 12 Nov 2020 12:13:47 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Paul Elder <paul.elder@ideasonboard.com>","Message-ID":"<20201112111347.GF1480295@oden.dyn.berto.se>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-29-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-29-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 28/37] libcamera: pipeline,\n\tipa: rkisp1: Support the new IPC mechanism","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]